Re: Documentation theme update

2024-02-21 Thread Christian MAUDERER 

Hello Chris,

On 2024-02-21 06:16, Chris Johns wrote:

Hi,

I have a patch for rtems-docs.git to move us to the pip installed
sphinx-rtd-theme removing the custom theme based on sphinx-rtd-theme we
currently use.



I think reducing RTEMS specific adaptions is a great idea. So thank you 
for that.



The ticket is #4994.

The patch is over 4M in size as it deletes common/sphinx_rtd_theme_rtems. YOu
can download it from:

  
https://ftp.rtems.org/pub/rtems/people/chrisj/0001-sphinx-Use-the-pip-installed-sphinx-rtd-theme.patch

What I am not sure about is how old Sphinx can be to build the documentation. My
versions are:

  Sphinx7.2.6
  sphinx-rtd-theme  2.0.0
  sphinxcontrib-applehelp   1.0.7
  sphinxcontrib-bibtex  2.6.1
  sphinxcontrib-devhelp 1.0.5
  sphinxcontrib-htmlhelp2.0.4
  sphinxcontrib-jquery  4.1
  sphinxcontrib-jsmath  1.0.1
  sphinxcontrib-qthelp  1.0.6
  sphinxcontrib-serializinghtml 1.1.9

Is it OK to push?


I tried building the manuals with your patches on OpenSUSE. It's 
basically the same procedure as without the patch except that the 
sphinx-rtd-theme is now necessary. The result looks as expected.


With the patch, the search seems to work again. That hasn't been the 
case with the old version.


So from my point of view, the patch is a great improvement and OK.

Best regards

Christian
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] bsps/xnandpsu: Allow creation of BBT

2024-02-21 Thread Kinsey Moore 
This fixes a logic inversion that was preventing creation of a Bad Block
Table (BBT) from scratch on devices that lack one. This was discovered
during upstream integration testing. The BBT management layer in this
driver is not designed to be easily testable other than on real hardware.
---
 bsps/shared/dev/nand/xnandpsu_bbm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/shared/dev/nand/xnandpsu_bbm.c 
b/bsps/shared/dev/nand/xnandpsu_bbm.c
index b8428a7328..40cf798965 100644
--- a/bsps/shared/dev/nand/xnandpsu_bbm.c
+++ b/bsps/shared/dev/nand/xnandpsu_bbm.c
@@ -653,7 +653,7 @@ static s32 XNandPsu_WriteBbt(XNandPsu *InstancePtr, 
XNandPsu_BbtDesc *Desc,
for(Index = 0U; Index < Desc->MaxBlocks; Index++) {
Block  = (EndBlock - Index);
 #ifdef __rtems__
-   if (XNandPsu_IsBlockBad(InstancePtr, Block) == 
XST_FAILURE) {
+   if (XNandPsu_IsBlockBad(InstancePtr, Block) != 
XST_FAILURE) {
continue;
}
 #else
-- 
2.39.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Documentation theme update

2024-02-21 Thread Joel Sherrill 
Based on Christian saying it works and me confirming that, I pushed this.

Thanks a lot Chris! 

--joel

On Wed, Feb 21, 2024 at 2:22 AM Christian MAUDERER <
christian.maude...@embedded-brains.de> wrote:

> Hello Chris,
>
> On 2024-02-21 06:16, Chris Johns wrote:
> > Hi,
> >
> > I have a patch for rtems-docs.git to move us to the pip installed
> > sphinx-rtd-theme removing the custom theme based on sphinx-rtd-theme we
> > currently use.
> >
>
> I think reducing RTEMS specific adaptions is a great idea. So thank you
> for that.
>
> > The ticket is #4994.
> >
> > The patch is over 4M in size as it deletes
> common/sphinx_rtd_theme_rtems. YOu
> > can download it from:
> >
> >
> https://ftp.rtems.org/pub/rtems/people/chrisj/0001-sphinx-Use-the-pip-installed-sphinx-rtd-theme.patch
> >
> > What I am not sure about is how old Sphinx can be to build the
> documentation. My
> > versions are:
> >
> >   Sphinx7.2.6
> >   sphinx-rtd-theme  2.0.0
> >   sphinxcontrib-applehelp   1.0.7
> >   sphinxcontrib-bibtex  2.6.1
> >   sphinxcontrib-devhelp 1.0.5
> >   sphinxcontrib-htmlhelp2.0.4
> >   sphinxcontrib-jquery  4.1
> >   sphinxcontrib-jsmath  1.0.1
> >   sphinxcontrib-qthelp  1.0.6
> >   sphinxcontrib-serializinghtml 1.1.9
> >
> > Is it OK to push?
>
> I tried building the manuals with your patches on OpenSUSE. It's
> basically the same procedure as without the patch except that the
> sphinx-rtd-theme is now necessary. The result looks as expected.
>
> With the patch, the search seems to work again. That hasn't been the
> case with the old version.
>
> So from my point of view, the patch is a great improvement and OK.
>
> Best regards
>
> Christian
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel