[PATCH] score: Remove unused return value
Several SMP message processing functions returned a value. This value
was always unused.
Close #4822.
---
cpukit/include/rtems/score/smpimpl.h | 15 ---
cpukit/score/src/smp.c | 7 +--
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/cpukit/include/rtems/score/smpimpl.h
b/cpukit/include/rtems/score/smpimpl.h
index ef32687bec..2ffc047070 100644
--- a/cpukit/include/rtems/score/smpimpl.h
+++ b/cpukit/include/rtems/score/smpimpl.h
@@ -166,12 +166,9 @@ RTEMS_NO_RETURN void
_SMP_Start_multitasking_on_secondary_processor(
* @param[in, out] cpu_self is the processor control of the processor executing
* this function.
*
- * @return Returns the processed message.
+ * @param message is the message to process.
*/
-long unsigned _SMP_Process_message(
- Per_CPU_Control *cpu_self,
- long unsignedmessage
-);
+void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned message );
/**
* @brief Tries to process the current SMP message.
@@ -200,10 +197,8 @@ void _SMP_Try_to_process_message(
*
* @param[in, out] cpu_self is the processor control of the processor executing
* this function.
- *
- * @return Returns the processed message.
*/
-static inline long unsigned _SMP_Inter_processor_interrupt_handler(
+static inline void _SMP_Inter_processor_interrupt_handler(
Per_CPU_Control *cpu_self
)
{
@@ -222,10 +217,8 @@ static inline long unsigned
_SMP_Inter_processor_interrupt_handler(
);
if ( RTEMS_PREDICT_FALSE( message != 0 ) ) {
-return _SMP_Process_message( cpu_self, message );
+_SMP_Process_message( cpu_self, message );
}
-
- return message;
}
/**
diff --git a/cpukit/score/src/smp.c b/cpukit/score/src/smp.c
index 7c068f3c51..75520829e1 100644
--- a/cpukit/score/src/smp.c
+++ b/cpukit/score/src/smp.c
@@ -311,10 +311,7 @@ void _SMP_Request_shutdown( void )
}
}
-long unsigned _SMP_Process_message(
- Per_CPU_Control *cpu_self,
- long unsignedmessage
-)
+void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned message )
{
if ( ( message & SMP_MESSAGE_SHUTDOWN ) != 0 ) {
ISR_Level level;
@@ -332,8 +329,6 @@ long unsigned _SMP_Process_message(
if ( ( message & SMP_MESSAGE_PERFORM_JOBS ) != 0 ) {
_Per_CPU_Perform_jobs( cpu_self );
}
-
- return message;
}
void _SMP_Try_to_process_message(
--
2.35.3
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] score: Remove unused return value
I looked at this issue earlier this morning and this fix looks ok.
On Tue, Jan 24, 2023 at 9:56 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Several SMP message processing functions returned a value. This value
> was always unused.
>
> Close #4822.
> ---
> cpukit/include/rtems/score/smpimpl.h | 15 ---
> cpukit/score/src/smp.c | 7 +--
> 2 files changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/cpukit/include/rtems/score/smpimpl.h
> b/cpukit/include/rtems/score/smpimpl.h
> index ef32687bec..2ffc047070 100644
> --- a/cpukit/include/rtems/score/smpimpl.h
> +++ b/cpukit/include/rtems/score/smpimpl.h
> @@ -166,12 +166,9 @@ RTEMS_NO_RETURN void
> _SMP_Start_multitasking_on_secondary_processor(
> * @param[in, out] cpu_self is the processor control of the processor
> executing
> * this function.
> *
> - * @return Returns the processed message.
> + * @param message is the message to process.
> */
> -long unsigned _SMP_Process_message(
> - Per_CPU_Control *cpu_self,
> - long unsignedmessage
> -);
> +void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned
> message );
>
> /**
> * @brief Tries to process the current SMP message.
> @@ -200,10 +197,8 @@ void _SMP_Try_to_process_message(
> *
> * @param[in, out] cpu_self is the processor control of the processor
> executing
> * this function.
> - *
> - * @return Returns the processed message.
> */
> -static inline long unsigned _SMP_Inter_processor_interrupt_handler(
> +static inline void _SMP_Inter_processor_interrupt_handler(
>Per_CPU_Control *cpu_self
> )
> {
> @@ -222,10 +217,8 @@ static inline long unsigned
> _SMP_Inter_processor_interrupt_handler(
>);
>
>if ( RTEMS_PREDICT_FALSE( message != 0 ) ) {
> -return _SMP_Process_message( cpu_self, message );
> +_SMP_Process_message( cpu_self, message );
>}
> -
> - return message;
> }
>
> /**
> diff --git a/cpukit/score/src/smp.c b/cpukit/score/src/smp.c
> index 7c068f3c51..75520829e1 100644
> --- a/cpukit/score/src/smp.c
> +++ b/cpukit/score/src/smp.c
> @@ -311,10 +311,7 @@ void _SMP_Request_shutdown( void )
>}
> }
>
> -long unsigned _SMP_Process_message(
> - Per_CPU_Control *cpu_self,
> - long unsignedmessage
> -)
> +void _SMP_Process_message( Per_CPU_Control *cpu_self, long unsigned
> message )
> {
>if ( ( message & SMP_MESSAGE_SHUTDOWN ) != 0 ) {
> ISR_Level level;
> @@ -332,8 +329,6 @@ long unsigned _SMP_Process_message(
>if ( ( message & SMP_MESSAGE_PERFORM_JOBS ) != 0 ) {
> _Per_CPU_Perform_jobs( cpu_self );
>}
> -
> - return message;
> }
>
> void _SMP_Try_to_process_message(
> --
> 2.35.3
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH] user/hosts/posix.rst: Update Ubuntu instructions to 22.x
Closes #4821. --- user/hosts/posix.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/user/hosts/posix.rst b/user/hosts/posix.rst index d263247..d79e183 100644 --- a/user/hosts/posix.rst +++ b/user/hosts/posix.rst @@ -137,16 +137,16 @@ prefix under your home directory as recommended and end up on the SD card. Ubuntu ~~ -The latest version is Ubuntu 20.04.3 LTS 64-bit. This section also includes +The latest version is Ubuntu 22.04 LTS 64-bit. This section also includes Xubuntu. A minimal installation was used and the following packages installed: .. code-block:: none - $ sudo apt-get build-dep build-essential gcc-defaults g++ gdb unzip \ - pax bison flex texinfo python3-dev libpython2-dev libncurses5-dev \ - zlib1g-dev + $ sudo apt install build-essential g++ gdb unzip pax bison flex texinfo \ + python3-dev python-is-python3 libpython2-dev libncurses5-dev zlib1g-dev \ + ninja-build pkg-config -Note that in previous versions of Ubuntu, the package libpython2-dev was +Note that in older versions of Ubuntu, the package libpython2-dev was python2.7-dev. The name of packages changes over time. You need the package with Python development libraries for C/C++ programs. The following is needed for recent versions: -- 1.8.3.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: formal: Fixes Licenses
On 23.01.23 13:01, andrew.butterfi...@scss.tcd.ie wrote: Patches to fix licenses for formal material are attached. The main issue was missing/wrong SPDX identifiers Thanks, I checked it in. With respect to the licensing, there is currently a mix of BSD-2-Clause and BSD-3-Clause with copyright Trinity College Dublin (www.tcd.ie). Since BSD-3-Clause is more restrictive, maybe this should be changed so that all files use BSD-3-Clause. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
