date:20210807

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-07 Thread Gedare Bloom

On Fri, Aug 6, 2021 at 11:55 AM zack leung  wrote:
>
> How do i report the findings of the  psx and  tests?
>

You can just copy-paste the final part of the log file when you run
rtems-test. Or you can share the full log file as attachment

>
> Thanks
> Zack
>
> On Thu, 5 Aug 2021 at 19:23, Gedare Bloom  wrote:
>>
>> On Thu, Aug 5, 2021 at 12:36 PM Zacchaeus Leung
>>  wrote:
>> >
>> > the timer_create() method can use CLOCK_MONOTONIC but there was  no test 
>> > for this
>> >
>> The commit message needs to be improved, because this patch is doing
>> more than adding a "test", it is implementing the functionality to
>> create a CLOCK_MONOTONIC timer and to gettime() on it.
>>
>> > Closes #3888
>> https://devel.rtems.org/ticket/3888  ??
>>
>> >
>> > ---
>>
>> [...]
>>
>> > +
>> > + if ( rtems_timespec_less_than( &now, &expire ) ) {
>> > +  rtems_timespec_subtract( &now, &expire, &result );
>> > +} else {
>> > +  result.tv_nsec = 0;
>> > +  result.tv_sec  = 0;
>> > +}
>> The indentation level is wrong in this block.
>>
>> > +
>> > +  value->it_value = result;
>> > +  value->it_interval = ptimer->timer_data.it_interval;
>> > +
>> > +  _POSIX_Timer_Release( cpu, &lock_context );
>> > +  return 0;
>> > +}
>> > \ No newline at end of file
>> > diff --git a/testsuites/psxtests/psxtimer02/psxtimer.c 
>> > b/testsuites/psxtests/psxtimer02/psxtimer.c
>> > index 9f79d33c42..1a79369efb 100644
>> > --- a/testsuites/psxtests/psxtimer02/psxtimer.c
>> > +++ b/testsuites/psxtests/psxtimer02/psxtimer.c
>> > @@ -126,6 +126,32 @@ void *POSIX_Init (
>> >puts( "timer_delete - bad id - EINVAL" );
>> >status = timer_delete( timer );
>> >fatal_posix_service_status_errno( status, EINVAL, "bad id" );
>> > +
>> > +  puts( "timer_create (monotonic) - bad timer id pointer - EINVAL" );
>> > +  status = timer_create( CLOCK_MONOTONIC, &event, NULL );
>> > +  fatal_posix_service_status_errno( status, EINVAL, "bad timer id" );
>> > +
>> > +  puts( "timer_create (monotonic) - OK" );
>> > +  status = timer_create( CLOCK_MONOTONIC, NULL, &timer );
>> > +  posix_service_failed( status, "timer_create OK" );
>> > +
>> > +  puts( "timer_create (monotonic) - too many - EAGAIN" );
>> > +  status = timer_create( CLOCK_MONOTONIC, NULL, &timer1 );
>> > +  fatal_posix_service_status_errno( status, EAGAIN, "too many" );
>> > +
>> > +  clock_gettime( CLOCK_MONOTONIC, &now );
>> > +  itimer.it_value = now;
>> > +  itimer.it_value.tv_sec = itimer.it_value.tv_sec - 1;
>> > +  puts( "timer_settime (monotonic) - bad itimer value - previous time - 
>> > EINVAL" );
>> > +  status = timer_settime( timer, TIMER_ABSTIME, &itimer, NULL );
>> > +  fatal_posix_service_status_errno( status, EINVAL, "bad itimer value #3" 
>> > );
>> > +
>> > +  clock_gettime( CLOCK_MONOTONIC, &now );
>> > +  itimer.it_value = now;
>> > +  itimer.it_value.tv_sec = itimer.it_value.tv_sec + 1;
>> > +  puts( "timer_settime (monotonic) - bad id - EINVAL" );
>> > +  status = timer_settime( timer1, TIMER_ABSTIME, &itimer, NULL );
>> > +  fatal_posix_service_status_errno( status, EINVAL, "bad id" );
>> >
>>
>> Please provide updated psxtimer02.scn and report the results for
>> running rtems-test for at least the sparc/erc32 with sis including the
>> sptests and psxtests. If you need help how to run rtems-test, consult
>> the documentation and ask questions.
>> https://docs.rtems.org/branches/master/user/testing/index.html
>>
>> >TEST_END();
>> >rtems_test_exit (0);
>> > --
>> > 2.32.0
>> >
>> > ___
>> > devel mailing list
>> > devel@rtems.org
>> > http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-07 Thread Joel Sherrill

On Sat, Aug 7, 2021 at 10:57 AM Gedare Bloom  wrote:
>
> On Fri, Aug 6, 2021 at 11:55 AM zack leung  wrote:
> >
> > How do i report the findings of the  psx and  tests?
> >
>
> You can just copy-paste the final part of the log file when you run
> rtems-test. Or you can share the full log file as attachment

I also asked that Zack try to run coverage. I don't mind merging this
before he gets those results. But since he is on sparc, sis can do
coverage, so it is not a far reach. And he can be sure the test covers
the new code added completely.

timergettime.c reports as not having an end of line at the end of the
file. It is missing
a carriage return. Just hit enter and then make sure there isn't a
blank line at the end
of the file.

> >
> > Thanks
> > Zack
> >
> > On Thu, 5 Aug 2021 at 19:23, Gedare Bloom  wrote:
> >>
> >> On Thu, Aug 5, 2021 at 12:36 PM Zacchaeus Leung
> >>  wrote:
> >> >
> >> > the timer_create() method can use CLOCK_MONOTONIC but there was  no test 
> >> > for this
> >> >
> >> The commit message needs to be improved, because this patch is doing
> >> more than adding a "test", it is implementing the functionality to
> >> create a CLOCK_MONOTONIC timer and to gettime() on it.
> >>
> >> > Closes #3888
> >> https://devel.rtems.org/ticket/3888  ??
> >>
> >> >
> >> > ---
> >>
> >> [...]
> >>
> >> > +
> >> > + if ( rtems_timespec_less_than( &now, &expire ) ) {
> >> > +  rtems_timespec_subtract( &now, &expire, &result );
> >> > +} else {
> >> > +  result.tv_nsec = 0;
> >> > +  result.tv_sec  = 0;
> >> > +}
> >> The indentation level is wrong in this block.
> >>
> >> > +
> >> > +  value->it_value = result;
> >> > +  value->it_interval = ptimer->timer_data.it_interval;
> >> > +
> >> > +  _POSIX_Timer_Release( cpu, &lock_context );
> >> > +  return 0;
> >> > +}
> >> > \ No newline at end of file
> >> > diff --git a/testsuites/psxtests/psxtimer02/psxtimer.c 
> >> > b/testsuites/psxtests/psxtimer02/psxtimer.c
> >> > index 9f79d33c42..1a79369efb 100644
> >> > --- a/testsuites/psxtests/psxtimer02/psxtimer.c
> >> > +++ b/testsuites/psxtests/psxtimer02/psxtimer.c
> >> > @@ -126,6 +126,32 @@ void *POSIX_Init (
> >> >puts( "timer_delete - bad id - EINVAL" );
> >> >status = timer_delete( timer );
> >> >fatal_posix_service_status_errno( status, EINVAL, "bad id" );
> >> > +
> >> > +  puts( "timer_create (monotonic) - bad timer id pointer - EINVAL" );
> >> > +  status = timer_create( CLOCK_MONOTONIC, &event, NULL );
> >> > +  fatal_posix_service_status_errno( status, EINVAL, "bad timer id" );
> >> > +
> >> > +  puts( "timer_create (monotonic) - OK" );
> >> > +  status = timer_create( CLOCK_MONOTONIC, NULL, &timer );
> >> > +  posix_service_failed( status, "timer_create OK" );
> >> > +
> >> > +  puts( "timer_create (monotonic) - too many - EAGAIN" );
> >> > +  status = timer_create( CLOCK_MONOTONIC, NULL, &timer1 );
> >> > +  fatal_posix_service_status_errno( status, EAGAIN, "too many" );
> >> > +
> >> > +  clock_gettime( CLOCK_MONOTONIC, &now );
> >> > +  itimer.it_value = now;
> >> > +  itimer.it_value.tv_sec = itimer.it_value.tv_sec - 1;
> >> > +  puts( "timer_settime (monotonic) - bad itimer value - previous time - 
> >> > EINVAL" );
> >> > +  status = timer_settime( timer, TIMER_ABSTIME, &itimer, NULL );
> >> > +  fatal_posix_service_status_errno( status, EINVAL, "bad itimer value 
> >> > #3" );
> >> > +
> >> > +  clock_gettime( CLOCK_MONOTONIC, &now );
> >> > +  itimer.it_value = now;
> >> > +  itimer.it_value.tv_sec = itimer.it_value.tv_sec + 1;
> >> > +  puts( "timer_settime (monotonic) - bad id - EINVAL" );
> >> > +  status = timer_settime( timer1, TIMER_ABSTIME, &itimer, NULL );
> >> > +  fatal_posix_service_status_errno( status, EINVAL, "bad id" );
> >> >
> >>
> >> Please provide updated psxtimer02.scn and report the results for
> >> running rtems-test for at least the sparc/erc32 with sis including the
> >> sptests and psxtests. If you need help how to run rtems-test, consult
> >> the documentation and ask questions.
> >> https://docs.rtems.org/branches/master/user/testing/index.html
> >>
> >> >TEST_END();
> >> >rtems_test_exit (0);
> >> > --
> >> > 2.32.0
> >> >
> >> > ___
> >> > devel mailing list
> >> > devel@rtems.org
> >> > http://lists.rtems.org/mailman/listinfo/devel
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

2021-08-07 Thread Ahamed Husni

Hi Christian,

Are there any issues I should address in this patch set?

On Mon, Aug 2, 2021 at 12:09 PM Christian MAUDERER <
christian.maude...@embedded-brains.de> wrote:

> Hello Husni,
>
> Am 01.08.21 um 19:59 schrieb Ahamed Husni:
> > Hi Christian,
> >
> > On Sun, Aug 1, 2021 at 4:57 PM Christian Mauderer  > > wrote:
> >
> > Hello Husni,
> >
> > just tested that and it works fine. With a simple curl I can reach
> > about
> > 8.5 MByte/s sending to the beagle and 19.5 MByte/s receiving from it.
> >
> > That's 68 Mbps for sending. That's an acceptable speed isn't it?
> >
>
> At the moment I would be OK with basically any speed. It was just some
> information so that someone who finds the mail knows what he can expect.
>
> It would be interesting to see how the speeds compare to a FreeBSD setup
> on the Beagle. If there is no bug in our port, it should be about the same.
>
> Best regards
>
> Christian
>
> > Please take a look at the points that Chris Johns asked. As soon as
> > these are addressed, I think the patches could be merged.
> >
> > I just replied to it now. Sorry for the delay.
> >
> >
> > Please also make the documentation that you started for this more
> > public
> > visible. In other words: Send it as patches to the list and not only
> as
> > a link to some branch!
> >
> > Noted.
> >
> >
> > Best regards
> >
> > Christian
> >
> > On 28/07/2021 13:56, Husni Faiz wrote:
> >  > This set of patches import the drivers from freebsd and
> >  > configures it for the beagle bsp.
> >  >
> >  > Github Branch for the commits
> >  > https://github.com/drac98/rtems-libbsd/commits/usb-cdce
> > 
> >  >
> >  > Patch for 6-freebsd-12 branch
> >  > https://github.com/drac98/rtems-libbsd/commits/usb-cdce12
> > 
> >  >
> >  > Husni Faiz (5):
> >  >usb_template:Import CDC Ethernet
> >  >usb_template: Configure template driver only for CDC Ethernet
> >  >nexus-devices: Include CDC Ethernet for Beagle
> >  >libbsd.py: add usb template files
> >  >create-kernel-namespace for USB Template driver
> >  >
> >  >   buildset/default.ini  |1 +
> >  >   buildset/minimal.ini  |3 +-
> >  >   freebsd/sys/dev/usb/template/usb_template.c   | 1493
> > +
> >  >   freebsd/sys/dev/usb/template/usb_template.h   |  130 ++
> >  >   .../sys/dev/usb/template/usb_template_cdce.c  |  355 
> >  >   freebsd/sys/dev/usb/usb_device.c  |8 +-
> >  >   libbsd.py |   25 +
> >  >   rtemsbsd/include/bsp/nexus-devices.h  |5 +
> >  >   .../machine/rtems-bsd-kernel-namespace.h  |5 +
> >  >   .../include/machine/rtems-bsd-nexus-bus.h |   19 +
> >  >   10 files changed, 2041 insertions(+), 3 deletions(-)
> >  >   create mode 100644 freebsd/sys/dev/usb/template/usb_template.c
> >  >   create mode 100644 freebsd/sys/dev/usb/template/usb_template.h
> >  >   create mode 100644
> freebsd/sys/dev/usb/template/usb_template_cdce.c
> >  >
> >
> >
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> >
>
> --
> 
> embedded brains GmbH
> Herr Christian MAUDERER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: christian.maude...@embedded-brains.de
> phone: +49-89-18 94 741 - 18
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

Re: [PATCH v3] Test needed for timer_create with CLOCK_MONOTONIC

Re: [PATCH rtems-libbsd v2 0/5] Beagle BSP: USB Template Driver for CDC Ethernet

3 matches

Site Navigation

Mail list logo

Footer information