Re: Need help in understanding some of the existing code in RTEMS

2020-07-12 Thread Richi Dubey 
I understand now. Thank you.

On Sat, Jul 11, 2020 at 7:35 PM Gedare Bloom  wrote:

> On Sat, Jul 11, 2020 at 12:31 AM Richi Dubey  wrote:
> >
> > Hi,
> >
> > I noticed that we have defined all the scheduler non entry-point
> functions in
> https://git.rtems.org/rtems/tree/cpukit/score/src/scheduleredfsmp.c as
> static inline, which makes them invisible inside the doxygen comments (
> https://docs.rtems.org/doxygen/branches/master/scheduleredfsmp_8c.html).
> >
> > Is there any reason why we choose to do so?
> >
>
> Encapsulation / method hiding. It is normal to define and document
> interfaces moreso than implementations.
>
> > Thanks,
> > Richi.
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/1] Generate application configuration option documentation

2020-07-12 Thread Chris Johns 
On 8/7/20 3:35 pm, Sebastian Huber wrote:
> Hello Chris,
> 
> thanks for the detailed response.
> 
> On 08/07/2020 03:55, Chris Johns wrote:
>> Hi Sebastian,
>>
>> Thank you for this patch. I am sorry but I would like to see this central 
>> repo
>> issue resolved before any generated files are added to any of the project's
>> repos.
>>
>> I understand to some level the path you are taking and moving along but these
>> generated files are coming from a personal repo that has changes, processes 
>> and
>> tools that are not being reviewed. I think it would be wise for us to agree 
>> on
>> what is behind all this before we agree to what is being generated.
> 
> I rescheduled some work to be able to provide this patch earlier. Richi Dubey
> asked a couple of questions with respect to the scheduler implementation and
> some of them are related to how application configuration options define
> internal scheduler data structures. So, It would be nice to be able to 
> reference
> them in Doxygen. You can review this patch independent from the way it is 
> produced.

Ah OK. Can Richi hold the changes locally until we work through the process to
bring this work into the project?

>> On 7/7/20 9:25 pm, Sebastian Huber wrote:
>>> This patch adds the application configuration option documentation generated
>>> from specification items:
>>>
>>> https://git.rtems.org/sebh/rtems-qual.git/tree/spec/if/acfg
>>  That is a lot of files. I am not sure I am ready to accept 
>> documentation
>> as a lot of small files. I am happy to be persuaded otherwise.
>>
>> It is not clear to me if these YAML files generate documentation, headers, 
>> are
>> requirements or something else.
> 
> Each application configuration option and group is provided as a separate
> specification item (YAML file). The type of the specification items is
> documented here:
> 
> https://docs.rtems.org/branches/master/eng/req/items.html

Thanks. I have looked at this before and it is detailed. The documentation make
sense and it is a really good starting place.

> https://docs.rtems.org/branches/master/eng/req/items.html#spectypeapplicationconfigurationoptionitemtype
> 
> Application configuration options are things on their own, so they have their
> own items. This enables other items to reference application configuration
> options. 

When you say `item` is this in relation to the qual tools and the `item` as
documented?

> In the manual you have now a lot more cross references for example if
> you compare it with the RTEMS 4.11 documentation. Items have their own history
> and can be reviewed individually. I see this as benefits.

Yes there are benefits and I am not questioning these benefits. Once we depend
on these generated files we also depend on what generates these so this should
be our focus. Accepting the output into the repos means accepting the tools that
generated these files.

I see the process to get the repo accepted being related to the high level
architectural and procedure things this change brings. There needs to be a
review, consideration and discussion.

>> There is nothing I can see in them that defines
>> their `role` or `roles`.
> 
> When you look at an item
> 
> https://git.rtems.org/sebh/rtems-qual.git/tree/spec/if/acfg/message-buffer-memory.yml
> 
> 
> you see attributes like
> 
> |type: interface ||interface-type: appl-config-option 
> ||appl-config-option-type:
> integer This defines the type of an item. I corresponds to the specification
> type refinement:
> https://docs.rtems.org/branches/master/eng/req/items.html#spectyperootitemtype
> https://docs.rtems.org/branches/master/eng/req/items.html#spectypeinterfaceitemtype
> https://docs.rtems.org/branches/master/eng/req/items.html#spectypeapplicationconfigurationoptionitemtype
> https://docs.rtems.org/branches/master/eng/req/items.html#spectypeapplicationconfigurationvalueoptionitemtype
> All attributes and the value types are defined by specification item types. 
> The
> specification item types are defined by specification items:
> https://git.rtems.org/sebh/rtems-qual.git/tree/spec/spec The type information 
> is
> used to generate the documentation in the RTEMS Software Engineering manual 
> and
> is used to verify that the items are in line with the type specification:
> https://git.rtems.org/sebh/rtems-qual.git/tree/specverify.py |
> 
>> If they do generate files how does that happen and how
>> are those generated header files related to the C code they are an interface
>> for?
> 
> The Doxygen header file of this patch is not read by the C compiler. However, 
> I
> would like to generate also the API header files from specification items. I 
> am
> now able to generate  and all header files included by this header
> which define API elements. About 585 items describe the API defined by 
> :
> 
> https://git.rtems.org/sebh/rtems-qual.git/tree/spec/if/rtems
> 
> This item describes rtems_semaphore_create():
> 
> https://git.rtems.org/sebh/rtems-qual.git/tree/spec/if/r

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-12 Thread Chris Johns 
On 8/7/20 9:37 pm, Sebastian Huber wrote:
> On 08/07/2020 13:34, Chris Johns wrote:
> 
>> Are these flags needed for all BSPs?
> Yes, these flags are needed to build and use libbsd.

Why not define them for all BSPs and for all applications?

What is special about libbsd that it needs these flags over any other type of
application?

>> If so why add to here ...
>>
>> https://git.rtems.org/rtems/tree/c/src/bsp.pc.in
> These are optimization flags. I thought the consensus was to export only ABI
> relevant flags in the new build system.

In CFLAGS yes. Pkgconfig files (.pc) support variables and I had always thought
we define a number of RTEMS specific variables and these hold various flags or
commands needed to handle other things, for example the options to mkimage. A
user could then test for a variable and if present know this BSP does or has
extra "what ever".

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] build: Ensure mandatory compiler/linker flags

2020-07-12 Thread Sebastian Huber 

On 13/07/2020 02:09, Chris Johns wrote:

On 8/7/20 9:37 pm, Sebastian Huber wrote:

On 08/07/2020 13:34, Chris Johns wrote:


Are these flags needed for all BSPs?

Yes, these flags are needed to build and use libbsd.


Why not define them for all BSPs 


In the new build system they are the default.


and for all applications?


I don't think we should mandate any optimization flags for applications. 
These flags affect the code generation.




What is special about libbsd that it needs these flags over any other type of
application?


libbsd needs these flags since FreeBSD was not designed as a static 
library. In addition, the porting to RTEMS is less intrusive and labour 
intensive using these flags.





If so why add to here ...

https://git.rtems.org/rtems/tree/c/src/bsp.pc.in

These are optimization flags. I thought the consensus was to export only ABI
relevant flags in the new build system.


In CFLAGS yes. Pkgconfig files (.pc) support variables and I had always thought
we define a number of RTEMS specific variables and these hold various flags or
commands needed to handle other things, for example the options to mkimage. A
user could then test for a variable and if present know this BSP does or has
extra "what ever".


You mean some sort of recommended optimization flags? We should really 
define what the pkg-config files should export so that I can implement 
this in the new build system.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 00/16] Remove obsoleted APIs

2020-07-12 Thread Sebastian Huber 
This patch set removes APIs obsoleted in RTEMS 5.1.

Sebastian Huber (16):
  rtems: Remove _RTEMS_version
  rtems: Remove RTEMS_MAXIMUM_NAME_LENGTH
  rtems: Remove _Copyright_Notice from API header
  rtems: Remove deprecated 
  rtems: Remove deprecated rtems_io_lookup_name()
  rtems: Remove rtems_get_current_processor()
  rtems: Remove rtems_get_processor_count()
  rtems: Remove deprecated rtems_extension
  rtems: Remove rtems_rate_monotonic_period_time_t
  rtems: Remove rtems_context
  rtems: Remove rtems_context_fp
  rtems: Remove region_information_block
  rtems: Remove rtems_thread_cpu_usage_t
  rtems: Remove support for RTEMS_DEPRECATED_TYPES
  rtems: Remove deprecated proc_ptr definition
  score: Remove deprecated Thread

 bsps/shared/rtems-version.c   |  5 ++-
 cpukit/headers.am |  1 -
 cpukit/include/rtems.h|  1 -
 cpukit/include/rtems/extension.h  |  3 --
 cpukit/include/rtems/io.h | 17 +--
 cpukit/include/rtems/rtems/ratemon.h  |  2 -
 cpukit/include/rtems/rtems/tasks.h| 30 -
 cpukit/include/rtems/rtems/types.h| 49 
 cpukit/include/rtems/score/basedefs.h | 13 --
 cpukit/include/rtems/score/copyrt.h   |  5 +++
 cpukit/include/rtems/score/thread.h   |  6 ---
 cpukit/include/rtems/score/userext.h  |  2 -
 cpukit/include/rtems/system.h | 65 ---
 cpukit/libfs/src/imfs/ioman.c | 21 -
 cpukit/sapi/src/getversionstring.c|  5 +--
 testsuites/sptests/sp21/init.c| 21 -
 testsuites/sptests/spsize/size.c  |  2 +-
 17 files changed, 12 insertions(+), 236 deletions(-)
 delete mode 100644 cpukit/include/rtems/system.h

-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 16/16] score: Remove deprecated Thread

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3991.
---
 cpukit/include/rtems/score/thread.h | 6 --
 1 file changed, 6 deletions(-)

diff --git a/cpukit/include/rtems/score/thread.h 
b/cpukit/include/rtems/score/thread.h
index 2e7380f99a..ee0aee5b79 100644
--- a/cpukit/include/rtems/score/thread.h
+++ b/cpukit/include/rtems/score/thread.h
@@ -89,12 +89,6 @@ extern "C" {
 #define RTEMS_SCORE_THREAD_ENABLE_RESOURCE_COUNT
 #endif
 
-/*
- * Only provided for backward compatiblity to not break application
- * configurations.
- */
-typedef void *Thread RTEMS_DEPRECATED;
-
 /**
  *  @brief Type of the numeric argument of a thread entry function with at
  *  least one numeric argument.
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 07/16] rtems: Remove rtems_get_processor_count()

2020-07-12 Thread Sebastian Huber 
This function was deprecated in RTEMS 5.1.

Close #3990.
---
 cpukit/include/rtems/rtems/tasks.h | 15 ---
 1 file changed, 15 deletions(-)

diff --git a/cpukit/include/rtems/rtems/tasks.h 
b/cpukit/include/rtems/rtems/tasks.h
index 6580a209e1..12c323e60e 100644
--- a/cpukit/include/rtems/rtems/tasks.h
+++ b/cpukit/include/rtems/rtems/tasks.h
@@ -621,21 +621,6 @@ rtems_status_code rtems_scheduler_ident_by_processor_set(
  */
 #define rtems_scheduler_get_processor_maximum() _SMP_Get_processor_maximum()
 
-/**
- * @brief Returns the processor maximum supported by the system.
- *
- * @return The processor maximum supported by the system.
- *
- * @deprecated
- *
- * Use rtems_scheduler_get_processor_maximum() instead.
- */
-RTEMS_DEPRECATED RTEMS_INLINE_ROUTINE uint32_t
-rtems_get_processor_count( void )
-{
-  return rtems_scheduler_get_processor_maximum();
-}
-
 /**
  * @brief Gets the set of processors owned by the specified scheduler instance.
  *
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 13/16] rtems: Remove rtems_thread_cpu_usage_t

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3594.
---
 cpukit/include/rtems/rtems/types.h | 8 
 1 file changed, 8 deletions(-)

diff --git a/cpukit/include/rtems/rtems/types.h 
b/cpukit/include/rtems/rtems/types.h
index 51b8297113..994e097afa 100644
--- a/cpukit/include/rtems/rtems/types.h
+++ b/cpukit/include/rtems/rtems/types.h
@@ -108,14 +108,6 @@ typedef CPU_Interrupt_framertems_interrupt_frame;
  */
 typedef Watchdog_Interval rtems_interval;
 
-/**
- * @brief Represents the CPU usage per thread.
- *
- * When using nanoseconds granularity timing, RTEMS may internally use a
- * variety of representations.
- */
-typedef struct timespec rtems_thread_cpu_usage_t RTEMS_DEPRECATED;
-
 /**
  * @brief Data structure to manage and manipulate calendar
  * @ref ClassicRTEMSSecTime "time".
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 06/16] rtems: Remove rtems_get_current_processor()

2020-07-12 Thread Sebastian Huber 
This function was deprecated in RTEMS 5.1.

Close #3989.
---
 cpukit/include/rtems/rtems/tasks.h | 15 ---
 1 file changed, 15 deletions(-)

diff --git a/cpukit/include/rtems/rtems/tasks.h 
b/cpukit/include/rtems/rtems/tasks.h
index a4af236b6b..6580a209e1 100644
--- a/cpukit/include/rtems/rtems/tasks.h
+++ b/cpukit/include/rtems/rtems/tasks.h
@@ -603,21 +603,6 @@ rtems_status_code rtems_scheduler_ident_by_processor_set(
  */
 #define rtems_scheduler_get_processor() _SMP_Get_current_processor()
 
-/**
- * @brief Returns the index of the current processor.
- *
- * @return The index of the current processor.
- *
- * @deprecated
- *
- * Use rtems_scheduler_get_processor() instead.
- */
-RTEMS_DEPRECATED RTEMS_INLINE_ROUTINE uint32_t
-rtems_get_current_processor( void )
-{
-  return rtems_scheduler_get_processor();
-}
-
 /**
  * @brief Returns the processor maximum supported by the system.
  *
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 03/16] rtems: Remove _Copyright_Notice from API header

2020-07-12 Thread Sebastian Huber 
Close #3981.
---
 bsps/shared/rtems-version.c   | 3 ++-
 cpukit/include/rtems/system.h | 9 -
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/bsps/shared/rtems-version.c b/bsps/shared/rtems-version.c
index 26f7a5731a..930e643484 100644
--- a/bsps/shared/rtems-version.c
+++ b/bsps/shared/rtems-version.c
@@ -8,7 +8,8 @@
  */
 
 #include 
-#include 
+#include 
+#include 
 
 #include 
 
diff --git a/cpukit/include/rtems/system.h b/cpukit/include/rtems/system.h
index a1018e2c86..78332e3bfa 100644
--- a/cpukit/include/rtems/system.h
+++ b/cpukit/include/rtems/system.h
@@ -37,15 +37,6 @@
 extern "C" {
 #endif
 
-#ifndef ASM
-
-/**
- *  The following is the extern for the RTEMS copyright string.
- */
-extern RTEMS_DEPRECATED const char _Copyright_Notice[];
-
-#endif /* ASM */
-
 #ifdef __cplusplus
 }
 #endif
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 14/16] rtems: Remove support for RTEMS_DEPRECATED_TYPES

2020-07-12 Thread Sebastian Huber 
Close #3584.
---
 cpukit/include/rtems/rtems/types.h| 23 ---
 cpukit/include/rtems/score/basedefs.h |  6 --
 2 files changed, 29 deletions(-)

diff --git a/cpukit/include/rtems/rtems/types.h 
b/cpukit/include/rtems/rtems/types.h
index 994e097afa..e5dd1afc3b 100644
--- a/cpukit/include/rtems/rtems/types.h
+++ b/cpukit/include/rtems/rtems/types.h
@@ -44,29 +44,6 @@ extern "C" {
  */
 /**@{**/
 
-#ifdef RTEMS_DEPRECATED_TYPES
-/**
- * @brief Single precision float type.
- *
- * @deprecated Use @c float instead.
- */
-typedef single_precision rtems_single RTEMS_DEPRECATED;
-
-/**
- * @brief Double precision float type.
- *
- * @deprecated Use @c double instead.
- */
-typedef double_precision rtems_double RTEMS_DEPRECATED;
-
-/**
- * @brief RTEMS boolean type.
- *
- * @deprecated Use @c bool instead
- */
-typedef boolean  rtems_boolean RTEMS_DEPRECATED;
-#endif
-
 /**
  * @brief Classic API @ref ClassicRTEMSSubSecObjectNames "object name" type.
  *
diff --git a/cpukit/include/rtems/score/basedefs.h 
b/cpukit/include/rtems/score/basedefs.h
index 01c773ffe9..95d5fc2999 100644
--- a/cpukit/include/rtems/score/basedefs.h
+++ b/cpukit/include/rtems/score/basedefs.h
@@ -549,12 +549,6 @@ extern void RTEMS_DEQUALIFY_types_not_compatible(void);
 #define RTEMS_XSTRING( _x ) RTEMS_STRING( _x )
 
 #ifndef ASM
-  #ifdef RTEMS_DEPRECATED_TYPES
-typedef bool boolean RTEMS_DEPRECATED;
-typedef float single_precision RTEMS_DEPRECATED;
-typedef double double_precision RTEMS_DEPRECATED;
-  #endif
-
   /**
* XXX: Eventually proc_ptr needs to disappear!!!
*/
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 05/16] rtems: Remove deprecated rtems_io_lookup_name()

2020-07-12 Thread Sebastian Huber 
Close #3420.
---
 cpukit/include/rtems/io.h  | 17 +
 cpukit/libfs/src/imfs/ioman.c  | 21 -
 testsuites/sptests/sp21/init.c | 21 -
 3 files changed, 1 insertion(+), 58 deletions(-)

diff --git a/cpukit/include/rtems/io.h b/cpukit/include/rtems/io.h
index 972a0aa431..f4066b647a 100644
--- a/cpukit/include/rtems/io.h
+++ b/cpukit/include/rtems/io.h
@@ -4,7 +4,7 @@
  * @brief Classic Input/Output Manager API
  * 
  * This file emulates the old Classic RTEMS IO manager directives
- * which register and lookup names using the in-memory filesystem.
+ * which register names using the in-memory filesystem.
  */
 
 /*
@@ -231,21 +231,6 @@ rtems_status_code rtems_io_control(
 
 /** @} */
 
-typedef struct {
-const char   *device_name;
-size_tdevice_name_length;
-rtems_device_major_number major;
-rtems_device_minor_number minor;
-} rtems_driver_name_t;
-
-/**
- * @deprecated Use stat() instead.
- */
-rtems_status_code rtems_io_lookup_name(
-const char   *name,
-rtems_driver_name_t  *device_info
-) RTEMS_DEPRECATED;
-
 #ifdef __cplusplus
 }
 #endif
diff --git a/cpukit/libfs/src/imfs/ioman.c b/cpukit/libfs/src/imfs/ioman.c
index 59b93e400c..55fb1728b5 100644
--- a/cpukit/libfs/src/imfs/ioman.c
+++ b/cpukit/libfs/src/imfs/ioman.c
@@ -45,24 +45,3 @@ rtems_status_code rtems_io_register_name(
 
   return RTEMS_SUCCESSFUL;
 }
-
-rtems_status_code rtems_io_lookup_name(
-  const char   *name,
-  rtems_driver_name_t  *device_info
-)
-{
-  rtems_status_code sc = RTEMS_SUCCESSFUL;
-  struct stat st;
-  int rv = stat( name, &st );
-
-  if ( rv == 0 && S_ISCHR( st.st_mode ) ) {
-device_info->device_name = name;
-device_info->device_name_length = strlen( name );
-device_info->major = rtems_filesystem_dev_major_t( st.st_rdev );
-device_info->minor = rtems_filesystem_dev_minor_t( st.st_rdev );
-  } else {
-sc = RTEMS_UNSATISFIED;
-  }
-
-  return sc;
-}
diff --git a/testsuites/sptests/sp21/init.c b/testsuites/sptests/sp21/init.c
index f44f2ba851..bd0ae2b6a1 100644
--- a/testsuites/sptests/sp21/init.c
+++ b/testsuites/sptests/sp21/init.c
@@ -21,7 +21,6 @@ const char rtems_test_name[] = "SP 21";
 /* forward declarations to avoid warnings */
 rtems_task Init(rtems_task_argument argument);
 void do_test_io_manager(void);
-void do_test_io_lookup_name(void);
 void do_test_zero_driver(void);
 
 #define PRIurtems_device_major_number PRIu32
@@ -193,24 +192,6 @@ void do_test_io_manager(void)
   puts( "rtems_io_unregister_driver - RTEMS_SUCCESSFUL" );
 }
 
-void do_test_io_lookup_name(void)
-{
-  rtems_status_codesc;
-  rtems_driver_name_t  info;
-
-  puts( "rtems_io_lookup_name( \"\", &info ) - RTEMS_UNSATISFIED" );
-  sc = rtems_io_lookup_name( "", &info );
-  fatal_directive_status( sc, RTEMS_UNSATISFIED, "lookup empty string" );
-  
-  puts( "rtems_io_lookup_name( \"/dev\", &info ) - RTEMS_UNSATISFIED" );
-  sc = rtems_io_lookup_name( "/dev", &info );
-  fatal_directive_status( sc, RTEMS_UNSATISFIED, "lookup empty string" );
-
-  puts( "rtems_io_lookup_name( \"/dev/null\", &info ) - RTEMS_SUCCESSFUL" );
-  sc = rtems_io_lookup_name( "/dev/null", &info );
-  directive_failed( sc, "lookup /dev/null" );
-}
-
 void do_test_zero_driver(void)
 {
   rtems_status_code sc = RTEMS_SUCCESSFUL;
@@ -258,8 +239,6 @@ rtems_task Init(
 
   do_test_io_manager();
 
-  do_test_io_lookup_name();
-
   do_test_zero_driver();
 
   TEST_END();
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 01/16] rtems: Remove _RTEMS_version

2020-07-12 Thread Sebastian Huber 
Move declaration and rename constant in _Version_String.

Close #3978.
---
 bsps/shared/rtems-version.c | 2 +-
 cpukit/include/rtems/score/copyrt.h | 5 +
 cpukit/include/rtems/system.h   | 6 --
 cpukit/sapi/src/getversionstring.c  | 5 ++---
 testsuites/sptests/spsize/size.c| 2 +-
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/bsps/shared/rtems-version.c b/bsps/shared/rtems-version.c
index 99b98966e6..26f7a5731a 100644
--- a/bsps/shared/rtems-version.c
+++ b/bsps/shared/rtems-version.c
@@ -25,7 +25,7 @@
 #error "Missing RTEMS_BSP"
 #endif
 
-const char _RTEMS_version[] =
+const char _Version_String[] =
   "rtems-" RTEMS_VERSION " (" CPU_NAME "/" CPU_MODEL_NAME "/"
   RTEMS_XSTRING( RTEMS_BSP ) ")";
 
diff --git a/cpukit/include/rtems/score/copyrt.h 
b/cpukit/include/rtems/score/copyrt.h
index c7b00b4247..7addf4dbda 100644
--- a/cpukit/include/rtems/score/copyrt.h
+++ b/cpukit/include/rtems/score/copyrt.h
@@ -41,6 +41,11 @@ extern "C" {
  */
 extern const char _Copyright_Notice[];
 
+/**
+ * @brief The RTEMS version string.
+ */
+extern const char _Version_String[];
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/cpukit/include/rtems/system.h b/cpukit/include/rtems/system.h
index 032ac56a95..3a2dff9721 100644
--- a/cpukit/include/rtems/system.h
+++ b/cpukit/include/rtems/system.h
@@ -39,12 +39,6 @@ extern "C" {
 
 #ifndef ASM
 
-/*
- * The use of this variable is deprecated, use rtems_get_version_string()
- * instead.
- */
-extern RTEMS_DEPRECATED const char _RTEMS_version[];
-
 /**
  *  The following is the extern for the RTEMS copyright string.
  */
diff --git a/cpukit/sapi/src/getversionstring.c 
b/cpukit/sapi/src/getversionstring.c
index f3fada9c48..4f29db0350 100644
--- a/cpukit/sapi/src/getversionstring.c
+++ b/cpukit/sapi/src/getversionstring.c
@@ -19,11 +19,10 @@
 #include "config.h"
 #endif
 
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-
 #include 
+#include 
 
 const char *rtems_get_version_string(void)
 {
-  return _RTEMS_version;
+  return _Version_String;
 }
diff --git a/testsuites/sptests/spsize/size.c b/testsuites/sptests/spsize/size.c
index d26e34f51d..ca6c3fc538 100644
--- a/testsuites/sptests/spsize/size.c
+++ b/testsuites/sptests/spsize/size.c
@@ -432,7 +432,7 @@ uninitialized += (sizeof _CPU_Interrupt_stack_low) +
 
 initialized +=
 /*copyrt.h*/(strlen(_Copyright_Notice)+1) +
-(strlen(_RTEMS_version)+1);
+(strlen(_Version_String)+1);
 
 
 
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 15/16] rtems: Remove deprecated proc_ptr definition

2020-07-12 Thread Sebastian Huber 
Close #3586.
---
 cpukit/include/rtems/score/basedefs.h | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/cpukit/include/rtems/score/basedefs.h 
b/cpukit/include/rtems/score/basedefs.h
index 95d5fc2999..e301292375 100644
--- a/cpukit/include/rtems/score/basedefs.h
+++ b/cpukit/include/rtems/score/basedefs.h
@@ -548,13 +548,6 @@ extern void RTEMS_DEQUALIFY_types_not_compatible(void);
  */
 #define RTEMS_XSTRING( _x ) RTEMS_STRING( _x )
 
-#ifndef ASM
-  /**
-   * XXX: Eventually proc_ptr needs to disappear!!!
-   */
-  typedef void * proc_ptr RTEMS_DEPRECATED;
-#endif
-
 /** @} */
 
 #endif /* _RTEMS_BASEDEFS_H */
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 12/16] rtems: Remove region_information_block

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3592.
---
 cpukit/include/rtems/rtems/types.h | 6 --
 1 file changed, 6 deletions(-)

diff --git a/cpukit/include/rtems/rtems/types.h 
b/cpukit/include/rtems/rtems/types.h
index cf748a0a5f..51b8297113 100644
--- a/cpukit/include/rtems/rtems/types.h
+++ b/cpukit/include/rtems/rtems/types.h
@@ -102,12 +102,6 @@ typedef Objects_Id   rtems_id;
 typedef CPU_Interrupt_framertems_interrupt_frame;
 #endif
 
-/**
- * @brief Information structure returned by the Heap Handler via the Region
- * Manager.
- */
-typedef Heap_Information_block region_information_block RTEMS_DEPRECATED;
-
 /**
  * @brief Used to manage and manipulate intervals specified by
  * @ref ClassicRTEMSSecTime "clock ticks".
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 09/16] rtems: Remove rtems_rate_monotonic_period_time_t

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3596.
---
 cpukit/include/rtems/rtems/ratemon.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/cpukit/include/rtems/rtems/ratemon.h 
b/cpukit/include/rtems/rtems/ratemon.h
index c5918372a8..16d390d59f 100644
--- a/cpukit/include/rtems/rtems/ratemon.h
+++ b/cpukit/include/rtems/rtems/ratemon.h
@@ -55,8 +55,6 @@ extern "C" {
  */
 /**@{*/
 
-typedef struct timespec rtems_rate_monotonic_period_time_t RTEMS_DEPRECATED;
-
 /**
  *  The following enumerated type defines the states in which a
  *  period may be.
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 10/16] rtems: Remove rtems_context

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3588.
---
 cpukit/include/rtems/rtems/types.h | 5 -
 1 file changed, 5 deletions(-)

diff --git a/cpukit/include/rtems/rtems/types.h 
b/cpukit/include/rtems/rtems/types.h
index b0600eb0a8..870d443dfe 100644
--- a/cpukit/include/rtems/rtems/types.h
+++ b/cpukit/include/rtems/rtems/types.h
@@ -89,11 +89,6 @@ typedef Objects_Id   rtems_id;
  */
 #define RTEMS_ID_NONE OBJECTS_ID_NONE
 
-/**
- * @brief Public name for task context area.
- */
-typedef Context_Controlrtems_context RTEMS_DEPRECATED;
-
 #if (CPU_HARDWARE_FP == TRUE) || (CPU_SOFTWARE_FP == TRUE)
 /**
  * @brief Public name for task floating point context area.
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 11/16] rtems: Remove rtems_context_fp

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3590.
---
 cpukit/include/rtems/rtems/types.h | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/cpukit/include/rtems/rtems/types.h 
b/cpukit/include/rtems/rtems/types.h
index 870d443dfe..cf748a0a5f 100644
--- a/cpukit/include/rtems/rtems/types.h
+++ b/cpukit/include/rtems/rtems/types.h
@@ -89,13 +89,6 @@ typedef Objects_Id   rtems_id;
  */
 #define RTEMS_ID_NONE OBJECTS_ID_NONE
 
-#if (CPU_HARDWARE_FP == TRUE) || (CPU_SOFTWARE_FP == TRUE)
-/**
- * @brief Public name for task floating point context area.
- */
-typedef Context_Control_fp rtems_context_fp RTEMS_DEPRECATED;
-#endif
-
 #if (CPU_ISR_PASSES_FRAME_POINTER == TRUE)
 /**
  * @brief Defines the format of the interrupt stack frame as it appears to a
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 02/16] rtems: Remove RTEMS_MAXIMUM_NAME_LENGTH

2020-07-12 Thread Sebastian Huber 
Close #3979.
---
 cpukit/include/rtems/system.h | 4 
 1 file changed, 4 deletions(-)

diff --git a/cpukit/include/rtems/system.h b/cpukit/include/rtems/system.h
index 3a2dff9721..a1018e2c86 100644
--- a/cpukit/include/rtems/system.h
+++ b/cpukit/include/rtems/system.h
@@ -44,10 +44,6 @@ extern "C" {
  */
 extern RTEMS_DEPRECATED const char _Copyright_Notice[];
 
-typedef RTEMS_DEPRECATED uint32_t RTEMS_MAXIMUM_NAME_LENGTH;
-/* The use of this define is deprecated, use sizeof(rtems_name) instead */
-#define RTEMS_MAXIMUM_NAME_LENGTH sizeof(RTEMS_MAXIMUM_NAME_LENGTH)
-
 #endif /* ASM */
 
 #ifdef __cplusplus
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 08/16] rtems: Remove deprecated rtems_extension

2020-07-12 Thread Sebastian Huber 
This type was deprecated in RTEMS 5.1.

Close #3988.
---
 cpukit/include/rtems/extension.h | 3 ---
 cpukit/include/rtems/score/userext.h | 2 --
 2 files changed, 5 deletions(-)

diff --git a/cpukit/include/rtems/extension.h b/cpukit/include/rtems/extension.h
index ec9ad7f83f..59d4839bf4 100644
--- a/cpukit/include/rtems/extension.h
+++ b/cpukit/include/rtems/extension.h
@@ -26,9 +26,6 @@
 extern "C" {
 #endif
 
-typedef User_extensions_routine
-  rtems_extension RTEMS_DEPRECATED;
-
 /**
  * @defgroup ClassicUserExtensions User Extensions
  *
diff --git a/cpukit/include/rtems/score/userext.h 
b/cpukit/include/rtems/score/userext.h
index aec795cd57..4d41212957 100644
--- a/cpukit/include/rtems/score/userext.h
+++ b/cpukit/include/rtems/score/userext.h
@@ -26,8 +26,6 @@ extern "C" {
 
 struct _Thread_Control;
 
-typedef void User_extensions_routine RTEMS_DEPRECATED;
-
 /**
  * @defgroup RTEMSScoreUserExt User Extension Handler
  *
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 04/16] rtems: Remove deprecated

2020-07-12 Thread Sebastian Huber 
Close #3980.
---
 cpukit/headers.am |  1 -
 cpukit/include/rtems.h|  1 -
 cpukit/include/rtems/system.h | 46 ---
 3 files changed, 48 deletions(-)
 delete mode 100644 cpukit/include/rtems/system.h

diff --git a/cpukit/headers.am b/cpukit/headers.am
index fcf679f09d..dd38c69242 100644
--- a/cpukit/headers.am
+++ b/cpukit/headers.am
@@ -166,7 +166,6 @@ include_rtems_HEADERS += include/rtems/status-checks.h
 include_rtems_HEADERS += include/rtems/stdio-redirect.h
 include_rtems_HEADERS += include/rtems/stringto.h
 include_rtems_HEADERS += include/rtems/sysinit.h
-include_rtems_HEADERS += include/rtems/system.h
 include_rtems_HEADERS += include/rtems/telnetd.h
 include_rtems_HEADERS += include/rtems/termios_printk.h
 include_rtems_HEADERS += include/rtems/termios_printk_cnf.h
diff --git a/cpukit/include/rtems.h b/cpukit/include/rtems.h
index 1b91965563..4392f08ce8 100644
--- a/cpukit/include/rtems.h
+++ b/cpukit/include/rtems.h
@@ -26,7 +26,6 @@
  */
 /** @{ */
 
-#include 
 #include 
 #include 
 
diff --git a/cpukit/include/rtems/system.h b/cpukit/include/rtems/system.h
deleted file mode 100644
index 78332e3bfa..00
--- a/cpukit/include/rtems/system.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/**
- * @file
- *
- * @brief Information Included in Every Function in the Executive
- *
- * This include file contains information that is included in every
- * function in the executive.  This must be the first include file
- * included in all internal RTEMS files.
- */
-
-/*
- *  COPYRIGHT (c) 1989-2007.
- *  On-Line Applications Research Corporation (OAR).
- *
- *  The license and distribution terms for this file may be
- *  found in the file LICENSE in this distribution or at
- *  http://www.rtems.org/license/LICENSE.
- */
-
-#ifndef _RTEMS_SYSTEM_H
-#define _RTEMS_SYSTEM_H
-
-#include 
-
-#ifndef _RTEMS_H
-#warning "This header file is deprecated and will be removed in RTEMS 6"
-#endif
-
-/**
- *  @defgroup RTEMSScoreSystem System Information
- *
- *  @ingroup RTEMSScore
- */
-/**@{*/
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-#ifdef __cplusplus
-}
-#endif
-
-/**@}*/
-#endif
-/* end of include file */
-- 
2.26.2

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 01/16] rtems: Remove _RTEMS_version

2020-07-12 Thread Sebastian Huber 

On 13/07/2020 08:51, Sebastian Huber wrote:

diff --git a/bsps/shared/rtems-version.c b/bsps/shared/rtems-version.c
index 99b98966e6..26f7a5731a 100644
--- a/bsps/shared/rtems-version.c
+++ b/bsps/shared/rtems-version.c
@@ -25,7 +25,7 @@
  #error "Missing RTEMS_BSP"
  #endif
  
-const char _RTEMS_version[] =

+const char _Version_String[] =


Now I think that renaming this variable is unnecessary. We should just 
move the declaration and keep the name as is.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel