[PATCH] user: add a warning not to use special characters in pathnames

[Joel Sherrill]

From: Marçal Comajoan Cara 

Spaces and other specical characters in pathnames break builds of any
software packages using GNU make.

All of the GNU tools and RTEMS use make and this breaks builds. This
is a long standing known issue with GNU make, which can't handle spaces
in pathnames:

https://savannah.gnu.org/bugs/?712

This work was part of GCI 2018.

Probably closes #3450.
---
 user/hosts/os.rst | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/user/hosts/os.rst b/user/hosts/os.rst
index 82ff4de..d9fe943 100644
--- a/user/hosts/os.rst
+++ b/user/hosts/os.rst
@@ -63,6 +63,13 @@ proven over the years to be difficult to manage in 
production systems.
 means it is searched first and the RTEMS needed versions of the tools are
 used.
 
+.. warning::
+
+Do not put spaces or special characters in the directories you use to build
+RTEMS. Many of the packages built by the RSB use GNU *make*, which cannot
+handle spaces in pathnames. If there is a space in the pathname the build
+will fail. Special characters are also likely to confuse build systems.
+
 .. note::
 
 RSB and RTEMS have a matching *git branch* for each version of RTEMS. For
-- 
1.8.3.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] rtemstoolkit/path : Add support to copy single files

[Vijay Kumar Banerjee]

On Wed, 7 Nov 2018 at 13:11, Vijay Kumar Banerjee 
wrote:

> ---
>  rtemstoolkit/path.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/rtemstoolkit/path.py b/rtemstoolkit/path.py
> index 760f4bd..83fb361 100644
> --- a/rtemstoolkit/path.py
> +++ b/rtemstoolkit/path.py
> @@ -191,10 +191,11 @@ def copy_tree(src, dst):
>  hsrc = host(src)
>  hdst = host(dst)
>
> -if os.path.exists(src):
> +if os.path.exists(src) and os.path.isdir(src):
>  names = os.listdir(src)
>  else:
> -name = []
> +names = [basename(src)]
> +src = dirname(src)
>
>  if not os.path.isdir(dst):
>  os.makedirs(dst)
> --
> 2.17.2
>
ping :)
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 1/2] Coverage: add the style and js files to the symbol-set report directory

[Vijay Kumar Banerjee]

On Wed, 7 Nov 2018 at 13:11, Vijay Kumar Banerjee 
wrote:

> ---
>  tester/rt/coverage.py | 17 -
>  1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py
> index 978a8c4..cfac464 100644
> --- a/tester/rt/coverage.py
> +++ b/tester/rt/coverage.py
> @@ -201,23 +201,14 @@ class report_gen_html:
>  index_content = self._prepare_index_content(partial_reports)
>  self._create_index_file(head_section,index_content)
>
> -def add_covoar_src_path(self):
> +def add_covoar_css(self):
>  table_js_path = path.join(self.covoar_src_path, 'table.js')
>  covoar_css_path = path.join(self.covoar_src_path, 'covoar.css')
>  for symbol_set in self.symbol_sets:
>  symbol_set_dir = path.join(self.build_dir,
> self.bsp + '-coverage', symbol_set)
> -html_files = os.listdir(symbol_set_dir)
> -for html_file in html_files:
> -html_file = path.join(symbol_set_dir, html_file)
> -if path.exists(html_file) and 'html' in html_file:
> -with open(html_file, 'r') as f:
> -file_data = f.read()
> -file_data = file_data.replace('table.js',
> table_js_path)
> -file_data = file_data.replace('covoar.css',
> -  covoar_css_path)
> -with open(html_file, 'w') as f:
> -f.write(file_data)
> +path.copy_tree(covoar_css_path, symbol_set_dir)
> +path.copy_tree(table_js_path, symbol_set_dir)
>
>  class build_path_generator(object):
>  '''
> @@ -402,7 +393,7 @@ class coverage_run(object):
>   self.rtdir,
>   self.macros['bsp'])
>  report.generate()
> -report.add_covoar_src_path()
> +report.add_covoar_css()
>
>  def _cleanup(self):
>  if not self.no_clean:
> --
> 2.17.2
>
> ping :)
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

qemu for riscv not in RSB

[Joel Sherrill]

Hi

I was trying to duplicate Sebastian's RISC-V testing for rv64imafd_medany
and found that
qemu-system-riscv* does not seem to be in our qemu RSB configuration.

Where is this supposed to come from? Is it time to bump our qemu
configuration?

Thanks

--joel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] rtemstoolkit/path : Add support to copy single files

[Chris Johns]

On 15/11/2018 05:49, Vijay Kumar Banerjee wrote:
> 
> On Wed, 7 Nov 2018 at 13:11, Vijay Kumar Banerjee  > wrote:
> 
> ---
>  rtemstoolkit/path.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/rtemstoolkit/path.py b/rtemstoolkit/path.py
> index 760f4bd..83fb361 100644
> --- a/rtemstoolkit/path.py
> +++ b/rtemstoolkit/path.py
> @@ -191,10 +191,11 @@ def copy_tree(src, dst):
>      hsrc = host(src)
>      hdst = host(dst)
> 
> -    if os.path.exists(src):
> +    if os.path.exists(src) and os.path.isdir(src):
>          names = os.listdir(src)
>      else:
> -        name = []
> +        names = [basename(src)]
> +        src = dirname(src)
> 
>      if not os.path.isdir(dst):
>          os.makedirs(dst)
> -- 
> 2.17.2
> 
> ping :) 

Sorry about the delay. OK to push.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] rtemstoolkit/path : Add support to copy single files

[Chris Johns]

On 15/11/2018 05:49, Vijay Kumar Banerjee wrote:
> On Wed, 7 Nov 2018 at 13:11, Vijay Kumar Banerjee  > wrote:
> 
> ---
>  rtemstoolkit/path.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/rtemstoolkit/path.py b/rtemstoolkit/path.py
> index 760f4bd..83fb361 100644
> --- a/rtemstoolkit/path.py
> +++ b/rtemstoolkit/path.py
> @@ -191,10 +191,11 @@ def copy_tree(src, dst):
>      hsrc = host(src)
>      hdst = host(dst)
> 
> -    if os.path.exists(src):
> +    if os.path.exists(src) and os.path.isdir(src):
>          names = os.listdir(src)
>      else:
> -        name = []
> +        names = [basename(src)]
> +        src = dirname(src)
> 
>      if not os.path.isdir(dst):
>          os.makedirs(dst)
> -- 
> 2.17.2
> 
> ping :) 

OK to push.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Git hook changes.

[Amar Takhar]

I've mucked about with the Git hooks in a question to fix the issue with not 
all 
tickets updating in track.  I belive I've fixed it see my note here:

  https://devel.rtems.org/ticket/3561#comment:9

If you see any errors when committing please let me know directly it should be 
fine but just in case. :)


Amar.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: qemu for riscv not in RSB

[Sebastian Huber]

On 14/11/2018 22:07, Joel Sherrill wrote:

Hi

I was trying to duplicate Sebastian's RISC-V testing for 
rv64imafd_medany and found that

qemu-system-riscv* does not seem to be in our qemu RSB configuration.

Where is this supposed to come from? Is it time to bump our qemu 
configuration?


I had to use the RISC-V Qemu repository. The upstream Qemu didn't work.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Added new test suite psxtmthreadattr01 (GCI 2018)

[Himanshu Sekhar Nayak]

Hi guys,
Here is the patch file for the new test suite.

Thanks
Himanshu Sekhar Nayak
From f9c332a52f2588f827dbd0d0783f7c6886258368 Mon Sep 17 00:00:00 2001
From: Himanshu40 
Date: Thu, 15 Nov 2018 11:48:48 +0530
Subject: [PATCH] Added new test suite psxtmthreadattr01(GCI 2018)

---
 testsuites/psxtmtests/Makefile.am |  11 +
 testsuites/psxtmtests/configure.ac|   1 +
 testsuites/psxtmtests/psxtmtests_plan.csv |  34 +-
 .../psxtmtests/psxtmthreadattr01/init.c   | 423 ++
 .../psxtmthreadattr01/psxtmthreadattr01.doc   |  33 ++
 5 files changed, 485 insertions(+), 17 deletions(-)
 create mode 100644 testsuites/psxtmtests/psxtmthreadattr01/init.c
 create mode 100644 testsuites/psxtmtests/psxtmthreadattr01/psxtmthreadattr01.doc

diff --git a/testsuites/psxtmtests/Makefile.am b/testsuites/psxtmtests/Makefile.am
index 5af13e48a0..124f1414f7 100644
--- a/testsuites/psxtmtests/Makefile.am
+++ b/testsuites/psxtmtests/Makefile.am
@@ -569,5 +569,16 @@ psxtmthread06_CPPFLAGS = $(AM_CPPFLAGS) $(TEST_FLAGS_psxtmthread06) \
 	-DOPERATION_COUNT=$(OPERATION_COUNT)
 endif
 
+if TEST_psxtmthreadattr01
+psxtm_tests += psxtmthreadattr01
+psxtm_docs += psxtmthreadattr01/psxtmthreadattr01.doc
+psxtmthreadattr01_SOURCES = psxtmthreadattr01/init.c \
+	../tmtests/include/timesys.h ../support/src/tmtests_empty_function.c \
+	../support/src/tmtests_support.c
+psxtmthreadattr01_CPPFLAGS = $(AM_CPPFLAGS) $(TEST_FLAGS_psxtmthreadattr01) \
+	$(support_includes) -I$(top_srcdir)/../tmtests/include \
+	-DOPERATION_COUNT=$(OPERATION_COUNT)
+endif
+
 rtems_tests_PROGRAMS = $(psxtm_tests)
 dist_rtems_tests_DATA = $(psxtm_screens) $(psxtm_docs)
diff --git a/testsuites/psxtmtests/configure.ac b/testsuites/psxtmtests/configure.ac
index 0c3b1438e0..dde3e9b879 100644
--- a/testsuites/psxtmtests/configure.ac
+++ b/testsuites/psxtmtests/configure.ac
@@ -80,6 +80,7 @@ RTEMS_TEST_CHECK([psxtmthread03])
 RTEMS_TEST_CHECK([psxtmthread04])
 RTEMS_TEST_CHECK([psxtmthread05])
 RTEMS_TEST_CHECK([psxtmthread06])
+RTEMS_TEST_CHECK([psxtmthreadattr01])
 
 AC_CONFIG_FILES([Makefile])
 AC_OUTPUT
diff --git a/testsuites/psxtmtests/psxtmtests_plan.csv b/testsuites/psxtmtests/psxtmtests_plan.csv
index 6066429b74..3e31eed76d 100644
--- a/testsuites/psxtmtests/psxtmtests_plan.csv
+++ b/testsuites/psxtmtests/psxtmtests_plan.csv
@@ -45,23 +45,23 @@
 "pthread_create: no preempt","psxtmthread01","psxtmtest_single","Yes"
 "pthread_create: preempt","psxtmthread02","psxtmtest_single","Yes"
 
-"pthread_attr_init: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_destroy: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getdetachstate: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getguardsize: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getinheritsched: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getschedparam: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getschedpolicy: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getscope: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getstack: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_getstacksize: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setdetachstate: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setguardsize: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setinheritsched: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setschedparam: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setschedpolicy: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setscope: only case", "psxtmthreadattr01", "psxtmtest_single","No"
-"pthread_attr_setstack: only case", "psxtmthreadattr01", "psxtmtest_single","No"
+"pthread_attr_init: only case", "psxtmthreadattr01", "psxtmtest_init_destroy","Yes"
+"pthread_attr_destroy: only case", "psxtmthreadattr01", "psxtmtest_init_destroy","Yes"
+"pthread_attr_getdetachstate: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getguardsize: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getinheritsched: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getschedparam: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getschedpolicy: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getscope: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getstack: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_getstacksize: only case", "psxtmthreadattr01", "psxtmtest_single","yes"
+"pthread_attr_setdetachstate: only case", "psxtmthreadattr01", "psxtmtest_single","Yes"
+"pthread_attr_setguardsize: only case", "psxtmthreadattr01", "psxtmtest_single