Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

2018-07-10 Thread Vijay Kumar Banerjee 
ping :)
On 6 July 2018 at 02:08, Vijay Kumar Banerjee 
wrote:

> Hello Chris,
>
> If you find some time, please review this patch.
> It's a small patch but it's important since it affects how the command
> will look like.
>
> please review if this patch is alright or we need to have a different
> approach.
>
> Thanks
> On 3 July 2018 at 20:30, Vijay Kumar Banerjee 
> wrote:
>
>> Close #3440
>> ---
>>  tester/rt/test.py| 21 ++---
>>  tester/rtems/testing/bsps/leon3-qemu-cov.ini |  1 +
>>  2 files changed, 15 insertions(+), 7 deletions(-)
>>
>> diff --git a/tester/rt/test.py b/tester/rt/test.py
>> index 9214ad6..5d25d82 100644
>> --- a/tester/rt/test.py
>> +++ b/tester/rt/test.py
>> @@ -232,7 +232,7 @@ def run(command_path = None):
>>  '--filter': 'Glob that executables must
>> match to run (default: ' +
>>default_exefilter + ')',
>>  '--stacktrace': 'Dump a stack trace on a user
>> termination (^C)',
>> -'--coverage':   'Perform coverage analysis of
>> test executables.'}
>> +'--coverage-sets':  'Perform coverage analysis for
>> specific sets.'}
>>  mailer.append_options(optargs)
>>  opts = options.load(sys.argv,
>>  optargs = optargs,
>> @@ -283,14 +283,21 @@ def run(command_path = None):
>>  raise error.general('RTEMS BSP not provided or an invalid
>> option')
>>  bsp = config.load(bsp[1], opts)
>>  bsp_config = opts.defaults.expand(opts.defaults['tester'])
>> -coverage_enabled = opts.find_arg('--coverage')
>> +coverage_sets = opts.find_arg('--coverage-sets')
>> +try:
>> +coverage_enabled = opts.defaults.get('coverage')
>> +except:
>> +coverage_enabled = False
>>  if coverage_enabled:
>>  cov_trace = 'cov' in debug_trace.split(',')
>> -if len(coverage_enabled) == 2:
>> -coverage_runner = coverage.coverage_run(opts.defaults,
>> -executables,
>> -symbol_set =
>> coverage_enabled[1],
>> -trace =
>> cov_trace)
>> +if coverage_sets:
>> +if len(coverage_sets) != 2:
>> +raise error.general('No sets provided in
>> --coverage-sets')
>> +else:
>> +coverage_runner = coverage.coverage_run(opts.def
>> aults,
>> +executables,
>> +symbol_set =
>> coverage_sets[1],
>> +trace =
>> cov_trace)
>>  else:
>>  coverage_runner = coverage.coverage_run(opts.defaults,
>>  executables,
>> diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> index 2f89117..6462448 100644
>> --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>> @@ -38,3 +38,4 @@ target= sparc-rtems5
>>  tester= %{_rtscripts}/qemu.cfg
>>  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
>>  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
>> +coverage  = True
>> --
>> 2.14.4
>>
>>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

2018-07-10 Thread Gedare Bloom 
I don't see any problem with it, but I prefer to let Chris decide on merging...

On Tue, Jul 10, 2018 at 8:11 AM, Vijay Kumar Banerjee
 wrote:
> ping :)
>
> On 6 July 2018 at 02:08, Vijay Kumar Banerjee 
> wrote:
>>
>> Hello Chris,
>>
>> If you find some time, please review this patch.
>> It's a small patch but it's important since it affects how the command
>> will look like.
>>
>> please review if this patch is alright or we need to have a different
>> approach.
>>
>> Thanks
>> On 3 July 2018 at 20:30, Vijay Kumar Banerjee 
>> wrote:
>>>
>>> Close #3440
>>> ---
>>>  tester/rt/test.py| 21 ++---
>>>  tester/rtems/testing/bsps/leon3-qemu-cov.ini |  1 +
>>>  2 files changed, 15 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/tester/rt/test.py b/tester/rt/test.py
>>> index 9214ad6..5d25d82 100644
>>> --- a/tester/rt/test.py
>>> +++ b/tester/rt/test.py
>>> @@ -232,7 +232,7 @@ def run(command_path = None):
>>>  '--filter': 'Glob that executables must
>>> match to run (default: ' +
>>>default_exefilter + ')',
>>>  '--stacktrace': 'Dump a stack trace on a user
>>> termination (^C)',
>>> -'--coverage':   'Perform coverage analysis of
>>> test executables.'}
>>> +'--coverage-sets':  'Perform coverage analysis for
>>> specific sets.'}
>>>  mailer.append_options(optargs)
>>>  opts = options.load(sys.argv,
>>>  optargs = optargs,
>>> @@ -283,14 +283,21 @@ def run(command_path = None):
>>>  raise error.general('RTEMS BSP not provided or an invalid
>>> option')
>>>  bsp = config.load(bsp[1], opts)
>>>  bsp_config = opts.defaults.expand(opts.defaults['tester'])
>>> -coverage_enabled = opts.find_arg('--coverage')
>>> +coverage_sets = opts.find_arg('--coverage-sets')
>>> +try:
>>> +coverage_enabled = opts.defaults.get('coverage')
>>> +except:
>>> +coverage_enabled = False
>>>  if coverage_enabled:
>>>  cov_trace = 'cov' in debug_trace.split(',')
>>> -if len(coverage_enabled) == 2:
>>> -coverage_runner = coverage.coverage_run(opts.defaults,
>>> -executables,
>>> -symbol_set =
>>> coverage_enabled[1],
>>> -trace =
>>> cov_trace)
>>> +if coverage_sets:
>>> +if len(coverage_sets) != 2:
>>> +raise error.general('No sets provided in
>>> --coverage-sets')
>>> +else:
>>> +coverage_runner =
>>> coverage.coverage_run(opts.defaults,
>>> +executables,
>>> +symbol_set =
>>> coverage_sets[1],
>>> +trace =
>>> cov_trace)
>>>  else:
>>>  coverage_runner = coverage.coverage_run(opts.defaults,
>>>  executables,
>>> diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> index 2f89117..6462448 100644
>>> --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
>>> @@ -38,3 +38,4 @@ target= sparc-rtems5
>>>  tester= %{_rtscripts}/qemu.cfg
>>>  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
>>>  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
>>> +coverage  = True
>>> --
>>> 2.14.4
>>>
>>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

2018-07-10 Thread Vijay Kumar Banerjee 
On 10 July 2018 at 20:47, Gedare Bloom  wrote:

> I don't see any problem with it, but I prefer to let Chris decide on
> merging...
>
> Thank you for the feedback :)

> On Tue, Jul 10, 2018 at 8:11 AM, Vijay Kumar Banerjee
>  wrote:
> > ping :)
> >
> > On 6 July 2018 at 02:08, Vijay Kumar Banerjee 
> > wrote:
> >>
> >> Hello Chris,
> >>
> >> If you find some time, please review this patch.
> >> It's a small patch but it's important since it affects how the command
> >> will look like.
> >>
> >> please review if this patch is alright or we need to have a different
> >> approach.
> >>
> >> Thanks
> >> On 3 July 2018 at 20:30, Vijay Kumar Banerjee  >
> >> wrote:
> >>>
> >>> Close #3440
> >>> ---
> >>>  tester/rt/test.py| 21
> ++---
> >>>  tester/rtems/testing/bsps/leon3-qemu-cov.ini |  1 +
> >>>  2 files changed, 15 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/tester/rt/test.py b/tester/rt/test.py
> >>> index 9214ad6..5d25d82 100644
> >>> --- a/tester/rt/test.py
> >>> +++ b/tester/rt/test.py
> >>> @@ -232,7 +232,7 @@ def run(command_path = None):
> >>>  '--filter': 'Glob that executables must
> >>> match to run (default: ' +
> >>>default_exefilter + ')',
> >>>  '--stacktrace': 'Dump a stack trace on a user
> >>> termination (^C)',
> >>> -'--coverage':   'Perform coverage analysis of
> >>> test executables.'}
> >>> +'--coverage-sets':  'Perform coverage analysis for
> >>> specific sets.'}
> >>>  mailer.append_options(optargs)
> >>>  opts = options.load(sys.argv,
> >>>  optargs = optargs,
> >>> @@ -283,14 +283,21 @@ def run(command_path = None):
> >>>  raise error.general('RTEMS BSP not provided or an invalid
> >>> option')
> >>>  bsp = config.load(bsp[1], opts)
> >>>  bsp_config = opts.defaults.expand(opts.defaults['tester'])
> >>> -coverage_enabled = opts.find_arg('--coverage')
> >>> +coverage_sets = opts.find_arg('--coverage-sets')
> >>> +try:
> >>> +coverage_enabled = opts.defaults.get('coverage')
> >>> +except:
> >>> +coverage_enabled = False
> >>>  if coverage_enabled:
> >>>  cov_trace = 'cov' in debug_trace.split(',')
> >>> -if len(coverage_enabled) == 2:
> >>> -coverage_runner = coverage.coverage_run(opts.
> defaults,
> >>> -executables,
> >>> -symbol_set =
> >>> coverage_enabled[1],
> >>> -trace =
> >>> cov_trace)
> >>> +if coverage_sets:
> >>> +if len(coverage_sets) != 2:
> >>> +raise error.general('No sets provided in
> >>> --coverage-sets')
> >>> +else:
> >>> +coverage_runner =
> >>> coverage.coverage_run(opts.defaults,
> >>> +
> executables,
> >>> +
> symbol_set =
> >>> coverage_sets[1],
> >>> +trace =
> >>> cov_trace)
> >>>  else:
> >>>  coverage_runner = coverage.coverage_run(opts.
> defaults,
> >>>  executables,
> >>> diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> >>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> >>> index 2f89117..6462448 100644
> >>> --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> >>> +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini
> >>> @@ -38,3 +38,4 @@ target= sparc-rtems5
> >>>  tester= %{_rtscripts}/qemu.cfg
> >>>  bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic
> >>>  bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov
> >>> +coverage  = True
> >>> --
> >>> 2.14.4
> >>>
> >>
> >
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

4.10

2018-07-10 Thread Joel Sherrill 
Hi

I use this to test the master but it doesn't seem to work for 4.10 branch
of rtems-tools.

nohup time ./rtems-tools/tester/rtems-bsp-builder \
  --rtems=/home/joel/rtems-410-work/rtems \
  --build-path=build \
  --prefix=/home/joel/rtems-410-work/bsps \
  --log=build.log \
  --warnings-report=warnings.log \
   --mail \
   --mail-from=j...@rtems.org \
   --mail-to=bu...@rtems.org \
  --profiles=everything \
  --jobs=6/12 \
  > nohup.out 2>&1 &

usage: rtems-bsp-builder [-h] [--prefix PREFIX] [--rtems-tools RTEMS_TOOLS]
 [--rtems RTEMS] [--build-path BUILD_PATH] [--log
LOG]
 [--stop-on-error] [--no-clean] [--profiles
PROFILES]
 [--arch ARCH] [--bsp BSP] [--dry-run]
rtems-bsp-builder: error: unrecognized arguments:
--warnings-report=warnings.log --mail --mail-from=j...@rtems.org --mail-to=
bu...@rtems.org --jobs=6/12

--joel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

2018-07-10 Thread Chris Johns 
On 11/7/18 3:18 am, Vijay Kumar Banerjee wrote:
> On 10 July 2018 at 20:47, Gedare Bloom  > wrote:
> 
> I don't see any problem with it, but I prefer to let Chris decide on 
> merging...
> 
> Thank you for the feedback :) 
>

Sorry for the delay in responding.

I suggest you leave the option as `--coverage` and consider looking at the
`--debug-trace` option as a way to handle sets, for example
`--coverage="sets:xyz,abc",report=gcov`.

The idea is to provide a single option we can add suboption parts.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v3] coverage : Add support to run coverage in supported bsp without extra options

2018-07-10 Thread Vijay Kumar Banerjee 
On 11 July 2018 at 02:49, Chris Johns  wrote:

> On 11/7/18 3:18 am, Vijay Kumar Banerjee wrote:
> > On 10 July 2018 at 20:47, Gedare Bloom  > > wrote:
> >
> > I don't see any problem with it, but I prefer to let Chris decide on
> merging...
> >
> > Thank you for the feedback :)
> >
>
> Sorry for the delay in responding.
>
> I suggest you leave the option as `--coverage` and consider looking at the
> `--debug-trace` option as a way to handle sets, for example
> `--coverage="sets:xyz,abc",report=gcov`.
>
> That's a good idea!
So we leave it for now and make a sub option when we have another report
format (gcov).

> The idea is to provide a single option we can add suboption parts.
>
> Chris
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel