Remove _t from all libdl structures

2018-04-12 Thread Chris Johns
Hi

These patches remove _t from the structures cleaning up the code.

The tests are fixed and will now pass as the file in the tarfiles had
changed name.

Chris

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH 2/2] libdl: Fix the tests loading the correct files

2018-04-12 Thread Chris Johns
---
 testsuites/libtests/Makefile.am |  2 +-
 testsuites/libtests/dl01/dl-load.c  |  4 ++--
 testsuites/libtests/dl02/dl-load.c  |  4 ++--
 testsuites/libtests/dl03/dl-cache.c | 22 +++---
 testsuites/libtests/dl04/dl-load.c  |  2 +-
 testsuites/libtests/dl05/dl-load.c  |  2 +-
 6 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/testsuites/libtests/Makefile.am b/testsuites/libtests/Makefile.am
index 692df90b6f..b786e73e89 100644
--- a/testsuites/libtests/Makefile.am
+++ b/testsuites/libtests/Makefile.am
@@ -364,7 +364,7 @@ dl02-o2.o: dl02/dl-o2.c Makefile
$(AM_V_CC)$(COMPILE) -c -o $@ $<
 dl02.tar: dl02-o1.o dl02-o2.o
@rm -f $@
-   $(AM_V_GEN)$(PAX) -w -f $@ $<
+   $(AM_V_GEN)$(PAX) -w -f $@ $+
 dl02-tar.c: dl02.tar
$(AM_V_GEN)$(BIN2C) -C $< $@
 dl02-tar.h: dl02.tar
diff --git a/testsuites/libtests/dl01/dl-load.c 
b/testsuites/libtests/dl01/dl-load.c
index e8f84bd5b5..5438196e67 100644
--- a/testsuites/libtests/dl01/dl-load.c
+++ b/testsuites/libtests/dl01/dl-load.c
@@ -28,9 +28,9 @@ int dl_load_test(void)
   intunresolved;
   char*  message = "loaded";
 
-  printf("load: /dl-o1.o\n");
+  printf("load: /dl01-o1.o\n");
 
-  handle = dlopen ("/dl-o1.o", RTLD_NOW | RTLD_GLOBAL);
+  handle = dlopen ("/dl01-o1.o", RTLD_NOW | RTLD_GLOBAL);
   if (!handle)
   {
 printf("dlopen failed: %s\n", dlerror());
diff --git a/testsuites/libtests/dl02/dl-load.c 
b/testsuites/libtests/dl02/dl-load.c
index 5bb40dccba..601d62113c 100644
--- a/testsuites/libtests/dl02/dl-load.c
+++ b/testsuites/libtests/dl02/dl-load.c
@@ -49,10 +49,10 @@ int dl_load_test(void)
   intcall_ret;
   intret;
 
-  o1 = dl_load_obj("/dl-o1.o");
+  o1 = dl_load_obj("/dl02-o1.o");
   if (!o1)
 return 1;
-  o2 = dl_load_obj("/dl-o2.o");
+  o2 = dl_load_obj("/dl02-o2.o");
   if (!o1)
 return 1;
 
diff --git a/testsuites/libtests/dl03/dl-cache.c 
b/testsuites/libtests/dl03/dl-cache.c
index 82227cbf85..53c4fe7401 100644
--- a/testsuites/libtests/dl03/dl-cache.c
+++ b/testsuites/libtests/dl03/dl-cache.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016 Chris Johns .  All rights reserved.
+ * Copyright (c) 2016, 2018 Chris Johns .  All rights 
reserved.
  *
  * The license and distribution terms for this file may be
  * found in the file LICENSE in this distribution or at
@@ -63,7 +63,7 @@ static bool dl_cache_check(void* buffer, off_t offset, size_t 
length)
   return memcmp(buffer, contents + offset, length) == 0;
 }
 
-static off_t dl_cache_buffer_offset(rtems_rtl_obj_cache_t* cache, void* buffer)
+static off_t dl_cache_buffer_offset(rtems_rtl_obj_cache* cache, void* buffer)
 {
   return (off_t) (((uint8_t*) buffer) - ((uint8_t*) cache->buffer));
 }
@@ -73,22 +73,22 @@ static void dl_init_rtl(void)
   /*
* Check the RTL object is created and can be locked and unlocked.
*/
-  rtems_test_assert(rtems_rtl_data () == NULL);
+  rtems_test_assert(rtems_rtl_data_unprotected () == NULL);
   rtems_test_assert(rtems_rtl_lock () != NULL);
   rtems_rtl_unlock ();
-  rtems_test_assert(rtems_rtl_data () != NULL);
+  rtems_test_assert(rtems_rtl_data_unprotected () != NULL);
   rtems_rtl_trace_set_mask(RTEMS_RTL_TRACE_ALL | RTEMS_RTL_TRACE_CACHE);
 }
 
 int dl_cache_test(void)
 {
-  rtems_rtl_obj_cache_t cache;
-  int   fd;
-  void* buffer;
-  off_t offset_in;
-  off_t offset;
-  size_tlength_in;
-  size_tlength;
+  rtems_rtl_obj_cache cache;
+  int fd;
+  void*   buffer;
+  off_t   offset_in;
+  off_t   offset;
+  size_t  length_in;
+  size_t  length;
 
   /*
* Make sure the RTL can initialise.
diff --git a/testsuites/libtests/dl04/dl-load.c 
b/testsuites/libtests/dl04/dl-load.c
index 1409d79a9f..38810f48a9 100644
--- a/testsuites/libtests/dl04/dl-load.c
+++ b/testsuites/libtests/dl04/dl-load.c
@@ -26,7 +26,7 @@ int dl_load_test(void)
   const char* err;
 
   rtems_rtl_trace_set_mask(RTEMS_RTL_TRACE_ALL);
-  handle = dlopen("/dl-o4.o", RTLD_GLOBAL | RTLD_NOW);
+  handle = dlopen("/dl04-o4.o", RTLD_GLOBAL | RTLD_NOW);
   err = dlerror();
   if (err != NULL)
 printf("dlopen: %s\n", err);
diff --git a/testsuites/libtests/dl05/dl-load.c 
b/testsuites/libtests/dl05/dl-load.c
index c7d5698995..5ef64577cc 100644
--- a/testsuites/libtests/dl05/dl-load.c
+++ b/testsuites/libtests/dl05/dl-load.c
@@ -36,7 +36,7 @@ int dl_load_test(void)
 
   rtems_rtl_trace_set_mask(RTEMS_RTL_TRACE_ALL);
 
-  handle = dlopen("/dl-o5.o", RTLD_GLOBAL | RTLD_NOW);
+  handle = dlopen("/dl05-o5.o", RTLD_GLOBAL | RTLD_NOW);
   if (handle == NULL)
   {
 err = dlerror();
-- 
2.15.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH] build: Make entering the directories silent when building silent.

2018-04-12 Thread Chris Johns
---
 cpukit/automake/subdirs.am | 2 +-
 testsuites/automake/subdirs.am | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpukit/automake/subdirs.am b/cpukit/automake/subdirs.am
index b36ad80735..62634931f0 100644
--- a/cpukit/automake/subdirs.am
+++ b/cpukit/automake/subdirs.am
@@ -28,7 +28,7 @@ $1: $(preintstall_targets)
if test "target" = "all-local"; then \
  target="all"; \
fi; \
-   echo "Making target in subdir"; \
+   if $(AM_V_P); then echo "Making target in subdir"; fi; \
if test "subdir" != "."; then \
  cd subdir; \
  $(MAKE) $(AM_MAKEFLAGS) target; \
diff --git a/testsuites/automake/subdirs.am b/testsuites/automake/subdirs.am
index a566774bab..0406af7cb2 100644
--- a/testsuites/automake/subdirs.am
+++ b/testsuites/automake/subdirs.am
@@ -16,7 +16,7 @@ $1:
  if test "target" = "all-local"; then \
target="all"; \
  fi; \
- echo "Making target in $(1)"; \
+ if $(AM_V_P); then echo "Making target in $$(1)"; fi; \
  cd $(1); \
  $(MAKE) $(AM_MAKEFLAGS) TEST_FLAGS="test_FLAGS" target; \
fi;
-- 
2.15.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


[PATCH] RTEMS: Prefer int for int32_t

2018-04-12 Thread Sebastian Huber
Common systems like glibc and FreeBSD define int32_t to int.  This means
a lot of third party code works well in these cases:

  #include 

  void f(int32_t);

  void f(int);

  void g(int32_t *);

  void h(void)
  {
int i;
g(&i);
  }

On RTEMS you got however in C

  test.c:5:6: error: conflicting types for 'f'
void f(int);
^
  test.c:3:6: note: previous declaration of 'f' was here
void f(int32_t);
^
  test.c: In function 'h':
  test.c:12:4: warning: passing argument 1 of 'g' from incompatible
  pointer type [-Wincompatible-pointer-types]
g(&i);
  ^
  test.c:7:6: note: expected 'int32_t * {aka long int *}' but argument
  is of type 'int *' void g(int32_t *);

and C++

  test.c: In function 'void h()':
  test.c:12:4: error: invalid conversion from 'int*' to 'int32_t* {aka
  long int*}' [-fpermissive]
g(&i);
  ^~
  test.c:7:6: note:   initializing argument 1 of 'void g(int32_t*)'
void g(int32_t *);
  ^

This was due to a Newlib speciality which uses long for int32_t if long
is a 32-bit type.  To ease the use of third party software in RTEMS we
override this Newlib option now and use int for int32_t if int is a
32-bit type.

gcc
* config/rtems.h (STDINT_LONG32): Define.
---
 gcc/config/rtems.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/gcc/config/rtems.h b/gcc/config/rtems.h
index 439199d4cbb..35026efa2c7 100644
--- a/gcc/config/rtems.h
+++ b/gcc/config/rtems.h
@@ -48,3 +48,7 @@
  -latomic -lc -lgcc --end-group %{!qnolinkcmds: -T linkcmds%s}}}"
 
 #define TARGET_POSIX_IO
+
+/* Prefer int for int32_t (see stdint-newlib.h).  */
+#undef STDINT_LONG32
+#define STDINT_LONG32 (INT_TYPE_SIZE != 32 && LONG_TYPE_SIZE == 32)
-- 
2.12.3

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: error while running rtems-test with coverage

2018-04-12 Thread Vijay Kumar Banerjee
I got the parsing of the coverage from the ini file running , now I'm
getting the following error and warnings .




Running covoar for score
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/base_sp/base_sp.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/capture/capture.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/cdtest/cdtest.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/fileio/fileio.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/hello/hello.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/iostream/cxx_iostream.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/loopback/loopback.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/minimum/minimum.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/nsecs/nsecs.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/paranoia/paranoia.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/pppd/pppd.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/ticker/ticker.exe.cov
WARNING: Unable to read coverage file
/home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/unlimited/unlimited.exe.cov
ERROR: No information to analyze
***Cleaning tempfiles***
error: covoar failure exit code: 1




-- vijay

On 10 April 2018 at 18:10, Vijay Kumar Banerjee 
wrote:

> I managed to get the tests running with the following two patches .
> Please review them .
>
> -- vijay
>
> On 9 April 2018 at 15:28, Vijay Kumar Banerjee 
> wrote:
>
>>
>>
>> On Fri, 6 Apr 2018, 02:24 Vijay Kumar Banerjee, 
>> wrote:
>>
>>> I tried to solve the empty get in the way shown in the patch , but it
>>> doesn't seems to work, I'm getting the following error now
>>>
>>> RTEMS Testing - Tester, 5 (1ed6e2e64090)
>>> Traceback (most recent call last):
>>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
>>> line 40, in 
>>> rt.test.run()
>>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
>>> line 303, in run
>>> bsp = config.load(bsp[1], opts)
>>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/config.py",
>>> line 461, in load
>>> return opts.defaults['bsp']
>>>   File "/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py",
>>> line 190, in __getitem__
>>> raise IndexError('key: %s' % (key))
>>> IndexError: key: bsp
>>>
>>> I still Couldn't figure out why it's happening, when I use
>> RawConfigParse , it seems to run nicely though .
>>
>> Any Ideas on solving it without using RawConfigParser ?
>>
>>
>>> -- vijay
>>>
>>> On 5 April 2018 at 11:51, Cillian O'Donnell 
>>> wrote:
>>>


 On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, <
 vijaykumar9...@gmail.com> wrote:

> I got the rtems-test running
>
> I found that get_item_names(section, err) in configuration.py  was
> returning an empty list to the
> item_names in load(bsp,opts) for config.py this was giving out the
> error mandatory item not found .
>
> I have attached the patch file .
>
> current status :
> rtems-test is running without coverage
>
> running coverage gives the following error :
>
> RTEMS Testing - Tester, 5 (092c569e81ae)
> Traceback (most recent call last):
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
> line 40, in 
> rt.test.run()
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
> line 310, in run
> coverage = coverage_get_obj(opts, path_to_builddir[1])
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
> line 230, in coverage_get_obj
> coverage_obj = coverage.coverage_run(opts.defaults,
> path_to_builddir)
>   File 
> "/home/lunatic/development/rtems/rtems-tools/tester/rt/coverage.py",
> line 335, in __init__
> self.report_format = self.config_map['report_format'][2]
>

 This is back to the difference in cfg formats. It's looking for the
 last line here

 https://github.com/cillianodonnell/rtems-tools/blob/
 

Re: error while running rtems-test with coverage

2018-04-12 Thread Cillian O'Donnell
Ah that's good progress, those .cov files are supposed to be generated by
couverture-qemu as the test are run. They contain the trace data. Are you
definitely running couverture-qemu and not regular qemu?

On Thu, 12 Apr 2018, 17:41 Vijay Kumar Banerjee, 
wrote:

> I got the parsing of the coverage from the ini file running , now I'm
> getting the following error and warnings .
>
>
> 
>
> Running covoar for score
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/base_sp/base_sp.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/capture/capture.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/cdtest/cdtest.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/fileio/fileio.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/hello/hello.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/iostream/cxx_iostream.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/loopback/loopback.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/minimum/minimum.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/nsecs/nsecs.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/paranoia/paranoia.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/pppd/pppd.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/ticker/ticker.exe.cov
> WARNING: Unable to read coverage file
> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/unlimited/unlimited.exe.cov
> ERROR: No information to analyze
> ***Cleaning tempfiles***
> error: covoar failure exit code: 1
>
>
>
>
> -- vijay
>
> On 10 April 2018 at 18:10, Vijay Kumar Banerjee 
> wrote:
>
>> I managed to get the tests running with the following two patches .
>> Please review them .
>>
>> -- vijay
>>
>> On 9 April 2018 at 15:28, Vijay Kumar Banerjee 
>> wrote:
>>
>>>
>>>
>>> On Fri, 6 Apr 2018, 02:24 Vijay Kumar Banerjee, <
>>> vijaykumar9...@gmail.com> wrote:
>>>
 I tried to solve the empty get in the way shown in the patch , but it
 doesn't seems to work, I'm getting the following error now

 RTEMS Testing - Tester, 5 (1ed6e2e64090)
 Traceback (most recent call last):
   File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
 line 40, in 
 rt.test.run()
   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
 line 303, in run
 bsp = config.load(bsp[1], opts)
   File
 "/home/lunatic/development/rtems/rtems-tools/tester/rt/config.py", line
 461, in load
 return opts.defaults['bsp']
   File
 "/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py", line
 190, in __getitem__
 raise IndexError('key: %s' % (key))
 IndexError: key: bsp

 I still Couldn't figure out why it's happening, when I use
>>> RawConfigParse , it seems to run nicely though .
>>>
>>> Any Ideas on solving it without using RawConfigParser ?
>>>
>>>
 -- vijay

 On 5 April 2018 at 11:51, Cillian O'Donnell 
 wrote:

>
>
> On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, <
> vijaykumar9...@gmail.com> wrote:
>
>> I got the rtems-test running
>>
>> I found that get_item_names(section, err) in configuration.py  was
>> returning an empty list to the
>> item_names in load(bsp,opts) for config.py this was giving out the
>> error mandatory item not found .
>>
>> I have attached the patch file .
>>
>> current status :
>> rtems-test is running without coverage
>>
>> running coverage gives the following error :
>>
>> RTEMS Testing - Tester, 5 (092c569e81ae)
>> Traceback (most recent call last):
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test", line 40,
>> in 
>> rt.test.run()
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py", line 
>> 310,
>> in run
>> coverage = coverage_get_obj(opts, path_to_builddir[1])
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.p

[PATCH v2] build: Make entering the directories silent when building silent.

2018-04-12 Thread Chris Johns
---
 c/src/automake/subdirs.am  | 3 ++-
 cpukit/automake/subdirs.am | 3 ++-
 testsuites/automake/subdirs.am | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/c/src/automake/subdirs.am b/c/src/automake/subdirs.am
index 47d88cffcd..ef758f076d 100644
--- a/c/src/automake/subdirs.am
+++ b/c/src/automake/subdirs.am
@@ -29,7 +29,8 @@ $1:
if test "target" = "all-local"; then \
  target="all"; \
fi; \
-   echo "Making target in subdir"; \
+   if test x$(AM_V_P) != x; then silent=$(AM_V_P); else silent=false; fi; \
+   if silent; then echo "Making target in subdir"; fi; \
if test "subdir" != "."; then \
  cd subdir; \
  $(MAKE) $(AM_MAKEFLAGS) target; \
diff --git a/cpukit/automake/subdirs.am b/cpukit/automake/subdirs.am
index b36ad80735..dde2cf4403 100644
--- a/cpukit/automake/subdirs.am
+++ b/cpukit/automake/subdirs.am
@@ -28,7 +28,8 @@ $1: $(preintstall_targets)
if test "target" = "all-local"; then \
  target="all"; \
fi; \
-   echo "Making target in subdir"; \
+   if test x$(AM_V_P) != x; then silent=$(AM_V_P); else silent=false; fi; \
+   if silent; then echo "Making target in subdir"; fi; \
if test "subdir" != "."; then \
  cd subdir; \
  $(MAKE) $(AM_MAKEFLAGS) target; \
diff --git a/testsuites/automake/subdirs.am b/testsuites/automake/subdirs.am
index a566774bab..31ff284e4d 100644
--- a/testsuites/automake/subdirs.am
+++ b/testsuites/automake/subdirs.am
@@ -16,7 +16,8 @@ $1:
  if test "target" = "all-local"; then \
target="all"; \
  fi; \
- echo "Making target in $(1)"; \
+ if test x$(AM_V_P) != x; then silent=$(AM_V_P); else silent=false; 
fi; \
+ if silent; then echo "Making target in $$(1)"; fi; \
  cd $(1); \
  $(MAKE) $(AM_MAKEFLAGS) TEST_FLAGS="test_FLAGS" target; \
fi;
-- 
2.15.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: error while running rtems-test with coverage

2018-04-12 Thread Vijay Kumar Banerjee
I manually built qemu from here

https://github.com/AdaCore/qemu

I guess this is regular qemu , please send a link for couverture qemu for
manual build.

-- vijay

On 12 April 2018 at 22:23, Cillian O'Donnell  wrote:

> Ah that's good progress, those .cov files are supposed to be generated by
> couverture-qemu as the test are run. They contain the trace data. Are you
> definitely running couverture-qemu and not regular qemu?
>
> On Thu, 12 Apr 2018, 17:41 Vijay Kumar Banerjee, 
> wrote:
>
>> I got the parsing of the coverage from the ini file running , now I'm
>> getting the following error and warnings .
>>
>>
>> 
>>
>> Running covoar for score
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/base_sp/base_sp.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/capture/capture.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/cdtest/cdtest.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/fileio/fileio.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/hello/hello.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/iostream/cxx_iostream.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/loopback/loopback.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/minimum/minimum.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/nsecs/nsecs.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/paranoia/paranoia.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/pppd/pppd.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/ticker/ticker.exe.cov
>> WARNING: Unable to read coverage file /home/lunatic/development/
>> rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/
>> samples/unlimited/unlimited.exe.cov
>> ERROR: No information to analyze
>> ***Cleaning tempfiles***
>> error: covoar failure exit code: 1
>>
>>
>>
>>
>> -- vijay
>>
>> On 10 April 2018 at 18:10, Vijay Kumar Banerjee > > wrote:
>>
>>> I managed to get the tests running with the following two patches .
>>> Please review them .
>>>
>>> -- vijay
>>>
>>> On 9 April 2018 at 15:28, Vijay Kumar Banerjee >> > wrote:
>>>


 On Fri, 6 Apr 2018, 02:24 Vijay Kumar Banerjee, <
 vijaykumar9...@gmail.com> wrote:

> I tried to solve the empty get in the way shown in the patch , but it
> doesn't seems to work, I'm getting the following error now
>
> RTEMS Testing - Tester, 5 (1ed6e2e64090)
> Traceback (most recent call last):
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
> line 40, in 
> rt.test.run()
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
> line 303, in run
> bsp = config.load(bsp[1], opts)
>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/config.py",
> line 461, in load
> return opts.defaults['bsp']
>   File 
> "/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py",
> line 190, in __getitem__
> raise IndexError('key: %s' % (key))
> IndexError: key: bsp
>
> I still Couldn't figure out why it's happening, when I use
 RawConfigParse , it seems to run nicely though .

 Any Ideas on solving it without using RawConfigParser ?


> -- vijay
>
> On 5 April 2018 at 11:51, Cillian O'Donnell 
> wrote:
>
>>
>>
>> On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, <
>> vijaykumar9...@gmail.com> wrote:
>>
>>> I got the rtems-test running
>>>
>>> I found that get_item_names(section, err) in configuration.py  was
>>> returning an empty list to the
>>> item_names in load(bsp,opts) for config.py this was giving out the
>>> error mandatory item not found .
>>>
>>> I have attached the patch file .
>>>
>>> current status :
>>> rtems-test is running without coverage
>>>
>>> running coverage gives the following error :
>>>
>>> RTEMS Testing - Tester, 5 (092c569e81ae)
>>> Traceback (most recent call la

Re: [PATCH v2] build: Make entering the directories silent when building silent.

2018-04-12 Thread Amaan Cheval
On Fri, Apr 13, 2018 at 5:49 AM Chris Johns  wrote:

> ---
>   c/src/automake/subdirs.am  | 3 ++-
>   cpukit/automake/subdirs.am | 3 ++-
>   testsuites/automake/subdirs.am | 3 ++-
>   3 files changed, 6 insertions(+), 3 deletions(-)

> diff --git a/c/src/automake/subdirs.am b/c/src/automake/subdirs.am
> index 47d88cffcd..ef758f076d 100644
> --- a/c/src/automake/subdirs.am
> +++ b/c/src/automake/subdirs.am
> @@ -29,7 +29,8 @@ $1:
>  if test "target" = "all-local"; then \
>target="all"; \
>  fi; \
> -   echo "Making target in subdir"; \
> +   if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> +   if silent; then echo "Making target in subdir"; fi; \

Though this does the right thing, it reads misleadingly - "if silent, then
echo". Should it be named "verbose", perhaps, or be negated if it's meant
to be easy to search for "silent" for all instances where the silent
building takes effect? (The latter depends on how AM_V_P is set, which I'm
not sure about.)

>  if test "subdir" != "."; then \
>cd subdir; \
>$(MAKE) $(AM_MAKEFLAGS) target; \
> diff --git a/cpukit/automake/subdirs.am b/cpukit/automake/subdirs.am
> index b36ad80735..dde2cf4403 100644
> --- a/cpukit/automake/subdirs.am
> +++ b/cpukit/automake/subdirs.am
> @@ -28,7 +28,8 @@ $1: $(preintstall_targets)
>  if test "target" = "all-local"; then \
>target="all"; \
>  fi; \
> -   echo "Making target in subdir"; \
> +   if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> +   if silent; then echo "Making target in subdir"; fi; \
>  if test "subdir" != "."; then \
>cd subdir; \
>$(MAKE) $(AM_MAKEFLAGS) target; \
> diff --git a/testsuites/automake/subdirs.am b/testsuites/automake/
subdirs.am
> index a566774bab..31ff284e4d 100644
> --- a/testsuites/automake/subdirs.am
> +++ b/testsuites/automake/subdirs.am
> @@ -16,7 +16,8 @@ $1:
>if test "target" = "all-local"; then \
>  target="all"; \
>fi; \
> - echo "Making target in $(1)"; \
> + if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> + if silent; then echo "Making target in $$(1)"; fi; \
>cd $(1); \
>$(MAKE) $(AM_MAKEFLAGS) TEST_FLAGS="test_FLAGS" target;
\
>  fi;
> --
> 2.15.1

> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: error while running rtems-test with coverage

2018-04-12 Thread Cillian O'Donnell
No that's the right one. I think it might be something to do with qemu.cfg
in rtems-tools then. What's in your qemu.cfg? It's in
rtems-tools/tester/rtems/testing

On Fri, 13 Apr 2018, 06:39 Vijay Kumar Banerjee, 
wrote:

> I manually built qemu from here
>
> https://github.com/AdaCore/qemu
>
> I guess this is regular qemu , please send a link for couverture qemu for
> manual build.
>
> -- vijay
>
> On 12 April 2018 at 22:23, Cillian O'Donnell 
> wrote:
>
>> Ah that's good progress, those .cov files are supposed to be generated by
>> couverture-qemu as the test are run. They contain the trace data. Are you
>> definitely running couverture-qemu and not regular qemu?
>>
>> On Thu, 12 Apr 2018, 17:41 Vijay Kumar Banerjee, <
>> vijaykumar9...@gmail.com> wrote:
>>
>>> I got the parsing of the coverage from the ini file running , now I'm
>>> getting the following error and warnings .
>>>
>>>
>>> 
>>>
>>> Running covoar for score
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/base_sp/base_sp.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/capture/capture.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/cdtest/cdtest.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/fileio/fileio.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/hello/hello.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/iostream/cxx_iostream.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/loopback/loopback.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/minimum/minimum.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/nsecs/nsecs.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/paranoia/paranoia.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/pppd/pppd.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/ticker/ticker.exe.cov
>>> WARNING: Unable to read coverage file
>>> /home/lunatic/development/rtems/kernel/leon3/sparc-rtems5/c/leon3/testsuites/samples/unlimited/unlimited.exe.cov
>>> ERROR: No information to analyze
>>> ***Cleaning tempfiles***
>>> error: covoar failure exit code: 1
>>>
>>>
>>>
>>>
>>> -- vijay
>>>
>>> On 10 April 2018 at 18:10, Vijay Kumar Banerjee <
>>> vijaykumar9...@gmail.com> wrote:
>>>
 I managed to get the tests running with the following two patches .
 Please review them .

 -- vijay

 On 9 April 2018 at 15:28, Vijay Kumar Banerjee <
 vijaykumar9...@gmail.com> wrote:

>
>
> On Fri, 6 Apr 2018, 02:24 Vijay Kumar Banerjee, <
> vijaykumar9...@gmail.com> wrote:
>
>> I tried to solve the empty get in the way shown in the patch , but it
>> doesn't seems to work, I'm getting the following error now
>>
>> RTEMS Testing - Tester, 5 (1ed6e2e64090)
>> Traceback (most recent call last):
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test", line 40,
>> in 
>> rt.test.run()
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py", line 
>> 303,
>> in run
>> bsp = config.load(bsp[1], opts)
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/tester/rt/config.py", line
>> 461, in load
>> return opts.defaults['bsp']
>>   File
>> "/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py", 
>> line
>> 190, in __getitem__
>> raise IndexError('key: %s' % (key))
>> IndexError: key: bsp
>>
>> I still Couldn't figure out why it's happening, when I use
> RawConfigParse , it seems to run nicely though .
>
> Any Ideas on solving it without using RawConfigParser ?
>
>
>> -- vijay
>>
>> On 5 April 2018 at 11:51, Cillian O'Donnell 
>> wrote:
>>
>>>
>>>
>>> On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, <
>>> vijaykumar9...@gmail.com> wrote:
>>>
 I got the rtems-test running

 I found that get_item_names(section, err) in configuration.py  was
 returning an empty list to the

Re: [PATCH v2] build: Make entering the directories silent when building silent.

2018-04-12 Thread Chris Johns
On 13/04/2018 16:10, Amaan Cheval wrote:
> On Fri, Apr 13, 2018 at 5:49 AM Chris Johns  wrote:
> 
>> ---
>>   c/src/automake/subdirs.am  | 3 ++-
>>   cpukit/automake/subdirs.am | 3 ++-
>>   testsuites/automake/subdirs.am | 3 ++-
>>   3 files changed, 6 insertions(+), 3 deletions(-)
> 
>> diff --git a/c/src/automake/subdirs.am b/c/src/automake/subdirs.am
>> index 47d88cffcd..ef758f076d 100644
>> --- a/c/src/automake/subdirs.am
>> +++ b/c/src/automake/subdirs.am
>> @@ -29,7 +29,8 @@ $1:
>>  if test "target" = "all-local"; then \
>>target="all"; \
>>  fi; \
>> -   echo "Making target in subdir"; \
>> +   if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
> silent=false; fi; \
>> +   if silent; then echo "Making target in subdir"; fi; \
> 
> Though this does the right thing, it reads misleadingly - "if silent, then
> echo". Should it be named "verbose", perhaps, or be negated if it's meant
> to be easy to search for "silent" for all instances where the silent
> building takes effect?

Yes it is misleading and it makes sense to change. I will use `verbose`.

> (The latter depends on how AM_V_P is set, which I'm not sure about.)

It depends on the options in the makefile, the configure command line and then
V=? effects the value.

Thank you for the review.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel