Re: [PATCH 0/4] LEON: updates to SpaceWire Router driver

2017-11-14 Thread Joel Sherrill 
On Tue, Nov 14, 2017 at 12:10 AM, Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

>
>
> On 14/11/17 01:10, Joel Sherrill wrote:
>
>>
>>
>> On Mon, Nov 13, 2017 at 8:26 AM, Sebastian Huber <
>> sebastian.hu...@embedded-brains.de > ed-brains.de>> wrote:
>>
>> On 13/11/17 15:20, Daniel Hellstrom wrote:
>>
>> Currently there are some documentation on the drivers provided
>> with RCC. Where would the best place be for BSP specific
>> device driver documentation in the RTEMS project?
>>
>>
>> This is an open issue. My proposal is to move this to the CPU
>> Supplement:
>>
>> https://lists.rtems.org/pipermail/devel/2017-October/019270.html
>> 
>>
>>
>> We need to have some document that incorporates what has historically
>> in each BSP's wiki or READMEs. I don't think this is the CPU Supplement.
>>
>
> Ok, and what is "some document" from your point of view?


Chris suggested that a Users Manual include sections on each BSP with
instructions on setting the hardware up, debugging, etc. It makes sense that
this is user facing information specific to a set of BSPs. So in the
outline of
what Chris proposed it would either be in a SPARC > General or SPARC > LEON3
subsection.

Serious software project documentation falls into categories and we need
to honor those. There are internal design and development docs, process
and software engineering docs, and user facing documentation focused
on applications.

We have a "middle tier" of documentation where users are sometimes
developers. But it is probably best to ignore that because it often clouds
how we organize and approach things.

We don't need to mix categories of documentation. This is not what is
expected from the high criticality standards.


>
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail  : sebastian.hu...@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 0/4] LEON: updates to SpaceWire Router driver

2017-11-14 Thread Chris Johns 
On 15/11/2017 01:47, Joel Sherrill wrote:
> 
> Chris suggested that a Users Manual include sections on each BSP with
> instructions on setting the hardware up, debugging, etc. It makes sense that
> this is user facing information specific to a set of BSPs. So in the outline 
> of
> what Chris proposed it would either be in a SPARC > General or SPARC > LEON3
> subsection.

There is a section called 'Hardware'. I think the 'Tiers' section can be moved
to after 'Targets' and then 'Architectures / SPARC' and/or 'Board Support
Packages (BSP) / LEON3' can be added.

I am adding a new section after 'Hardware' to this document called 'Running and
Testing Executables' that details the set up and operation of 'rtems-test' and
'rtems-run'.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] dl01, dl02, dl05: Fix unresolved printf symbol

2017-11-14 Thread Sebastian Huber 
The link time wrap of printf leads to unresolved symboles in the
loadable modules.  This resulted in infinite loops and test timeouts.
Use rtems_printf() for output.

Update #3199.
---
 testsuites/libtests/dl01/dl-o1.c   | 7 +++
 testsuites/libtests/dl02/dl-o1.c   | 7 ---
 testsuites/libtests/dl02/dl-o2.c   | 6 --
 testsuites/libtests/dl05/dl-o5.cpp | 9 +++--
 4 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/testsuites/libtests/dl01/dl-o1.c b/testsuites/libtests/dl01/dl-o1.c
index 6e7bb8a07c..a47beb1d51 100644
--- a/testsuites/libtests/dl01/dl-o1.c
+++ b/testsuites/libtests/dl01/dl-o1.c
@@ -6,14 +6,13 @@
  * http://www.rtems.org/license/LICENSE.
  */
 
-#include 
-#include 
-
 /**
  * Hello World as a loadable module.
  */
 
-#include 
+#include 
+
+#define printf(...) rtems_printf(&rtems_test_printer, __VA_ARGS__);
 
 /*
  * Yes a decl in the source. This is a modules main and I could not find which
diff --git a/testsuites/libtests/dl02/dl-o1.c b/testsuites/libtests/dl02/dl-o1.c
index ff5a853c33..a4355d6e37 100644
--- a/testsuites/libtests/dl02/dl-o1.c
+++ b/testsuites/libtests/dl02/dl-o1.c
@@ -6,12 +6,13 @@
  * http://www.rtems.org/license/LICENSE.
  */
 
-#include 
-#include 
+#include "dl-o2.h"
 
 #include 
 
-#include "dl-o2.h"
+#include 
+
+#define printf(...) rtems_printf(&rtems_test_printer, __VA_ARGS__);
 
 typedef int (*func1_t)(int argc, const char* argv[]);
 
diff --git a/testsuites/libtests/dl02/dl-o2.c b/testsuites/libtests/dl02/dl-o2.c
index 43a337a1c0..4c1a918dea 100644
--- a/testsuites/libtests/dl02/dl-o2.c
+++ b/testsuites/libtests/dl02/dl-o2.c
@@ -6,10 +6,12 @@
  * http://www.rtems.org/license/LICENSE.
  */
 
-#include 
-
 #include "dl-o2.h"
 
+#include 
+
+#define printf(...) rtems_printf(&rtems_test_printer, __VA_ARGS__);
+
 int dl_o2_func1 (int argc, char* argv[])
 {
   int arg;
diff --git a/testsuites/libtests/dl05/dl-o5.cpp 
b/testsuites/libtests/dl05/dl-o5.cpp
index 5918e8f2d5..b70790ea7b 100644
--- a/testsuites/libtests/dl05/dl-o5.cpp
+++ b/testsuites/libtests/dl05/dl-o5.cpp
@@ -1,6 +1,11 @@
-#include 
-#include 
 #include "dl-load.h" /* make the symbol a C linkage */
+
+#include 
+
+#include 
+
+#define printf(...) rtems_printf(&rtems_test_printer, __VA_ARGS__);
+
 void exception_dl(bool throw_runtime)
 {
   printf("exception_dl: begin\n");
-- 
2.12.3

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] dl01, dl02, dl05: Fix unresolved printf symbol

2017-11-14 Thread Chris Johns 
On 15/11/2017 17:57, Sebastian Huber wrote:
> The link time wrap of printf leads to unresolved symboles in the
> loadable modules.  This resulted in infinite loops and test timeouts.
> Use rtems_printf() for output.

Of course. OK to push.

Thanks
Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel