Deprecated/removed function in the user manual?

2016-12-12 Thread Sebastian Huber 

Hello,

I work currently on documentation updates. How do we deal with 
deprecated/remove functions in the user manual? For example 
rtems_iterate_over_all_threads() is deprecated (replacement is 
rtems_task_iterate()). Task variables/notes are removed in RTEMS 4.12.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] score: Prevent thread_dispatch_disable_level < 0.

2016-12-12 Thread Christian Mauderer 
From: Christian Mauderer 

---
 cpukit/score/include/rtems/score/threaddispatch.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cpukit/score/include/rtems/score/threaddispatch.h 
b/cpukit/score/include/rtems/score/threaddispatch.h
index 0238f8f..63eb4c6 100644
--- a/cpukit/score/include/rtems/score/threaddispatch.h
+++ b/cpukit/score/include/rtems/score/threaddispatch.h
@@ -232,6 +232,7 @@ RTEMS_INLINE_ROUTINE void _Thread_Dispatch_enable( 
Per_CPU_Control *cpu_self )
 
 _ISR_Local_enable( level );
   } else {
+_Assert( disable_level > 0 );
 cpu_self->thread_dispatch_disable_level = disable_level - 1;
   }
 }
@@ -243,6 +244,7 @@ RTEMS_INLINE_ROUTINE void _Thread_Dispatch_enable( 
Per_CPU_Control *cpu_self )
  */
 RTEMS_INLINE_ROUTINE void _Thread_Dispatch_unnest( Per_CPU_Control *cpu_self )
 {
+  _Assert( cpu_self->thread_dispatch_disable_level > 0 );
   --cpu_self->thread_dispatch_disable_level;
 }
 
-- 
1.8.4.5

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Deprecated/removed function in the user manual?

2016-12-12 Thread Chris Johns 

On 12/12/2016 22:28, Sebastian Huber wrote:

I work currently on documentation updates. How do we deal with
deprecated/remove functions in the user manual? For example
rtems_iterate_over_all_threads() is deprecated (replacement is
rtems_task_iterate()). Task variables/notes are removed in RTEMS 4.12.


I would add a new section and group the removed functions etc by the 
version they are first removed. The record is historical, for example a 
4.9 user moving to 4.12 can use the 4.12 docs to see what has been 
removed without having to review the docs from each preceding release.


Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] score: Prevent thread_dispatch_disable_level < 0.

2016-12-12 Thread Chris Johns 

On 13/12/2016 01:03, Christian Mauderer wrote:

From: Christian Mauderer 

---
  cpukit/score/include/rtems/score/threaddispatch.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/cpukit/score/include/rtems/score/threaddispatch.h 
b/cpukit/score/include/rtems/score/threaddispatch.h
index 0238f8f..63eb4c6 100644
--- a/cpukit/score/include/rtems/score/threaddispatch.h
+++ b/cpukit/score/include/rtems/score/threaddispatch.h
@@ -232,6 +232,7 @@ RTEMS_INLINE_ROUTINE void _Thread_Dispatch_enable( 
Per_CPU_Control *cpu_self )

  _ISR_Local_enable( level );
} else {
+_Assert( disable_level > 0 );


Is the _Assert always enabled or just when built with --enable-debug?

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] score: Prevent thread_dispatch_disable_level < 0.

2016-12-12 Thread Sebastian Huber 



On 12/12/16 22:26, Chris Johns wrote:

On 13/12/2016 01:03, Christian Mauderer wrote:

From: Christian Mauderer 

---
  cpukit/score/include/rtems/score/threaddispatch.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/cpukit/score/include/rtems/score/threaddispatch.h 
b/cpukit/score/include/rtems/score/threaddispatch.h

index 0238f8f..63eb4c6 100644
--- a/cpukit/score/include/rtems/score/threaddispatch.h
+++ b/cpukit/score/include/rtems/score/threaddispatch.h
@@ -232,6 +232,7 @@ RTEMS_INLINE_ROUTINE void 
_Thread_Dispatch_enable( Per_CPU_Control *cpu_self )


  _ISR_Local_enable( level );
} else {
+_Assert( disable_level > 0 );


Is the _Assert always enabled or just when built with --enable-debug?


Only if RTEMS_DEBUG is defined via --enable-rtems-debug, see 
.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel