Re: [PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

[Ben Gras]

All,

On Fri, Jul 1, 2016 at 11:12 PM, Martin Galvan
 wrote:
> Hi Punit, thanks for the patch. As we spoke in the group chat with the other 
> mentors, this seems to
> be good for a first version. I'll be pointing out the required changes for 
> the next version, but
> unless somebody sees anything blocking this should be good to merge.

I agree!

[..]

> +
> +/* Currently these definitions are for BeagleBone Black board only
> + * Later on Beagle-xM board support can be added in this code.
> + * After support gets added if condition should be removed
>
> If you're referring to IS_AM335X/IS_DM3730, from what I've seen there are 
> always two
> versions of the code, one for each SoC. So I don't think this #if will be 
> removed,
> even after support is added for DM3730. Maybe Ben/Ketul know a bit more about 
> this than
> I do, though.

You're right, depending on how different the hardware is. It could be
(I haven't checked) that the hardware works the same but the base
address is different, such as with the UARTs.
In that case we can re-use this code and the differences will be
smaller. So I think here
simply removing "After support gets added if condition should be
removed" should be OK, although I don't consider it blocking for
merging.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: Error while adding usb ethernet driver

[Chris Johns]

On 30/06/2016 20:22, Deval Shah wrote:

On Tue, Jun 28, 2016 at 3:12 AM, Chris Johns mailto:chr...@rtems.org>> wrote:

It might pay for us to add these to an RTEMS header to make porting
simpler.

Can't we update our sys/net/if.c and sys/net/if_var.h files accourding
to new FreeBSD ?


I do not know. Currently we have a policy of keeping as much at the 
snapshot point as we can. Sebastian has looked at moving to FreeBSD 10 
and backed off doing so because it was more work than he could handle 
due to changes in FreeBSD 10.


I am not against something like this being merged if the change is 
localised to just those files, it works, and the existing drivers work. 
If the change ripples out across the code base then it would be a problem.


Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel