Re: [PATCH 1/2] RTEMS: Adjust layout of struct _Thread_queue_Queue
This should be fine. It's an "internal" API so we just need to ensure
consistency in our kernel code.
On Mon, May 2, 2016 at 3:55 PM, Jeff Johnston wrote:
> Do you have consensus with the RTEMS group for this change which breaks API
> introduced
> last year? Otherwise, I will leave it up to the RTEMS maintainers to comment.
>
> -- Jeff J.
>
> - Original Message -
>> Move _Thread_queue_Queue::_Lock to begin of the structure. On RTEMS,
>> the presence of a lock component in the thread queue structures actually
>> depends on the build-time RTEMS_SMP configuration option. A move of
>> this part to the begin of the structure allows an implementation re-use
>> for the other parts.
>>
>> Signed-off-by: Sebastian Huber
>> ---
>> newlib/libc/sys/rtems/include/sys/lock.h | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/newlib/libc/sys/rtems/include/sys/lock.h
>> b/newlib/libc/sys/rtems/include/sys/lock.h
>> index d2a7fb1..002064f 100644
>> --- a/newlib/libc/sys/rtems/include/sys/lock.h
>> +++ b/newlib/libc/sys/rtems/include/sys/lock.h
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright (c) 2015 embedded brains GmbH. All rights reserved.
>> + * Copyright (c) 2015, 2016 embedded brains GmbH. All rights reserved.
>> *
>> * Redistribution and use in source and binary forms, with or without
>> * modification, are permitted provided that the following conditions
>> @@ -43,8 +43,8 @@ struct _Ticket_lock_Control {
>> };
>>
>> struct _Thread_queue_Queue {
>> - struct _Thread_queue_Heads *_heads;
>> struct _Ticket_lock_Control _Lock;
>> + struct _Thread_queue_Heads *_heads;
>> };
>>
>> struct _Mutex_Control {
>> @@ -70,7 +70,7 @@ struct _Futex_Control {
>> struct _Thread_queue_Queue _Queue;
>> };
>>
>> -#define _THREAD_QUEUE_INITIALIZER { 0, { 0, 0 } }
>> +#define _THREAD_QUEUE_INITIALIZER { { 0, 0 }, 0 }
>>
>> #define _MUTEX_INITIALIZER { _THREAD_QUEUE_INITIALIZER, 0 }
>>
>> --
>> 1.8.4.5
>>
>>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: PWM driver tested in RTEMS with RGB
On Wed, May 4, 2016 at 8:31 AM, Chris Johns wrote: > On 04/05/2016 11:53, Gedare Bloom wrote: >>> >>> >>> I added Ti licence at last patch. Do I need to add any other licence ? >> >> Whenever you copy/paste code, you need to know/observe what the >> license is and keep track of that. So, the question of whether you >> need to add another license depends on whether you copied code from >> somewhere that has a different license. I copied the code from 2 files. Both files have same licence . So the licence I added is enough according to me. > > Where did the TI code from, for example a public tarball, a public TI git > repo, or a TI SDK? I have referred code from sourceforge. https://sourceforge.net/p/starterwarefree/code/ci/master/tree/ @Martin you can clone this code and keep it handy while reviewing my code. SW code is cloned from following link. git clone git://git.code.sf.net/p/starterwarefree/code starterwarefree-code This repo represents 2.0.x variant of SW by TI. @Martin For further communication should I communicate here or should I create new thread in user@rtems. I am asking because Gedare told to introduce project on user@rtems mail list but you mostly prefer devel@rtems. If I add code from anywhere else I will inform community. Thanks for the support. Regards, Punit Vara ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: PWM driver tested in RTEMS with RGB
On 05/05/2016 22:25, punit vara wrote: I have referred code from sourceforge. https://sourceforge.net/p/starterwarefree/code/ci/master/tree/ I am sorry but I am not comfortable with this repo at the moment and I would like to have origin of the code verified before any code from it enters RTEMS. The repo does not have a LICENSE file at the top and the AM335X_SoftwareManifest.pdf has "Ti Confidential" on every page yet it is public. If this code have been placed in a public repo after someone acknowledged an EULA then we need to be careful. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
