Re: [PATCH 2/7] bsp/tms570: Pinmux support and EMAC pin definition added

2015-11-15 Thread Gedare Bloom 
On Thu, Nov 12, 2015 at 5:11 PM, Pavel Pisa  wrote:
> From: Premysl Houdek 
>
> Signed-off-by: Premysl Houdek 
> ---
>  c/src/lib/libbsp/arm/tms570/Makefile.am|   3 +-
>  .../lib/libbsp/arm/tms570/include/tms570-pinmux.h  | 122 
> +
>  c/src/lib/libbsp/arm/tms570/pinmux/pinmux.c|  88 +++
>  c/src/lib/libbsp/arm/tms570/preinstall.am  |   4 +
>  4 files changed, 216 insertions(+), 1 deletion(-)
>  create mode 100644 c/src/lib/libbsp/arm/tms570/include/tms570-pinmux.h
>  create mode 100644 c/src/lib/libbsp/arm/tms570/pinmux/pinmux.c
>
> diff --git a/c/src/lib/libbsp/arm/tms570/Makefile.am 
> b/c/src/lib/libbsp/arm/tms570/Makefile.am
> index a278aa2..7936b07 100644
> --- a/c/src/lib/libbsp/arm/tms570/Makefile.am
> +++ b/c/src/lib/libbsp/arm/tms570/Makefile.am
> @@ -41,6 +41,7 @@ include_bsp_HEADERS += include/tms570-vim.h
>  include_bsp_HEADERS += include/tms570-pom.h
>  include_bsp_HEADERS += include/tms570-sci-driver.h
>  include_bsp_HEADERS += include/system-clocks.h
> +include_bsp_HEADERS += include/tms570-pinmux.h
>
>  include_bsp_ti_hercules_HEADERS = include/ti_herc/reg_adc.h
>  include_bsp_ti_hercules_HEADERS += include/ti_herc/reg_ccmsr.h
> @@ -151,7 +152,7 @@ libbsp_a_SOURCES += clock/benchmark_timer.c
>  # RTC
>
>  # GPIO
> -
> +libbsp_a_SOURCES += pinmux/pinmux.c
>  # Timer
>
>  # Benchmark Timer
> diff --git a/c/src/lib/libbsp/arm/tms570/include/tms570-pinmux.h 
> b/c/src/lib/libbsp/arm/tms570/include/tms570-pinmux.h
> new file mode 100644
> index 000..46c4ae5
> --- /dev/null
> +++ b/c/src/lib/libbsp/arm/tms570/include/tms570-pinmux.h
> @@ -0,0 +1,122 @@
> +/**
> + * @file tms570-pinmux.h
> + *
> + * @ingroup tms570
> + *
> + * @brief I/O Multiplexing Module (IOMM) basic support
> + */
> +
> +/*
> + * Copyright (c) 2015 Premysl Houdek 
> + *
> + * Google Summer of Code 2014 at
> + * Czech Technical University in Prague
> + * Zikova 1903/4
> + * 166 36 Praha 6
> + * Czech Republic
> + *
> + * The license and distribution terms for this file may be
> + * found in the file LICENSE in this distribution or at
> + * http://www.rtems.org/license/LICENSE.
> + */
> +
> +#ifndef LIBBSP_ARM_TMS570_PINMUX_H
> +#define LIBBSP_ARM_TMS570_PINMUX_H
> +
> +#ifndef ASM
> +#include 
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif /* __cplusplus */
> +
> +
> +#define TMS570_PIN_NUM_SHIFT 0
> +#define TMS570_PIN_NUM_MASK  0x0fff
> +
> +#define TMS570_PIN_FNC_SHIFT 12
> +#define TMS570_PIN_FNC_MASK  0xf000
> +
> +#define TMS570_PIN_FNC_AUTO  (-1)
> +
> +#define TMS570_PIN_AND_FNC(pin, fnc) \
> +  ((pin) | ((fnc)< +
> +#define TMS570_BALL_WITH_MMR(mmrx, pos) \
> +  ((pos) | ((mmrx)<<2))
> +
> +/* Definition for pins/balls which has to be set for Ethernet MII */
> +
> +#define TMS570_BALL_C3  TMS570_BALL_WITH_MMR(0, 2)
> +#define TMS570_BALL_C3_MIBSPI3NCS_3 TMS570_PIN_AND_FNC(TMS570_BALL_C3, 0)
> +#define TMS570_BALL_C3_I2C_SCL TMS570_PIN_AND_FNC(TMS570_BALL_C3, 1)
> +
> +#define TMS570_BALL_F3 TMS570_BALL_WITH_MMR(20, 2)
> +#define TMS570_BALL_F3_MII_COL TMS570_PIN_AND_FNC(TMS570_BALL_F3, 2)
> +
> +#define TMS570_BALL_B4 TMS570_BALL_WITH_MMR(17, 2)
> +#define TMS570_BALL_B4_MII_CRS TMS570_PIN_AND_FNC(TMS570_BALL_B4, 1)
> +
> +#define TMS570_BALL_B11 TMS570_BALL_WITH_MMR(19, 1)
> +#define TMS570_BALL_B11_MII_RX_DV TMS570_PIN_AND_FNC(TMS570_BALL_B11, 1)
> +
> +#define TMS570_BALL_N19 TMS570_BALL_WITH_MMR(10, 0)
> +#define TMS570_BALL_N19_MII_RX_ER TMS570_PIN_AND_FNC(TMS570_BALL_N19, 1)
> +
> +#define TMS570_BALL_K19 TMS570_BALL_WITH_MMR(14, 1)
> +#define TMS570_BALL_K19_MII_RX_CLK TMS570_PIN_AND_FNC(TMS570_BALL_K19, 1)
> +
> +#define TMS570_BALL_P1 TMS570_BALL_WITH_MMR(11, 3)
> +#define TMS570_BALL_P1_MII_RXD_0 TMS570_PIN_AND_FNC(TMS570_BALL_P1, 2)
> +
> +#define TMS570_BALL_A14 TMS570_BALL_WITH_MMR(12, 0)
> +#define TMS570_BALL_A14_MII_RXD_1 TMS570_PIN_AND_FNC(TMS570_BALL_A14, 1)
> +
> +#define TMS570_BALL_G19 TMS570_BALL_WITH_MMR(12, 2)
> +#define TMS570_BALL_G19_MII_RXD_2 TMS570_PIN_AND_FNC(TMS570_BALL_G19, 2)
> +
> +#define TMS570_BALL_H18 TMS570_BALL_WITH_MMR(12, 3)
> +#define TMS570_BALL_H18_MII_RXD_3 TMS570_PIN_AND_FNC(TMS570_BALL_H18, 2)
> +
> +#define TMS570_BALL_D19 TMS570_BALL_WITH_MMR(17, 0)
> +#define TMS570_BALL_D19_MII_TX_CLK TMS570_PIN_AND_FNC(TMS570_BALL_D19, 1)
> +
> +#define TMS570_BALL_J18 TMS570_BALL_WITH_MMR(13, 0)
> +#define TMS570_BALL_J18_MII_TXD_0 TMS570_PIN_AND_FNC(TMS570_BALL_J18, 2)
> +
> +#define TMS570_BALL_J19 TMS570_BALL_WITH_MMR(13, 1)
> +#define TMS570_BALL_J19_MII_TXD_1 TMS570_PIN_AND_FNC(TMS570_BALL_J19, 2)
> +
> +#define TMS570_BALL_R2 TMS570_BALL_WITH_MMR(13, 3)
> +#define TMS570_BALL_R2_MII_TXD_2 TMS570_PIN_AND_FNC(TMS570_BALL_R2, 2)
> +
> +#define TMS570_BALL_E18 TMS570_BALL_WITH_MMR(14, 0)
> +#define TMS570_BALL_E18_MII_TXD_3 TMS570_PIN_AND_FNC(TMS570_BALL_E18, 2)
> +
> +#define TMS570_BALL_H19 TMS570_BALL_WITH_MMR(13, 2)
> +#define TMS570_BALL_H19_MII_TXEN TMS570_PIN_AND_FNC(TMS570_BALL_H19, 2)
> +
> +#define TMS

Re: [PATCH 3/7] bsp/tms570: fixed sci driver freeze when closing terminal bug

2015-11-15 Thread Gedare Bloom 
On Thu, Nov 12, 2015 at 5:11 PM, Pavel Pisa  wrote:
> From: Premysl Houdek 
>
> tms570_sci_interrupt_last_close: do not wait for old data transmit.
>
> Signed-off-by: Premysl Houdek 
> ---
>  c/src/lib/libbsp/arm/tms570/console/tms570-sci.c | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/c/src/lib/libbsp/arm/tms570/console/tms570-sci.c 
> b/c/src/lib/libbsp/arm/tms570/console/tms570-sci.c
> index 54c1b69..a799a66 100644
> --- a/c/src/lib/libbsp/arm/tms570/console/tms570-sci.c
> +++ b/c/src/lib/libbsp/arm/tms570/console/tms570-sci.c
> @@ -531,9 +531,11 @@ static void tms570_sci_interrupt_last_close(
>tms570_sci_disable_interrupts(ctx);
>rtems_termios_device_lock_release(base, &lock_context);
>
> -  /* Flush device */
> -  while ( ( ctx->regs->FLR & TMS570_SCI_FLR_TX_EMPTY ) > 0 ) {
> -;/* Wait until all data has been sent */
> +  if ( 0 /* for flush on close */ ) {
I don't understand, this is dead code now?

> +/* Flush device */
> +while ( ( ctx->regs->FLR & TMS570_SCI_FLR_TX_EMPTY ) == 0 ) {
> +  ;/* Wait until all data has been sent */
> +}
>}
>
>/* uninstall ISR */
> --
> 1.9.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: BBB GPIO pullpup/pulldown patch

2015-11-15 Thread Gedare Bloom 
The code looks fine, if someone cares to verify they ran it

On Fri, Nov 13, 2015 at 8:49 AM, Federico Garcia Cruz <
federico.garciac...@tallertechnologies.com> wrote:

> Hi everyone,
> we're working with the latest RTEMS in the Beaglebone and we're using the
> GPIO api. We've added the code for configuring the pullup/pulldown resistor
> in the Beaglebone. Could anyone give it a shoot?
>
> --
>
> 
>
>
> Federico Garcia Cruz
>
> Software Engineer
>
>
> San Lorenzo 47, 3rd Floor, Office 5
>
> Córdoba, Argentina
>
>
> Phone: +54 351 4217888 / +54 351 4218211
>
>
> 
> 
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel