[PATCH] Add __synch_synchronize function for arm
From: Jan Sommer
Fixes link failure when linking Ada programs on the raspberry pi
---
cpukit/score/cpu/arm/Makefile.am | 1 +
cpukit/score/cpu/arm/armv4-sync-synchronize.c | 9 +
2 files changed, 10 insertions(+)
create mode 100644 cpukit/score/cpu/arm/armv4-sync-synchronize.c
diff --git a/cpukit/score/cpu/arm/Makefile.am b/cpukit/score/cpu/arm/Makefile.am
index c051a48..4b242f0 100644
--- a/cpukit/score/cpu/arm/Makefile.am
+++ b/cpukit/score/cpu/arm/Makefile.am
@@ -27,6 +27,7 @@ libscorecpu_a_SOURCES += arm_exc_handler_high.c
libscorecpu_a_SOURCES += arm-exception-frame-print.c
libscorecpu_a_SOURCES += arm-exception-default.c
libscorecpu_a_SOURCES += armv4-exception-default.S
+libscorecpu_a_SOURCES += armv4-sync-synchronize.c
libscorecpu_a_SOURCES += armv7-thread-idle.c
libscorecpu_a_SOURCES += armv7m-context-initialize.c
libscorecpu_a_SOURCES += armv7m-context-restore.c
diff --git a/cpukit/score/cpu/arm/armv4-sync-synchronize.c
b/cpukit/score/cpu/arm/armv4-sync-synchronize.c
new file mode 100644
index 000..6fcac05
--- /dev/null
+++ b/cpukit/score/cpu/arm/armv4-sync-synchronize.c
@@ -0,0 +1,9 @@
+void
+__sync_synchronize (void)
+{
+#ifdef ARM_MULTILIB_HAS_BARRIER_INSTRUCTIONS
+ asm volatile("dmb" : : : "memory");
+#else
+ asm volatile("" : : : "memory");
+#endif
+}
\ No newline at end of file
--
2.1.4
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE
--- cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h b/cpukit/posix/include/rtems/posix/pthreadimpl.h index f95ac9c..33fa33d 100644 --- a/cpukit/posix/include/rtems/posix/pthreadimpl.h +++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h @@ -24,6 +24,7 @@ #include #include #include +#include #include #ifdef __cplusplus -- 2.1.4 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE
Can you give a configuration or file that broke with this? I recall that I had a local patch that just added this line to an Ada specific C file. Nothing else broke. On August 1, 2015 5:51:31 AM CDT, Jan Sommer wrote: >--- > cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h >b/cpukit/posix/include/rtems/posix/pthreadimpl.h >index f95ac9c..33fa33d 100644 >--- a/cpukit/posix/include/rtems/posix/pthreadimpl.h >+++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h >@@ -24,6 +24,7 @@ > #include > #include > #include >+#include > #include > > #ifdef __cplusplus --joel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Chris review Re: Issues on FreeBSD
I just committed this as ticket 2378 on 4.10, 4.11 and master --joel On 07/23/2015 04:09 AM, Joel Sherrill wrote: On 7/23/2015 4:02 AM, Nick Withers wrote: On Thu, 2015-07-23 at 03:20 -0500, Joel Sherrill wrote: On 7/23/2015 3:17 AM, Nick Withers wrote: On Thu, 2015-07-23 at 02:50 -0500, Joel Sherrill wrote: Hi I was test building on FreeBSD and noticed a couple of issues. + none of the m68k BSPs link. Fixing this now. + mips tools do not build Anyone else notice any other issues or have comments? The only thing I've got is: What was the visible issue this fixed? I don't think I saw anything like this. But I used sb-bootstrap from rtems-source-builder. Sorry, It's ./bootstrap -p (I've a modified Makefile.am, though I'm not chaning installed headers and am no doubt over-running it!) that struggles, with: Ahh... Chris.. I am ok with this patch. But since you spend more time on FreeBSD than I do, please review and commit. ___ % ./bootstrap -p Generating ./c/src/ada/preinstall.am ./bootstrap: ./ampolish3: not found Generating ./c/src/libchip/preinstall.am ./bootstrap: ./ampolish3: not found Generating ./c/src/lib/libbsp/moxie/moxiesim/preinstall.am ./bootstrap: ./ampolish3: not found (...) ___ ...producing empty preinstall.ams and leading to a failure in the subsequent make. But yeah, in general users probably aren't running into it! ___ diff --git a/ampolish3 b/ampolish3 index aaa9757..23c2855 100755 --- a/ampolish3 +++ b/ampolish3 @@ -1,4 +1,4 @@ -#! /usr/bin/perl -w +#! /usr/bin/env perl # # Copyright (C) 2005, 2006 Ralf Corspius, Ulm, Germany # ___ ...to make the bootstrap happy again (the /usr/bin/perl -> /usr/local/bin/perl link was removed recently). 'Course that drops the "-w" flag for extra warnings. -- -- Joel Sherrill Ask me about RTEMS: a free RTOS Support and Training Available ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Outstanding Issues on 4.11 branch?
Hi There are a couple of issues I know of like ticket 2376 (tftp ticket really needs a patch) and some site administration to do. But does anyone have any outstanding issues? Please test and give feedback. Thanks. --joel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Add __synch_synchronize function for arm
I committed this patch to 4.11 and master.
Thanks.
--joel
On 08/01/2015 05:43 AM, Jan Sommer wrote:
From: Jan Sommer
Fixes link failure when linking Ada programs on the raspberry pi
---
cpukit/score/cpu/arm/Makefile.am | 1 +
cpukit/score/cpu/arm/armv4-sync-synchronize.c | 9 +
2 files changed, 10 insertions(+)
create mode 100644 cpukit/score/cpu/arm/armv4-sync-synchronize.c
diff --git a/cpukit/score/cpu/arm/Makefile.am b/cpukit/score/cpu/arm/Makefile.am
index c051a48..4b242f0 100644
--- a/cpukit/score/cpu/arm/Makefile.am
+++ b/cpukit/score/cpu/arm/Makefile.am
@@ -27,6 +27,7 @@ libscorecpu_a_SOURCES += arm_exc_handler_high.c
libscorecpu_a_SOURCES += arm-exception-frame-print.c
libscorecpu_a_SOURCES += arm-exception-default.c
libscorecpu_a_SOURCES += armv4-exception-default.S
+libscorecpu_a_SOURCES += armv4-sync-synchronize.c
libscorecpu_a_SOURCES += armv7-thread-idle.c
libscorecpu_a_SOURCES += armv7m-context-initialize.c
libscorecpu_a_SOURCES += armv7m-context-restore.c
diff --git a/cpukit/score/cpu/arm/armv4-sync-synchronize.c
b/cpukit/score/cpu/arm/armv4-sync-synchronize.c
new file mode 100644
index 000..6fcac05
--- /dev/null
+++ b/cpukit/score/cpu/arm/armv4-sync-synchronize.c
@@ -0,0 +1,9 @@
+void
+__sync_synchronize (void)
+{
+#ifdef ARM_MULTILIB_HAS_BARRIER_INSTRUCTIONS
+ asm volatile("dmb" : : : "memory");
+#else
+ asm volatile("" : : : "memory");
+#endif
+}
\ No newline at end of file
--
-- Joel Sherrill
Ask me about RTEMS: a free RTOS
Support and Training Available
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE
Yes, I needed to add it to make the ada-examples compile. Am Samstag, 1. August 2015, 12:08:12 schrieb Joel Sherrill: > Can you give a configuration or file that broke with this? > > I recall that I had a local patch that just added this line to an Ada > specific C file. Nothing else broke. > > On August 1, 2015 5:51:31 AM CDT, Jan Sommer > wrote: > >--- > > cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h > >b/cpukit/posix/include/rtems/posix/pthreadimpl.h > >index f95ac9c..33fa33d 100644 > >--- a/cpukit/posix/include/rtems/posix/pthreadimpl.h > >+++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h > >@@ -24,6 +24,7 @@ > > #include > > #include > > #include > >+#include > > #include > > > > #ifdef __cplusplus > > --joel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE
On 08/01/2015 12:24 PM, Jan Sommer wrote: Yes, I needed to add it to make the ada-examples compile. Did it need to be included anywhere other than libgnat/adasupp.c? Sebastian reworked public vs private .h files and more includes moved to .c files. Since everything but Ada specific support files compile on every target, I am prone to want to fix the file that needs this. I would check for my patches but I appear to have deleted my RTEMS clone since then and lost the small patch I had. :( --joel Am Samstag, 1. August 2015, 12:08:12 schrieb Joel Sherrill: Can you give a configuration or file that broke with this? I recall that I had a local patch that just added this line to an Ada specific C file. Nothing else broke. On August 1, 2015 5:51:31 AM CDT, Jan Sommer wrote: --- cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h b/cpukit/posix/include/rtems/posix/pthreadimpl.h index f95ac9c..33fa33d 100644 --- a/cpukit/posix/include/rtems/posix/pthreadimpl.h +++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h @@ -24,6 +24,7 @@ #include #include #include +#include #include #ifdef __cplusplus --joel -- -- Joel Sherrill Ask me about RTEMS: a free RTOS Support and Training Available ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE
Am Samstag, 1. August 2015, 12:31:53 schrieb Joel Sherrill: > On 08/01/2015 12:24 PM, Jan Sommer wrote: > > Yes, I needed to add it to make the ada-examples compile. > > > Did it need to be included anywhere other than libgnat/adasupp.c? > Well, so far I haven't encountered the problem somewhere else, but have been working with the Ada-examples mainly atm. > Sebastian reworked public vs private .h files and more includes moved > to .c files. Since everything but Ada specific support files compile > on every target, I am prone to want to fix the file that needs this. > I see. I just saw that pthreadimpl.h defines a call to a function it does not include and thought it might be slipped at some point because it's not used often. I don't mind keeping it local. My goal is to spend less time with the examples in the future anyway ;-) > I would check for my patches but I appear to have deleted my RTEMS > clone since then and lost the small patch I had. :( > > --joel > > Am Samstag, 1. August 2015, 12:08:12 schrieb Joel Sherrill: > >> Can you give a configuration or file that broke with this? > >> > >> I recall that I had a local patch that just added this line to an Ada > >> specific C file. Nothing else broke. > >> > >> On August 1, 2015 5:51:31 AM CDT, Jan > >> Sommer wrote: > >>> --- > >>> cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h > >>> b/cpukit/posix/include/rtems/posix/pthreadimpl.h > >>> index f95ac9c..33fa33d 100644 > >>> --- a/cpukit/posix/include/rtems/posix/pthreadimpl.h > >>> +++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h > >>> @@ -24,6 +24,7 @@ > >>> #include > >>> #include > >>> #include > >>> +#include > >>> #include > >>> > >>> #ifdef __cplusplus > >> --joel > > > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: GSoC 2015 RPi USB Support
During debugging of compiled Nexus module(driver) I found out that
content which suppose to be created in RTEMS_BSD_DEFINE_SET(nexus,
rtems_bsd_device) is empty, That should mean that either it is not
found or cannot be read. Please, let me know why empty content is not
create any error message and in what situation it can be empty.
2015-06-29 19:50 GMT+03:00 Yurii Shevtsov :
> So, it is empty.
>
> .rtemsroset.bsd.nexus.begin
> 0x001104bc0x0 ./libbsd.a(rtems-bsd-nexus.c.16.o)
> 0x001104bc_bsd__start_set_nexus
> .rtemsroset.bsd.nexus.end
> 0x001104bc0x0 ./libbsd.a(rtems-bsd-nexus.c.16.o)
> 0x001104bc_bsd__stop_set_nexus
>
> What will be next step? My repo:
> https://github.com/gtament/rtems-libbsd/commit/cf3f0fcafef3bcb9b0ec80d8c57e1304689ebace
>
> 2015-06-29 9:43 GMT+03:00 Sebastian Huber
> :
>> You can debug this issue on Qemu. The Nexus childes are registered in a
>> linker set, so I would consult the linker map file. It should look like
>> this:
>>
>> .rtemsroset.bsd.nexus.begin
>> 0x0052ef7c0x0 libbsd.a(rtems-bsd-nexus.o)
>> 0x0052ef7c _bsd__start_set_nexus
>> .rtemsroset.bsd.nexus.content
>> 0x0052ef7c 0x28
>> testsuite/telnetd01/test_main.o
>> .rtemsroset.bsd.nexus.end
>> 0x0052efa40x0 libbsd.a(rtems-bsd-nexus.o)
>> 0x0052efa4 _bsd__stop_set_nexus
>>
>> The .rtemsroset.bsd.nexus.content section must be non-empty.
>>
>>
>> On 27/06/15 16:39, Yurii Shevtsov wrote:
>>>
>>> Any ideas? Maybe I did some typo? Maybe you can compile and try it in
>>> qemu?
>>>
>>> 2015-06-26 17:05 GMT+03:00 Yurii Shevtsov :
2015-06-25 16:00 GMT+03:00 Sebastian Huber
:
>
> I would set a break point to nexus_probe(). In this loop
>
> SET_FOREACH(nd, nexus) {
> device_add_child(dev, nd->name, nd->unit);
> }
>
> your device must get added. I would also set break points to the probe
> and
> attach functions of your device.
Added printfs()
printf("before setforeach\n");
SET_FOREACH(nd, nexus) {
printf("setforeach: %s\n", nd->name);
device_add_child(dev, nd->name, nd->unit);
}
Got only 'before setforeach' in console. So it doesn't step into loop.
Any ideas? Also I already had printfs in my driver's probe and attach,
also got no output.
> On 25/06/15 14:50, Yurii Shevtsov wrote:
>>
>> This is ping message, with small update: the problem is not on the
>> linking stage, driver is linked to testsuite (checked with objdump)
>>
>> 2015-06-21 17:57 GMT+03:00 Yurii Shevtsov :
>>>
>>> Hello)
>>> Now I have apps from libbsd testsuite running. But DWC OTG driver
>>> doesn't
>>> loads.
>>> I added this lines to init01/test_main.c:
>>>
>>> +SYSINIT_NEED_USB_CORE;
>>> +SYSINIT_DRIVER_REFERENCE(bcm283x_dwcotg, nexus);
>>>
>>> (I know it's bad hardcode)
>>>
>>> If I run it. I get only this:
>>> nexus0:
>>> devctl: +nexus0 at on root0
>>> devctl: !system=IFNET subsystem=lo0 type=ATTACH
>>>
>>> Of course, I modified rtemsbsd/include/machine/rtems-bsd-sysinit.h and
>>> rtemsbsd/include/bsp/nexus-devices.h (took vlues from working DTS) and
>>> did other nexus-related changes to drivers. You can find changes in my
>>> repo https://github.com/gtament/rtems-libbsd/
>>> So I need some kind of code review, please.
>>> P.S. All testsuites (netshell01, usb01) with shell hangs without any
>>> output.
>>>
>>> Thanks in advance!
>>
>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail : sebastian.hu...@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>>
>> --
>> Sebastian Huber, embedded brains GmbH
>>
>> Address : Dornierstr. 4, D-82178 Puchheim, Germany
>> Phone : +49 89 189 47 41-16
>> Fax : +49 89 189 47 41-09
>> E-Mail : sebastian.hu...@embedded-brains.de
>> PGP : Public key available on request.
>>
>> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
