Re: [dev-servo] NCSU Team introduction
On Wednesday, October 19, 2016 at 7:53:11 AM UTC-4, Josh Matthews wrote: > Welcome! Please feel free to ask questions in > https://github.com/servo/servo/issues/11444 which is tracking this project. > > Cheers, > Josh > > On 2016-10-18 2:32 PM, Bhavya Bansal wrote: > > Hello All > > > > We are a team of three graduate students who have been assigned project > > "Implement HTML5 form validation" under course "Object Oriented Design and > > Development". > > > > Below is the team introduction: > > > > 1. Bhavya Bansal : master's student, computer science > > > > 2. Yuchen Sun: master's student, computer science > > > > 3. Mateenrehan Shaikh : master' student, computer science. > > > > At present we have started with the initial steps defined on the gitHub > > page and will be working towards the goal of the project. We have > > successfully compiled servo as stated in initial steps and now moving > > towards next steps. > > > > We are very excited to be a part of the project and looking forward to > > collaborate. > > > > Regards > > Bhavya Bansal > > 919-917-0115 > > Hello Josh Thanks for your response. We started working on validate function. I have a quick question from our team: While defining the trait Validatable, do we have to add a single function validate or you will suggest to add separate functions for different purpose like ValueMissing, TypeMisMatch etc. After which methods can be defined in the respective classes like HTMLInputElement. Regards Bhavya ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] NCSU Team introduction
On Saturday, October 22, 2016 at 10:24:51 AM UTC-4, Josh Matthews wrote: > On 2016-10-21 11:16 PM, bban...@ncsu.edu wrote: > > Hello Josh > > > > Thanks for your response. > > > > We started working on validate function. I have a quick question from our > > team: > > > > While defining the trait Validatable, do we have to add a single function > > validate or you will suggest to add separate functions for different > > purpose like ValueMissing, TypeMisMatch etc. > > > > After which methods can be defined in the respective classes like > > HTMLInputElement. > > > > Regards > > Bhavya > > > > I lean towards defining a single method for the time being. We can > refactor it into multiple ones later if it looks like it will make the > code clearer. > > Cheers, > Josh Hello Josh When we started project initially, we faced an error while run the test html file for which we figured out an open thread: https://github.com/servo/servo/issues/13515 We worked on it and tried a solution which was successful at that time. Solution is also posted on the thread by one of the team member. We added some methods today and compiled servo. Compilation is successful but we are now getting same shader error : Failed to compile shader: "/home/bbansal/Desktop/Servo/servo/resources/shaders/blur.vs.glsl" 0:1(10): error: GLSL 1.50 is not supported. Supported versions are: 1.10, 1.20, 1.30, and 1.00 ES Can you please provide some insights here? What is the issue which is blocking the code to run. Is this an issue related to graphics? Waiting for your response. Regards Bhavya ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] NCSU Team introduction
On Sunday, October 30, 2016 at 10:09:14 AM UTC-4, Josh Matthews wrote: > On 2016-10-28 1:01 PM, ysu...@ncsu.edu wrote: > > Hi Josh, we are a little bit confused about the last initial step. "Use the > > newly-added JS member to call these new methods as appropriate in > > each of the stub methods in ValidityState". We tried to call the function > > we declared in the trait and try to print out something when it get called > > but nothing happened. Can you explain the work flow of this validation > > stuff? > > > > The idea here is that: > * ValidityState has a JS member > * Element has a `as_maybe_validatable` method, that returns > Option<&Validatable> > * Validatable has a method that can perform validations > > We can combine these to make each of the stub methods that exist in > ValidityState (ValueMissing, TypeMismatch, etc.) invoke the method on > Validatable. Does that make sense? > > Cheers, > Josh Hello Josh Thanks for the explanation. So, when ever a form is submitted we call static validations and as we have pushed changes, for every element in the tree order, is that element is validatable, we have to invoke method is_validate which return either true or false. So, initial steps say that we have to add a method which takes enum as an argument. We had a discussion with our teaching assistant here and we wanted to confirm that by saying "method takes enum as an argument", does we have to pass whole enum set or method will take individual elements inside an enum and validate over that value. And is it possible to get your email id/ contact number so that we can discuss more about it. Regards Bhavya ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] NCSU Team introduction
On Thursday, November 3, 2016 at 5:43:29 PM UTC-4, Josh Matthews wrote: > On 2016-11-03 4:05 PM, ysu...@ncsu.edu wrote: > > Hi Josh, > > > > Do we need to write test cases for what we have done so far? If yes, do we > > need to run auto test cases (e.g. unit test) or a simple HTML test page is > > enough? Since right now we only did initial steps, we have no idea how to > > test it. Can you give us some instructions? > > > > I do not believe it is possible to create automated tests for the > changes in https://github.com/servo/servo/pull/13969 . > > Cheers, > Josh Thank you josh for your kind words and valuable suggestions. I was thinking, since we have changed the approach for the initial steps and are using bitflags instead of enum, shall we change the same on project description hosted on github so that the new team do not get confuse while implementing. Though I have explained them the whole sequence, and I am always available for them if they have any doubts, but still it would be great if we can update that. Regards Bhavya ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
