[dev-servo] Pull request template
Github introduced templates for issues and pull requests a couple months ago [1]. I'm interested in making use of them to address common points in our process where new contributors often miss steps. For example, consider a pull request template that looked like this: ``` Thanks for contributing to Servo! Please add an `X` inside each `[ ]` when the step is complete: - [ ] `./mach build` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes modify existing tests or add new ones, or update expected results in `ini` files OR: - [ ] These changes do not require tests Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. ``` This addresses common themes of: - contributors not knowing about `./mach test-tidy` - reviewers r+ing without waiting for TravisCI results - reviewers r+ing without requiring tests I'm on the fence about whether we should accept PRs that remove this boilerplate, since it doesn't feel like a significant burden to fill out to me. Thoughts? Cheers, Josh [1] https://github.com/blog/2111-issue-and-pull-request-templates ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Pull request template
I'm willing to give it a try. I'd suggest shortening up the text of the third one, and for the fourth one, add a "because:" so that they have to justify their lack of tests. jack. On Fri, May 6, 2016 at 9:13 AM, Josh Matthews wrote: > Github introduced templates for issues and pull requests a couple months ago > [1]. I'm interested in making use of them to address common points in our > process where new contributors often miss steps. For example, consider a > pull request template that looked like this: > > ``` > Thanks for contributing to Servo! Please add an `X` inside each `[ ]` when > the step is complete: > - [ ] `./mach build` does not report any errors > - [ ] `./mach test-tidy` does not report any errors > - [ ] These changes modify existing tests or add new ones, or update > expected results in `ini` files OR: > - [ ] These changes do not require tests > > Pull requests that do not address these steps are welcome, but they will > require additional verification as part of the review process. > ``` > > This addresses common themes of: > - contributors not knowing about `./mach test-tidy` > - reviewers r+ing without waiting for TravisCI results > - reviewers r+ing without requiring tests > > I'm on the fence about whether we should accept PRs that remove this > boilerplate, since it doesn't feel like a significant burden to fill out to > me. Thoughts? > > Cheers, > Josh > > > [1] https://github.com/blog/2111-issue-and-pull-request-templates > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
[dev-servo] Intermittent shutdown panics on Mac
We have a new intermittent failure that has been wreaking havoc on our CI all day. It's an intermittent shutdown panic in the script thread, possibly only on the Mac builders: https://github.com/servo/servo/issues/11059 Our usual trick of disabling tests won't work, since it seems to happen indiscriminately across all tests. If anyone has any ideas for fixing the bug or backing out patches that might have introduced it, please speak up. ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
