Re: [dev-servo] Reviewers
Le 1 sept. 2015 à 05:49, Simon Sapin a écrit : > On 01/09/15 02:21, Josh Matthews wrote: >> https://github.com/servo/servo/wiki/Meeting-2015-08-31 > >> Submodule reviews >> >> html5ever reviews > > I have delayed these html5ever reviews for various reasons, but they’re on my > queue. I’m willing to take this on officially, whatever that means. > > Speaking of which, we should figure out what that means. Ideally, I’d like us > to have at least two reviewers / owners for each area of code, with their > names published somewhere easy to find. One is not ideal when they’re on > vacation or otherwise unavailable, or to get their own PRs reviewed. "Areas > of code", to start, could be each crate in the servo/servo repository and > each other repository in the servo org on github. > > Of course we may not be able to reach this ideal state yet, but we should > still go towards it. I can be the second person on h5e, if you want. ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Reviewers
On 01/09/15 10:15, Anthony Ramine wrote: I can be the second person on h5e, if you want. That’s great, thanks! -- Simon Sapin ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Reviewers
Should we introduce some files which is like `OWNERS` file in Chromium tree, or write a document to wiki? 2015-09-01 12:49 GMT+09:00 Simon Sapin : > On 01/09/15 02:21, Josh Matthews wrote: >> >> https://github.com/servo/servo/wiki/Meeting-2015-08-31 > > >> Submodule reviews >> >> html5ever reviews > > > I have delayed these html5ever reviews for various reasons, but they’re on > my queue. I’m willing to take this on officially, whatever that means. > > Speaking of which, we should figure out what that means. Ideally, I’d like > us to have at least two reviewers / owners for each area of code, with their > names published somewhere easy to find. One is not ideal when they’re on > vacation or otherwise unavailable, or to get their own PRs reviewed. "Areas > of code", to start, could be each crate in the servo/servo repository and > each other repository in the servo org on github. > > Of course we may not be able to reach this ideal state yet, but we should > still go towards it. > > -- > Simon Sapin > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo -- Tetsuharu OHZEKI ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Reviewers
On 01/09/15 12:29, Tetsuharu OHZEKI wrote: Should we introduce some files which is like `OWNERS` file in Chromium tree, or write a document to wiki? If you want it in-tree — and that does have some advantages — it makes sense to make it easily machine readable using an existing format. Can you add arbitrary metadata to Cargo.toml files? ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Reviewers
On Sep 1, 2015, at 4:57 AM, James Graham wrote: On 01/09/15 12:29, Tetsuharu OHZEKI wrote: >> Should we introduce some files which is like `OWNERS` file in Chromium >> tree, or write a document to wiki? > > If you want it in-tree — and that does have some advantages — it makes sense > to make it easily machine readable using an existing format. Can you add > arbitrary metadata to Cargo.toml files? To date, I’d just been putting that information on our governance wiki page (https://github.com/servo/servo/wiki/Governance ). My only concern with having it in-tree is if we can’t have the convention consistent across our dependencies, then tooling expecting to be able to find an owner has to have a reasonable fallback. That said, it’s probably still better than my strategy, which required a human to read a wiki page. - Lars ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
