Re: [dev-servo] Adding Windows CI
On 10/05/2015 06:01, Manish Goregaokar wrote: Appveyor provides free CI for Windows, and is pretty easy to set up. Since we already have Travis set up on almost all deps, should we do the same with Appveyor? I tried it out on rust-url[1] and it worked pretty smoothly (yml copied from Glutin) Most of our deps should just work with Windows, and various volunteers have made progress on Windowsifying our native deps. Identifying which deps need Windows work; and ensuring that the working deps continue to work, would be quite helpful for the Windows effort. Thoughts? rust-url has platform-specific code (with e.g. #[cfg(windows)]) that, even though there’s not a lot of it, regularly got broken on Windows because I don’t test it and Travis-CI doesn’t test it: https://github.com/servo/rust-url/issues/102 So Appveyor is helpful there. For libraries like cssparser that don’t have platform-specific code however, I don’t think Appveyor brings us anything. -- Simon Sapin ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Adding Windows CI
It can be a sanity check that a library builds on Windows. Mostly that all its dependencies don't suddenly lose support or stop compiling. That's the only reason I'm considering doing so for hyper. On Sun, May 10, 2015, 2:11 AM Simon Sapin wrote: > On 10/05/2015 06:01, Manish Goregaokar wrote: > > Appveyor provides free CI for Windows, and is pretty easy to set up. > > > > Since we already have Travis set up on almost all deps, should we do > > the same with Appveyor? I tried it out on rust-url[1] and it worked > > pretty smoothly (yml copied from Glutin) > > > > > > Most of our deps should just work with Windows, and various > > volunteers have made progress on Windowsifying our native deps. > > Identifying which deps need Windows work; and ensuring that the > > working deps continue to work, would be quite helpful for the Windows > > effort. > > > > Thoughts? > > rust-url has platform-specific code (with e.g. #[cfg(windows)]) that, > even though there’s not a lot of it, regularly got broken on Windows > because I don’t test it and Travis-CI doesn’t test it: > > https://github.com/servo/rust-url/issues/102 > > So Appveyor is helpful there. > > For libraries like cssparser that don’t have platform-specific code > however, I don’t think Appveyor brings us anything. > > -- > Simon Sapin > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Adding Windows CI
Yeah, deps (and future addition of cfgs) is basically why I wanted this. But it's no big deal if we ignore crates like cssparser. I'm more interested in: - h5e (capi) - SM - fontconfig (not ported yet) - glutin (already CId) - openssl/hyper/other net libs - png/stb/other image libs -Manish Goregaokar On Sun, May 10, 2015 at 3:03 PM, Sean McArthur wrote: > It can be a sanity check that a library builds on Windows. Mostly that all > its dependencies don't suddenly lose support or stop compiling. > > That's the only reason I'm considering doing so for hyper. > > On Sun, May 10, 2015, 2:11 AM Simon Sapin wrote: > > > On 10/05/2015 06:01, Manish Goregaokar wrote: > > > Appveyor provides free CI for Windows, and is pretty easy to set up. > > > > > > Since we already have Travis set up on almost all deps, should we do > > > the same with Appveyor? I tried it out on rust-url[1] and it worked > > > pretty smoothly (yml copied from Glutin) > > > > > > > > > Most of our deps should just work with Windows, and various > > > volunteers have made progress on Windowsifying our native deps. > > > Identifying which deps need Windows work; and ensuring that the > > > working deps continue to work, would be quite helpful for the Windows > > > effort. > > > > > > Thoughts? > > > > rust-url has platform-specific code (with e.g. #[cfg(windows)]) that, > > even though there’s not a lot of it, regularly got broken on Windows > > because I don’t test it and Travis-CI doesn’t test it: > > > > https://github.com/servo/rust-url/issues/102 > > > > So Appveyor is helpful there. > > > > For libraries like cssparser that don’t have platform-specific code > > however, I don’t think Appveyor brings us anything. > > > > -- > > Simon Sapin > > ___ > > dev-servo mailing list > > dev-servo@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-servo > > > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
