Re: [dev-servo] Working on websocket student project

2015-04-14 Thread Allen Chen
On Monday, April 13, 2015 at 9:11:36 AM UTC-4, Ms2ger wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> On 04/13/2015 08:35 AM, ach...@ncsu.edu wrote:
> > Greetings,
> > 
> > I'm Allen, one of the students working on the Websocket student
> > project.
> > 
> > I can't seem to locate the mentioned Websocket.webidl file on this
> > spec page:
> > https://github.com/servo/servo/wiki/WebSocket-student-project
> > 
> > Find doesn't seem to locate it either. I would appreciate any help
> > on this.
> > 
> 
> It's WebSocket.idl (with a capital 'S') and lives in
> components/script/dom/webidls/.
> 
> HTH
> Ms2ger
> -BEGIN PGP SIGNATURE-
> 
> iQEcBAEBAgAGBQJVK8BgAAoJEOXgvIL+s8n2z9EH/1/7vOfUYBAWRf8RDcM5mS2K
> 2MqVwn7fTqvdoaNZg936frMQzdt4zmK60HQcbEf8rt9wmtzEvMymCeJP0ahV67vT
> qST021V3A4aUKDC+PBpVenOzJUnRF9DB2+GMeiuvgnXkIuxQOOqpqQ1iHhab6NBN
> /8IYlL85IczxMfuejcLdF+zy0NXX6w7XZUbWt9rGUYgikMk1QZ6A8QTp455XDy6/
> 8R5pKntxE4m/mOHB0sPpvzEonuI3ovwNqmtlh0ySDqy6kGHzzHDzX2ve/ptutqMN
> aFa3u3mHah83zAPqhP/CTTeaHQrzXj6thZ/70J5GPa/tX2bCjQYuh2ZX+8m3ynI=
> =rp5q
> -END PGP SIGNATURE-

Thank you!
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo


[dev-servo] Testing Reviewable for reviews

2015-04-14 Thread Lars Bergstrom
As was mentioned briefly in the meeting notes for this week 
(https://github.com/servo/servo/wiki/Meeting-2015-04-13 
 ), we are trying a new 
service, http://reviewable.io , for performing our 
reviews. This week, please make an effort to try out the tool for your reviews 
by clicking on the large purple “review on reviewable” link in the PR and let 
me know either via e-mail or IRC what you do and don’t like about it. 
Comparisons to either Critic or the built-in GitHub review UI are welcome.

I’m trying this out because:
- It handles rebases / force-pushes to PR branches automatically (easily our #1 
Critic failure point, especially for new contributors).
- The comments show up on GitHub & GitHub comments show up there, so there’s no 
“two worlds” experience.
- I only need to feel guilty for begging jgraham to help with our Web Platform 
Tests integration, and not both that AND our twice-weekly Critic crises.

Thanks,
- Lars

___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo