Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread Yizhi Liu
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1893968676
You are receiving this because you are subscribed to this thread.

Message ID: 

Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread Josh Fromm
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1893988138
You are receiving this because you are subscribed to this thread.

Message ID: 

Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread Bohan Hou
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1894017338
You are receiving this because you are subscribed to this thread.

Message ID: 

Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread Leandro Nunes
-1 (binding)

It has been raised before that [some tests are disabled in the `unity` 
branch](https://github.com/apache/tvm/blob/a2a1b534024e677a9407bec8d09d99f2237b2b0b/ci/jenkins/generated/gpu_jenkinsfile.groovy#L57-L60),
 so it would be good to double check that as this proposal is actioned by its 
proponents, we guarantee that all current `main` tests are passing on the 
proposed merged branch. It shouldn't be an onus of contributors working on 
`main` to re-enable their tests.

The linked source has a note that the test workaround shouldn't be moved into 
the target branch but the current vote statement isn't covering for this 
"disabled tests" item. If that's already planned, please let me know and I'll 
change the vote.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1894089436
You are receiving this because you are subscribed to this thread.

Message ID: 

Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread Tianqi Chen
see latest note in 
https://discuss.tvm.apache.org/t/discuss-tvm-core-strategy-for-emerging-needs/15751/27
 @Hzfengsy have take steps to ensure all main tests pass in unity. The the 
intention is to work with @Hzfengsy on enabling a smooth transition and main 
tests enabled

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1894123779
You are receiving this because you are subscribed to this thread.

Message ID: 

Re: [apache/tvm] [VOTE] Transition Main to Unity (Issue #16368)

2024-01-16 Thread gogo800
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1894848177
You are receiving this because you are subscribed to this thread.

Message ID: