[GitHub] tomcat issue #110: Debug log for pool's db properties
Github user wildloop commented on the issue: https://github.com/apache/tomcat/pull/110 It's just a debug-log to help find problems with incorrect config... in mys case it was: `db-properties.oracle.net.CONNECT_TIMEOUT: 3` --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #110: Debug log for pool's db properties
Github user wildloop commented on the issue: https://github.com/apache/tomcat/pull/110 Yes, cloud foundry connector initializes datasource basing on enviroment variables. My patch shows all properties, so it shows that something is missing. >Non-string values should probably be allowed within tomcat-pool. I think so, problem is here (`(oval instanceof String) ? (String)oval : null`): https://github.com/JetBrains/jdk8u_jdk/blob/master/src/share/classes/java/util/Properties.java#L970 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #110: Debug log for pool's db properties
GitHub user wildloop opened a pull request: https://github.com/apache/tomcat/pull/110 Debug log for pool's db properties I found that all non-string values are ignored by [java.util.Properties.java](https://github.com/JetBrains/jdk8u_jdk/blob/master/src/share/classes/java/util/Properties.java#L970) and sometime we don't know what exactly properties are passed to the driver. The way to log these properties out would be helpful... You can merge this pull request into a Git repository by running: $ git pull https://github.com/wildloop/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/110.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #110 commit 60612fc5ec708d38dad66c9b327163846aa3109b Author: wildloop Date: 2018-05-10T14:44:12Z Debug log for pool's db properties I found that all non-string values are ignored by [java.util.Properties.java](https://github.com/JetBrains/jdk8u_jdk/blob/master/src/share/classes/java/util/Properties.java#L970) and sometime we don't know what exactly properties are passed to the driver. The way to log these properties out would be helpful... commit 1e8532ccf275a564e1ffb10cd00df44283f6b0a4 Author: wildloop Date: 2018-05-10T14:47:57Z tabs to spaces --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
