[GitHub] tomcat pull request: Add maxStartTime to RequestInfo & RequestGrou...
GitHub user weipeng2k opened a pull request: https://github.com/apache/tomcat/pull/5 Add maxStartTime to RequestInfo & RequestGroupInfo. When retrieve Tomcat's request processor info through JMX, We can got maxTime and the maxRequestUri.Add maxStartTime (type is long, mills , start from 1970) to RequestInfo, We can know what time did this max request happen. You can merge this pull request into a Git repository by running: $ git pull https://github.com/weipeng2k/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit bbe06e4c803426c31717cf4f2298a9829ae37749 Author: weipeng2k Date: 2014-04-14T05:33:42Z RequestInfo add maxStartTime property. Add max start time, the longest response start time for a request. commit be7af1c3a52508444d9954bc224c8b2134056029 Author: weipeng2k Date: 2014-04-14T05:44:55Z reverse --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request: Add maxStartTime to RequestInfo & RequestGrou...
Github user weipeng2k commented on the pull request: https://github.com/apache/tomcat/pull/5#issuecomment-40353961 1. Not bug. It's not a bug. Just want to add maxStartTime to RequestInfo, it can record when does slow request happened. 2. Commit error. I am curious about tomcat-lite,read its code,but removed the .project and .classpath, It's my fault. I reverse it in my next commit. 3. maxStartTime decided by maxTime maxStartTime just record when did maxTime happened. If calculate maxStartTime itself, it may store the "last maxStartTime" not the real maxStartTime,I think maxStartTime would update when maxTime changed. 4. Missing I did not notice manager status web app. I should modify org.apache.catalina.manager.StatusTransformer, thank you remind me. 5. maxStartTime can see in console 6. About wiki I found request info in manager-howto.xml, it should updated also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
