[GitHub] tomcat pull request #130: Add two spaces (nbsp) in front of the Undeploy but...
GitHub user ljader opened a pull request: https://github.com/apache/tomcat/pull/130 Add two spaces (nbsp) in front of the Undeploy button Since there is no JavaScript in the Manager HTML, I decided to visually separate the Undeploy button from the rest of the buttons. This is to "prevent" **missclicks** on the Reload button, which ends with the Undeploy being clicked. (there is no Bugzilla ticket for this - I've created this to get your opinion on this.) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ljader/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit a775d89f16563de3959189baa6b74acfd6696419 Author: Lukasz Jader Date: 2018-11-01T00:12:12Z Add two spaces (nbsp) in front of the Undeploy button This is to "prevent" missclicks on the Reload button, which ends with the Undeploy being clicked. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #133: Update the ECJ dependency to 4.9 in ide-support fi...
GitHub user ljader opened a pull request: https://github.com/apache/tomcat/pull/133 Update the ECJ dependency to 4.9 in ide-support files The ECJ dependency was bumped in revision a2c399c3 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/ljader/tomcat fix_eclipse_support_classpath Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 commit 0fdb2550e142d3137d3b077a042d63e0184a05c0 Author: Lukasz Jader Date: 2018-11-17T21:41:34Z Update the ECJ dependency to 4.9 in ide-support files The ECJ dependency was bumped in revision a2c399c3 . --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #134: Display generate date when showing every message i...
GitHub user ljader opened a pull request: https://github.com/apache/tomcat/pull/134 Display generate date when showing every message in Html Manager This additions shows sample message in following format: ``` OK - Stopped application at context path [/app] Generated at: 2018-11-18 14:44:08 UTC (2018-11-18 15:44:08 VM time) ``` **Why the addition:** Often when I connect into our legacy servers with Windows RDP client, I intercept existing session where the Tomcat Manager was open in the browser. With current Tomcat Manager output I have no way of knowing **when** the Message shown was generated - was it 10 seconds ago or yesterday? I welcome any feedback on this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ljader/tomcat add_message_generate_date Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 41b7367f0e321608f23d3d5fb4d193543b0b7efa Author: Lukasz Jader Date: 2018-11-18T14:45:25Z Display generate date when showing every message in Html Manager --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Github user ljader commented on the issue: https://github.com/apache/tomcat/pull/134 Thank you all for the comments - could you help me with getting them right? 1. How I can get the "Date" header without reloading the page when the DevTools are **closed** (by default)? 2. Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox shows **every time a different** date ? If yes, then I can's see how it's helpfull. 3. I think I don't get why someone would like to checksum the response of Html Manager - can you give some examples? Isn't the `manager/text` designed to automate? Thinking about my 3rd question, I want to clarify that my change only affects (or what I originaly intended) is to change only the `manager/html` - NOT the `manager/text` --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Github user ljader commented on the issue: https://github.com/apache/tomcat/pull/134 When it comes to checksuming the response of Html Manager, recently there was a Pull Request which added 2 nbsp's to the produced Html - #130 If you decide to not proceed with this change, consider if the mentioned PR should be reverted. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
