[GitHub] tomcat-maven-plugin pull request: basic support for tomcat 8
GitHub user kalgon opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/6 basic support for tomcat 8 This is a basic port of tomcat7-maven-plugin to use the new tomcat 8.0.9 engine. No new feature from tomcat 8 has been added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit d0d93503cb520606fd2df9179e3f2521dda6be1e Author: kalgon Date: 2014-08-12T13:30:27Z basic support for tomcat 8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: basic support for tomcat 8
Github user kalgon closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 Classloading issues
GitHub user kalgon opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/7 MTOMCAT-234 Classloading issues this fixes the `java.lang.ClassFormatError` but there is another problem: it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies instead of the webapp ones. The result is that no `web-fragment.xml` or `ServletContainerInitializer` works anymore (and I suspect there should be other consequences as well). I did not have enough time to investigate but I noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't know the internals of Tomcat very well. I'll try to make some time next week to dig a bit deeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496 Author: kalgon Date: 2014-08-14T10:47:12Z MTOMCAT-234 Classloading issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 Classloading issues
Github user kalgon closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
