[GitHub] tomcat pull request #54: Respect minimum pool size
GitHub user jelmerterwal opened a pull request: https://github.com/apache/tomcat/pull/54 Respect minimum pool size You can merge this pull request into a Git repository by running: $ git pull https://github.com/jelmerterwal/tomcat respec_min_pool_size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 41e5f29530ff241d82f954911e48cb0af7bbdff6 Author: Jelmer ter Wal Date: 2017-04-24T10:17:38Z Respect minimum pool size --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #54: Respect minimum pool size
Github user jelmerterwal commented on the issue: https://github.com/apache/tomcat/pull/54 For an application I develop, I see a drop in connections. The screenshot show different values of the connection pool. Legend for the colours; - grey -> pool size - greenish -> idle connections - orange/red -> connections in use - purple -> waiting for a connection  The application uses dropwizard (www.dropwizard.io) which internally uses Tomcat's JDBC Pool. The application has 4 instances. The graph shows the sum of these instances for the number of connections. - min size of idle connection is set to 10 (so should be 10 x 4 = 40) - the decrease happens due abandoning of connections The documentation indicates a minimum pool of idle connections should be available. It scared me when I first saw this happening. ``` minIdle (int) The minimum number of established connections that should be kept in the pool at all times. The connection pool can shrink below this number if validation queries fail. Default value is derived from initialSize:10 (also see testWhileIdle) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #54: Respect minimum pool size
Github user jelmerterwal commented on the issue: https://github.com/apache/tomcat/pull/54 Below an image of further progress during the day. Where graphs peek at 40 the application has been restarted. https://cloud.githubusercontent.com/assets/5363087/25348472/af5048f0-291e-11e7-9c5c-ee9c4ffc7a87.png";> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #54: Respect minimum pool size [#61032]
Github user jelmerterwal commented on the issue: https://github.com/apache/tomcat/pull/54 @markt-asf could you have a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org