Re: Test failures with trunk/head

[Toby Hobson]

Rainer Jung  kippdata.de> writes:

> 
> Never have seen that one failing.
> 
> > junit.framework.AssertionFailedError: arrays first differed at element [0];
> > expected:<...Jan/1970:01:00:00 +0[1]00]> but was:<...Jan/1970:01:00:00
> > +0[0]00]> at
> >
org.apache.catalina.valves.TestAccessLogValve.testBug54044
(TestAccessLogValve.java:52)
> 
> This should have been fixed very recently by r1410770 about 4 days ago.
> Please check if your TC 7 checkout already contains that revision.
> 
> Regards,
> 
> Rainer
> 

I'm on r1412145

Regards,

Toby





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Contributing an authenticator - core vs extras

[Toby Hobson]

Hi Mark

Thanks for your quick response, I will do as you suggest

Toby

On 14 December 2012 09:51, Mark Thomas  wrote:

> Toby,
>
> Thanks for your mail.
>
> There are no hard and fast rules. The recommended destination depends on a
> number of factors:
> - amount of code
> - degree of demand for the feature
> - license
> - dependencies
>
> I'd suggest creating a Bugzilla entry and attach your patch for review.
>
> Mark
>
> Toby Hobson  wrote:
>
> >I have developed a catalina authenticator (which integrates SAML based
> >single sign on) and would be happy to contribute it to the tomcat
> >project.
> >I was wondering if there are any guidelines about what should be
> >contributed to the core vs the extras project? I ask because from what
> >I
> >have seen there are no example webapps/integration tests for the extras
> >projects (unless I have missed something?).
> >
> >Thanks
> >
> >Toby
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>