Need reviews for PR for bug 64644

2020-08-05 Thread Saksham Verma
Hi,

I need reviews for PR
https://github.com/apache/tomcat/pull/330#issue-462890625

It corresponds to the bug :
https://bz.apache.org/bugzilla/show_bug.cgi?id=64644

I can provide a video for the demo of the issue and how it is affecting my
product in real world.

Thanks in advance.

Regards,
Saksham Verma


How to run individual Test

2020-08-10 Thread Saksham Verma
Hi Dev Team,

Need help with below questions:

1. The Pull request Tests are failing on Travis CI. But Is there any way I
can get the logs for the test job?

2. How can I run any individual test. Whenever I am trying to run a single
test I get below error:
java.lang.VerifyError: Inconsistent stackmap frames at branch target 392
Exception Details:
  Location:

org/apache/juli/ClassLoaderLogManager.readConfiguration(Ljava/lang/ClassLoader;)V
@392: ldc_w
  Reason:
Type uninitialized 370 (current frame, stack[2]) is not assignable to
uninitialized 366 (stack map, stack[2])
  Current Frame:
bci: @383
flags: { }
locals: { 'org/apache/juli/ClassLoaderLogManager',
'java/lang/ClassLoader', 'java/io/InputStream', 'java/lang/String' }
stack: { uninitialized 366, uninitialized 366, uninitialized 370,
uninitialized 370, 'java/lang/String', integer }
  Stackmap Frame:
bci: @392
flags: { }
locals: { 'org/apache/juli/ClassLoaderLogManager',
'java/lang/ClassLoader', 'java/io/InputStream', 'java/lang/String' }
stack: { uninitialized 366, uninitialized 366, uninitialized 366,
uninitialized 366, 'java/lang/String' }
  Bytecode:

Thanks,
Saksham


Need to merge The patch for Bug 64644

2020-08-28 Thread Saksham Verma
Hi,

I am a thingworx developer and many of our customers are struggling due to
the bug https://bz.apache.org/bugzilla/show_bug.cgi?id=64644.

I have raised a PR
https://github.com/apache/tomcat/pull/346
It has one approval.

The PR is according to the suggestion from Mark on the bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=64644#c4

It will be a great help to us (Thingworx) and to our customers if we could
get this merged and release it soon.

Could someone please review it and let me know what are the next steps to
get it merged?

Thanks,
Saksham