Re: svn commit: r358285 - in /tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime: BodyContentImpl.java JspFactoryImpl.java

[Paul Speed]

Just wondering if/why this is better than simply calling:
Boolean.getBoolean( 
"org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER" );


All of them end up calling the same method anyway, but getBoolean() 
seems clearer to me in this case and was just wondering if there is 
something bad about it.


-Paul

[EMAIL PROTECTED] wrote:


Author: remm
Date: Wed Dec 21 05:09:42 2005
New Revision: 358285

URL: http://svn.apache.org/viewcvs?rev=358285&view=rev
Log:
- Ok, so I used a Java 5 API.

Modified:

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java?rev=358285&r1=358284&r2=358285&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
 Wed Dec 21 05:09:42 2005
@@ -41,7 +41,7 @@
 private static final String LINE_SEPARATOR = 
 System.getProperty("line.separator");
 private static final boolean LIMIT_BUFFER = 
-Boolean.parseBoolean(System.getProperty("org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER", "false"));

+
Boolean.valueOf(System.getProperty("org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER",
 "false")).booleanValue();
 
 private char[] cb;

 private int nextChar;

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java?rev=358285&r1=358284&r2=358285&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
 Wed Dec 21 05:09:42 2005
@@ -41,7 +41,7 @@
 
 private static final String SPEC_VERSION = "2.0";
 private static final boolean USE_POOL = 
-Boolean.parseBoolean(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.USE_POOL", "true"));

+
Boolean.valueOf(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.USE_POOL", 
"true")).booleanValue();
 
 private SimplePool pool = new SimplePool(100);
 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Challenges for Java hosting

[Paul Speed]

Reinhard Moosauer wrote:



Ok. But you can kill the webapp with the amok-thread. So we will not have a 
break every 3 requests. (the thread can be tracked down to the failing 
webapp. Send a mail with the thread-stack-dump)


You can't really kill a thread in Java.  We used to have a joke at a 
previous job that the only safe way to kill a thread in Java is 
System.exit(0).


And as I recall, while the javadocs for Thread.stop() detail some of the 
reasons, there is much more badness possible than even what it states.


-Paul

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]