Re: [VOTE] Release Apache Tomcat 9.0.30
[X] Stable - go ahead and release as 9.0.30 Many thanks Jon On Sat, Dec 7, 2019 at 5:24 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.30 release is now available for voting. > > The major changes compared to the 9.0.29 release are: > > - Correct multiple regressions in the static resource caching related to > using URLs provided for cached resources > > - Improvements to the Realm interface and implementations > > - Bug fixes and improvements to the CORS filter > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.30/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1240/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.30 > 4fab4cc012d0c31852e957d198cb0549f3d6074c > > The proposed 9.0.30 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 9.0.30 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.50
[X] Stable - go ahead and release as 8.5.50 Many thanks Jon On Sat, Dec 7, 2019 at 7:54 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.50 release is now available for voting. > > The major changes compared to the 8.5.49 release are: > > - Correct multiple regressions in the static resource caching related to > using URLs provided for cached resources > > - Improvements to the Realm interface and implementations > > - Bug fixes and improvements to the CORS filter > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.50/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1241/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.50 > c40ede65ea4fb44b1957ec482f28c7afa71f1b50 > > The proposed 8.5.50 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.5.50 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 7.0.99
[X] Stable - go ahead and release as 7.0.99 Stable Many thanks, Jon On Wed, Dec 11, 2019 at 1:52 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.99 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.99/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1242/ > The git tag is: > https://github.com/apache/tomcat/tree/7.0.99 > a94a0258f36d064aa032608a9e99c62018f22d94 > > The proposed 7.0.99 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 7.0.99 Stable > > Regards, > Violeta >
Re: [TCK] JSTL failure
I opened both the import-encoded.txt, and the positiveImportEncodingNotSpecifiedTest.gf file in a hex editor. I don't know if this mailing list allows attachments, but I can send a screenshot if that helps. In both cases, right before the word "output from text file", there's a sequence of 4 bytes 0xFE, 0xFF, 0x00, 0x6F. The 0x6F is the "o" on "output", so it looks like the 0xFF 0xFE is being dropped somewhere. The test sounds ok (although maybe not straightforward to understand). On the TomEE side, I think we need to understand whether this is an issue with our use of shading to include Xalan, or whether we'd still see this issue if we included Xalan etc manually without shading. Jon On Thu, Dec 17, 2020 at 8:27 AM Jean-Louis MONTEIRO wrote: > Hi, > > I have been using Tomcat Taglib (shaded with Xalan and Serializer). > Works quite well on TomEE but I have one failure I'd like to discuss with > you before possibly opening a challenge. > > > https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED > > I have fixed 4 or the 5, > but com.sun.ts.tests.jstl.spec.core.urlresource.importtag.JSTLClient is > still failing and I don't understand how to fix it. > > Here is the JSP > > https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.jsp > > Here is the expected result > > https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.gf > > The first file imported is > > https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/encoding/Encoding.jsp > > And the second > > https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/import-encoded.txt > > In the golden file, there seems to be 2 extra characters. > Here is the full log file for the test run > > https://tck.work/tomee/api/testlog/1218/1608116849515 > > Any thoughts? > The result from Tomcat looks ok to me unless I missed something. > > > > -- > Jean-Louis >
Re: [TCK] JSTL failure
Looking at this again, those characters are a BOM, and having that in the middle of the output seems a little strange. I'd suggest asking on the spec list. Jon On Thu, Dec 17, 2020 at 10:51 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I opened both the import-encoded.txt, and the > positiveImportEncodingNotSpecifiedTest.gf file in a hex editor. I don't > know if this mailing list allows attachments, but I can send a screenshot > if that helps. In both cases, right before the word "output from text > file", there's a sequence of 4 bytes 0xFE, 0xFF, 0x00, 0x6F. The 0x6F is > the "o" on "output", so it looks like the 0xFF 0xFE is being dropped > somewhere. The test sounds ok (although maybe not straightforward to > understand). On the TomEE side, I think we need to understand whether this > is an issue with our use of shading to include Xalan, or whether we'd still > see this issue if we included Xalan etc manually without shading. > > Jon > > On Thu, Dec 17, 2020 at 8:27 AM Jean-Louis MONTEIRO > wrote: > >> Hi, >> >> I have been using Tomcat Taglib (shaded with Xalan and Serializer). >> Works quite well on TomEE but I have one failure I'd like to discuss with >> you before possibly opening a challenge. >> >> >> https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED >> >> I have fixed 4 or the 5, >> but com.sun.ts.tests.jstl.spec.core.urlresource.importtag.JSTLClient is >> still failing and I don't understand how to fix it. >> >> Here is the JSP >> >> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.jsp >> >> Here is the expected result >> >> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.gf >> >> The first file imported is >> >> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/encoding/Encoding.jsp >> >> And the second >> >> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/import-encoded.txt >> >> In the golden file, there seems to be 2 extra characters. >> Here is the full log file for the test run >> >> https://tck.work/tomee/api/testlog/1218/1608116849515 >> >> Any thoughts? >> The result from Tomcat looks ok to me unless I missed something. >> >> >> >> -- >> Jean-Louis >> >
Re: [VOTE] Release Apache Tomcat 9.0.29
[X] Stable - go ahead and release as 9.0.29 Thanks Jon On Sat, Nov 16, 2019 at 6:56 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.29 release is now available for voting. > > The major changes compared to the 9.0.27 release are: > > - Improvements to Async error handling > > - Stricter processing of HTTP headers when looking for specific token > values > > - Fix various issues that could lead to modification to a JSP not being > reflected in the served page > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.29/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1236/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.29 > > > The proposed 9.0.29 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 9.0.29 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
