regarding logging practice in tomcat source

2017-04-20 Thread Hoa Phan
Hi,

I've been wondering if the condition guarding log statement in tomcat src
like:

if (log.isDebugEnabled()) log.debug("[4] Backup becoming primary");


Is it on purpose, for performance sake or just legacy code.

Would the string inside get GC or st?


Thanks.


Regards,


How to open and navigate tomcat project in IDE

2017-01-25 Thread Hoa Phan
Hi, is there a guide to open tomcat project in an IDE so that IO can
navigate through source code with all support from the IDE?

I tried to open with IntelliJ but couldn't get it to recognize the source
code.
I tried Eclipse too but got the same thing.
I tried:

*ant ide-eclipse*
but got:



















































*Buildfile:
C:\Users\hoaphan\tomcat\build.xmldownload-compile:testexist: [echo]
Testing  for
/usr/share/java/tomcat-native-1.1.29/tomcat-native.tar.gzdownloadfile-2:proxyflags:setproxy:testexist:
[echo] Testing  for
/usr/share/java/commons-daemon-1.0.15/commons-daemon-1.0.15.jardownloadgz-2:testexist:
[echo] Testing  for
/usr/share/java/commons-daemon-1.0.15/commons-daemon-1.0.15-native-src.tar.gzdownloadfile-2:proxyflags:setproxy:testexist:
[echo] Testing  for
/usr/share/java/commons-pool2-2.1-SNAPSHOT-src/build.xmldownloadgz-2:proxyflags:setproxy:trydownload.check:trydownload:proxyflags:setproxy:trydownload.check:trydownload:BUILD
FAILEDC:\Users\hoaphan\tomcat\build.xml:2583: The following error occurred
while execut*


How do I map a tomcat version to source code

2017-06-11 Thread Hoa Phan
On
https://github.com/apache/tomcat <https://github.com/apache/tomcat>
When I checked the “tag” of 8.x I only see:

8_0_RC_***

Is there a quick way to know exactly which revision to check out to debug 
apache-tomcat-8.0.36 that I am running?
Why isn’t there tag that have that exact version?

Thanks.

Regards,

Hoa Phan.

How do I map a tomcat version to source code

2017-06-11 Thread Hoa Phan
Thanks so much, Mark.