Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Guenter Knauf
Hi,
> Apache Tomcat Connectors 1.2.23 is:
> [x] Stable - no major issues, no regressions
> [ ] Beta - at least one significant issue -- tell us what it is
> [ ] Alpha - multiple significant issues -- tell us what they are

tested on NetWare with our standard Tomcat applications.

Binaries uploaded to:
http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/binaries/netware/

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat JK 1.2.23 Web Server Connector released

2007-05-19 Thread Guenter Knauf
Hi all,
> The Apache Tomcat team is pleased to announce the immediate availability
> of version 1.2.23 of the Apache Tomcat Connectors.
somehow I've a problem with our distribution directories..
currently I see:

http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/aix/
  empty folder
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/freebsd/
  empty folder
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/iseries/
  empty folder
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/linux/
  jk-1.2.21
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/macosx/
  empty folder
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/netware/
  jk-1.2.23
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/solaris/
  jk-1.2.21
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/win32/
  jk-1.2.21
  jk-1.2.22
  jk-1.2.23
http://www.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/win64/
  jk-1.2.23

this makes me ask a couple of questions:
1) why do some folders list older versions while others do not?
2) why do we have a history of the last 3 versions with Win32 but no history 
for any other platform?
3) where do the older versions go?
4) why do we prefix the directories with 'jk-' although 'jk' is already in the 
path?

For NetWare I would like to have at least the 1.2.15 release up again since 
that was last version where I supported Apache 1.3.x and Netscape - I point to 
this version in the README but obviously nobody can download anymore (except 
from my personal homedir). Sure its no problem for me just copy this over, but 
first I wanted to discuss that here, and ask if I probably missed that there's 
somewhere an archive from where older versions can be downloaded...
Then I would like to have at least the last three versions always up, + the 
last version we have for any platforms where we cant build self, or where the 
maintainer is currently busy and some versions behind.
This makes also sense in case it turns out later that we broke something with a 
release, and users may have to switch back.

what do you think?

greets, Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat JK 1.2.23 Web Server Connector released

2007-05-20 Thread Guenter Knauf
Hi Mark,
>> 1) why do some folders list older versions while others do not?
> Probably because they are the latest stable version for that platform.

>> 2) why do we have a history of the last 3 versions with Win32 but no
>> history for any other platform?
> Because the old version weren't cleaned out. They should have been.

>> 3) where do the older versions go?
> They are automatically copied to archive.apache.org which is linked
> off the Tomcat homepage.
I found though that the README.html files which are commonly used to provide 
further informations about the releases are not copied.

>> I probably missed that there's somewhere an archive from where older
>> versions can be downloaded...
> This is not correct. It is available along with all other versions in
> the archive.
that was what I missed - thanks!

>> Then I would like to have at least the last three versions always up, +
>> the last version we have for any platforms where we cant build self, or
>> where the maintainer is currently busy and some versions behind.
> -1.
> dist (and the mirrors) should only have the current stable version and
>  the latest non-stable release if there has been once since the last
> stable release.
so does this mean if we dont have a binary from current version the directory 
should remain empty?
Or should there then remain the last version we have as you wrote in 1) ?

If they should remain empty then I would find it useful to have a README in 
which points to the related archive, and I volunteer to create these if there's 
agreement. There are probably a lot of users who just link to the dist 
directory of their platform, and would find a poiter to the archives useful.

Then I found on the main docu page:
http://tomcat.apache.org/connectors-doc/
that there are direct links to the previous source versions, but all end up in 
a 'NOT FOUND';
should we change these to point to the archive now?

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat JK 1.2.23 Web Server Connector released

2007-05-20 Thread Guenter Knauf
Hi Henri,
> The iSeries (i5/OS) version need stuff added after 1.22 so it will be
> available in 1.24...
dont get me wrong - I didnt want to kick here, it was only a question why we 
had different handling for each platform

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat JK 1.2.23 Web Server Connector released

2007-05-20 Thread Guenter Knauf
Hi Rainer,
> Yes, I tried to delete all older versions of binaries (tried = as far as
> permissions allowed), but for sme platforms we don't have 1.2.23
> binares, so I kept the latest available ones.
that was what I expected.

> There is an open point, if we can find a way of distributing contributed
> builds. I know we could get some, but there were valid concerns, if we
> shold sign those with our own keys. So we would need some notion of
> "contributed" and could put the binaries there.
hmm, yes, that's a problem...

>>> 4) why do we prefix the directories with 'jk-' although 'jk' is already
>>> in the path?
>> No particular reason I am aware of. We just do.

> Seems to be history, and you decided to drop it for Netware :)
that was by acciedent - did rename the directory to be in sync with the others;
I thought that some longer time ago we did without, but when I looked through 
the archives it looked as if we did all the time; so it was merely a question 
before I checked the archives, and not the wish to change

> So if the archives are important, we could replace the link text
> "archives..." with something a little more prominent. Suggestions?
well, thanks to Mark pointing me to the archives I solved this with the README 
file where I inserted the link to the archive, so all fine for now; 
and if we find the memory leak with mod_jk AP13 then with 1.2.24 I can again 
provide binaries for AP13 and NS.

thanks, Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: mod_jk 1.2.24 withdrawal?

2007-08-03 Thread Guenter Knauf
Hi,
> I agree. Remove 1.2.24 and include all the patches.
> Let's roll that ASAP.
+1, same oppinion here.

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.25

2007-08-08 Thread Guenter Knauf
Hi,
> Apache Tomcat Connectors 1.2.25 is:

> [x] Stable - no major issues, no regressions

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [PROPOSAL] Rename all STATUS files to STATUS.txt

2007-11-14 Thread Guenter Knauf
Hi Mark,
> Alternatively, if anyone knows a workaround so I can just double click and
> edit that would be fine too.
not directly what you might expect - however much better than the open selector:
open the menue tree with right-click on the start button, then in the 'All 
users' or in your personal tree lookup the 'SendTo' folder (requires setting to 
be able to view hidden folders), inside the 'SendTo' folder add a link to your 
favorite text editor, and prepend the link description with a '-' so that it 
appears at the top of the SendTo menue. Now you can right-click any file, and 
via SendTo context menue send to your text editor.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat JK 1.2.21 Web Server Connector released

2007-03-03 Thread Guenter Knauf
Hi,
> The Apache Tomcat team is pleased to announce the immediate availability
> of version 1.2.21 of the Apache Tomcat Connectors.
I've just uploaded NetWare binaries to my directory:
http://people.apache.org/~fuankg/mod_jk/1.2.21/
can please someone with commit rights copy them over to the release location - 
my commit rights got lost with the move to SVN; or can someone kindly tell me 
how I can receive again the needed rights?

> This version of mod_jk is principally a bug and security fix release.
> The following potential security flaw is addressed:
It seems to me that with recently introduced check its no longer possible to 
use mod_jk without worker.properties file - was this intended? From the 
ChangeLog it sounds more as if the parameter is checked for proper path if 
exist; but the behaviour is that the worker.properties file is now mandatory.

greets, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Should we release mod_jk 1.2.21.1 or 1.2.22?

2007-03-11 Thread Guenter Knauf
> [ ] Try to improve the header files for a 1.2.21.1
> [x] Simply release 1.2.22
> [ ] Don't release at all, wait for more fixes or features before
> releasing.

Guenter.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: mod_jk 1.2.22-dev test

2007-03-13 Thread Guenter Knauf
Hi Henri,
> Testing jk 1.2.22 on iSeries :

> A little quirk on this OS (variables defined inside code ) :)

yes, same here on NetWare:

--- jk_map.c.orig   Fri Mar 09 22:42:06 2007
+++ jk_map.cMon Mar 12 17:37:42 2007
@@ -718,12 +718,12 @@
 unsigned int i;
 for (i = 0; i < m->size; i++) {
 if (!strncmp(m->names[i], from, strlen(from))) {
-rc = JK_TRUE;
 const char *prp = m->names[i] + strlen(from);
 char *to_prp = jk_pool_alloc(&m->p,
  (sizeof(char) *
  (strlen(to) +
  strlen(prp) + 1)));
+rc = JK_TRUE;
 if (!to_prp) {
 jk_log(l, JK_LOG_ERROR,
"Error in string allocation for attribute '%s.%s'",


that fixes it for NetWare.

greetz, Guen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk 1.2.22-dev test

2007-03-13 Thread Guenter Knauf
Hi Rainer,
> I'll take care of your comments (before 1.2.22).
ok; beside this small build issue I can say that two other testers and I found 
no other issues so far with our applications using Tomcat on NetWare, so:

+ for NetWare platform.

greetz, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 1.2.22

2007-04-10 Thread Guenter Knauf
Hi Rainer,
> - Fix whitespace in Netware make file
non-important, was more a test that commit works again; please drop from the 
list.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 1.2.22

2007-04-12 Thread Guenter Knauf
Hi,
> Hi there is new quality check release available from:
> http://people.apache.org/~mturk/jk-1.2.22-dev/

> It contains few minor fixes mostly for documentation
> and release script (owner/group for .tar)

> I'll give it 24 hours before making a tag for any
> last minute checks.
+1 for NetWare, tested with TC 3.3.1, 4.1.31, 4.1.34, 5.0.30.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Guenter Knauf
> Apache Tomcat Connectors 1.2.22 is:
> [x] Stable - no major issues, no regressions
> [ ] Beta - at least one significant issue -- tell us what it is
> [ ] Alpha - multiple significant issues -- tell us what they are

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: snprintf/vsnprintf in mod_jk

2007-04-14 Thread Guenter Knauf
Hi,
> We have those routines twice (in jk_util.c and jk_status.c).
> We are also assuming that the platforms always have snprintf() in
> jk_lb_worker.c for example.
yes, and that was one reason why I couldnt build post-1.2.15 versions for 
NetWare Apache 1.3.x and Netscape.

> In jk_global.h there is:
> +++
> /*  There is a snprintf() and vsnprintf() in jk_util.c */
> /* if those work remove the #define. */
> #if defined(NETWARE) || defined(AS400)
> #define USE_SPRINTF
> #define USE_VSPRINTF
> #endif
> +++

> Could someone check that the snprintf() and snprintf() of jk_util.c are
> working on NETWARE and AS400?
I've just checked with these, and they dont work for NetWare because we have no 
/dev/null support.
Therefore I would like to suggest another approach: let us import ap_snprintf.c 
from Apache 1.3.x into the mod_jk project.
I think this is a good solution; we have there a ready-to-use stable 
implementation, and every platform which lacks of an own snprintf() / 
vsnprintf() implementation can then pick this up only when not build with/for 
Apache; when build with Apache 1.3.x then its even not needed to compile this 
external ap_snprintf.c because then we can directly import ap_snprintf() / 
ap_vsnprint() from Apache, and only need the defines in jk_global.h.

I have hacked a new header ap_snprintf.h:
http://people.apache.org/~fuankg/diffs/ap_snprintf.h

and patched ap_snprintf.c from Apache 1.3.37 to build standalone:
http://people.apache.org/~fuankg/diffs/ap_snprintf.c.diff

then changed the defines in jk_global.h:
http://people.apache.org/~fuankg/diffs/jk_global.h.diff

these changes let me again build mod_jk for Apache 1.3 and also the Netscape 
plugin for NetWare platform.

Also we can then remove the other snprintf() / vsnprintf() functions, and 
remove the USE_SPRINTF and USE_VSPRINTF hacks completely which is also 
important because it removes a potential buffer overflow.

anybody out there who can test this with AS400?

comments welcome!

greets, Guenter,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: snprintf/vsnprintf in mod_jk

2007-04-16 Thread Guenter Knauf
Hi Henri,
>> anybody out there who can test this with AS400?

> I could test on AS400 but mod_jk didn't works on AS400, seems to me a
> thread/log problem and I can't figure it where
I've just put the stuff into SVN, perhaps you can check it that builds at least;
if you see linkage errors then you might have to add ap_spnprintf.c somwhere to 
the buid process...

does mod_jk 1.2.15 work on AS400? I see currently with this 1.2.23-dev a memory 
leak of 8280 bytes;
with 1.2.15 I dont see this; but I've not further tracked down yet where this 
might be - however its _not_ from the HUGE_BUFFER_SIZE buffer; I did a quick 
test with this buffer doubled in size, but the leak kept same...

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: mod_jk on i5/OS v5R4

2007-04-18 Thread Guenter Knauf
Hi Henri,
> Well I add to remove the JkWorkersFile directive to make mod_jk start
> and have some debug.

> I suspect the problem is that in the first stage of init the user
> profile on i5/OS is different than the real user profile in the second
> stage.

> This profile didn't have access to JkWorkersFile and so mod_jk fail to
> load the WorkersFile and report as error in first stage.

> Question :

> - How could we determine that we're in the first stage ?

> - Could 'relax' file access check for instance in the first stage to
> avoid file access problem on i5/OS ?

IIRC there were at some time similar probs with mod_ssl which also handles its 
own log files;
if mod_ssl works on i5/OS probably you can find the trick there in the code...?

just an idea...

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[PROPOSAL] add Tomcat version output to snoop.jsp sample

2007-04-18 Thread Guenter Knauf
Hi all,
since I often test with different Tomcat versions I would find it useful to see 
the TC version too with the snoop sample, f.e. something like that (or also at 
the end added):

--- snoop.jsp.orig  Wed Apr 18 18:35:12 2007
+++ snoop.jsp   Wed Apr 18 18:41:46 2007
@@ -19,6 +19,8 @@
 
  Request Information 
 
+Server Software: <%= getServletContext().getServerInfo() %>
+
 JSP Request Method: <% out.print(util.HTMLFilter.filter(request.getMethod())); 
%>
 
 Request URI: <%= request.getRequestURI() %>

do you agree with this small add?

thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: snprintf/vsnprintf in mod_jk

2007-04-19 Thread Guenter Knauf
Hi,
> Well the latest mod_jk working on i5/OS v5R3 was 1.2.19. 1.2.20,
> 1.2.21 and 1.2.22 didn't works and you could see on the dev list the
> various problems encoutered.
hmm, interesting; 
I did just apply my recent sp_snprintf() hack to 1.1.19 and 1.2.20 so that I 
could now compile it for Apache 1.3.x, and while 1.1.19 loads/unloads fine, 
with 1.2.20 I see the memory leak of 8280 bytes introduced; that was just a 
quick test to make sure I didnt introduce it with linking the compiler runtime.
So there was definitely a memory leak introduced between 1.2.19 and 1.2.20, and 
its still present in trunk...

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: snprintf/vsnprintf in mod_jk

2007-04-19 Thread Guenter Knauf
Hi,
> yes, very interesting, it could explain why there is core under i5/OS,
> this platform is very sensible when memory leak or buffer overflow
> happens...
I can add that I currently assume the leak in Apache-1.3/mod_jk.c since I dont 
see the leak when I build the Apache2 module

NetWare is also that sensible normally, just in this case it seems that only a 
buffer is not free'd; its sufficient that I just load / unload to see this 
leak; and such things are only reported with NetWare when I enable developer 
option...; otherwise such is silently ignored.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: snprintf/vsnprintf in mod_jk

2007-04-19 Thread Guenter Knauf
Hi Rainer,
> What's the cycle of the leak:

> - per request
> - per restart
> - ??
per start/stop (restart isnt possible with AP 1.3 on NetWare) - request or no 
request doesnt matter;
leak is reported after unload...; unfortunately AP 1.3 is build upon old clib, 
and there I dont have the cool debug features as with new system; but will see 
if I can further track down when I have some more time for that...

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: More on i5/OS and some modifications needed

2007-04-23 Thread Guenter Knauf
Hi,
> My question will be, could we make APR mandatory, even for Apache 1.3 or
> IIS ?
-1 from my side; APR cant be used on NetWare with Apache 1.3 / Netscape due to 
other lib version APR depends on. This would again break my just fixed things 
with AP13 mod_jk and the Netscape connectors...
isnt it possible that we just do some more defines as Jean-Frederic already 
suggested, f.e. something similar to apr_compat.h, apu_compat.h? Probably into 
a separate header?

Guenter.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: More on i5/OS and some modifications needed

2007-04-23 Thread Guenter Knauf
Hi Henri,
> I can adapt some by defines (allready commited) but others require
> more code (to be commited) and of course code less readable...
you may be able to reduce some ifdefs in jk_utils.c with f.e.:
#ifdef AS400
#define S_IFREG _S_IFREG
#endif


> BTW, I will replace call to stat() by calls to jk_file_exists
I believe that doesnt work; if you remove the stat() call then further down the 
lines:

if (modified)
*modified = statbuf.st_mtime;

cant work since statbuf isnt then populated.

Guenter.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: More on i5/OS and some modifications needed

2007-04-23 Thread Guenter Knauf
Hi Henri,
suggestion (otherwise we would also have 2 unused vars rc and ptr on all 
non-AS400 platforms):

int jk_file_exists(const char *f)
{
if (f) {
struct stat st;
int rc;
#ifdef AS400
#define S_IFREG _S_IFREG
char *ptr;
/**
 * i5/OS V5R4 expect filename in ASCII for fopen but required them in EBCDIC 
for stat()
 */
#ifdef AS400_UTF8
ptr = (char *)malloc(strlen(f) + 1);
jk_ascii2ebcdic((char *)f, ptr);
rc = stat(ptr, &st);
free(ptr);
#else /* AS400_UTF8 */
rc = stat(f, &st);
#endif /* AS400_UTF8 */
#else /* AS400 */
rc = stat(f, &st);
#endif /* AS400 */
if ((0 == rc) && (st.st_mode & S_IFREG))
return JK_TRUE;
}

return JK_FALSE;
}


Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r532307 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-25 Thread Guenter Knauf
Hi,
> Well jk_stat was defined as stat in jk_util.h

> #define jk_stat(a, b) stat(a, b)

> but at the bad location ;(

sorry, just realized that and was going to revert the change and change *.h 
instead...

do you fix, or should I?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: More on i5/OS and some modifications needed

2007-04-25 Thread Guenter Knauf
Hi Henry,

in jk_util.h we have:
#define jk_stat(a, b) stat(a, b)

in jk_map.c we have now:

if (jk_stat(f, &statbuf) != -1)
return JK_FALSE;

previously in 1.2.22 code we had:

if ((rc = stat(f, &statbuf)) == -1)
return JK_FALSE;

am I missing something, or is the logic now inverted?

Guen.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: More on i5/OS and some modifications needed

2007-04-25 Thread Guenter Knauf
Hi Henri,

we still need to take care of the change in jk_map_read_properties():

-if (jk_file_exists(f) != JK_TRUE)
+if ((rc = jk_stat(f, &statbuf)) == -1)


otherwise we cant return time_t *modified since the statbuf isnt initialized.

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r534021 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

2007-05-01 Thread Guenter Knauf
Hi Henri,
I've commited the change below because I think this is an oversight with all 
your recent changes;
the stat struct was not initialized with your change to jk_file_exists(f), and 
thus later on
*modified = statbuf.st_mtime
was set from the uninitialized struct, and could never return someting useful 
in 'time_t modified'.

greets, Guenter.

> Author: fuankg
> Date: Tue May  1 04:53:37 2007
> New Revision: 534021

> URL: http://svn.apache.org/viewvc?view=rev&rev=534021
> Log:
> changed to use jk_stat() to initialite the stat struct so that *modified =
> statbuf.st_mtime can work.

> Modified:
> tomcat/connectors/trunk/jk/native/common/jk_map.c

> Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common
> /jk_map.c?view=diff&rev=534021&r1=534020&r2=534021
> ==
> 
> --- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
> +++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue May  1 04:53:37
> 2007
> @@ -485,7 +485,7 @@
>  if (m && f) {
>  struct stat statbuf;
>  FILE *fp;
> -if (jk_file_exists(f) != JK_TRUE)
> +if (jk_stat(f, &statbuf) == -1)
>  return JK_FALSE;
>  #if defined(AS400) && !defined(AS400_UTF8)
>  fp = fopen(f, "r, o_ccsid=0");



> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Modified dist.xml to produce platform native packages

2009-06-18 Thread Guenter Knauf
Hi,
Mark Thomas schrieb:
> +1. If we get feedback from users that suggests changes we can re-evaluate.
I got in the past every now and then feedbacks from users who wanted to
upgrade TC from a previous version: they were really confused by the
single packages, and always asking 'what do I really need to download
now?' ...
Personally I would prefer something like the MSYS or Cygwin installer:
one executable (I think this could / should even be written in Java)
which then downloads the required packages from the mirrors depending on
the platform it runs on, and depending on choices the user selects.
This way you split into as many packages as you think makes sense while
finally hiding this from the user who always only needs to download the
installer - and perhaps its even more simple if we would have a
installer applet which launches via Java Webstart...

Günter.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: KEYS files

2009-11-23 Thread Guenter Knauf
Hi,
jean-frederic clere schrieb:
> On 11/23/2009 03:23 PM, jean-frederic clere wrote:
>> It seems there is a bunch of KEYS file in the
>> https://svn.apache.org/repos/asf/tomcat and in the web site.
>>
>> Should we only have one of those?
> 
> The most problematic is ./tomcat-connectors/KEYS (Which does correspond
> to a repos.
I guess that my key is only in this one since only needed for the mod_jk
binary releases I do for NetWare ...

Gün.




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Native 1.1.12 release

2008-01-14 Thread Guenter Knauf
Hi Mladen,
> But that is exactly what we should *not* do.
> Tomcat comes with it's native, so if you upgrade the
> Tomcat, upgrade its native as well (if changed)

> Like said, all that can be easy done by simply
> extending requirements for building Tomcat release.
> One will need Python and a set of GNU build tools,
> and we can easily forget the native helper tarballs.

> It would mean that you will need *nix for building
> the Tomcat release, but that's fine with me.

> If the Tomcat RM's are fine with that, it's a very
> simple task.

just an idea / suggestion:
isnt it usable for the release process that you create a place in SVN where you 
commit the tarballs, and then download them via http from there instead from a 
directory location?

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Native 1.1.12 release

2008-01-14 Thread Guenter Knauf
Hi,
> Still need to figure out what to do with all the other versions in
> a.o/dist though - we can't just leave them.

well, someone needs to commit them all to a project's SVN subdir like 
'tagged_tarballs' or such;
this way the history would stay available...

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-27 Thread Guenter Knauf
Hi all,
another user pointed out that Tomcat4 versions later than 4.1.34 dont work 
properly on NetWare;
when you try to call any of the jsp examples, f.e. snoop.jsp, then you receive 
an HTTP Status 500:
An error occurred at line: -1 in the jsp file: null
full error report here:
http://www.gknw.net/test/tomcat/Apache%20Tomcat-4_1_37%20-%20Error%20report.htm

so it seems that Tomcat 4.1.36 / 4.1.37 are no longer able to compile jsp.
The same user also reported that there was a change with the Ant version:
TC 4.1.34 uses Ant 1.5, and TC 4.1.36 and later uses Ant 1.7.
Indeed the issue can be fixed with only copying ant.jar from TC 4.1.34 over to 
TC 4.1.36 or 4.1.37;
after that all works fine as usual.

I googled for that error, and got tons back, however as usual nothing but same 
question and no solution; only that other recommended to upgrade JDK to 1.5 - 
and indeed some then reported back that it works.

But when I look at the Ant page:
http://ant.apache.org/manual/install.html#sysrequirements
I can read there that Ant 1.7 requires JDK 1.3 only which is same as what the 
TC 4.1.x docs say;
and the version I currently run on NetWare is:
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_13)
Java HotSpot(TM) Client VM (build 1.4.2, mixed mode)

We have also TC 5.0.x and even TC 5.5.x running on NetWare, so I wonder what 
here breaks with TC 4.1.37?

I hope someone can give me some hints what's missing;
my guess is that Ant 1.7 requires now some additional pieces with the 
classpath, whatever

Thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-28 Thread Guenter Knauf
Hi Mark,
> Not sure. It works for me with 1.4.2 on windows so it looks to be a
> platform specific issue.

> Is there anything else in any of the logs? There should be something on
> stderr if nothing else.
here's all what I could get:
http://www.gknw.net/test/tomcat/

thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-28 Thread Guenter Knauf
Hi Mark,
> What I can't figure out is where the initial \ is coming from. Can you run
> the following code on your system and post the output?
now that you pointed this out I remember that I came over same issue already 
with some other apps;
and it turned out that they do check for absolute paths, but dont take into 
account that on NetWare the volume name can be up to 16 chars I think - but 
there's often only a check for Windows drive letters = one char followed by a 
colon; but as you see the standard volume is SYS: which are already 3 chars 
followed by colon; so maybe someone changed somewhere the logic to detect 
absolute paths but forgot a check for NetWare? Or what I also came over was 
that a check for a protocol prefix (like http: or file:) detected sys: as 
unknown protocol...
The downside is here that file: or http: would also be valid volume names on 
NetWare, and so there's no real way to differ between a protocol specifier and 
a volume name, argh! Fortunately the standard volume is always named sys: and 
that's where most Java stuff gets installed

> package org.apache.markt;

> import java.io.File;
> import java.io.IOException;
> import java.net.URL;

> public class NetWareTest {

>  public static void main(String[] args) throws IOException {
>  File testDir1 = new File(".");
>  System.out.println(testDir1.getCanonicalPath());

>  File testDir2 = new File(testDir1.getCanonicalPath());
>  System.out.println(testDir2.getCanonicalPath());

>  URL outURL = testDir2.toURL();
>  String outURI = outURL.toString();
>  System.out.println(outURI);

>  outURL = new URL(outURI);
>  File outDirF = new File(outURL.getFile());
>  System.out.println(outDirF.getCanonicalPath());
>  }
> }

I see nothing unusual with that - NetWare behaves here exactly same as Windows;
OS: NetWare
VM: 1.4.2
SYS:\nwtest
SYS:\nwtest
file:/SYS:/nwtest/
SYS:\nwtest
java: Class org.apache.markt.NetWareTest exited successfully

OS: Windows XP
VM: 1.4.2_12-b03
D:\projects\java\nwtest
D:\projects\java\nwtest
file:/D:/projects/java/nwtest/
D:\projects\java\nwtest

thanks for looking into this issue, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-28 Thread Guenter Knauf
Hi Mark,
> I see nothing unusual with that - NetWare behaves here exactly same as
> Windows;
> OS: NetWare
> VM: 1.4.2
> SYS:\nwtest
> SYS:\nwtest
> file:/SYS:/nwtest/
> SYS:\nwtest
> java: Class org.apache.markt.NetWareTest exited successfully
The above test was called with netware-specific -envCWD which is same as a cd 
into the dir:
java -envCWD=sys:/nwtest org.apache.markt.NetWareTest %1

I did a second test with:
java -cp sys:/nwtest org.apache.markt.NetWareTest

OS: NetWare
VM: 1.4.2
SYS:
SYS:
file:/SYS:/
SYS:
java: Class org.apache.markt.NetWareTest exited successfully

java -cp d:\projects\java\nwtest org.apache.markt.NetWareTest
OS: Windows XP
VM: 1.4.2_12-b03
D:\
D:\
file:/D:/
D:\

and now we see a difference to Windows in that the the Windows drive has a 
trailing backslash while the NetWare volume doesnt have one

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-30 Thread Guenter Knauf
Hi Mark,
> Mark Thomas wrote:

> Found it. Test case was slightly wrong. Try the test case below. You
> should see a difference between Windows and NetWare.
yep:
java -cp sys:/nwtest org.apache.markt.NetWareTest %1
OS: NetWare
VM: 1.4.2
.
file:/SYS:/./
/SYS:/./
\SYS:\.
java: Class org.apache.markt.NetWareTest exited successfully

X:\>java -cp x:\nwtest org.apache.markt.NetWareTest
OS: Windows XP
VM: 1.4.2_12-b03
.
file:/X://./
/X://./
X:\.

> This does indeed look like a JVM bug that has been exposed by stricter
> checking in the newer versions of Ant.

> Options for a work-around are:
> - Try a later JVM. If the test case below works - you should be OK.
SP7 JVM is latest.

> - Use an older version of Ant. Ant was upgraded to keep up to date rather
> than for a specific big fix so again, you should be OK.
ok, that's what I did to make it working.
> - Patch Tomcat. You'll need to add a few getCanonicalPath() calls.
Tomcat? Not Ant?

> We could patch Tomcat but generally I am against patching to work around
> someone else's bug unless we absolutely have to.
agreed, and will try to see what I get back from Novell.

> As an aside, the Tomcat 4 install with NetWare 6.5 SP7 is a complete mess.
> There are multiple versions of the same libraries present and if you try
> enabling the http connector it fails with a NoSuchMethod exception. A
> little digging showed that the connector jars are from multiple versions
> of Tomcat 4 and are not compatible with each other.
whoups?!

> If you do want to use Tomcat on NetWare then you will probably need to
> install a fresh version from Apache rather than trying to use the NetWare
> one.
Sure, that's what most of us always do - download from Apache and leave the 
Novell stuff as is;
and just launch ower own TC instance; but just that fails now because of the 
issue you just found.

I'll try to find someone responsible at Novell - please if possible dont delete 
yet
your NetWare VM, they might have questions or such which I probably cant 
answer...

thanks very much for looking into this issue!

greets, Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: HttpOnly and Kauai

2008-04-01 Thread Guenter Knauf
Hi,
> we can't do this one
> https://issues.apache.org/bugzilla/attachment.cgi?id=21741

> that's a servlet spec class

well, that wasnt clever now!
You should first have commited, then made a trip to Kauai with your laptop, and 
then from there at the Tomcat coding party via wireless *just found* that this 
is invalid, told him personally, and then revoke the commit again.!

cheers, Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Question about Tomcat memory leaks

2008-04-11 Thread Guenter Knauf
Hi all,
I've a prob with a Tomcat application.
This is an app which was bought by a customer which I work for.
The app runs on a plain WinXP box with nothing else installed on it but only 
the Tomcat servive + MySQL server. The app is used through the standalone http 
connector; Tomcat version is 5.5.25.
Now since few days the box tends to crash with all memory exhausted...
I cant tell at the moment if any component of the involved software packages 
was updated recently.
Now my question is: can someone give me some hints how I can observe the memory 
consumption of Tomcat to see if there might be a leak either in Tomcat self 
(saw some BZ, and ChangeLog entries that something was fixed with 5.5.26), or 
also with their app?

thanks in advance for any suggestions!

greets, Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Question about Tomcat memory leaks

2008-04-13 Thread Guenter Knauf
Hi all,
> But since you describe "server" memory exhaustion, you should use Windows
> perfmon tool to log process memory (see  HOW TO: Create and Configure
> Performance Monitor Trace Logs, http://support.microsoft.com/?kbid=302552
hmm, this link give's me a 'currently not available'.
> ) and determine which process is leaking.  If this is tomcat, then start
> by reducing -Xmx option to a level that the server can handle (and not
> crash).
> And finally, use the very good suggestions of others to use a java memory
> profiler.
yes, a big thanks to all for your suggestions, that helped a lot already.
Unfortunately at current state I want to do as less as possible on the config + 
app itself;
so for now I've hacked a WSH script which does fetch some perfmon memory values 
and mails the results to me so that I monitor the rate on which the memory goes 
low, and act before the WinXP box freezes up.

If I can nail down what leaks within the next days, then next step will be a 
test installation on another box where I can check details with YourKit; I 
found that currently a 7.1 EAP version is available without need for a licence, 
and I hope this might be good enough to show up where the main probs are - it 
is enough for me to proof that it is their app (which I assume); however few 
other things might be possible as well: mysqld or the mysql jdbc driver (which 
I doubt).
I think its most likely that they dont free all mysql result resources

thanks all again, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



found very old feature request ...

2009-06-08 Thread Guenter Knauf
All,
while I was just looking at BZ I found a very old feature request for
NetWare:
https://issues.apache.org/bugzilla/show_bug.cgi?id=8441
what do you think? These 3 files are those we use for start/stop of TC
...; maybe we can add these files to TC 4/5, or are there any objections?

then another question: the path issue in Novell's JVM was not fixed as
we expected (Mark hacked a sample to recreate and confirm the prob some
longer time ago), and I think it would probably make sense to add a hint
in the RUNNING file of TC 4/5 in troubleshooting section that NetWare
users need to downdate Ant to version 1.5, probably something like:

Since Tomcat 4.1.36 / 5.0.3x / 5.5.x? Tomcat ships with Ant 1.7 which
turned out to have path issues on NetWare platform due to a bug in the
NetWare JVM. The bug was reported to Novell, but not fixed up to now.
NetWare users therefore need to downdate to Ant 1.5 which is known to
work properly on NetWare; it seems sufficient to copy the
./common/lib/ant.jar file from an older Tomcat over to the new Tomcat
version.

greets, Gün.




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org