Re: svn commit: r1293119 - in /tomcat/native/branches/1.1.x: native/configure.in native/include/ssl_private.h native/src/sslutils.c xdocs/miscellaneous/changelog.xml
Am Freitag, den 24.02.2012, 07:43 + schrieb mt...@apache.org: > Author: mturk > Date: Fri Feb 24 07:43:44 2012 > New Revision: 1293119 > > URL: http://svn.apache.org/viewvc?rev=1293119&view=rev > Log: > BZ45392 Apply modified patch. OCSP is enabled is explicitly configure with > --enable-ocsp at build time > > Modified: > tomcat/native/branches/1.1.x/native/configure.in > tomcat/native/branches/1.1.x/native/include/ssl_private.h > tomcat/native/branches/1.1.x/native/src/sslutils.c > tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml > > Modified: tomcat/native/branches/1.1.x/native/configure.in > URL: > http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/configure.in?rev=1293119&r1=1293118&r2=1293119&view=diff > == > --- tomcat/native/branches/1.1.x/native/configure.in (original) > +++ tomcat/native/branches/1.1.x/native/configure.in Fri Feb 24 07:43:44 2012 > @@ -151,6 +151,17 @@ AC_ARG_ENABLE(openssl, >esac > ]) > > +AC_ARG_ENABLE(ocsp, > +[AS_HELP_STRING([--enable-openssl],[Turn on OpenSSL OCSP verification > support])], I think the help string should read --enable-ocsp. Regards Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1099032 - in /tomcat/trunk/res/scripts: ./ check-mime.pl
Hi Rainer,
Am Dienstag, den 03.05.2011, 12:12 + schrieb rj...@apache.org:
> Author: rjung
> Date: Tue May 3 12:12:35 2011
> New Revision: 1099032
>
> URL: http://svn.apache.org/viewvc?rev=1099032&view=rev
> Log:
> Add a script to check web.xml and httpd mime.types
> for differences.
>
> Added:
> tomcat/trunk/res/scripts/
> tomcat/trunk/res/scripts/check-mime.pl (with props)
>
> Added: tomcat/trunk/res/scripts/check-mime.pl
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/res/scripts/check-mime.pl?rev=1099032&view=auto
> ==
> --- tomcat/trunk/res/scripts/check-mime.pl (added)
> +++ tomcat/trunk/res/scripts/check-mime.pl Tue May 3 12:12:35 2011
> @@ -0,0 +1,410 @@
> +#!/usr/bin/perl
> +
...
> +# Script version, printed via getopts with "--version"
> +$main::VERSION = '1.0';
Any reason for not using 'our' like
our $VERSION = '1.0'; ?
> +
...
> +
> +# Parse arguments:
> +# -m: mime.types file (httpd) to use
> +# -i: input web.xml file to check
> +# -o: output web.xml file (gets generated and overwritten)
> +
> +$Getopt::Std::STANDARD_HELP_VERSION = 1;
> +our($opt_m, $opt_i, $opt_o);
Why should those options be visible by everyone outside this package?
'my' should be enough:
my ($opt_m, $opt_i, $opt_o);
> +getopts('m:i:o:');
> +
> +
> +# Check whether mandatory arguments are given
> +if ($opt_m eq '' || $opt_i eq '' || $opt_o eq '') {
> +HELP_MESSAGE(*STDOUT);
> +exit 1;
> +}
> +
> +
> +# Switch locale for alphabetical ordering
> +setlocale(LC_COLLATE, $LOCALE);
> +
> +# Read and parse httpd mime.types, build up hash extension->mime-type
> +open(MIMETYPES, "<$opt_m") or die "Could not open file '$opt_m' for read -
> Aborting!";
You could use three param open and use lexical filehandles like
open my $mimetpyes_fh, '<', $opt_m or die "...";
> +while () {
> +chomp($_);
> +$line = $_;
while (my $line = <$mimetypes_fh>) {
chomp($line);
> +$line =~ s/#.*//;
> +$line =~ s/^\s+//;
> +if ($line ne '') {
> +@cols = split(/\s+/, $line);
> +if ($#cols > 0) {
> +for ($i=1; $i <= $#cols; $i++) {
> +$httpd{$cols[$i]} = $cols[0];
> +}
> +} else {
> +print STDERR "WARN mime.types line ignored: $_\n";
> +}
> +}
> +}
> +close(MIMETYPES);
>
($mimetype, @endings) = split(/\s+/, $line);
if (@endings > 0) {
for my $ending (@endings) {
$httpd{$ending} = $mimetype;
}
} else {
print STDERR "WARN mime.types line ignored: $_\n";
}
close $mimetypes_fh;
would be possible also.
> +
> +# Read and parse web.xml, build up hash extension->mime-type
> +# and store the file parts form before and after mime mappings.
> +open(WEBXML, "<$opt_i") or die "Could not open file '$opt_i' for read -
> Aborting!";
three-params open could be used again.
> +
> +# Skip and record all lines before the first mime type definition.
> +# Because of comment handling we need to read one line ahead.
> +$line = '';
> +while () {
> +if ($_ !~ //) {
> +$tomcat_pre .= $line;
> +} else {
> +last;
> +}
> +$line = $_;
> +}
> +
> +$commented = 0;
> +# If the previous line was start of a comment
> +# set marker, else add it to pre.
> +if ($line =~ /^\s*\s*$/) {
> +$comment = $1;
> +$_ = ;
> +chomp($_);
> +}
> +if ($_ =~ /^\s*([^<]*)<\/extension>\s*$/ ) {
> +$extension = $1;
> +$extension =~ s/^\s+//;
> +$extension =~ s/\s+$//;
> +} else {
> +print STDERR "ERROR Parse error in Tomcat mime-mapping line $.\n";
> +print STDERR "ERROR Expected ...', got '$_' -
> Aborting!\n";
> +close(WEBXML);
> +exit 2;
> +}
> +$_ = ;
> +chomp($_);
> +if ($_ =~ /^\s*([^<]*)<\/mime-type>\s*$/ ) {
> +$type = $1;
> +$type =~ s/^\s+//;
> +$type =~ s/\s+$//;
> +if (exists($tomcat{$extension}) && $tomcat{$extension} ne $type) {
> +print STDERR "WARN MIME mapping redefinition detected!\n";
> +print STDERR "WARN Kept '$extension' -> '$tomcat{$extension}'\n";
> +print STDERR "WARN Ignored '$extension' -> '$type'\n";
> +} else {
> +$tomcat{$extension} = $type;
> +if ($comment ne '') {
> +$tomcat_comments{$extension} = $comment;
> +}
> +if ($commented) {
> +$tomcat_commented{$extension} = 1;
> +}
> +push(@tomcat_extensions, $extension);
> +}
> +} else {
> +print STDERR "ERROR Parse error in Tomcat mime-mapping line $.\n";
> +print STDERR "ERROR Expected ...', got '$_' -
> Aborting!\n";
> +close(WEBXML);
> +exit 3;
> +}
> +$_ = ;
> +chomp($_);
> +if ($_ !~ /^\s*<\/mime-mapping>\s*$/) {
> +print STDERR "ERROR Parse error in Tomcat mime-mapping line $.\n";
> +print STDERR "ERROR Expect
Re: svn commit: r1099032 - in /tomcat/trunk/res/scripts: ./ check-mime.pl
Hi Rainer, Am Sonntag, den 08.05.2011, 14:20 +0200 schrieb Rainer Jung: > Hi Felix, > > TMTOWTDI. For standalone scripts I don't care very much about style. right :) > Let's see below ... > > On 08.05.2011 13:17, Felix Schumacher wrote: > > Hi Rainer, > > > >> + > >> +# Parse arguments: > >> +# -m: mime.types file (httpd) to use > >> +# -i: input web.xml file to check > >> +# -o: output web.xml file (gets generated and overwritten) > >> + > >> +$Getopt::Std::STANDARD_HELP_VERSION = 1; > >> +our($opt_m, $opt_i, $opt_o); > > Why should those options be visible by everyone outside this package? > > 'my' should be enough: > > my ($opt_m, $opt_i, $opt_o); > > Doesn't work. Seems getopts needs "our". I tried it and I thougt it works, but you are right. In my tests it eats $opt_m if used with my, the other parameters are set though :( I usually use getopt with a hash reference... But enough of those bagatelles. Regards Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/man
Am Montag, den 06.06.2011, 17:56 +0100 schrieb Mark Thomas:
> On 06/06/2011 11:59, Keiichi Fujino wrote:
> > When jdbc-pool or DBCP is used as DB connection pool and
> > removeAbandoned is "true",
> > dbConnection is closed because dbConnection is not returned to the
> > connection pool.
> > And then, dbConnection is acquired again because dbConnection has been
> > already closed.
> >
> > Should I return the connection to the connection pool?
> > Or, is the DB connection cached until removeAbandoned works?
>
> The connection should be returned to the pool. If you could take care of
> that, that would be great. Sorry for missing that when I applied the patch.
It was a conscious decision not to return the connection to the pool for
the following reasons:
1. the original code didn't do it
2. we would have to close the prepared statements in case of pooled
connections
3. the connection is not really abandoned, so one could argue, that you
should run the pool with removeAbandoned set to 'false'
But I would gladly provide a patch where connections are returned to the
pool.
Felix
>
> Mark
>
> >
> >
> > 2011/6/4 :
> >> Author: markt
> >> Date: Fri Jun 3 22:13:09 2011
> >> New Revision: 1131263
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1131263&view=rev
> >> Log:
> >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51264
> >> Allow the JDBC persistent session store to use a JNDI datasource to define
> >> the database in which sessions are persisted.
> >> Patch provided by Felix Schumacher.
> >>
> >> Modified:
> >>tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java
> >>tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
> >>tomcat/trunk/webapps/docs/changelog.xml
> >>tomcat/trunk/webapps/docs/config/manager.xml
> >>
> >> Modified: tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java
> >> URL:
> >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java?rev=1131263&r1=1131262&r2=1131263&view=diff
> >> ==
> >> --- tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java (original)
> >> +++ tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java Fri Jun
> >> 3 22:13:09 2011
> >> @@ -33,6 +33,11 @@ import java.sql.SQLException;
> >> import java.util.ArrayList;
> >> import java.util.Properties;
> >>
> >> +import javax.naming.Context;
> >> +import javax.naming.InitialContext;
> >> +import javax.naming.NamingException;
> >> +import javax.sql.DataSource;
> >> +
> >> import org.apache.catalina.Container;
> >> import org.apache.catalina.LifecycleException;
> >> import org.apache.catalina.Loader;
> >> @@ -102,6 +107,16 @@ public class JDBCStore extends StoreBase
> >> */
> >> protected String driverName = null;
> >>
> >> +/**
> >> + * name of the JNDI resource
> >> + */
> >> +protected String dataSourceName = null;
> >> +
> >> +/**
> >> + * DataSource to use
> >> + */
> >> +protected DataSource dataSource = null;
> >> +
> >> // - Table
> >> & cols
> >>
> >> /**
> >> @@ -436,6 +451,27 @@ public class JDBCStore extends StoreBase
> >> return (this.sessionLastAccessedCol);
> >> }
> >>
> >> +/**
> >> + * Set the JNDI name of a DataSource-factory to use for db access
> >> + *
> >> + * @param dataSourceName The JNDI name of the DataSource-factory
> >> + */
> >> +public void setDataSourceName(String dataSourceName) {
> >> +if (dataSourceName == null || "".equals(dataSourceName.trim())) {
> >> +manager.getContainer().getLogger().warn(
> >> +sm.getString(getStoreName() +
> >> ".missingDataSourceName"));
> >> +return;
> >> +}
> >> +this.dataSourceName = dataSourceName;
> >> +}
> >> +
> >> +/**
> >> + * Return the name of the JNDI DataSource-factory
> >> + */
> >> +public String getDataSourceName() {
> >> +
Re: svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/man
Am Dienstag, den 07.06.2011, 10:34 +0100 schrieb Mark Thomas: > On 06/06/2011 21:40, Felix Schumacher wrote: > > Am Montag, den 06.06.2011, 17:56 +0100 schrieb Mark Thomas: > >> On 06/06/2011 11:59, Keiichi Fujino wrote: > >>> When jdbc-pool or DBCP is used as DB connection pool and > >>> removeAbandoned is "true", > >>> dbConnection is closed because dbConnection is not returned to the > >>> connection pool. > >>> And then, dbConnection is acquired again because dbConnection has been > >>> already closed. > >>> > >>> Should I return the connection to the connection pool? > >>> Or, is the DB connection cached until removeAbandoned works? > >> > >> The connection should be returned to the pool. If you could take care of > >> that, that would be great. Sorry for missing that when I applied the patch. > > It was a conscious decision not to return the connection to the pool for > > the following reasons: > > 1. the original code didn't do it > > The expected usage of pooled connections is that they are obtained from > the pool, used and then immediately returned. Removing a connection from > the pool and just keeping it defeats the point of having a pool. There would be one other usage of jndi-resources, that would be to hide password and db-user from the context. > > > 2. we would have to close the prepared statements in case of pooled > > connections > > Yes, although DBCP can pool those too (if appropriately configured). You > may wish to add something on that topic to the docs, if only a link the > the relevant DBCP config docs. done. > > > 3. the connection is not really abandoned, so one could argue, that you > > should run the pool with removeAbandoned set to 'false' > > Yep, but as per 1, it isn't really following the expected conventions > when using a connection pool. > > > But I would gladly provide a patch where connections are returned to the > > pool. > > That would be great. Thanks. I have attached it, but I could also upload it to the original bugzilla entry. I also corrected one of my previous error messages, which contained a single-tick, which was not so good. Felix > > Mark > > > > > Felix > >> > >> Mark > >> > >>> > >>> > >>> 2011/6/4 : > >>>> Author: markt > >>>> Date: Fri Jun 3 22:13:09 2011 > >>>> New Revision: 1131263 > >>>> > >>>> URL: http://svn.apache.org/viewvc?rev=1131263&view=rev > >>>> Log: > >>>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51264 > >>>> Allow the JDBC persistent session store to use a JNDI datasource to > >>>> define the database in which sessions are persisted. > >>>> Patch provided by Felix Schumacher. > >>>> > >>>> Modified: > >>>>tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java > >>>>tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties > >>>>tomcat/trunk/webapps/docs/changelog.xml > >>>>tomcat/trunk/webapps/docs/config/manager.xml > >>>> > >>>> Modified: tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java > >>>> URL: > >>>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java?rev=1131263&r1=1131262&r2=1131263&view=diff > >>>> == > >>>> --- tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java > >>>> (original) > >>>> +++ tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java Fri Jun > >>>> 3 22:13:09 2011 > >>>> @@ -33,6 +33,11 @@ import java.sql.SQLException; > >>>> import java.util.ArrayList; > >>>> import java.util.Properties; > >>>> > >>>> +import javax.naming.Context; > >>>> +import javax.naming.InitialContext; > >>>> +import javax.naming.NamingException; > >>>> +import javax.sql.DataSource; > >>>> + > >>>> import org.apache.catalina.Container; > >>>> import org.apache.catalina.LifecycleException; > >>>> import org.apache.catalina.Loader; > >>>> @@ -102,6 +107,16 @@ public class JDBCStore extends StoreBase > >>>> */ > >>>>
Re: svn commit: r1145383 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml
Hi Mark,
ma...@apache.org schrieb:
>Author: markt
>Date: Mon Jul 11 22:27:06 2011
>New Revision: 1145383
>
>URL: http://svn.apache.org/viewvc?rev=1145383&view=rev
>Log:
>Protect against infinite loops in the HTTP NIO connector if sendfile is
>configured to send more data than is available in the file. (markt)
>
>Modified:
>tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>tomcat/trunk/webapps/docs/changelog.xml
>
>Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1145383&r1=1145382&r2=1145383&view=diff
>==
>--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>(original)
>+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Mon
>Jul 11 22:27:06 2011
>@@ -1240,6 +1240,13 @@ public class NioEndpoint extends Abstrac
> sd.pos += written;
> sd.length -= written;
> attachment.access();
>+} else {
>+// Unusual not to be unable to transfer any
>bytes
There really are too many negations for me to understand the meaning of the
above, but I think you mean "able".
Regards
Felix
>+// Check the length was set correctly
>+if (sd.fchannel.size() <= sd.pos) {
>+throw new IOException("Sendfile configured
>to " +
>+"send more data than was
>available");
>+}
> }
> }
> if ( sd.length <= 0 && sc.getOutboundRemaining()<=0) {
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1149104 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/config/valve.xml
Hi Konstantin, while correcting typos. I think UvNIX is a typo also. It is present in AccessLogValve and ExtendedLogValve only. Regards Felix Am Donnerstag, den 21.07.2011, 10:52 + schrieb kkoli...@apache.org: > Author: kkolinko > Date: Thu Jul 21 10:52:46 2011 > New Revision: 1149104 > > URL: http://svn.apache.org/viewvc?rev=1149104&view=rev > Log: ... * > + * > + * For UvNIX users, another field called checkExists is also > + * available. If set to true, the log file's existence will be checked before > + ... > * > - * For UvNIX users, another field called checkExistsis also > + * For UvNIX users, another field called checkExists is also > * available. If set to true, the log file's existence will be checked before - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1165338 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java
ma...@apache.org schrieb: >Author: markt >Date: Mon Sep 5 15:31:46 2011 >New Revision: 1165338 > >URL: http://svn.apache.org/viewvc?rev=1165338&view=rev >Log: >Align request processing between the connectors > >Modified: >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java >tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java >tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java > >Modified: >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >URL: >http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1165338&r1=1165337&r2=1165338&view=diff >== >--- >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >(original) >+++ >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java >Mon Sep 5 15:31:46 2011 >@@ -1291,6 +1291,12 @@ public abstract class AbstractHttp11Proc > protected abstract void resetTimeouts(); > > >+/** >+ * Provides a mechanism for those connectors (currently only NIO) >that need >+ * that need to set comment timeouts. Did you mean Comet timeouts? >+ */ >+protected abstract void setCometTimeouts(SocketWrapper >socketWrapper); Regards Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r958214 - in /tomcat/trunk/webapps/examples/WEB-INF/classes: CookieExample.java RequestHeaderExample.java RequestInfoExample.java RequestParamExample.java SessionExample.java chat/Chat
Hi Mark,
Am Samstag, den 26.06.2010, 12:17 + schrieb ma...@apache.org:
> Author: markt
> Date: Sat Jun 26 12:17:33 2010
> New Revision: 958214
>
> URL: http://svn.apache.org/viewvc?rev=958214&view=rev
> Log:
> Fix some Eclispe / Findbugs warnings
...
> Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/CookieExample.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/CookieExample.java?rev=958214&r1=958213&r2=958214&view=diff
> ==
> --- tomcat/trunk/webapps/examples/WEB-INF/classes/CookieExample.java
> (original)
> +++ tomcat/trunk/webapps/examples/WEB-INF/classes/CookieExample.java Sat Jun
> 26 12:17:33 2010
> @@ -35,7 +35,7 @@ public class CookieExample extends HttpS
>
> private static final long serialVersionUID = 1L;
>
> -ResourceBundle rb = ResourceBundle.getBundle("LocalStrings");
> +private transient ResourceBundle rb =
> ResourceBundle.getBundle("LocalStrings");
shouldn't we init rb in an init method, so that it will be reinitialized
after deserialization, like messageSender in ChatServlet? That way we
would get rid of the warnings and have a correct servlet.
Regards,
Felix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
> On 06/12/2010 20:49, slaur...@apache.org wrote:
> > Author: slaurent
> > Date: Mon Dec 6 20:49:14 2010
> > New Revision: 1042786
> >
> > URL: http://svn.apache.org/viewvc?rev=1042786&view=rev
>
>
> > @@ -63,7 +72,7 @@ public class ThreadLocalLeakPreventionLi
> > try {
> > Lifecycle lifecycle = event.getLifecycle();
> > if (Lifecycle.AFTER_START_EVENT.equals(event.getType())
> > -&& lifecycle instanceof Server) {
> > +&& lifecycle instanceof Server) {
> > // when the server starts, we register ourself as listener
> > for
> > // all context
> > // as well as container event listener so that we know
> > when new
>
> That indenting is now misleading (it was fine before) and the operator
> is still at the beginning of the line.
I just made a quick lookup for usage of (&&) operator at the end of line
versus (&&) operator at the beginning of the next line. It seems that
usage has changed between tomcat 6 and trunk.
In tomcat6.x it is
> egrep -r "&&\s*$" * | wc -l # && at the end of line
217
> egrep -r "^\s*&&" * | wc -l # && at front of line
228
that is slightly in favor of operator after line wrapping.
In tomcat.trunk it is now
> egrep -r "&&\s*$" * | wc -l # && at the end of line
279
> egrep -r "^\s*&&" * | wc -l # && at front of line
264
Which is favors operator before line wrapping.
Java coding conventions and eclipse coding conventions both prefer
operator after line wrapping.
So is operator after line wrapping really a tomcat standard?
>
>
> > -log.error("Exception processing event " + event, e);
> > +String msg =
> > +sm.getString(
> > +
> > "threadLocalLeakPreventionListener.lifecycleEvent.error",
> > +event);
> > +log.error(msg, e);
>
> More auto formatting "helpfulness" by the look of it. No reason for
> String msg = sm.getString(
> not to be on one line.
It would probably break the 80 character limits :)
>
> If we can pull some Eclipse settings together to help folks with this
> that would be great.
That would be great, if we knew what the conventions were.
http://tomcat.apache.org/getinvolved.html only mentions four
conventions.
>
> Mark
Bye
Felix
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Am Dienstag, den 07.12.2010, 13:28 + schrieb Mark Thomas:
> On 07/12/2010 12:29, Felix Schumacher wrote:
> > Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
> >>> -log.error("Exception processing event " + event, e);
> >>> +String msg =
> >>> +sm.getString(
> >>> +
> >>> "threadLocalLeakPreventionListener.lifecycleEvent.error",
> >>> +event);
> >>> +log.error(msg, e);
> >>
> >> More auto formatting "helpfulness" by the look of it. No reason for
> >> String msg = sm.getString(
> >> not to be on one line.
> > It would probably break the 80 character limits :)
>
> I don't get this. I was suggesting the following:
> String msg = sm.getString(
> "threadLocalLeakPreventionListener.lifecycleEvent.error",
> event);
> i.e. get rid of the unnecessary line break.
Oh, didn't think of that one, you are right :)
>
> >> If we can pull some Eclipse settings together to help folks with this
> >> that would be great.
> > That would be great, if we knew what the conventions were.
> > http://tomcat.apache.org/getinvolved.html only mentions four
> > conventions.
>
> I'm not sure on the best way to approach this. The code is not
> consistent. The committers don't have a consistent style for new stuff.
> I'm not sure how much we can agree on.
>
> What I have been doing is slowly adding rules to Checkstyle. So far
> there hasn't been any push back but I'm sure there will be some at some
> point. My idea was to add the rules the community was happy with and
> where we disagree leave things as they are. Modifier order and redundant
> modifiers are the next ones on the list. I'll see if there is an
> operator placement one ... there is so I'll add that as well (commented
> out until the issues are fixed).
Great, I really love to use eclipse auto formatting, but that can only
be used, if we commit ourselves onto one style.
If we have already commited the style by checkstyle rules, we should
prepare an eclipse formatting rule that matches those.
Regards
Felix
>
> Mark
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1042482 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/tomcat/util/threads/ res/confinstall/ webapps/ webapps/docs/ webap
Am Montag, den 06.12.2010, 22:01 +0100 schrieb Sylvain Laurent:
> >
> >> +public void lifecycleEvent(LifecycleEvent event) {
> >> +try {
> >> +Lifecycle lifecycle = event.getLifecycle();
> >> +if (Lifecycle.AFTER_START_EVENT.equals(event.getType())
> >> +&& lifecycle instanceof Server) {
> > With the operator on the new line it is easy to miss what is going on.
> > Generally, Tomcat style is to put the operator on the first line. e.g.
> > if (Lifecycle.AFTER_START_EVENT.equals(event.getType()) &&
> >lifecycle instanceof Server) {
> >
> > There are multiple instances of this throughout the commit.
>
> Still eclipse. But I did not manage to find a setting to change this behavior
> :-(
It is "Line Wrapping->Expressions->Binary expressions" [x] Wrap before
operator.
hth
Felix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1069824 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml
ma...@apache.org schrieb:
>Author: markt
>Date: Fri Feb 11 14:49:41 2011
>New Revision: 1069824
>
>URL: http://svn.apache.org/viewvc?rev=1069824&view=rev
>Log:
>Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
>Don't try to retrieve attributes if we don't need to. If anonymous bind
>is not allowed, the login will always fail.
>
>Modified:
>tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
>tomcat/trunk/webapps/docs/changelog.xml
>
>Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=1069824&r1=1069823&r2=1069824&view=diff
>==
>--- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
>(original)
>+++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Fri Feb
>11 14:49:41 2011
>@@ -1245,6 +1245,11 @@ public class JNDIRealm extends RealmBase
> String dn)
> throws NamingException {
>
>+// If no attributes are requested, no need to look for them
>+if (attrIds == null || attrIds.length > 0) {
Shouldn't this be attrIds.length == 0?
Regards
Felix
>+return new User(username, dn, null, null);
>+}
>+
> // Get required attributes from user entry
> Attributes attrs = null;
> try {
>
>Modified: tomcat/trunk/webapps/docs/changelog.xml
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1069824&r1=1069823&r2=1069824&view=diff
>==
>--- tomcat/trunk/webapps/docs/changelog.xml (original)
>+++ tomcat/trunk/webapps/docs/changelog.xml Fri Feb 11 14:49:41 2011
>@@ -72,6 +72,11 @@
> point the response is committed when a writer is being used. (markt)
>
>
>+50751: When authenticating with the JNDI Realm,
>only attempt
>+to read user attributes from the directory if attributes are
>required.
>+(markt)
>+
>+
> 50752: Fix typo in debug message in deprecated Embedded
> class. (markt)
>
>
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1074192 - in /tomcat/trunk/webapps/docs: changelog.xml config/valve.xml
On Thu, 24 Feb 2011 16:01:39 -, wrote: Author: markt Date: Thu Feb 24 16:01:38 2011 New Revision: 1074192 URL: http://svn.apache.org/viewvc?rev=1074192&view=rev Log: Add documentation for the Crawler Session Manager Valve. Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/valve.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1074192&r1=1074191&r2=1074192&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Thu Feb 24 16:01:38 2011 @@ -130,6 +130,14 @@ ServletContext.getResourcePaths() includes static resources packaged in JAR files in its output. (markt) + +Web crawlers can trigger the creation of many thousands of sessions as +they crawl a site which may result in significant memory consumption. +Thw new Crawler Session Manager Valve ensures that crawlers are The new Crawler ... regards Felix +associated with a single session - just like normal users - regardless +of whether or not they provide a session token with their requests. +(markt) + Modified: tomcat/trunk/webapps/docs/config/valve.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=1074192&r1=1074191&r2=1074192&view=diff == --- tomcat/trunk/webapps/docs/config/valve.xml (original) +++ tomcat/trunk/webapps/docs/config/valve.xml Thu Feb 24 16:01:38 2011 @@ -880,6 +880,62 @@ + + + + +Web crawlers can trigger the creation of many thousands of sessions as +they crawl a site which may result in significant memory consumption. This +Valve ensures that crawlers are associated with a single session - just like +normal users - regardless of whether or not they provide a session token +with their requests. + +This Valve may be used at the Engine, Host or +Context level as required. Normally, this Valve would be used +at the Engine level. + +If used in conjunction with Remote IP valve then the Remote IP valve +should be defined before this valve to ensure that the correct client IP +address is presented to this valve. + + + + + +The Crawler Session Manager Valve supports the +following configuration attributes: + + + + +Java class name of the implementation to use. This MUST be set to + org.apache.catalina.valves.CrawlerSessionManagerValve. + + + + +Regular expression (using java.util.regex) that the user +agent HTTP request header is matched against to determine if a request +is from a web crawler. If not set, the default of +.*GoogleBot.*|.*bingbot.*|.*Yahoo! Slurp.* is used. + + + +The minimum time in seconds that the Crawler Session Manager Valve +should keep the mapping of client IP to session ID in memory without any +activity from the client. The client IP / session cache will be +periodically purged of mappings that have been inactive for longer than +this interval. If not specified the default value of 60 +will be used. + + + + + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r915323 - in /tomcat/jk/trunk/native: common/jk_version.h iis/isapi_redirect.rc
Hi, I think the new version string JK_VERSTRING should be 1.2.30 not 1.2.10. Bye Felix mt...@apache.org schrieb: >Author: mturk >Date: Tue Feb 23 13:02:15 2010 >New Revision: 915323 > >URL: http://svn.apache.org/viewvc?rev=915323&view=rev >Log: >Increment version to 1.2.30-dev > >Modified: >tomcat/jk/trunk/native/common/jk_version.h >tomcat/jk/trunk/native/iis/isapi_redirect.rc > >Modified: tomcat/jk/trunk/native/common/jk_version.h >URL: >http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_version.h?rev=915323&r1=915322&r2=915323&view=diff >== >--- tomcat/jk/trunk/native/common/jk_version.h (original) >+++ tomcat/jk/trunk/native/common/jk_version.h Tue Feb 23 13:02:15 2010 >@@ -26,11 +26,11 @@ > /** START OF AREA TO MODIFY BEFORE RELEASING */ > #define JK_VERMAJOR 1 > #define JK_VERMINOR 2 >-#define JK_VERFIX 29 >-#define JK_VERSTRING"1.2.29" >+#define JK_VERFIX 30 >+#define JK_VERSTRING"1.2.10" > > /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */ >-#define JK_VERISRELEASE 1 >+#define JK_VERISRELEASE 0 > /* Beta number */ > #define JK_VERBETA 0 > #define JK_BETASTRING "0" > >Modified: tomcat/jk/trunk/native/iis/isapi_redirect.rc >URL: >http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/isapi_redirect.rc?rev=915323&r1=915322&r2=915323&view=diff >== >--- tomcat/jk/trunk/native/iis/isapi_redirect.rc (original) >+++ tomcat/jk/trunk/native/iis/isapi_redirect.rc Tue Feb 23 13:02:15 2010 >@@ -18,13 +18,13 @@ >"specific language governing permissions and " \ >"limitations under the License." > >-#define JK_VERSION_STR "1.2.29" >+#define JK_VERSION_STR "1.2.30" > #define JK_DLL_BASENAME "isapi_redirect-" JK_VERSION_STR > > > 1 VERSIONINFO >- FILEVERSION 1,2,29,0 >- PRODUCTVERSION 1,2,29,0 >+ FILEVERSION 1,2,30,0 >+ PRODUCTVERSION 1,2,30,0 > FILEFLAGSMASK 0x3fL > #if defined(_DEBUG) > FILEFLAGS 0x01L > > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r935510 - /tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
Hi,
if sessions is an instance of something, it can't be null. So the check for
null can be eliminated.
Felix
kfuj...@apache.org schrieb:
>Author: kfujino
>Date: Mon Apr 19 10:12:02 2010
>New Revision: 935510
>
>URL: http://svn.apache.org/viewvc?rev=935510&view=rev
>Log:
>Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49151
>
>Modified:
>tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
>
>Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java?rev=935510&r1=935509&r2=935510&view=diff
>==
>--- tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
>(original)
>+++ tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java Mon
>Apr 19 10:12:02 2010
>@@ -248,9 +248,11 @@ public class BackupManager extends Stand
>
> setState(LifecycleState.STOPPING);
>
>-LazyReplicatedMap map = (LazyReplicatedMap)sessions;
>-if ( map!=null ) {
>-map.breakdown();
>+if (sessions instanceof LazyReplicatedMap) {
>+LazyReplicatedMap map = (LazyReplicatedMap)sessions;
>+if ( map!=null ) {
>+map.breakdown();
>+}
> }
>
> cluster.removeManager(this);
>
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1704483 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java
Am 22.09.2015 um 10:47 schrieb r...@apache.org:
Author: remm
Date: Tue Sep 22 08:47:52 2015
New Revision: 1704483
URL: http://svn.apache.org/viewvc?rev=1704483&view=rev
Log:
Fix test compile.
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java?rev=1704483&r1=1704482&r2=1704483&view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java
Tue Sep 22 08:47:52 2015
@@ -37,7 +37,7 @@ public class TestStandardSession {
static {
TEST_MANAGER = new StandardManager();
-TEST_MANAGER.setContext(new StandardContext());
+TEST_MANAGER.setContainer(new StandardContext());
Why set a Context as a Container?
Regards,
Felix
}
@@ -104,7 +104,7 @@ public class TestStandardSession {
StandardSession s1 = new StandardSession(TEST_MANAGER);
s1.setValid(true);
-Map value = new HashMap<>();
+Map value = new HashMap();
value.put("key", new NonSerializable());
s1.setAttribute(nestedNonSerializableKey, value);
s1.setAttribute(serializableKey, serializableValue);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.27
Am 28.09.2015 um 13:26 schrieb Mark Thomas:
The proposed Apache Tomcat 8.0.27 release is now available for voting.
The main changes since 8.0.26 are:
- Correctly handle \${ vs \$ escaping in JSP and EL
- Fix for issues with NIO + SSL + sendfile
- Various TLD parsing fixes
- Fix multiple (mostly rare and/or zero impact) concurrency issues
Note: Due to an issues with the Symantec code signing service (the
certificates used to access the web-based admin GUI have all
expired and infra is having to jump through some hoops to get
new ones issues) the Windows Installer package has NOT been
signed for this release.
There is the usual collection of bug fixes, new features and
performance improvements. For full details, see the changelog:
http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.27/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1051/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_27/
The proposed 8.0.27 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 8.0.27 (non-binding)
Regards,
Felix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.28
Am 7. Oktober 2015 21:13:07 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.28 release is now available for voting. > >The main changes since 8.0.27 are: > >- Allow file based configuration resources (e.g. key stores) to be > configured using URLs > >- Restore code signing to the Windows installer an uninstaller > >There is a smaller that usual collection of bug fixes, new features and >performance improvements. For full details, see the changelog: >http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.28/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1052/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_28/ > >The proposed 8.0.28 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.28 (non-binding) Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.65
Am 09.10.2015 um 13:04 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.65 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1053/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/ The proposed 7.0.65 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 7.0.65 Stable (non-binding) md5, sha1 and pgp keys seem to be valid. Tests are OK on ubuntu 14.04.3 64 bit with openjdk java version "1.7.0_79". Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1708505 - in /tomcat/trunk/java/org/apache/catalina: Realm.java realm/RealmBase.java
Am 13.10.2015 um 22:17 schrieb fschumac...@apache.org: Author: fschumacher Date: Tue Oct 13 20:17:50 2015 New Revision: 1708505 URL: http://svn.apache.org/viewvc?rev=1708505&view=rev Log: javadoc: Add missing parameter and describe the parameters for the newer RFC 2617, which is used for digest authentication and replaces RFC 2069. Modified: tomcat/trunk/java/org/apache/catalina/Realm.java tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java ... Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=1708505&r1=1708504&r2=1708505&view=diff == --- tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Tue Oct 13 20:17:50 2015 @@ -329,19 +329,23 @@ public abstract class RealmBase extends return getPrincipal(username); } - /** - * Return the Principal associated with the specified username, which + * Try to authenticate with the specified username, which * matches the digest calculated using the given parameters using the - * method described in RFC 2069; otherwise return null. + * method described in RFC 2617 (which is a superset of RFC 2069). * * @param username Username of the Principal to look up - * @param clientDigest Digest which has been submitted by the client + * @param digest Digest which has been submitted by the client * @param nonce Unique (or supposedly unique) token which has been used * for this request + * @param nc the nonce counter + * @param cnonce the client chosen nonce + * @param qop the "quality of protection" (nc and cnonce + *will only be used, if qop is not null). * @param realm Realm name * @param md5a2 Second MD5 digest used to calculate the digest : * MD5(Method + ":" + uri) + * @return the associated principal, or null if there is none. */ @Override public Principal authenticate(String username, String clientDigest, The javadoc on the methods in RealmBase that override the Realm methods is just duplication. Should we really keep them? They would have to be corrected to the same extend as the ones in Realm and javadoc is intelligent enough to show the javadoc of the overriden method. Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Moderators wanted
Am 15.10.2015 um 11:56 schrieb Mark Thomas: On 01/12/2014 19:27, Felix Schumacher wrote: Am 1. Dezember 2014 16:56:17 MEZ, schrieb Mark Thomas : Hi, I've been reviewing the moderators for our various lists and if I ignore the no longer active ones we are below the 3 moderators the ASF likes to have on a number of lists. Therefore, can I have some volunteers for the following lists: users@tomcat.a.o- Need two moderators dev@tomct.a.o - Need one moderator announce@tomcat.a.o - Need one moderator private@tomcat.a.o - Need one moderator security@tomcat.a.o - Need one moderator You can volunteer for more than one :) I would be willing to moderate users and/ or dev. Felix, I dropped the ball on this. Are you still willing to moderate these? If so, I'll get you set up. Yes. I will try to do my best. Felix Mark Regards Felix There is typically less than one message a week that requires moderator input (security@ is a little higher) which is usually explaining to folks how to unsubscribe themselves or doing it for them if they are unable to. Note all of our public lists automatically reject mails from unsubscribed users so there is no moderator traffic from that source. Generally, you need to be a committer to moderate a list. To moderate the private and security list you need to be a PMC member. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1708780 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java modules/jdbc-pool/src/test/java/org/apache/tomcat/j
Am 18. Oktober 2015 20:48:48 MESZ, schrieb Konstantin Kolinko
:
>2015-10-15 13:40 GMT+03:00 :
>> Author: fschumacher
>> Date: Thu Oct 15 10:40:25 2015
>> New Revision: 1708780
>>
>> URL: http://svn.apache.org/viewvc?rev=1708780&view=rev
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58489
>>
>> Comparator should follow the rules. If first object has
>lastInvocation of zero,
>> we should compare it to the second objects lastInvocation and vice
>versa.
>> When we do that, we can use Long#compare just as well.
>>
>> Merge r1708779 from /tomcat/tc8.0.x/trunk (Merged r1708687 and
>r1708745 from /tomcat/trunk)
>>
>> Added:
>>
>tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
>> - copied unchanged from r1708779,
>tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
>> Modified:
>> tomcat/tc7.0.x/trunk/ (props changed)
>>
>tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
>
>
>> Modified:
>tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
>> URL:
>http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java?rev=1708780&r1=1708779&r2=1708780&view=diff
>>
>==
>> ---
>tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
>(original)
>> +++
>tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
>Thu Oct 15 10:40:25 2015
>> @@ -447,17 +447,7 @@ public class SlowQueryReport extends Abs
>>
>> @Override
>> public int compare(QueryStats stats1, QueryStats stats2) {
>> -if (stats1.lastInvocation == 0) return 1;
>> -if (stats2.lastInvocation == 0) return -1;
>> -
>> -long result = stats1.lastInvocation -
>stats2.lastInvocation;
>> -if (result > 0) {
>> -return 1;
>> -} else if (result == 0) {
>> -return 0;
>> -} else {
>> -return -1;
>> -}
>> +return Long.compare(stats1.lastInvocation,
>stats2.lastInvocation);
>> }
>> }
>
>
>Tomcat 7 (minus websocket APIs) must be built with Java 6.
>
>The above Long.compare() method is @since 1.7.
>
>https://ci.apache.org/builders/tomcat-7-trunk/builds/99
Thanks for the reminder.
I have committed a fix.
Best Regards,
Felix
>
>
>Best regards,
>Konstantin Kolinko
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1708687 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.
Am 19.10.2015 um 06:26 schrieb Keiichi Fujino:
2015-10-15 5:28 GMT+09:00 :
Author: fschumacher
Date: Wed Oct 14 20:28:55 2015
New Revision: 1708687
URL: http://svn.apache.org/viewvc?rev=1708687&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58489
Comparator should follow the rules. If first object has lastInvocation of
zero,
we should compare it to the second objects lastInvocation and vice versa.
When we do that, we can use Long#compare just as well.
Added:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java?rev=1708687&r1=1708686&r2=1708687&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
Wed Oct 14 20:28:55 2015
@@ -475,17 +475,7 @@ public class SlowQueryReport extends Abs
@Override
public int compare(QueryStats stats1, QueryStats stats2) {
-if (stats1.lastInvocation == 0) return 1;
-if (stats2.lastInvocation == 0) return -1;
-
-long result = stats1.lastInvocation - stats2.lastInvocation;
-if (result > 0) {
-return 1;
-} else if (result == 0) {
-return 0;
-} else {
-return -1;
-}
+return Long.compare(stats1.lastInvocation,
stats2.lastInvocation);
}
}
Hi.
I think this fix does not handle 0 value of lastInvocation correctly.
The older code handles 0 value of lastInvocation as the latest QueryStats.
This new code handles 0 value of lastInvocation as the oldest QueryStats.
I think the fix of this bug is described in comment1.
Or set current time to the lastInvocation in the constructor of QueryStats.
You are right, that 0 is a special value. I have added code to handle it.
Thanks,
Felix
Added:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java?rev=1708687&view=auto
==
---
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
(added)
+++
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryComparator.java
Wed Oct 14 20:28:55 2015
@@ -0,0 +1,121 @@
+package org.apache.tomcat.jdbc.test;
+
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
+import org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport.QueryStats;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestSlowQueryComparator {
+
+@Test
+public void testBug58489() throws ClassNotFoundException,
+InstantiationException, IllegalAccessException,
+InvocationTargetException {
+
+long[] testData = { 0, 0, 0, 1444225382010l, 0, 1444225382011l, 0,
+1444225382012l, 0, 1444225382056l, 0, 1444225382014l, 0,
+1444225382015l, 0, 1444225382016l, 0, 0, 1444225382017l,
0,
+1444225678350l, 0, 1444225680397l, 0, 1444225382018l,
+1444225382019l, 1444225382020l, 0, 1444225382021l, 0,
+1444225382022l, 1444225382023l
+
+};
+
+List stats = new ArrayList<>();
+
+for (int i = 0; i < testData.length; i++) {
+QueryStats qs = new QueryStats(String.valueOf(i));
+qs.add(0, testData[i]);
+stats.add(qs);
+}
+
+try {
+Collections.sort(stats, createComparator());
+} catch (IllegalArgumentException e) {
+Assert.fail(e.getMessage());
+}
+}
+
+@Test
+public void testEqualQueryStatsWithNoLastInvocation()
+throws ClassNotFoundException, InstantiationException,
+IllegalAccessException, IllegalArgumentException,
+InvocationTargetException {
+Comparator queryStatsComparator = createComparator();
+QueryStats q1 = new QueryStats("abc");
+Assert.assertEquals(0, queryStatsComparator.compare(q1, q1));
+}
+
+@Test
+public void testEqualQueryStatsWithLastInvocation()
+
Re: [ANN] New committer: Ognjen Blagojevic
Am 24.10.2015 um 15:58 schrieb Mark Thomas: On behalf of the Tomcat committers I am pleased to announce that Ognjen Blagojevic (ognjen) has been voted in as a new Tomcat committer. Please join me in welcoming him. Congrats! Felix Regards, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] New committer: Martin Grigorov
Am 26. Oktober 2015 15:35:52 MEZ, schrieb Mark Thomas : >On behalf of the Tomcat committers I am pleased to announce that >Martin Grigorov (mgrigorov) has been voted in as a new Tomcat >committer. > >Please join me in welcoming him. Congrats! Felix > >Regards, > >Mark > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Switch 6.0.x from RTC to CTR
Am 28. Oktober 2015 23:42:08 MEZ, schrieb Mark Thomas : >All, > >Many years ago, we switched all release branches to RTC primarily to >address a community problem where we could not agree on the best way >forward for some parts of the code. > >RTC served us well. The disagreements ceased pretty much instantly. >However, RTC also slowed us down. > >The development of 7.0.x started as CTR with a possibility of switching >to RTC if necessary. It never was. We chose not to switch 7.0.x to RTC >because the community issues that made RTC necessary had been solved >and >RTC added unnecessary overhead and delay. 8.0.x and now 9.0.x >progressed >the same way. Today, only 6.0.x is RTC. > >I believe the use of RTC for 6.0.x is causing more harm than good. >There >are fixes I don't propose for backport to 6.0.x because of the extra >hassle RTC introduces. I suspect others take a similar approach judging >on the number of fixes that don't make it back to 6.0.x. > >I would therefore like to propose that we switch the 6.0.x release >branch from RTC to CTR and am therefore calling a VOTE to make this >change. > >[ ] Continue to use RTC for 6.0.x >[x] Switch 6.0.x to CTR Felix > >Thanks, > >Mark > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat Native 1.2.0
Am 28.10.2015 um 03:33 schrieb Mark Thomas: The following votes were cast: Binding: +1: markt, remm, violetagg, jfclere This vote therefore passes. The included README.txt states, that java 1.7 is needed, but build.xml wants to have java 1.8. Should I correct this? Felix Thanks all. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r10986 - in /dev/tomcat/tomcat-connectors/native/1.2.1: ./ source/
Am 02.11.2015 um 16:20 schrieb Mark Thomas: On 02/11/2015 15:10, ma...@apache.org wrote: Author: markt Date: Mon Nov 2 15:10:18 2015 New Revision: 10986 Log: Upload Tomcat Native 1.2.1 source files The Windows binaries should follow shortly. I've tested building on OSX from the tar.gz archive and that works so I believe that the problems with 1.2.0 are resolved. I tried to build it on ubuntu 14.04 LTS, but since that only includes openssl 1.0.1, it will not build (out of the box). Felix Mark Added: dev/tomcat/tomcat-connectors/native/1.2.1/ dev/tomcat/tomcat-connectors/native/1.2.1/source/ dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz (with props) dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.asc dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.md5 dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.sha1 dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip (with props) dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.asc dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.md5 dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.sha1 Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz == Binary file - no diff available. Propchange: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz -- svn:mime-type = application/x-gzip Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.asc == --- dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.asc (added) +++ dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.asc Mon Nov 2 15:10:18 2015 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Comment: GPGTools - http://gpgtools.org + +iQIcBAABCAAGBQJWN3rrAAoJEBDAHFovYFnnHnwP/RmW3NPQ8mRwvc3hLrU58+JI +eA5RQySFQphTaA16x5uMOTbg0WRf69lTGx8qpxD5lwvuZl/WYD6keWVm3mhTpnts +SIwf/d54im17O1ZPfJRAlU8sBYX/Xnu72KpgNOPPZvckhscrWpx1/c5MNpelSCW3 +Ud+9xyXMX+zo163uJnfmLplJZqtJYLmyl2qhtjRxm9bzePo9r8EuWKnCDUgMl3Yi +EnV5q5Ut3wMxdh/fykvmgcMnX9ACD+GVQf088dGAD7WtMuaRnk8rvsbFLU9/e1oX +keDEuuAgNhxHsBy/ULgXpOzTFice0Wo15dayFT20j2FPxtsb19LbGLMkUFm3QfPF +aJ+tUnvOmkAnCHzem0iX5EcXe5KFhh9JRBnog5LUEWwsz6/S0ITekIP9mFsdJB+f +og4v55WMZnnRH/tJ6TbDtFkZpMCq5VjpWCgpIzrs2luZDl8bL51nW675ri51peAe +Vu630/UIaxS+w8Jt92bSI4sBd46YCNUOCOeQ28Ua3JnudUqOxp9aaBFQv0eBkapc +U1ubGXtFYgEwOB1syo/GrdA+LX4EkpqqNcSh+ltV7KK+eFwq4jwl7uLmTB4i6Ndt +BmEkm4Qi+QSTQ6ySqEpDXKfdAeQMg32MyvPKX29a9HeS2VRUwydLfvNXEYlGKVmd +IphDjxfz9/3o0XObqT6Y +=F6qM +-END PGP SIGNATURE- Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.md5 == --- dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.md5 (added) +++ dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.md5 Mon Nov 2 15:10:18 2015 @@ -0,0 +1 @@ +2fc6c513e8cbef00bf87abdca697995a *tomcat-native-1.2.1-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.sha1 == --- dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.sha1 (added) +++ dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-src.tar.gz.sha1 Mon Nov 2 15:10:18 2015 @@ -0,0 +1 @@ +a3698c32bcc02b0054c7b6c8362f6793902fe77b *tomcat-native-1.2.1-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.asc == --- dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.asc (added) +++ dev/tomcat/tomcat-connectors/native/1.2.1/source/tomcat-native-1.2.1-win32-src.zip.asc Mon Nov 2 15:10:18 2015 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Comment: GPGTools - http://gpgtools.org + +iQIcBAABCAAGBQJWN3rrAAoJEBDAHFovYFnn
bugs in tomcat 5
Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat 5 has reached EOL, or because I don't have permission to do so? Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: buildbot failure in ASF Buildbot on tomcat-trunk
Am 21.11.2015 um 14:43 schrieb build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/645 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch tomcat/trunk] 1715521 Blamelist: fschumacher BUILD FAILED: failed compile_1 How could my last changes effect TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt? Regards, Felix Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
PersistenManager and StoreBase
Hi all, while looking at the PersistentManager and StoreBase, I found a few more inefficiencies other than bz 34319/47061. If a Node is started, it will load all sessions from the Store, even if those sessions are old enough, to be swapped out to the Store on the next maintenance run. I think it would be nicer, to load only those sessions, that stay in memory. Another thing is the cluster awareness. At the moment a node will read in all sessions from all nodes. I think it would be nicer to read in only those sessions, that are meant for the node (jvmroute). The same (slightly less problematic) is true for expiry of the sessions. Every node will try to invalidate all sessions from all nodes. This is not that much of a problem, when one node is fast enough to invalidate all expired sessions, before the other nodes will try to do the same. I would like to adress the first and probably the second point. Any thoughts on this? Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.29
Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added support for URIs in config file locations - Add a new RestCsrfPreventionFilter that provides basic CSRF protection for REST APIs - Use instance manager for WebSocket server endpoint instances It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.29/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1055/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_29/ The proposed 8.0.29 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.0.29 On my ubuntu 14.04.03 with java 7 (OpenJDK Runtime Environment (IcedTea 2.6.1) (7u85-2.6.1-5ubuntu0.14.04.1)) a few tests are failing, that I haven't noticed before. Those are in TestNonLoginAndBasicAuthenticator. Testcase: testBasicLoginRejectProtectedWithSession took 0,102 sec >---Caused an ERROR Illegal character(s) in message header field: Cookie: java.lang.IllegalArgumentException: Illegal character(s) in message header field: Cookie: >---at sun.net.www.protocol.http.HttpURLConnection.checkMessageHeader(HttpURLConnection.java:465) >---at sun.net.www.protocol.http.HttpURLConnection.isExternalMessageHeaderAllowed(HttpURLConnection.java:435) >---at sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:2767) >---at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:662) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:640) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:634) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.doTestNonLogin(TestNonLoginAndBasicAuthenticator.java:364) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.testBasicLoginRejectProtectedWithSession(TestNonLoginAndBasicAuthenticator.java:348) A quick check with older tomcat versions showed the same errors. So I believe, that the jre got stricter about the values in cookie names (: at the end of Cookie). If I remove the ":" from the "Cookie" name in the tests will run without warning. Any reason to add ":" in line 360 and 383 in test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java? Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.29
Am 21.11.2015 um 17:02 schrieb Felix Schumacher: Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added support for URIs in config file locations - Add a new RestCsrfPreventionFilter that provides basic CSRF protection for REST APIs - Use instance manager for WebSocket server endpoint instances It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.29/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1055/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_29/ The proposed 8.0.29 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.0.29 On my ubuntu 14.04.03 with java 7 (OpenJDK Runtime Environment (IcedTea 2.6.1) (7u85-2.6.1-5ubuntu0.14.04.1)) a few tests are failing, that I haven't noticed before. Those are in TestNonLoginAndBasicAuthenticator. Testcase: testBasicLoginRejectProtectedWithSession took 0,102 sec >---Caused an ERROR Illegal character(s) in message header field: Cookie: java.lang.IllegalArgumentException: Illegal character(s) in message header field: Cookie: >---at sun.net.www.protocol.http.HttpURLConnection.checkMessageHeader(HttpURLConnection.java:465) >---at sun.net.www.protocol.http.HttpURLConnection.isExternalMessageHeaderAllowed(HttpURLConnection.java:435) >---at sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:2767) >---at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:662) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:640) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:634) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.doTestNonLogin(TestNonLoginAndBasicAuthenticator.java:364) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.testBasicLoginRejectProtectedWithSession(TestNonLoginAndBasicAuthenticator.java:348) A quick check with older tomcat versions showed the same errors. So I believe, that the jre got stricter about the values in cookie names (: at the end of Cookie). If I remove the ":" from the "Cookie" name in the tests will run without warning. Any reason to add ":" in line 360 and 383 in test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java? Now I have found, that this was already discussed in the vote for native 1.2.1. But it seems, that there was no solution found. Any other news on this? https://www.mail-archive.com/dev@tomcat.apache.org/msg102070.html Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.29
Am 21.11.2015 um 17:06 schrieb Felix Schumacher: Am 21.11.2015 um 17:02 schrieb Felix Schumacher: Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added support for URIs in config file locations - Add a new RestCsrfPreventionFilter that provides basic CSRF protection for REST APIs - Use instance manager for WebSocket server endpoint instances It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.29/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1055/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_29/ The proposed 8.0.29 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.0.29 On my ubuntu 14.04.03 with java 7 (OpenJDK Runtime Environment (IcedTea 2.6.1) (7u85-2.6.1-5ubuntu0.14.04.1)) a few tests are failing, that I haven't noticed before. Those are in TestNonLoginAndBasicAuthenticator. Testcase: testBasicLoginRejectProtectedWithSession took 0,102 sec >---Caused an ERROR Illegal character(s) in message header field: Cookie: java.lang.IllegalArgumentException: Illegal character(s) in message header field: Cookie: >---at sun.net.www.protocol.http.HttpURLConnection.checkMessageHeader(HttpURLConnection.java:465) >---at sun.net.www.protocol.http.HttpURLConnection.isExternalMessageHeaderAllowed(HttpURLConnection.java:435) >---at sun.net.www.protocol.http.HttpURLConnection.setRequestProperty(HttpURLConnection.java:2767) >---at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:662) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:640) >---at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:634) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.doTestNonLogin(TestNonLoginAndBasicAuthenticator.java:364) >---at org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.testBasicLoginRejectProtectedWithSession(TestNonLoginAndBasicAuthenticator.java:348) A quick check with older tomcat versions showed the same errors. So I believe, that the jre got stricter about the values in cookie names (: at the end of Cookie). If I remove the ":" from the "Cookie" name in the tests will run without warning. Any reason to add ":" in line 360 and 383 in test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java? Now I have found, that this was already discussed in the vote for native 1.2.1. But it seems, that there was no solution found. Any other news on this? https://www.mail-archive.com/dev@tomcat.apache.org/msg102070.html While debugging this issue in eclipse, I found that checkMessageHeader is explicitly checking for ":" (and "\n") in the key and throwing an exception, when one is found. So I believe the ":" is not allowed (anymore). Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: bugs in tomcat 5
Am 21.11.2015 um 15:30 schrieb Mark Thomas: On 21/11/2015 13:35, Felix Schumacher wrote: Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat 5 has reached EOL, or because I don't have permission to do so? Hmm. I just CLOSED it but I have admin karma in BZ. Let me take a quick look... Yes, Tomcat 5 is set as read only. That stops people opening new bugs against an unsupported product. Generally, we don't bother closing a bug. Once the fix is in svn we mark the bug as resolved and leave it at that. Now the bug is in state closed wontfix, while the bug is fixed (alas not in tomcat 5). Shrug. Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: bugs in tomcat 5
Am 21.11.2015 um 17:34 schrieb Mark Thomas: On 21/11/2015 16:32, Felix Schumacher wrote: Am 21.11.2015 um 15:30 schrieb Mark Thomas: On 21/11/2015 13:35, Felix Schumacher wrote: Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat 5 has reached EOL, or because I don't have permission to do so? Hmm. I just CLOSED it but I have admin karma in BZ. Let me take a quick look... Yes, Tomcat 5 is set as read only. That stops people opening new bugs against an unsupported product. Generally, we don't bother closing a bug. Once the fix is in svn we mark the bug as resolved and leave it at that. Now the bug is in state closed wontfix, while the bug is fixed (alas not in tomcat 5). Shrug. I can re-open it and move it to trunk. Would that help? I think it would be the right thing to do, since we will not fix it in tomcat 5, but it is being addressed in trunk (and I will backport it to 7 and 8 - if no one objects). Thanks Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: bugs in tomcat 5
Am 21. November 2015 19:47:48 MEZ, schrieb Mark Thomas : >On 21/11/2015 16:37, Felix Schumacher wrote: >> Am 21.11.2015 um 17:34 schrieb Mark Thomas: >>> On 21/11/2015 16:32, Felix Schumacher wrote: >>>> Am 21.11.2015 um 15:30 schrieb Mark Thomas: >>>>> On 21/11/2015 13:35, Felix Schumacher wrote: >>>>>> Hi all, >>>>>> >>>>>> I wanted to close bug 34319, which is a tomcat 5 bug, but was not >>>>>> allowed to do so. >>>>>> >>>>>> Is it because tomcat 5 has reached EOL, or because I don't have >>>>>> permission to do so? >>>>> Hmm. I just CLOSED it but I have admin karma in BZ. Let me take a >quick >>>>> look... >>>>> >>>>> Yes, Tomcat 5 is set as read only. That stops people opening new >bugs >>>>> against an unsupported product. >>>>> >>>>> Generally, we don't bother closing a bug. Once the fix is in svn >we >>>>> mark >>>>> the bug as resolved and leave it at that. >>>> Now the bug is in state closed wontfix, while the bug is fixed >(alas not >>>> in tomcat 5). >>>> >>>> Shrug. >>> I can re-open it and move it to trunk. Would that help? >> I think it would be the right thing to do, since we will not fix it >in >> tomcat 5, but it is being addressed in trunk (and I will backport it >to >> 7 and 8 - if no one objects). > >Done. Thanks, Felix > >Mark > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1715661 - in /tomcat/trunk: java/org/apache/catalina/ha/session/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/
Hi all,
do I have to add a changelog entry for such a trivial change?
Regards,
Felix
Am 22.11.2015 um 18:31 schrieb fschumac...@apache.org:
Author: fschumacher
Date: Sun Nov 22 17:31:30 2015
New Revision: 1715661
URL: http://svn.apache.org/viewvc?rev=1715661&view=rev
Log:
Fix potential integer overflow. Reported by coverity scan.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=1715661&r1=1715660&r2=1715661&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Sun Nov
22 17:31:30 2015
@@ -221,7 +221,7 @@ public class DeltaSession extends Standa
@Override
public boolean isAccessReplicate() {
long replDelta = System.currentTimeMillis() - getLastTimeReplicated();
-if (maxInactiveInterval >=0 && replDelta > (maxInactiveInterval *
1000)) {
+if (maxInactiveInterval >=0 && replDelta > (maxInactiveInterval *
1000L)) {
return true;
}
return false;
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1715661&r1=1715660&r2=1715661&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Sun Nov 22 17:31:30 2015
@@ -954,7 +954,7 @@ public class ConnectionPool {
busy.remove(con);
abandon(con);
setToNull = true;
-} else if (sto > 0 && (now - time) > (sto*1000)) {
+} else if (sto > 0 && (now - time) > (sto * 1000L)) {
suspect(con);
} else {
//do nothing
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1715661&r1=1715660&r2=1715661&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
Sun Nov 22 17:31:30 2015
@@ -400,7 +400,7 @@ public class PooledConnection {
if (poolProperties.getRemoveAbandonedTimeout() <= 0) {
return Long.MAX_VALUE;
} else {
-return poolProperties.getRemoveAbandonedTimeout()*1000;
+return poolProperties.getRemoveAbandonedTimeout() * 1000L;
} //end if
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.29
Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added support for URIs in config file locations - Add a new RestCsrfPreventionFilter that provides basic CSRF protection for REST APIs - Use instance manager for WebSocket server endpoint instances It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.29/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1055/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_29/ The proposed 8.0.29 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.0.29 Tested on ubuntu 14.04.3 with OpenJDK Runtime Environment (IcedTea 2.6.1) (7u85-2.6.1-5ubuntu0.14.04.1). Reported broken tests with ssl, since ubuntu has an old version of openssl. The other broken tests, can be explained with a quite new jre and are really broken tests, rather than broken code. sha1, md5 and pgp sums are valid. Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1715633 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java webapps/docs/changelog.xml
Am 23.11.2015 um 03:19 schrieb Huxing Zhang:
Hi fschumacher,
Just a friendly reminder that I had a discussion with kkolinko about this
before.
I seems that it is better to explicitly define the default value rather than
the Boolean.getBoolean syntactic sugar.
Thanks for the hint.
I will change it.
Regards,
Felix
private static final boolean onlyAttemptFirstLoader =
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
Details can be found here:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58564
--
From:fschumacher
Time:2015 Nov 22 (Sun) 23:29
To:dev
Subject:svn commit: r1715633 - in /tomcat/trunk:
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
webapps/docs/changelog.xml
Author: fschumacher
Date: Sun Nov 22 15:28:55 2015
New Revision: 1715633
URL: http://svn.apache.org/viewvc?rev=1715633&view=rev
Log:
Correct evaluation of system property
org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader.
It was basically ignored before. Reported by coverity scan.
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java?rev=1715633&r1=1715632&r2=1715633&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
Sun Nov 22 15:28:55 2015
@@ -24,7 +24,7 @@ public class ClassLoaderUtil {
private static final Log log = LogFactory.getLog(ClassLoaderUtil.class);
private static final boolean onlyAttemptFirstLoader =
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
public static Class loadClass(String className, ClassLoader... classLoaders) throws ClassNotFoundException {
ClassNotFoundException last = null;
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1715633&r1=1715632&r2=1715633&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Nov 22 15:28:55 2015
@@ -95,6 +95,14 @@
+
+
+
+Correct evaluation of system property
org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader.
+It was basically ignored before. Reported by coverity scan.
(fschumacher)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1715633 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java webapps/docs/changelog.xml
Am 30.11.2015 um 16:43 schrieb Christopher Schultz:
Felix,
On 11/24/15 3:47 PM, Felix Schumacher wrote:
Am 23.11.2015 um 03:19 schrieb Huxing Zhang:
Hi fschumacher,
Just a friendly reminder that I had a discussion with kkolinko about
this before.
I seems that it is better to explicitly define the default value
rather than the Boolean.getBoolean syntactic sugar.
Thanks for the hint.
I will change it.
I'm not sure why Konstantin had a strong opinion on this;
Boolean.getBoolean has a well-defined default value of Boolean.FALSE. I
suppose it's a little more readable when you have the default explicitly
in there.
That was his main point.
But:
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
This was definitely wrong... it's looking-up the system property called
"[something]" or "false" depending upon the value of
org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader. This is what
was intended:
Boolean.valueOf(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader","false")
right.
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
... and I have no objection to the above.
I will not change it back again :) but thanks for the review.
Regards,
Felix
-chris
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.30
Am 2. Dezember 2015 00:02:08 MEZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.30 release is now available for voting. > >The main changes since 8.0.29 are: > >- Location headers for redirects now use relative URIs. This can > be controlled by Context with the useRelativeRedirects attribute. > >- Correct a regression in 8.0.29 that broke redirects for context > roots. > >- Restore the default setting of quoteAttributeEL in Jasper to true > to align with 8.0.26/7.0.64 and earlier as well as other JSP > implementations. > > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.30/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1057/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_30/ > >The proposed 8.0.30 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.30 Tested on java 1.7.0_91 on x86_64. md5, sha1 and pgp keys are valid. Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.67
Am 7. Dezember 2015 16:15:22 MEZ, schrieb Violeta Georgieva : >The proposed Apache Tomcat 7.0.67 release is now available for voting. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.67/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1058/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_67/ > >The proposed 7.0.67 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 7.0.67 Stable Regards, Felix > >Regards, >Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat JDBC Pool memory leak when using StatementFinalizer interceptor
Am 19.07.2018 um 02:18 schrieb Filip Hanik:
Thanks Martin, I agree, regardless of use case, the pool should not
generate a leak.
What do you think about adding a size test in createStatement and if it
is bigger than a threshold start a cleanup of the list. If the list is
after the cleanup still "too big", we could generate a warning, that the
finalizer might not be helpful.
Regards,
Felix
let me review your proposal
Filip
On Wed, Jul 18, 2018 at 07:48 Martin Knoblauch wrote:
On Wed, Jul 18, 2018 at 3:24 PM, Martin Knoblauch
wrote:
Hi Filip,
On Fri, Jul 13, 2018 at 4:33 PM, Filip Hanik wrote:
hi Martin,
On Fri, Jul 13, 2018 at 5:48 AM, Martin Knoblauch
wrote:
Hi, (moving to developers list)
any ideas on the problem below? This thing is kind of itching me :-)
So I instrumented the "StatementFinalizer" class with some logging and
learned that over time a few instances of the "StatementFinalizer" are
created, used and destroyed. So far so good. For most of those
instances,
the overall number of statements that are added to the "statements"
list by
"createStatement" and the number of statements removed from the list
by
"closeInvoked" is identical and after "closeInvoked" finishes, the
list
is
empty.
But only for most instances of "StatementFinalizer". I could find
that
there is one instance that is used (statements are added), but the
invocation of "closednvoked" stops after some minutes into the
application.
As a result the "statements" list starts growing.
Could it be that your application checks out a connection and uses it
for
the life time of the application?
Meaning Connection.close is never called?
So in fact some instrumentation and digging deeper showed 3 different
problems in the application:
1) there is one SQL Statement not closed (revealed by
"StatementFinalizer(trace=true)")
2) there is one connection not closed after the "final" SQL statement
(revealed by properly activating the "Abandoned" mechanism)
3) there is one connection that is used heavily over the entire lifetime
of the application, and never closed. This one accumulates the memory
that
made me ask the "leak" question
Need to address all three to the application developers.
Given that 1+2 each only happen once, the best solution to avoid the
"leak" might really be to just not use the "StatementFinalizer".
But then, just for the fun of it, would something like this patch be of
interest? It adds a private method "removeClosed()" to the
"StatementFinalizer code. What it does is to remove all "closed" or "null"
statements from the "statements" list. In order to keep it low in the
performance profile, it only does this every "sweepMinutes" minutes (new
interceptor property). My testing shows it keeps the memory consumption
down.
Martin
---
apache-tomcat-8.0.36-src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
2016-06-09 16:00:49.0 +0200
+++
apache-tomcat-8.0.36-src-mkn/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java
2018-07-18 14:53:35.242785369 +0200
@@ -18,7 +18,9 @@
import java.lang.ref.WeakReference;
import java.lang.reflect.Method;
+import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
@@ -40,15 +42,64 @@
protected List statements = new LinkedList<>();
private boolean logCreationStack = false;
+private long sweepMillis = 0;
+private long lastSweep = 0;
+
+private int addedStmts = 0;
+
+/**
+ * Removes closed or "null" statements from the "statements" list. Useful
for connections that are
+ * never closed. Returns without doing anything in the following cases:
+ * - Interceptor property "sweepMinutes" is 0 (default)
+ * - First call after "borrow"
+ * - Time difference between now and last sweep has not reached yet
+ * - Only one statement on list (or list is empty)
+ */
+private void removeClosed() {
+
+if (sweepMillis == 0) // Nothing to do
+return;
+if (lastSweep == 0) { // First time around. Nothing to do
+lastSweep = System.currentTimeMillis();
+return;
+}
+if ((System.currentTimeMillis() - lastSweep) < sweepMillis) // Age not
reached, nothing to do
+return;
+if (statements.size() < 2) // empty, or exactely one statement (has
just been added), nothing to do
+return;
+
+lastSweep = System.currentTimeMillis();
+Iterator it = statements.iterator();
+int clsdStmts = 0;
+int nullStmts = 0;
+while(it.hasNext()){
+StatementEntry ws = (StatementEntry)it.next();
+Statement st = ws.getStatement();
+try {
+if (st == null) nullStmts++;
+else if (st.isClosed()) clsdStmts++;
+if ((st == null) || st.isClosed()) it.remove();
+} catch (SQLException e) {
+//ignore t
appName for JAASRealm
Hi all, while looking into the docs and code for JAASRealm I found that the docs say that appName has to be set for the JAASRealm, while the code says that it defaults to Catalina (well the Containers name to be exact). Is there any reason that the doc says it has to be set? Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.11
Am 11. August 2018 21:32:01 GMT+01:00 schrieb Mark Thomas :
>The proposed Apache Tomcat 9.0.11 release is now available for voting.
>
>The major changes compared to the 9.0.10 release are:
>
>- Fix issues with Servlet asynchronous listeners when using the
> asynchronous Servlet API in conjunction with HTTP/2.
>
>- Add a default location for the native library: ${catalina.home}/bin
>
>- Make the Jasper (JSP Engine) Java file generation process
> multi-threaded. By default, one thread will be used per core.
> Based on a patch by Dan Fabulich.
>
>
>Along with lots of other bug fixes and improvements.
>
>For full details, see the changelog:
>http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.11/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1191/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_11/
>
>The proposed 9.0.11 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 9.0.11
Regards,
Felix
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.33
Am 12. August 2018 09:43:37 GMT+01:00 schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.33 release is now available for voting. > >The major changes compared to the 8.5.32 release are: > >- Fix issues with Servlet asynchronous listeners when using the > asynchronous Servlet API in conjunction with HTTP/2. > >- When pre-compiling with JspC, report all compilation errors rather > than stopping after the first error. A new option -failFast can be > used to restore the previous behaviour of stopping after the first > error. > Based on a patch provided by Marc Pompl. > >- Make the Jasper (JSP Engine) Java file generation process > multi-threaded. By default, one thread will be used per core. > Based on a patch by Dan Fabulich. > >Along with lots of other bug fixes and improvements. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.33/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1192/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_33/ > >The proposed 8.5.33 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.5.33 Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.12
Am 05.09.2018 um 00:32 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.12 release is now available for voting. The major changes compared to the 9.0.11 release are: - Fix multiple issues associated with using the asynchronous Servlet API in combination with HTTP/2 - Add recursion to rewrite substitution parsing - Expand the information in the documentation web application regarding the use of CATALINA_HOME and CATALINA_BASE. Patch provided by Marek Czernek. Along with lots of other bug fixes and improvements. For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.12/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1193/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_12/ The proposed 9.0.12 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 9.0.12 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.91
Am 13.09.2018 um 22:28 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.91 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1195/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_91/ The proposed 7.0.91 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 7.0.91 Stable Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
docs for web.xml.defaults
Hi all, today I looked for documentation about the usage of host specific web.xml variations like the one provided by context.xml.default. I found no documentation, but it is implemented in all supported versions of tomcat. Is there any reason for not telling our users about that feature? I think it would fit on the page about virtual hosts (together with a remark about the context.xml.default files, which are only mentioned in the conf/context page). When there are no objections, I will add it. Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Felix Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 12:16 schrieb Rémy Maucherat: 2016-03-13 11:52 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Sure, go ahead and fix any you find. What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in AbstractJsseEndpoint? That seems the last java 7 related issue in normal tomcat classes. I will look at the webapps code now. Felix Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 14:04 schrieb Felix Schumacher: Am 13.03.2016 um 12:16 schrieb Rémy Maucherat: 2016-03-13 11:52 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Sure, go ahead and fix any you find. What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in AbstractJsseEndpoint? That seems the last java 7 related issue in normal tomcat classes. I will look at the webapps code now. The webapps issues are missing destroy() methods and usage of GenericFilter in the filters. I think these should be adressed, once the javax.servlet parts are resolved. Felix Felix Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 14:40 schrieb Mark Thomas: On 13/03/2016 13:04, Felix Schumacher wrote: Am 13.03.2016 um 12:16 schrieb Rémy Maucherat: 2016-03-13 11:52 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Sure, go ahead and fix any you find. What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in AbstractJsseEndpoint? What does Tomcat 8 do in the equivalent code? It uses reflection to test for java 8. Will look into it. (Should have looked closer in the first place) Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 14:48 schrieb Felix Schumacher: Am 13.03.2016 um 14:40 schrieb Mark Thomas: On 13/03/2016 13:04, Felix Schumacher wrote: Am 13.03.2016 um 12:16 schrieb Rémy Maucherat: 2016-03-13 11:52 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Sure, go ahead and fix any you find. What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in AbstractJsseEndpoint? What does Tomcat 8 do in the equivalent code? It uses reflection to test for java 8. Will look into it. (Should have looked closer in the first place) ant test compiles without an error. Let's see, if it runs without an error. Felix Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1734771 - in /tomcat/tc8.5.x: ./ branches/ tags/ trunk/
Am 13.03.2016 um 15:49 schrieb Felix Schumacher: Am 13.03.2016 um 14:48 schrieb Felix Schumacher: Am 13.03.2016 um 14:40 schrieb Mark Thomas: On 13/03/2016 13:04, Felix Schumacher wrote: Am 13.03.2016 um 12:16 schrieb Rémy Maucherat: 2016-03-13 11:52 GMT+01:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 13.03.2016 um 11:31 schrieb Rémy Maucherat: 2016-03-13 11:01 GMT+01:00 Mark Thomas : The task list is (probably): - Switch to Java 7 for source and target - Cleanup "9" version numbers in various places - Resolve Java 7 issues - Replace javax.servlet API with the classes from Tomcat 8.0 From that list, what can I do without causing conflicts ? If you can start on the Java 7 issues that would be great. I'll work on the Servlet API stuff next and then help out with Java 7 if necessary. Ok, I'll do that. I could help, too. I think I will try to convert the RestCsrfPreventionFilter. Sure, go ahead and fix any you find. What should we do with SSLParameters#setUseCipherSuitesOrder(boolean) in AbstractJsseEndpoint? What does Tomcat 8 do in the equivalent code? It uses reflection to test for java 8. Will look into it. (Should have looked closer in the first place) ant test compiles without an error. Let's see, if it runs without an error. ant test runs without any error except cipher suite tests, which are expected on my ubuntu 14.04 setup. Felix Felix Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Default for honorCipherOrder in tomcat 8.5
Hi, what should be the default value for honorCipherOrder? It has to be false, when run on java 7. But it could be set to true, if java 8 was detected. This might be a bit confusing, so what do you think? Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M4
Am 12.03.2016 um 14:58 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M4 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M3 branch are: - Added JASPIC support - Switch to the ParallelWebappClassLoader by default - Reduce runtime memory footprint - Lots of bug fixes For full details, see the changelog: http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1065/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/ The proposed 9.0.0.M4 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M4 Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.0
Am 17.03.2016 um 21:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.0 release is now available for voting. This is the first release of the 8.5.x branch. The release is, in essence: - Based on a copy of the 9.0.0.M4 tag - All 9.0.x changes to the specification APIs have been reverted. The specification APIs should match 8.0.x exactly - Java 8 specific code has been re-written for Java 7 - Tomcat and specification versions have been set It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1066/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/ The proposed 8.5.0 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.5.0 [x] Beta - go ahead and release as 8.5.0 [ ] Stable - go ahead and release as 8.5.0 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.33
Am 18. März 2016 21:55:26 MEZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.33 release is now available for voting. > >The main changes since 8.0.32 are: > >- Correct a false positive warning for ThreadLocal related memory > leaks when the key class but not the value class has been loaded > by the web application class loader. > >- Improve the performance of > javax.servlet.jsp.el.ScopedAttributeELResolver when resolving > attributes that do not exist. > >- Update the packaged version of the Tomcat Native Library to 1.2.5 > to pick up the Windows binaries that are based on OpenSSL 1.0.2g > and APR 1.5.1. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.33/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1067/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_33/ > >The proposed 8.0.33 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.33 Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.69
Am 11.04.2016 um 12:55 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.69 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1074/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_69/ The proposed 7.0.69 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 7.0.69 Stable Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.1
Am 11. Mai 2016 13:29:23 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.1 release is now available for voting. > >The major changes compared to the 8.5.0 release are: >- Add the org.apache.catalina.servlet4preview package that can be > used to gain early access to Servlet 4.0 features. Note that this > package will not be present in Tomcat 9. >- Make default TLS configuration more secure >- Add direct HTTP/2 connection support >- Update the packaged version of the Tomcat Native Library to 1.2.7 to > pick up the Windows binaries that are based on OpenSSL 1.0.2h and > APR 1.5.2. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.1/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1077/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_1/ > >The proposed 8.5.1 release is: >[ ] Broken - do not release >[ ] Alpha - go ahead and release as 8.5.1 >[x] Beta - go ahead and release as 8.5.1 Felix >[ ] Stable - go ahead and release as 8.5.1 > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M6
Am 12. Mai 2016 00:06:55 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 9.0.0.M6 release is now available for >voting. > >This is a milestone release for the 9.0.x branch. It should be >noted that, as a milestone release: >- Servlet 4.0 is not finalised >- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 > >9.0.0.M6 corrects a regression found in 9.0.0.M5 > >The major changes compared to the 9.0.0.M4 release are: >- Add direct HTTP/2 connection support >- Update the implementation of the the proposed Servlet 4.0 API to > provide mapping type information for the current request to reflect > discussions within the EG. >- Update the packaged version of the Tomcat Native Library to 1.2.7 to > pick up the Windows binaries that are based on OpenSSL 1.0.2h and > APR 1.5.2. > > >For full details, see the changelog: >http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M6/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1079/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M6/ > >The proposed 9.0.0.M6 release is: >[ ] Broken - do not release >[x] Alpha - go ahead and release as 9.0.0.M6 Felix > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.2
Am 12. Mai 2016 00:22:07 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.2 release is now available for voting. > >8.5.2 corrects a regression found in 8.5.1. > >The major changes compared to the 8.5.0 release are: >- Add the org.apache.catalina.servlet4preview package that can be > used to gain early access to Servlet 4.0 features. Note that this > package will not be present in Tomcat 9. >- Make default TLS configuration more secure >- Add direct HTTP/2 connection support >- Update the packaged version of the Tomcat Native Library to 1.2.7 to > pick up the Windows binaries that are based on OpenSSL 1.0.2h and > APR 1.5.2. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.2/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1081/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_2/ > >The proposed 8.5.2 release is: >[ ] Broken - do not release >[ ] Alpha - go ahead and release as 8.5.2 >[x] Beta - go ahead and release as 8.5.2 >[ ] Stable - go ahead and release as 8.5.2 Felix > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.35
Am 12.05.2016 um 00:34 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.35 release is now available for voting. 8.0.35 corrects a regression found in 8.0.34. The main changes since 8.0.33 are: - Make the default TLS configuration more secure. - Update the packaged version of the Tomcat Native Library to 1.2.7 to pick up the Windows binaries that are based on OpenSSL 1.0.2h and APR 1.5.2. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.35/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1082/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_35/ The proposed 8.0.35 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.0.35 org.apache.tomcat.websocket.server.TestCloseBug58624 seems to be a bit flaky, especially with nio2. Could by my ubuntu setup, though. [junit] Running org.apache.tomcat.websocket.server.TestCloseBug58624 [junit] 12-May-2016 21:29:13.261 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["http-nio2-127.0.0.1-auto-1"] [junit] 12-May-2016 21:29:13.281 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service Tomcat [junit] 12-May-2016 21:29:13.282 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet Engine: Apache Tomcat/8.0.35-dev [junit] 12-May-2016 21:29:13.416 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["http-nio2-127.0.0.1-auto-1-41135"] [junit] java.io.EOFException [junit] at org.apache.coyote.http11.upgrade.Nio2ServletInputStream$1.completed(Nio2ServletInputStream.java:60) [junit] at org.apache.coyote.http11.upgrade.Nio2ServletInputStream$1.completed(Nio2ServletInputStream.java:51) [junit] at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126) [junit] at sun.nio.ch.Invoker$2.run(Invoker.java:218) [junit] at sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112) [junit] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [junit] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [junit] at java.lang.Thread.run(Thread.java:745) [junit] 12-May-2016 21:29:13.809 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["http-nio2-127.0.0.1-auto-1-41135"] [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,192 sec [junit] 12-May-2016 21:29:13.865 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service Tomcat [junit] 12-May-2016 21:29:13.896 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["http-nio2-127.0.0.1-auto-1-41135"] [junit] 12-May-2016 21:29:13.898 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["http-nio2-127.0.0.1-auto-1-41135"] [junit] Test org.apache.tomcat.websocket.server.TestCloseBug58624 FAILED Ubuntu 16.04 x86-64 and Java 1.7.0_80. Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PATCH]
Am 27.05.2016 um 23:42 schrieb gradstud: Good afternoon, Your emails back and forth are all going through our graduate admissions email, can you please find another place for your Bugzilla, Apache, Tomcat business. You should find instructions to unsubscribe yourself from this mailinglist at the bottom of every mail sent by the list. Nonetheless, I will unsubscribe you on your request. Regards, Felix Thank you From: Sadik Kalia [mailto:kalia.sa...@gmail.com] Sent: Friday, May 27, 2016 3:36 PM To: dev@tomcat.apache.org Subject: [PATCH] Hello, I am new to Apache Tomcat. While i was reading the code i found something that i could change. In org.apache.catalina.users.MemoryGroup and org.apache.catalina.users.MemoryUser i have change the ArrayList to HashSet because i think HashSet will have better performance in this case and does not have to search for duplicates. I am sorry if i have not follow the procedure of submitting a patch. I would be very thankful if anyone explain the procedure to me. Please find attached with this email the patch i have provided. Thank you, Sadik Kalia - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.3
Am 9. Juni 2016 14:13:07 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.3 release is now available for voting. > >The major changes compared to the 8.5.2 release are: > >- Ensure error will not be thrown during deployment when scanning jar > files with no or invalid MANIFEST.MF files. > >- Improvements to memory leak detection and prevention > >- The HTTP Server header is no longer set by default > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.3/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1086/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_3/ > >The proposed 8.5.3 release is: >[ ] Broken - do not release >[ ] Alpha - go ahead and release as 8.5.3 >[ ] Beta - go ahead and release as 8.5.3 >[x] Stable - go ahead and release as 8.5.3 Tests pass. Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.36
Am 9. Juni 2016 16:17:47 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.36 release is now available for voting. > >The main changes since 8.0.35 are: > >- Ensure error will not be thrown during deployment when scanning jar > files with no or invalid MANIFEST.MF files. > >- Improvements to memory leak detection and prevention > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.36/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1087/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_36/ > >The proposed 8.0.36 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.36 Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M8
Am 07.06.2016 um 18:02 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M8 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M6 release are: - Improvements to memory leak detection and prevention including the change RMI memory leaks are now correctly treated as application bugs rather than a JRE bug - Fix a couple of memory leaks found in Tomcat - The HTTP Server header is no longer set by default For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M8/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1085/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M8/ The proposed 9.0.0.M8 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M8 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.70
Am 15.06.2016 um 21:47 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.70 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.70/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1088/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_70/ The proposed 7.0.70 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 7.0.70 Stable Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
Am 22.06.2016 um 20:19 schrieb Matt Cosentino: I figured out the problem. The NPE was occurring because it couldn’t match the default SSLHostConfig. The documentation says to use the sslDefaultHost attribute of the Connector, but I get warnings saying that no matching property is found. I had to dig into the code to find that the correct attribute is defaultSSLHostConfigName. The documentation should be updated to reflect this. https://tomcat.apache.org/migration-85.html I have changed the doc. Thanks for the hint. Regards, Felix - Matt -Original Message- From: Matt Cosentino Sent: Friday, May 27, 2016 2:15 PM To: 'Tomcat Developers List' Subject: RE: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. I see, that explains why it isn't in 8.5, thanks for the helpful response. I'll investigate further why the NPE is still occurring. - Matt -Original Message- From: Coty Sutherland [mailto:csuth...@redhat.com] Sent: Friday, May 27, 2016 1:27 PM To: Tomcat Developers List Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. It may have been branched in March, but wouldn't it have been branched from the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still occurs. No, 8.5 was branched from trunk and therefore included the revision that you pointed out. Please see the dev list thread titled "Tomcat 8.next" for more information on the 8.5 origin. Additionally, looking at the mergeinfo in svn (svn mergeinfo ^/tomcat/trunk@1726515) shows that it was forked from trunk. If you looked at the 8.5 AprEndpoint class and don't see the change, it's because it was changed by r1727667 on 1/29 (r1726515 was included on 1/24). On Fri, May 27, 2016 at 12:24 PM, Matt Cosentino wrote: It may have been branched in March, but wouldn't it have been branched from the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still occurs. Bringing an issue to your attention is spamming? - Matt -Original Message- From: Rémy Maucherat [mailto:r...@apache.org] Sent: Friday, May 27, 2016 11:06 AM To: Tomcat Developers List Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL. 2016-05-27 17:45 GMT+02:00 Matt Cosentino : No? 8.5 suffers from the same NPE. First, 8.5 was branched in March, then I am not happy about being spammed. Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M9
Am 04.07.2016 um 21:03 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M9 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M8 release are: For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M9/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1089/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M9/ The proposed 9.0.0.M9 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M9 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.4
Am 6. Juli 2016 11:42:47 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.4 release is now available for voting. > >The major changes compared to the 8.5.3 release are: > >- Correct a regression in the embedded packaging > >- Add the ability to control the degree of concurrency when processing > HTTP/2 connections > >- Update to Tomcat Native 1.2.8 > > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.4/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1090/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_4/ > >The proposed 8.5.4 release is: >[ ] Broken - do not release >[ ] Alpha - go ahead and release as 8.5.4 >[ ] Beta - go ahead and release as 8.5.4 >[x] Stable - go ahead and release as 8.5.4 Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Request for Wiki karma
Hi all, I wanted to add Greg Trasuk to the wiki contributors, but it seems I haven't enough karma to do it. Please add my id FelixSchumacher to the admin group, so that I could accomplish such tasks in the future. Thanks, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1755056 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java webapps/docs/changelog.xml
Am 3. August 2016 11:36:34 MESZ, schrieb kfuj...@apache.org:
>Author: kfujino
>Date: Wed Aug 3 09:36:34 2016
>New Revision: 1755056
>
>URL: http://svn.apache.org/viewvc?rev=1755056&view=rev
>Log:
>Ensure that the ResultSet is returned as Proxy object when enabling the
>StatementDecoratorInterceptor.
>
>Modified:
>tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
>tomcat/trunk/webapps/docs/changelog.xml
>
>Modified:
>tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java?rev=1755056&r1=1755055&r2=1755056&view=diff
>==
>---
>tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
>(original)
>+++
>tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementDecoratorInterceptor.java
>Wed Aug 3 09:36:34 2016
>@@ -40,7 +40,11 @@ public class StatementDecoratorIntercept
>
>private static final Log logger =
>LogFactory.getLog(StatementDecoratorInterceptor.class);
>
>-private static final String[] EXECUTE_QUERY_TYPES = {
>"executeQuery" };
>+protected static final String EXECUTE_QUERY = "executeQuery";
>+protected static final String GETGENERATEDKEYS =
>"getGeneratedKeys";
Shouldn't this be GET_GENERATED_KEYS?
Regards,
Felix
>+protected static final String GET_RESULTSET = "getResultSet";
>+
>+protected static final String[] RESULTSET_TYPES = {EXECUTE_QUERY,
>GETGENERATEDKEYS, GET_RESULTSET};
>
> /**
> * the constructors that are used to create statement proxies
>@@ -157,13 +161,17 @@ public class StatementDecoratorIntercept
> }
>
> protected boolean isExecuteQuery(String methodName) {
>-return EXECUTE_QUERY_TYPES[0].equals(methodName);
>+return EXECUTE_QUERY.equals(methodName);
> }
>
> protected boolean isExecuteQuery(Method method) {
> return isExecuteQuery(method.getName());
> }
>
>+protected boolean isResultSet(Method method, boolean process) {
>+return process(RESULTSET_TYPES, method, process);
>+}
>+
> /**
> * Class to measure query execute time.
> */
>@@ -239,7 +247,8 @@ public class StatementDecoratorIntercept
> if (compare(GETCONNECTION_VAL,method)){
> return connection;
> }
>-boolean process = isExecuteQuery(method);
>+boolean process = false;
>+process = isResultSet(method, process);
> // check to see if we are about to execute a query
> // if we are executing, get the current time
> Object result = null;
>@@ -259,7 +268,7 @@ public class StatementDecoratorIntercept
> throw t;
> }
> }
>-if (process){
>+if (process && result != null) {
> Constructor cons = getResultSetConstructor();
>result = cons.newInstance(new Object[]{new ResultSetProxy(actualProxy,
>result)});
> }
>
>Modified: tomcat/trunk/webapps/docs/changelog.xml
>URL:
>http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1755056&r1=1755055&r2=1755056&view=diff
>==
>--- tomcat/trunk/webapps/docs/changelog.xml (original)
>+++ tomcat/trunk/webapps/docs/changelog.xml Wed Aug 3 09:36:34 2016
>@@ -157,6 +157,10 @@
> that continues to return an invalid connection after database restart.
> (kfujino)
>
>+
>+Ensure that the ResultSet is returned as Proxy
>object when
>+enabling the StatementDecoratorInterceptor.
>(kfujino)
>+
>
>
>
>
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.72
Am 14. September 2016 15:01:59 MESZ, schrieb Violeta Georgieva : >The proposed Apache Tomcat 7.0.72 release is now available for voting. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.72/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1095/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_72/ > >The proposed 7.0.72 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 7.0.72 Stable Regards, Felix > >Regards, >Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1758842 - in /tomcat/trunk: build.properties.default webapps/docs/changelog.xml
Am 01.09.2016 um 21:24 schrieb violet...@apache.org:
Author: violetagg
Date: Thu Sep 1 19:24:30 2016
New Revision: 1758842
URL: http://svn.apache.org/viewvc?rev=1758842&view=rev
Log:
Objenesis binary was moved to another download location.
Any reason, why we download the zip version instead of going for the jar
version, which is published in the maven repo under
${base-maven.loc}/org/objenesis/objenesis/${objenesis.version}/objenesis-${objenesis.version}.jar
?
Regards,
Felix
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1758842&r1=1758841&r2=1758842&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Thu Sep 1 19:24:30 2016
@@ -177,7 +177,7 @@ cglib.jar=${cglib.home}/cglib-nodep-${cg
# - objenesis, used by EasyMock, version 1.2 or later -
objenesis.version=1.2
objenesis.home=${base.path}/objenesis-${objenesis.version}
-objenesis.loc=https://objenesis.googlecode.com/files/objenesis-${objenesis.version}-bin.zip
+objenesis.loc=https://bintray.com/easymock/distributions/download_file?file_path=objenesis-${objenesis.version}-bin.zip
objenesis.jar=${objenesis.home}/objenesis-${objenesis.version}.jar
# - Checkstyle, version 6.16 or later -
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1758842&r1=1758841&r2=1758842&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Sep 1 19:24:30 2016
@@ -45,6 +45,13 @@
issues do not "pop up" wrt. others).
-->
+
+
+
+Update the download location for Objenesis. (violetagg)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.10
Am 26.09.2016 18:17, schrieb Mark Thomas: Version 1.2.10 includes the following change: - Update minimum recommended OpenSSL version to 1.0.2j - Windows binaries built with OpenSSL 1.0.2j The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.2.10 is [x] Stable, go ahead and release [ ] Broken because of ... Regards, Felix Thanks, Mark [1] https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.10/ [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_10 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Missing replication of Tomcat 9 svn repo to github
Am 6. Oktober 2016 15:40:31 MESZ, schrieb Violeta Georgieva : >Hi, > >There is not replication of Tomcat 9 svn repo to github since 26.09. >All other repos are ok (Tomcat7/8/8.5). >Should I create an infra issue? Infra-12645 has a comment from me about the sync problem. But maybe it is better to have one for ourselves. JMeter is affected as well. And at least for JMeter the Apache git repo is not in sync, too. Regards, Felix > >Thanks, >Violeta -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Missing replication of Tomcat 9 svn repo to github
Am 06.10.2016 um 16:21 schrieb Felix Schumacher: Am 6. Oktober 2016 15:40:31 MESZ, schrieb Violeta Georgieva : Hi, There is not replication of Tomcat 9 svn repo to github since 26.09. All other repos are ok (Tomcat7/8/8.5). Should I create an infra issue? Infra-12645 has a comment from me about the sync problem. But maybe it is better to have one for ourselves. JMeter is affected as well. And at least for JMeter the Apache git repo is not in sync, too. JMeter is in sync after I did a commit a few minutes ago. Same for tomcat. Regards, Felix Regards, Felix Thanks, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.38
Am 6. Oktober 2016 23:18:39 MESZ, schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.38 release is now available for voting. > >The main changes since 8.0.37 are: > >- Refactoring the non-container thread Async complete()/dispatch() > handling to remove the possibility of deadlock > >- Update the packaged version of the Tomcat Native Library to > 1.2.10 to pick up the latest Windows binaries built with > OpenSSL 1.0.2j > >- Improved UTF-8 handling for the RewriteValve > > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.38/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1098/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_38/ > >The proposed 8.0.38 release is: >[ ] Broken - do not release >[ ] Stable - go ahead and release as 8.0.38 The pgp signatures seem to be missing. Regards, Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.6
Am 06.10.2016 um 22:33 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.6 release is now available for voting. The major changes compared to the 8.5.5 release are: - Refactoring the non-container thread Async complete()/dispatch() handling to remove the possibility of deadlock - Update the packaged version of the Tomcat Native Library to 1.2.10 to pick up the latest Windows binaries built with OpenSSL 1.0.2j - Improved UTF-8 handling for the RewriteValve It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.6/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1097/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_6/ The proposed 8.5.6 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.5.6 [ ] Beta - go ahead and release as 8.5.6 [x] Stable - go ahead and release as 8.5.6 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.38
Am 06.10.2016 um 23:18 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.38 release is now available for voting. The main changes since 8.0.37 are: - Refactoring the non-container thread Async complete()/dispatch() handling to remove the possibility of deadlock - Update the packaged version of the Tomcat Native Library to 1.2.10 to pick up the latest Windows binaries built with OpenSSL 1.0.2j - Improved UTF-8 handling for the RewriteValve It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.38/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1098/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_38/ The proposed 8.0.38 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.0.38 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M11
Am 06.10.2016 um 21:51 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M11 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M10 release are: - Refactoring the non-container thread Async complete()/dispatch() handling to remove the possibility of deadlock - Update the packaged version of the Tomcat Native Library to 1.2.10 to pick up the latest Windows binaries built with OpenSSL 1.0.2j - Improved UTF-8 handling for the RewriteValve Along with lots of other bug fixes and improvements For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M11/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1096/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M11/ The proposed 9.0.0.M11 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M11 Regards, Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 6.0.46
Am 07.10.2016 um 16:11 schrieb Violeta Georgieva: The proposed Apache Tomcat 6.0.46 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.46/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1099/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_46/ The proposed 6.0.46 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 6.0.46 Stable On startup I see the following message, which I didn't see with 6.0.45: INFO: Deploying web application directory ROOT Oct 11, 2016 6:55:06 PM org.apache.catalina.session.ManagerBase setMaxInactiveInterval WARNING: Manager.setMaxInactiveInterval() is deprecated and calls to this method are ignored. Session timeouts should be configured in web.xml or via Context.setSessionTimeout(int timeoutInMinutes) Tests run fine, though. Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 6.0.46
Am 12.10.2016 um 21:47 schrieb Violeta Georgieva: Hi, 2016-10-11 21:56 GMT+03:00 Felix Schumacher < felix.schumac...@internetallee.de>: Am 07.10.2016 um 16:11 schrieb Violeta Georgieva: The proposed Apache Tomcat 6.0.46 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.46/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1099/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_46/ The proposed 6.0.46 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 6.0.46 Stable On startup I see the following message, which I didn't see with 6.0.45: INFO: Deploying web application directory ROOT Oct 11, 2016 6:55:06 PM org.apache.catalina.session.ManagerBase setMaxInactiveInterval WARNING: Manager.setMaxInactiveInterval() is deprecated and calls to this method are ignored. Session timeouts should be configured in web.xml or via Context.setSessionTimeout(int timeoutInMinutes) In the previous versions the invocation of this method was ignored. Now we log that it will be ignored. http://svn.apache.org/viewvc?view=revision&revision=1732678 Should we really release a version, that emits warnings in its default configuration? I just changed into output/build and ran bin/startup.sh. Felix Thanks, Violeta Tests run fine, though. Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 6.0.47
Am 13.10.2016 um 12:51 schrieb Violeta Georgieva: The proposed Apache Tomcat 6.0.47 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.47/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1100/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_47/ The proposed 6.0.47 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 6.0.47 Stable With java 1.5.0_22 I get the following stacktrace: org.w3c.dom.ls.LSException: java.lang.NullPointerException at com.sun.org.apache.xml.internal.serialize.DOMSerializerImpl.writeToString(DOMSerializerImpl.java:546) at org.apache.catalina.core.JreMemoryLeakPreventionListener.lifecycleEvent(JreMemoryLeakPreventionListener.java:410) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142) at org.apache.catalina.core.StandardServer.initialize(StandardServer.java:818) at org.apache.catalina.startup.Catalina.load(Catalina.java:538) at org.apache.catalina.startup.Catalina.load(Catalina.java:562) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:261) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:413) But that seems to be a problem of java 5 and goes away, if I start tomcat with java 8. Regards, Felix Regards, Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M18
Am 08.03.2017 um 16:56 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M18 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M17 release are: - Updates to the early access version of the Serlet 4.0 API to align it with the most recent discussions in the Servlet EG - Support for Java 9 during annotation scanning - Enable ALPN (and hence HTTP/2) for NIO and NIO2 connectors when using JSSE for TLS on Java 9 - Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries built with OpenSSL 1.0.2k Along with lots of other bug fixes and improvements For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1120/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M18/ The proposed 9.0.0.M18 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M18 Tests pass. Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.12
Am 8. März 2017 19:56:32 MEZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.12 release is now available for voting. > >The major changes compared to the 8.5.11 release are: > >- Updates to the early access version of the Serlet 4.0 API to align it > with the most recent discussions in the Servlet EG > >- Support for Java 9 during annotation scanning > >- Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries > built with OpenSSL 1.0.2k > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.12/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1121/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_12/ > >The proposed 8.5.12 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.5.12 Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.38
Am 8. März 2017 21:26:52 MEZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.0.42 release is now available for voting. > >The main changes since 8.0.41 are: > >- Limited relaxation of the HTTP request line validation > >- Support for Java 9 during annotation scanning > >- Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries > built with OpenSSL 1.0.2k > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.42/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1122/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_42/ > >The proposed 8.0.42 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.42 Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 6.0.51
Am 9. März 2017 21:45:09 MEZ schrieb Mark Thomas : >The proposed Apache Tomcat 6.0.51 release is now available for voting. > >Note: This is expected to be the last Tomcat 6 release. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.51/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1124/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_51/ > >The proposed 6.0.51 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 6.0.51 Stable Felix > >Regards, >Mark > > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE][RESULT] Release Apache Tomcat 8.0.42
Am 14. März 2017 16:10:04 MEZ schrieb Mark Thomas : >The following votes were cast: > >Binding: >+1: markt, remm, mgrigorov For the record, I voted for it, too. Felix > >No other votes were cast. > >The vote therefore passes. > >Thanks to everyone who contributed towards this release. > >Mark > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M19
Am 27. März 2017 14:56:41 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 9.0.0.M19 release is now available for >voting. > >This is a milestone release for the 9.0.x branch. It should be >noted that, as a milestone release: >- Servlet 4.0 is not finalised >- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 > >The major changes compared to the 9.0.0.M18 release are: > >- Various HTTP/2 improvements > >- Fixes for sendfile related issues that could cause subsequent >requests > to experience IllegalStateExceptions > >- Servlet 4.0 updates > > >Along with lots of other bug fixes and improvements > >For full details, see the changelog: >http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1125/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/ > >The proposed 9.0.0.M19 release is: >[ ] Broken - do not release >[x] Alpha - go ahead and release as 9.0.0.M19 Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.13
Am 27. März 2017 17:13:51 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.13 release is now available for voting. > >The major changes compared to the 8.5.12 release are: > >- Various HTTP/2 improvements > >- Fixes for sendfile related issues that could cause subsequent >requests > to experience IllegalStateExceptions > >- Servlet 4.0 updates > > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1126/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/ > >The proposed 8.5.13 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.5.13 Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.43
Am 28. März 2017 17:28:30 MESZ schrieb Violeta Georgieva : >The proposed Apache Tomcat 8.0.43 release is now available for voting. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1127/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_43/ > >The proposed 8.0.43 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.0.43 Felix > >Regards, >Violeta - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Java 8 in TC 8.5 BUILDING.txt
Am 15. April 2017 21:20:21 MESZ schrieb Rainer Jung : >file BUILDING.txt for TC 8.5 contains: > >... >Download a version 8 of Java Development Kit (JDK) release >... > >Do we have a build requirement for Java 8? I thought 7 still suffices. I think it is a left over from Tomcat 9. It should be Java 7. Regards, Felix > >The runtime docs are OK (point to Java 7), also compile.source and >compile.target are 1.7, the which version web page also shows 7. > >Any reason we require 8 for building? Or should I correct the info in >BUILDING.txt to 7? > >Thanks and regards, > >Rainer > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] New committer: Michael Osipov
Welcome. Regards, Felix Am 8. Mai 2017 10:08:45 MESZ schrieb Mark Thomas : >On behalf of the Tomcat committers I am pleased to announce that >Michael Osipov (michaelo) has been voted in as a new Tomcat committer. > >Please join me in welcoming him. > >Regards, > >Mark > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.0.M21
Am 05.05.2017 um 11:03 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M21 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0 The major changes compared to the 9.0.0.M20 release are: - Update the default URIEncoding for a Connector to UTF-8 as required by the Servlet 4.0 specification. - Various improvements to the handling of static custom error pages - Update to Eclipse JDT Compiler 4.6.3 Along with lots of other bug fixes and improvements For full details, see the changelog: http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M21/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1133/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M21/ The proposed 9.0.0.M21 release is: [ ] Broken - do not release [x] Alpha - go ahead and release as 9.0.0.M21 Some failures about missing ciphers in org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser for APR, NIO and NIO2, but those are probably expected: junit.framework.AssertionFailedError: Expected 36 ciphers but got 24 for the specification 'TLSv1' expected:<[TLS_DHE_PSK_WITH_AES_128_CBC_SHA256, TLS _DHE_PSK_WITH_AES_256_CBC_SHA384, TLS_DHE_PSK_WITH_CAMELLIA_128_CBC_SHA256, TLS_DHE_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_DHE_PSK_WITH_NULL_SHA256, TL S_DHE_PSK_WITH_NULL_SHA384, TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_ECDSA_WITH_NULL_SHA, TLS_ECDHE_PSK_W ITH_AES_128_CBC_SHA, TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256, TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA, TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384, TLS_ECDHE_PSK_W ITH_CAMELLIA_128_CBC_SHA256, TLS_ECDHE_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_ECDHE_PSK_WITH_NULL_SHA, TLS_ECDHE_PSK_WITH_NULL_SHA256, TLS_ECDHE_PSK_WI TH_NULL_SHA384, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_RSA_WITH_NULL_SHA, TLS_ECDH_anon_WITH_AES_128_CBC_SH A, TLS_ECDH_anon_WITH_AES_256_CBC_SHA, TLS_ECDH_anon_WITH_NULL_SHA, TLS_PSK_WITH_AES_128_CBC_SHA256, TLS_PSK_WITH_AES_256_CBC_SHA384, TLS_PSK_WITH_CAM ELLIA_128_CBC_SHA256, TLS_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_PSK_WITH_NULL_SHA256, TLS_PSK_WITH_NULL_SHA384, TLS_RSA_PSK_WITH_AES_128_CBC_SHA256, T LS_RSA_PSK_WITH_AES_256_CBC_SHA384, TLS_RSA_PSK_WITH_CAMELLIA_128_CBC_SHA256, TLS_RSA_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_RSA_PSK_WITH_NULL_SHA256, TLS_RSA_PSK_WITH_NULL_SHA384]> but was:<[TLS_DHE_PSK_WITH_AES_128_CBC_SHA256, TLS_DHE_PSK_WITH_AES_256_CBC_SHA384, TLS_DHE_PSK_WITH_CAMELLIA_128_CBC_S HA256, TLS_DHE_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_DHE_PSK_WITH_NULL_SHA256, TLS_DHE_PSK_WITH_NULL_SHA384, TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256, TL S_ECDHE_PSK_WITH_AES_256_CBC_SHA384, TLS_ECDHE_PSK_WITH_CAMELLIA_128_CBC_SHA256, TLS_ECDHE_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_ECDHE_PSK_WITH_NULL_S HA256, TLS_ECDHE_PSK_WITH_NULL_SHA384, TLS_PSK_WITH_AES_128_CBC_SHA256, TLS_PSK_WITH_AES_256_CBC_SHA384, TLS_PSK_WITH_CAMELLIA_128_CBC_SHA256, TLS_PSK _WITH_CAMELLIA_256_CBC_SHA384, TLS_PSK_WITH_NULL_SHA256, TLS_PSK_WITH_NULL_SHA384, TLS_RSA_PSK_WITH_AES_128_CBC_SHA256, TLS_RSA_PSK_WITH_AES_256_CBC_S HA384, TLS_RSA_PSK_WITH_CAMELLIA_128_CBC_SHA256, TLS_RSA_PSK_WITH_CAMELLIA_256_CBC_SHA384, TLS_RSA_PSK_WITH_NULL_SHA256, TLS_RSA_PSK_WITH_NULL_SHA384] > at org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.testSpecification(TestOpenSSLCipherConfigurationParser.java :570) at org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.testTLSv1(TestOpenSSLCipherConfigurationParser.java:296) Felix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.15
Am 5. Mai 2017 13:38:24 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.15 release is now available for voting. > >The major changes compared to the 8.5.13 release are: > >- Various improvements to the handling of static custom error pages > >- Update to Eclipse JDT Compiler 4.6.3 > >- Review those places where Tomcat re-encodes a URI or URI component > and ensure that that correct encoding is consistently applied. > >It can be obtained from: >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.15/ >The Maven staging repo is: >https://repository.apache.org/content/repositories/orgapachetomcat-1134/ >The svn tag is: >http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_15/ > >The proposed 8.5.15 release is: >[ ] Broken - do not release >[x] Stable - go ahead and release as 8.5.15 Felix > >- >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
