Re: Tomcat 7 & regex
+1
i like the approach toward standard regex.
ones that use it most likely will be sysadmins, so they should at least know
how to use regex in their tools like shell, awk, perl, python or powershell.
it will be nice if the standard regex is in place.
---
daniel baktiar
http://savinggaia.tritiumapps.com - saving the planet is everyone's
business!
On 26 December 2010 04:02, Mark Thomas wrote:
> On 25/12/2010 13:37, Konstantin Kolinko wrote:
> > 1) It it were configurable, in certain places it makes sense to use
> > space as a separator (e.g. in IP addresses).
> > -> any whitespace? -> \w+ and we end up with using a regex to split a
> > list of regexes.
>
> Yes, space could work but I'd rather stick to what folks expect of
> standard regex. | achieves the same result but is standard regex.
>
> > 2) It might make sense to require regex expressions to be surrounded by
> '/'.
> > E.g. "/192\.168\.1\.\d{1,3}/" is a regex, but "192.168.1.17" is a literal
> value.
>
> I'd rather Tomcat 7 moved towards an existing standard rather than tried
> to create a new one.
>
> > 3) I wonder if it makes sense to manipulate RequestFilterValve though
> > JMX. E.g. to add/remove some filtering patterns at runtime.
>
> It is certainly something I can see would be useful - e.g. reacting to
> an attacker. Making that dynamic should be do-able with care.
>
> > Mark, are there other places than RequestFilterValve and its
> > subclasses (RemoteAddrValve, RemoteHostValve) where you are planning
> > this change?
>
> It was actually RemoteIpValve that got me started on this. You can't
> explicitly set the default since it uses ',' in the regex but we also
> split using ','. I wanted to fix that and moving to a single regex fixes
> that and removes any chance of any similar gotchas in the future.
>
> > There this feature can be configurable. E.g. if split='' then
> > splitting is not performed at all. I do not see why we should force
> > users to use a single regex only.
>
> All it really does is force users to use the standard regex of '|' where
> they currently use ','.
>
> > Having a single regex by default is OK with me, but forcing a single
> > regex saves too little in performance of
> > RequestFilterValve.process(..) (removes iterating over an array but
> > adds a null check).
>
> I don't have any hard numbers but I suspect matching a single regex
> using '|' is going to be faster than matching multiple. Probably not by
> much. The code simplification is pretty minor too.
>
> > [OT] Merry X'mas
> +1 to all.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
the trunk build.xml breaks because of missing commons-pool2-2.1
Hi there,
I don't know whether anyone was aware or it's been discussed here earlier.
I just rejoined this milis after around 1 year ago.
I just checkout the tomcat trunk (rev 1556266) and tried to follow the
build instruction, running the ant build.
The build breaks, and later I found out that the content of the
build.properties.default (which I copied to build.properties and modified
locally) had a stale version of commons-pool2 version (2.1) which is no
longer exists in the repository.
Somewhere in line 169, we need to update the version from 2.1 to 2.2.
commons-pool.version=2.2-20140107.135000-1
171 commons-pool.home=${base.path}/commons-pool2-2.2-SNAPSHOT-src
172 commons-pool-src.loc.1=
https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.2-SNAPSHOT/commons-pool2-${c
ommons-pool.version}-src.tar.gz
173 commons-pool-src.loc.2=
https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.2-SNAPSHOT/commons-pool2-${c
ommons-pool.version}-src.tar.gz
After modifying those 3 lines, it works.
Regards,
Daniel Baktiar
Re: the trunk build.xml breaks because of missing commons-pool2-2.1
Oh, I see. Now they have released the commons-pool2 2.1.
That'll be great.
Thanks for the info, Mark.
Daniel
On Wed, Jan 8, 2014 at 12:40 AM, Mark Thomas wrote:
> On 07/01/2014 16:35, Daniel Baktiar wrote:
> > Hi there,
> >
> > I don't know whether anyone was aware or it's been discussed here
> earlier.
> >
> > I just rejoined this milis after around 1 year ago.
> >
> > I just checkout the tomcat trunk (rev 1556266) and tried to follow the
> > build instruction, running the ant build.
> > The build breaks, and later I found out that the content of the
> > build.properties.default (which I copied to build.properties and modified
> > locally) had a stale version of commons-pool2 version (2.1) which is no
> > longer exists in the repository.
> >
> > Somewhere in line 169, we need to update the version from 2.1 to 2.2.
> >
> > commons-pool.version=2.2-20140107.135000-1
> > 171 commons-pool.home=${base.path}/commons-pool2-2.2-SNAPSHOT-src
> > 172 commons-pool-src.loc.1=
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.2-SNAPSHOT/commons-pool2-${c
> > ommons-pool.version}-src.tar.gz
> > 173 commons-pool-src.loc.2=
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-pool2/2.2-SNAPSHOT/commons-pool2-${c
> > ommons-pool.version}-src.tar.gz
> >
> >
> > After modifying those 3 lines, it works.
>
> The CI server that produces snapshots was off-line for several months
> and came back today. That resulted in all the snapshots being updated
> and the old ones were removed.
>
> Right now trunk should actually be using the 2.1 release rather than the
> snapshot. I'll get that fixed later today.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
