Re: [VOTE] Release Apache Tomcat 9.0.92

2024-07-31 Thread Rémy Maucherat
On Tue, Jul 30, 2024 at 7:06 PM Christopher Schultz
 wrote:
>
> Rémy,
>
> Thanks for RMing.
>
> On 7/29/24 11:32 PM, Rémy Maucherat wrote:
> > The proposed Apache Tomcat 9.0.92 release is now available for voting.
> >
> > The notable changes compared to 9.0.91 are:
> >
> > - Align HTTP/2 with HTTP/1.1 and recycle the container internal request
> > and response processing objects by default. This behaviour can be
> > controlled via the new discardRequestsAndResponses attribute on the
> > HTTP/2 upgrade protocol.
> >
> > - Add OpenSSL support for FFM. Using this feature requires Java 22
> > or newer.
> >
> > - Add support for RFC 8297 (Early Hints). Applications can use this
> > feature by casting the HttpServletResponse to
> > org.apache.catalina.connector.Reponse and then calling the method
> > void sendEarlyHints()
> >
> > For full details, see the changelog:
> > https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.92/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1505
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/9.0.92
> > b6ca266795a4245f3c3308a619987136ad46e19a
> >
> > The proposed 9.0.92 release is:
> > [ ] -1, Broken - do not release
> > [ ] +1, Stable - go ahead and release as 9.0.92
>
> +1 for stable release.
>
> The build is reproducible[*] and the unit tests pass on MacOS x86-64.
>
> [*] The fulldocs package is not identical. Usually this is because of
> LICENSE files and stuff like that, but this is not the case this time.
> Instead, the documentation is actually different. My locally-built
> fulldocs package includes references to the Jre22Compat class while
> yours includes references to the Jre19Compat class and some other
> semingly-related differences.

The fulldocs at
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.92/bin/apache-tomcat-9.0.92-fulldocs.tar.gz
does have Jre22Compat. Jre19Compat has not been removed.

Rémy

>
> Since the fulldocs package is not executable, I don't think there is any
> reason to block the release.
>
> Works with a vanilla servlet-based application in a development environment.
>
> Details:
> * Environment
> *  Java (build):openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime
> Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM
> Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
> *  Java (test): openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime
> Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM
> Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
> *  Ant: Apache Ant(TM) version 1.10.14 compiled on August 16
> 2023
> *  OS:  Darwin 21.6.0 x86_64
> *  cc:  Apple clang version 12.0.0 (clang-1200.0.31.1)
> *  make:GNU Make 3.81
> *  OpenSSL: OpenSSL 3.2.1 30 Jan 2024 (Library: OpenSSL 3.2.1 30
> Jan 2024)
> *  APR: 1.7.4
> *
> * Valid SHA-512 signature for apache-tomcat-9.0.92.zip
> * Valid GPG signature for apache-tomcat-9.0.92.zip
> * Valid SHA-512 signature for apache-tomcat-9.0.92.tar.gz
> * Valid GPG signature for apache-tomcat-9.0.92.tar.gz
> * Valid SHA-512 signature for apache-tomcat-9.0.92.exe
> * Valid GPG signature for apache-tomcat-9.0.92.exe
> * Valid SHA512 signature for apache-tomcat-9.0.92-src.zip
> * Valid GPG signature for apache-tomcat-9.0.92-src.zip
> * Valid SHA512 signature for apache-tomcat-9.0.92-src.tar.gz
> * Valid GPG signature for apache-tomcat-9.0.92-src.tar.gz
> *
> * Binary Zip and tarball: Same
> * Source Zip and tarball: Same
> *
> * Building dependencies returned: 0
> * tcnative builds cleanly
> * Tomcat builds cleanly
> * Junit Tests: PASSED
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69234] Parallel deployment not working with tomcat 11

2024-07-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69234

--- Comment #1 from Mark Thomas  ---
Comnfirmed. As a work-around if you manually unpack the WAR that should work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69234] Parallel deployment not working with tomcat 11

2024-07-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69234

--- Comment #2 from mattia.paglia...@zerob.it ---
(In reply to Mark Thomas from comment #1)
> Comnfirmed. As a work-around if you manually unpack the WAR that should work.

you mean by disabling autodeploy ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69234] Parallel deployment not working with tomcat 11

2024-07-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69234

--- Comment #3 from Mark Thomas  ---
The simplest approach is to unpack the WAR (any unzip tool should work)
somewhere and then copy the unpacked directory structure to
$CATALINA_BASE/webapps rather than copying the WAR to $CATALINA_BASE/webapps

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69234] Parallel deployment not working with tomcat 11

2024-07-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69234

--- Comment #4 from Mark Thomas  ---
Found the root cause.

This refactoring:
https://github.com/apache/tomcat/commit/e9d1404b2d8c7713847592023771d58e032423c5

is causing double encoding. Working on a fix now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.92

2024-07-31 Thread Christopher Schultz

Rémy,

On 7/31/24 04:14, Rémy Maucherat wrote:

On Tue, Jul 30, 2024 at 7:06 PM Christopher Schultz
 wrote:


Rémy,

Thanks for RMing.

On 7/29/24 11:32 PM, Rémy Maucherat wrote:

The proposed Apache Tomcat 9.0.92 release is now available for voting.

The notable changes compared to 9.0.91 are:

- Align HTTP/2 with HTTP/1.1 and recycle the container internal request
 and response processing objects by default. This behaviour can be
 controlled via the new discardRequestsAndResponses attribute on the
 HTTP/2 upgrade protocol.

- Add OpenSSL support for FFM. Using this feature requires Java 22
 or newer.

- Add support for RFC 8297 (Early Hints). Applications can use this
 feature by casting the HttpServletResponse to
 org.apache.catalina.connector.Reponse and then calling the method
 void sendEarlyHints()

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.92/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1505

The tag is:
https://github.com/apache/tomcat/tree/9.0.92
b6ca266795a4245f3c3308a619987136ad46e19a

The proposed 9.0.92 release is:
[ ] -1, Broken - do not release
[ ] +1, Stable - go ahead and release as 9.0.92


+1 for stable release.

The build is reproducible[*] and the unit tests pass on MacOS x86-64.

[*] The fulldocs package is not identical. Usually this is because of
LICENSE files and stuff like that, but this is not the case this time.
Instead, the documentation is actually different. My locally-built
fulldocs package includes references to the Jre22Compat class while
yours includes references to the Jre19Compat class and some other
semingly-related differences.


The fulldocs at
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.92/bin/apache-tomcat-9.0.92-fulldocs.tar.gz
does have Jre22Compat. Jre19Compat has not been removed.


Yes, I understand, but diffoscope is showing me that in the fulldocs 
package, the Javadoc APIs are referencing Jre19Compat instead of 
Jre22Compat.


I'm puzzled, but since it's just documentation I don't really care that 
much.


-chris


Since the fulldocs package is not executable, I don't think there is any
reason to block the release.

Works with a vanilla servlet-based application in a development environment.

Details:
* Environment
*  Java (build):openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime
Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM
Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
*  Java (test): openjdk version "22.0.1" 2024-04-16 OpenJDK Runtime
Environment Temurin-22.0.1+8 (build 22.0.1+8) OpenJDK 64-Bit Server VM
Temurin-22.0.1+8 (build 22.0.1+8, mixed mode)
*  Ant: Apache Ant(TM) version 1.10.14 compiled on August 16
2023
*  OS:  Darwin 21.6.0 x86_64
*  cc:  Apple clang version 12.0.0 (clang-1200.0.31.1)
*  make:GNU Make 3.81
*  OpenSSL: OpenSSL 3.2.1 30 Jan 2024 (Library: OpenSSL 3.2.1 30
Jan 2024)
*  APR: 1.7.4
*
* Valid SHA-512 signature for apache-tomcat-9.0.92.zip
* Valid GPG signature for apache-tomcat-9.0.92.zip
* Valid SHA-512 signature for apache-tomcat-9.0.92.tar.gz
* Valid GPG signature for apache-tomcat-9.0.92.tar.gz
* Valid SHA-512 signature for apache-tomcat-9.0.92.exe
* Valid GPG signature for apache-tomcat-9.0.92.exe
* Valid SHA512 signature for apache-tomcat-9.0.92-src.zip
* Valid GPG signature for apache-tomcat-9.0.92-src.zip
* Valid SHA512 signature for apache-tomcat-9.0.92-src.tar.gz
* Valid GPG signature for apache-tomcat-9.0.92-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: PASSED


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.92

2024-07-31 Thread Coty Sutherland
On Mon, Jul 29, 2024 at 11:33 PM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.92 release is now available for voting.
>
> The notable changes compared to 9.0.91 are:
>
> - Align HTTP/2 with HTTP/1.1 and recycle the container internal request
>and response processing objects by default. This behaviour can be
>controlled via the new discardRequestsAndResponses attribute on the
>HTTP/2 upgrade protocol.
>
> - Add OpenSSL support for FFM. Using this feature requires Java 22
>or newer.
>
> - Add support for RFC 8297 (Early Hints). Applications can use this
>feature by casting the HttpServletResponse to
>org.apache.catalina.connector.Reponse and then calling the method
>void sendEarlyHints()
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.92/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1505
>
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.92
> b6ca266795a4245f3c3308a619987136ad46e19a
>
> The proposed 9.0.92 release is:
> [ ] -1, Broken - do not release
> [x] +1, Stable - go ahead and release as 9.0.92
>

+1, LGTM on Fedora 39


>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


(tomcat) branch main updated (a10c7d650b -> 808cebd68c)

2024-07-31 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


from a10c7d650b Support running FFM tests with OpenSSL on MacOS
 new eb6a46861c Add test case for BZ 69234 - URLs for WARs with version 
information
 new 808cebd68c Fix BZ 69234 - fix regression - URL->URI refactor broke 
parallel deploy

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 java/org/apache/tomcat/util/buf/UriUtil.java   |  3 ++-
 test/org/apache/tomcat/util/buf/TesterUriUtilBase.java | 18 ++
 webapps/docs/changelog.xml |  9 +
 3 files changed, 29 insertions(+), 1 deletion(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) 02/02: Fix BZ 69234 - fix regression - URL->URI refactor broke parallel deploy

2024-07-31 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 808cebd68c19692fa1f4190fe922b2080ebaeccb
Author: Mark Thomas 
AuthorDate: Wed Jul 31 16:12:05 2024 +0100

Fix BZ 69234 - fix regression - URL->URI refactor broke parallel deploy

https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
---
 java/org/apache/tomcat/util/buf/UriUtil.java | 3 ++-
 webapps/docs/changelog.xml   | 9 +
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/tomcat/util/buf/UriUtil.java 
b/java/org/apache/tomcat/util/buf/UriUtil.java
index a86292128f..29e80d3453 100644
--- a/java/org/apache/tomcat/util/buf/UriUtil.java
+++ b/java/org/apache/tomcat/util/buf/UriUtil.java
@@ -128,7 +128,8 @@ public final class UriUtil {
 }
 URI uri;
 try {
-uri = new URI("jar", sb.toString(), null);
+// Have to use the single argument constructor as that is the only 
one that doesn't escape input.
+uri = new URI("jar:" + sb.toString());
 } catch (URISyntaxException e) {
 throw new IOException(e);
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 0ec2846316..68ff622d86 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,15 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+69234: Fix a regression caused by the refactoring to use
+java.net.URI rather than java.net.URL that
+broke support for parallel deployment with WAR files. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) 01/02: Add test case for BZ 69234 - URLs for WARs with version information

2024-07-31 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit eb6a46861c99efff1177d026582913f3afa80691
Author: Mark Thomas 
AuthorDate: Wed Jul 31 15:57:15 2024 +0100

Add test case for BZ 69234 - URLs for WARs with version information

e.g. test##001.war

https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
---
 test/org/apache/tomcat/util/buf/TesterUriUtilBase.java | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java 
b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
index 1de4724130..8356783e30 100644
--- a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
+++ b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
@@ -86,6 +86,24 @@ public abstract class TesterUriUtilBase {
 }
 
 
+@Test
+public void testBuildJarUrl05() throws IOException {
+File jarFile = new File("/patha/pathb/pathc/war##001.war");
+String result = UriUtil.buildJarUrl(jarFile).toString();
+
+int index = result.indexOf("!/");
+Assert.assertEquals(result, result.length() - 2, index);
+
+index = result.indexOf(separator + "/");
+Assert.assertEquals(result, -1, index);
+
+// Ensure there is no double decoding
+// https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
+index = result.indexOf("%25");
+Assert.assertEquals(result, -1, index);
+}
+
+
 @Test
 public void testWarToJar02() throws IOException {
 doTestWarToJar("*");


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69234] Parallel deployment not working with tomcat 11

2024-07-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69234

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Mark Thomas  ---
Only 11.0.x is affected.

This has been fixed in 11.0.x for 11.0.0-M24 onwards.

Mark

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 10.1.x updated: Add test case for BZ 69234 - URLs for WARs with version information

2024-07-31 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new dd9b9a4bfb Add test case for BZ 69234 - URLs for WARs with version 
information
dd9b9a4bfb is described below

commit dd9b9a4bfbfbb6504c55b484f8d0569e523c2ff6
Author: Mark Thomas 
AuthorDate: Wed Jul 31 15:57:15 2024 +0100

Add test case for BZ 69234 - URLs for WARs with version information

e.g. test##001.war

https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
---
 test/org/apache/tomcat/util/buf/TesterUriUtilBase.java | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java 
b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
index b176788bf4..918a913c3e 100644
--- a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
+++ b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
@@ -85,6 +85,24 @@ public abstract class TesterUriUtilBase {
 }
 
 
+@Test
+public void testBuildJarUrl05() throws MalformedURLException {
+File jarFile = new File("/patha/pathb/pathc/war##001.war");
+String result = UriUtil.buildJarUrl(jarFile).toString();
+
+int index = result.indexOf("!/");
+Assert.assertEquals(result, result.length() - 2, index);
+
+index = result.indexOf(separator + "/");
+Assert.assertEquals(result, -1, index);
+
+// Ensure there is no double decoding
+// https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
+index = result.indexOf("%25");
+Assert.assertEquals(result, -1, index);
+}
+
+
 @Test
 public void testWarToJar01() throws MalformedURLException {
 doTestWarToJar("^");


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 9.0.x updated: Add test case for BZ 69234 - URLs for WARs with version information

2024-07-31 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 4bbc383f0f Add test case for BZ 69234 - URLs for WARs with version 
information
4bbc383f0f is described below

commit 4bbc383f0fae6eaf8bb151401a3d3ad8db94901a
Author: Mark Thomas 
AuthorDate: Wed Jul 31 15:57:15 2024 +0100

Add test case for BZ 69234 - URLs for WARs with version information

e.g. test##001.war

https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
---
 test/org/apache/tomcat/util/buf/TesterUriUtilBase.java | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java 
b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
index b176788bf4..918a913c3e 100644
--- a/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
+++ b/test/org/apache/tomcat/util/buf/TesterUriUtilBase.java
@@ -85,6 +85,24 @@ public abstract class TesterUriUtilBase {
 }
 
 
+@Test
+public void testBuildJarUrl05() throws MalformedURLException {
+File jarFile = new File("/patha/pathb/pathc/war##001.war");
+String result = UriUtil.buildJarUrl(jarFile).toString();
+
+int index = result.indexOf("!/");
+Assert.assertEquals(result, result.length() - 2, index);
+
+index = result.indexOf(separator + "/");
+Assert.assertEquals(result, -1, index);
+
+// Ensure there is no double decoding
+// https://bz.apache.org/bugzilla/show_bug.cgi?id=69234
+index = result.indexOf("%25");
+Assert.assertEquals(result, -1, index);
+}
+
+
 @Test
 public void testWarToJar01() throws MalformedURLException {
 doTestWarToJar("^");


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Buildbot success in on tomcat-11.0.x

2024-07-31 Thread buildbot
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/1213
Blamelist: Mark Thomas 
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch main] 808cebd68c19692fa1f4190fe922b2080ebaeccb


Steps:

  worker_preparation: 0

  git: 0

  shell: 0

  shell_1: 0

  shell_2: 0

  shell_3: 0

  shell_4: 0

  shell_5: 0

  shell_6: 0

  compile: 1

  shell_7: 0

  shell_8: 0

  shell_9: 0

  shell_10: 0

  Rsync docs to nightlies.apache.org: 0

  shell_11: 0

  Rsync RAT to nightlies.apache.org: 0

  compile_1: 1

  shell_12: 0

  Rsync Logs to nightlies.apache.org: 0


-- ASF Buildbot


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Buildbot failure in on tomcat-10.1.x

2024-07-31 Thread buildbot
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot 
repository (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/44/builds/1346
Blamelist: Mark Thomas 
Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure)
Status Detected: new failure
Build Source Stamp: [branch 10.1.x] dd9b9a4bfbfbb6504c55b484f8d0569e523c2ff6


Steps:

  worker_preparation: 0

  git: 0

  shell: 0

  shell_1: 0

  shell_2: 0

  shell_3: 0

  shell_4: 0

  shell_5: 0

  compile: 1

  shell_6: 0

  shell_7: 0

  shell_8: 2


-- ASF Buildbot


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.27

2024-07-31 Thread Christopher Schultz

All,

On 7/30/24 11:56, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.27 release is now available for
voting.

All committers and PMC members are kindly requested to provide a vote if 
possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes are 
binding. We welcome non-committer votes or comments on release builds.


The notable changes compared to 10.1.26 are:

- Add support for RFC 8297 (Early Hints). Applications can use this
   feature by casting the HttpServletResponse to
   org.apache.catalina.connector.Reponse and then calling the method
   void sendEarlyHints()

- Align HTTP/2 with HTTP/1.1 and recycle the container internal request
   and response processing objects by default. This behaviour can be
   controlled via the new discardRequestsAndResponses attribute on the
   HTTP/2 upgrade protocol.

- Ensure statements returned from Statement methods executeQuery(),
   getResultSet() and getGeneratedKeys() are correctly wrapped before
   being returned to the caller.

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.27/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1506

The tag is:
https://github.com/apache/tomcat/tree/10.1.27
https://github.com/apache/tomcat/commit/50d264f3bc6c8595a1e611940668fb46d076e0ba

Please reply with a +1 for release or +0/-0/-1 with an explanation.


+1 for stable release.

Unit tests pass on MacOS except for some which require special 
configuration in this environment. Taking the build script from 10.1.x/ 
branch and re-running these tests yields a pass.


Works on a vanilla-servlet application in a development environment -- 
including auto-migration of a JavaEE-based application.


Details:

* Environment
*  Testing Apache Tomcat  10.1.27
*  Java (build):openjdk version "22.0.2" 2024-07-16 OpenJDK Runtime 
Environment Temurin-22.0.2+9 (build 22.0.2+9) OpenJDK 64-Bit Server VM 
Temurin-22.0.2+9 (build 22.0.2+9, mixed mode)

*  Java (test): 22 ( openjdk version "22.0.2" 2024-07-16
*  OS:  Darwin 23.5.0 x86_64
*  cc:  Apple clang version 12.0.5 (clang-1205.0.22.9)
*  make:GNU Make 3.81
*  OpenSSL: OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 
Jun 2024)

*  APR: 1.7.4
*
* Valid SHA-512 signature for apache-tomcat-10.1.27.zip
* Valid GPG signature for apache-tomcat-10.1.27.zip
* Valid SHA-512 signature for apache-tomcat-10.1.27.tar.gz
* Valid GPG signature for apache-tomcat-10.1.27.tar.gz
* Valid SHA-512 signature for apache-tomcat-10.1.27.exe
* Valid GPG signature for apache-tomcat-10.1.27.exe
* Valid Windows Digital Signature for apache-tomcat-10.1.27.exe
* Valid SHA512 signature for apache-tomcat-10.1.27-src.zip
* Valid GPG signature for apache-tomcat-10.1.27-src.zip
* Valid SHA512 signature for apache-tomcat-10.1.27-src.tar.gz
* Valid GPG signature for apache-tomcat-10.1.27-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:^H^H^H^H^H^H^Hpassed:
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO.txt
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO2.txt
* org.apache.tomcat.util.net.TestClientCert.NIO.txt
* org.apache.tomcat.util.net.TestClientCert.NIO2.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO2.txt
* org.apache.tomcat.util.net.TestCustomSslTrustManager.NIO.txt
* org.apache.tomcat.util.net.TestCustomSslTrustManager.NIO2.txt

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org