TestDataSourceUserDatabase and TestDataSourceRealm need Java 17

2024-06-18 Thread Rainer Jung

Hi there,

the test classes org.apache.catalina.users.TestDataSourceUserDatabase 
and org.apache.catalina.realm.TestDataSourceRealm have a filing test 
which needs Java 17 due to the class version of 
org/apache/derby/jdbc/EmbeddedDriver. For TC 10.1 this leads to failures 
when testing with JDK 11-16.


Details:

Testcase: testBasicUserRoleDatabase took 0.749 sec
Caused an ERROR
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of 
the Java Runtime only recognizes class file versions up to 55.0
java.lang.UnsupportedClassVersionError: 
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of 
the Java Runtime only recognizes class file versions up to 55.0

at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at 
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)

at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:315)
at 
org.apache.catalina.users.TestDataSourceUserDatabase$DerbyUserDatabase.open(TestDataSourceUserDatabase.java:103)
at 
org.apache.catalina.users.TestDataSourceUserDatabase.testBasicUserRoleDatabase(TestDataSourceUserDatabase.java:131)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


and

Testcase: testRealm took 1.298 sec
Caused an ERROR
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of 
the Java Runtime only recognizes class file versions up to 55.0
java.lang.UnsupportedClassVersionError: 
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of 
the Java Runtime only recognizes class file versions up to 55.0

at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at 
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
at 
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
at 
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)

at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:315)
at 
org.apache.catalina.realm.TestDataSourceRealm$DerbyDataSourceRealm.open(TestDataSourceRealm.java:61)
at 
org.apache.catalina.realm.TestDataSourceRealm.testRealm(TestDataSourceRealm.java:106)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)



Best regards,

Rainer



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



panama test TestOpenSSLConf.testOpenSSLConfCmdCipher() failing

2024-06-18 Thread Rainer Jung

Hi all,

when testing 11.0.0-M21 and 10.1.25 I observe new failures in panama:

Testcase: 
testOpenSSLConfCmdCipher[org.apache.tomcat.util.net.openssl.panama.OpenSSLImplementation] 
took 4.438 sec

FAILED
Wrong HostConfig ciphers
Expected: is ["AES256-SHA256"]
 but: was ["TLS_AES_256_GCM_SHA384", 
"TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]

junit.framework.AssertionFailedError: Wrong HostConfig ciphers
Expected: is ["AES256-SHA256"]
 but: was ["TLS_AES_256_GCM_SHA384", 
"TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]

at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at 
org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher(TestOpenSSLConf.java:132)
at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)


The test was done with the recent releases of OpenSSL 3.0, 3.1, 3.2 and 
3.3. All of them fail in the same way.


Best regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



jakarta.el.TestImportHandlerStandardPackages fails for JDK 23

2024-06-18 Thread Rainer Jung

Hi all,

I observe test failures for jakarta.el.TestImportHandlerStandardPackages 
on JDK 23:


Testsuite: jakarta.el.TestImportHandlerStandardPackages
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.593 sec

Testcase: testClassListsAreComplete took 0.525 sec
FAILED
java.lang.ScopedValue.CallableOp
junit.framework.AssertionFailedError: java.lang.ScopedValue.CallableOp
at 
jakarta.el.TestImportHandlerStandardPackages.lambda$checkPackageClassList$13(TestImportHandlerStandardPackages.java:76)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
at 
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
at 
java.base/jdk.internal.module.SystemModuleFinders$ModuleContentSpliterator.tryAdvance(SystemModuleFinders.java:573)
at 
java.base/java.util.Spliterator.forEachRemaining(Spliterator.java:332)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:636)
at 
jakarta.el.TestImportHandlerStandardPackages.checkPackageClassList(TestImportHandlerStandardPackages.java:76)
at 
jakarta.el.TestImportHandlerStandardPackages.testClassListsAreComplete(TestImportHandlerStandardPackages.java:46)
at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)



I am using the current JDK 23 EA 27.

Best regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: TestDataSourceUserDatabase and TestDataSourceRealm need Java 17

2024-06-18 Thread Rémy Maucherat
On Tue, Jun 18, 2024 at 9:45 AM Rainer Jung  wrote:
>
> Hi there,
>
> the test classes org.apache.catalina.users.TestDataSourceUserDatabase
> and org.apache.catalina.realm.TestDataSourceRealm have a filing test
> which needs Java 17 due to the class version of
> org/apache/derby/jdbc/EmbeddedDriver. For TC 10.1 this leads to failures
> when testing with JDK 11-16.

More build dependencies now need Java 17 for the testsuite (bnd in
particular, and even the Ant from my Fedora ...). How do you work
around that to reach the test ?

Rémy

> Details:
>
> Testcase: testBasicUserRoleDatabase took 0.749 sec
>  Caused an ERROR
> org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
> version of the Java Runtime (class file version 61.0), this version of
> the Java Runtime only recognizes class file versions up to 55.0
> java.lang.UnsupportedClassVersionError:
> org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
> version of the Java Runtime (class file version 61.0), this version of
> the Java Runtime only recognizes class file versions up to 55.0
>  at java.base/java.lang.ClassLoader.defineClass1(Native Method)
>  at
> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
>  at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
>  at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
>  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
>  at java.base/java.lang.Class.forName0(Native Method)
>  at java.base/java.lang.Class.forName(Class.java:315)
>  at
> org.apache.catalina.users.TestDataSourceUserDatabase$DerbyUserDatabase.open(TestDataSourceUserDatabase.java:103)
>  at
> org.apache.catalina.users.TestDataSourceUserDatabase.testBasicUserRoleDatabase(TestDataSourceUserDatabase.java:131)
>  at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
>  at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> and
>
> Testcase: testRealm took 1.298 sec
>  Caused an ERROR
> org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
> version of the Java Runtime (class file version 61.0), this version of
> the Java Runtime only recognizes class file versions up to 55.0
> java.lang.UnsupportedClassVersionError:
> org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
> version of the Java Runtime (class file version 61.0), this version of
> the Java Runtime only recognizes class file versions up to 55.0
>  at java.base/java.lang.ClassLoader.defineClass1(Native Method)
>  at
> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
>  at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
>  at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
>  at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
>  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
>  at java.base/java.lang.Class.forName0(Native Method)
>  at java.base/java.lang.Class.forName(Class.java:315)
>  at
> org.apache.catalina.realm.TestDataSourceRealm$DerbyDataSourceRealm.open(TestDataSourceRealm.java:61)
>  at
> org.apache.catalina.realm.TestDataSourceRealm.testRealm(TestDataSourceRealm.java:106)
>  at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
>  at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
>
> Best regards,
>
> Rainer
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, 

(tomcat) branch main updated: Cleanup and log OpenSSL errors before checking commands

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 33273e9132 Cleanup and log OpenSSL errors before checking commands
33273e9132 is described below

commit 33273e91320b3e90371f25843ecd16460941e552
Author: remm 
AuthorDate: Tue Jun 18 11:55:01 2024 +0200

Cleanup and log OpenSSL errors before checking commands

Also fix logic to avoid trying to set "builtin" seed.
---
 .../net/openssl/panama/LocalStrings.properties |  2 +
 .../util/net/openssl/panama/OpenSSLContext.java| 73 +++---
 .../util/net/openssl/panama/OpenSSLEngine.java |  4 +-
 .../util/net/openssl/panama/OpenSSLLibrary.java| 39 +++-
 4 files changed, 65 insertions(+), 53 deletions(-)

diff --git 
a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties 
b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
index 5b4ef5c6ee..b42309b801 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
+++ b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
@@ -51,6 +51,7 @@ openssl.errCheckConf=Error during OpenSSLConf check
 openssl.errMakeConf=Could not create OpenSSLConf context [{0}]
 openssl.errorAddingCertificate=Error adding certificate to chain: [{0}]
 openssl.errorConfiguringLocations=Error configuring CA certificate locations: 
[{0}]
+openssl.errorInit=Non fatal error initializing certificates or configuration: 
[{0}]
 openssl.errorLoadingCertificate=Error loading certificate: [{0}]
 openssl.errorLoadingCertificateWithError=Error loading certificate [{0}] with 
error [{1}]
 openssl.errorLoadingPassword=Error loading password file: [{0}]
@@ -92,6 +93,7 @@ openssllibrary.initializeFIPSFailed=Failed to enter FIPS mode
 openssllibrary.initializeFIPSSuccess=Successfully entered FIPS mode
 openssllibrary.initializedOpenSSL=OpenSSL successfully initialized using FFM 
[{0}]
 openssllibrary.initializingFIPS=Initializing FIPS mode...
+openssllibrary.errorSettingSSLRandomSeed=Setting random seed [{0}] caused 
error [{1}]
 openssllibrary.requireNotInFIPSMode=The listener is configured to require the 
library to already be in FIPS mode, but it was not in FIPS mode
 openssllibrary.skipFIPSInitialization=Already in FIPS mode; skipping FIPS 
initialization.
 openssllibrary.tooLateForFIPSMode=Cannot setFIPSMode: SSL has already been 
initialized
diff --git a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java 
b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
index 4b21075c5b..9a8ba2ea2b 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
+++ b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
@@ -76,8 +76,6 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 
 private static final Cleaner cleaner = Cleaner.create();
 
-private static final int OPENSSL_ERROR_MESSAGE_BUFFER_SIZE = 256;
-
 private static final String defaultProtocol = "TLS";
 
 private static final int SSL_AIDX_RSA = 0;
@@ -179,7 +177,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 }
 confCtx = SSL_CONF_CTX_new();
 if (MemorySegment.NULL.equals(confCtx)) {
-throw new SSLException(sm.getString("openssl.errMakeConf", 
getLastError()));
+throw new SSLException(sm.getString("openssl.errMakeConf", 
OpenSSLLibrary.getLastError()));
 }
 SSL_CONF_CTX_set_flags(confCtx, SSL_CONF_FLAG_FILE() |
 SSL_CONF_FLAG_SERVER() |
@@ -344,7 +342,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 } else {
 int code = SSL_CONF_cmd_value_type(state.confCtx, 
localArena.allocateFrom(name));
 rc = 1;
-String errorMessage = getLastError();
+String errorMessage = OpenSSLLibrary.getLastError();
 if (errorMessage != null) {
 log.error(sm.getString("opensslconf.checkFailed", 
errorMessage));
 rc = 0;
@@ -416,7 +414,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 } else {
 rc = SSL_CONF_cmd(state.confCtx, 
localArena.allocateFrom(name),
 localArena.allocateFrom(value));
-String errorMessage = getLastError();
+String errorMessage = OpenSSLLibrary.getLastError();
 if (rc <= 0 || errorMessage != null) {
 log.error(sm.getString("opensslconf.commandError", 
name, value, errorMessage));
 rc = 0;
@@ -592,6 +5

(tomcat) branch 10.1.x updated: Cleanup and log OpenSSL errors before checking commands

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new cc96ad9c53 Cleanup and log OpenSSL errors before checking commands
cc96ad9c53 is described below

commit cc96ad9c534551ecc8b599b66f14b6f4941a3ed0
Author: remm 
AuthorDate: Tue Jun 18 11:55:01 2024 +0200

Cleanup and log OpenSSL errors before checking commands

Also fix logic to avoid trying to set "builtin" seed.
---
 .../net/openssl/panama/LocalStrings.properties |  2 +
 .../util/net/openssl/panama/OpenSSLContext.java| 73 +++---
 .../util/net/openssl/panama/OpenSSLEngine.java |  4 +-
 .../util/net/openssl/panama/OpenSSLLibrary.java| 39 +++-
 4 files changed, 65 insertions(+), 53 deletions(-)

diff --git 
a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties 
b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
index 1a2f3d83fa..307fa3f4a2 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
+++ b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
@@ -51,6 +51,7 @@ openssl.errCheckConf=Error during OpenSSLConf check
 openssl.errMakeConf=Could not create OpenSSLConf context [{0}]
 openssl.errorAddingCertificate=Error adding certificate to chain: [{0}]
 openssl.errorConfiguringLocations=Error configuring CA certificate locations: 
[{0}]
+openssl.errorInit=Non fatal error initializing certificates or configuration: 
[{0}]
 openssl.errorLoadingCertificate=Error loading certificate: [{0}]
 openssl.errorLoadingCertificateRevocationListWithError=Error loading 
certificate revocation [{0}] with error [{1}]
 openssl.errorLoadingCertificateWithError=Error loading certificate [{0}] with 
error [{1}]
@@ -90,6 +91,7 @@ openssllibrary.initializeFIPSFailed=Failed to enter FIPS mode
 openssllibrary.initializeFIPSSuccess=Successfully entered FIPS mode
 openssllibrary.initializedOpenSSL=OpenSSL successfully initialized using FFM 
[{0}]
 openssllibrary.initializingFIPS=Initializing FIPS mode...
+openssllibrary.errorSettingSSLRandomSeed=Setting random seed [{0}] caused 
error [{1}]
 openssllibrary.requireNotInFIPSMode=The listener is configured to require the 
library to already be in FIPS mode, but it was not in FIPS mode
 openssllibrary.skipFIPSInitialization=Already in FIPS mode; skipping FIPS 
initialization.
 openssllibrary.tooLateForFIPSMode=Cannot setFIPSMode: SSL has already been 
initialized
diff --git a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java 
b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
index 4b21075c5b..9a8ba2ea2b 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
+++ b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
@@ -76,8 +76,6 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 
 private static final Cleaner cleaner = Cleaner.create();
 
-private static final int OPENSSL_ERROR_MESSAGE_BUFFER_SIZE = 256;
-
 private static final String defaultProtocol = "TLS";
 
 private static final int SSL_AIDX_RSA = 0;
@@ -179,7 +177,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 }
 confCtx = SSL_CONF_CTX_new();
 if (MemorySegment.NULL.equals(confCtx)) {
-throw new SSLException(sm.getString("openssl.errMakeConf", 
getLastError()));
+throw new SSLException(sm.getString("openssl.errMakeConf", 
OpenSSLLibrary.getLastError()));
 }
 SSL_CONF_CTX_set_flags(confCtx, SSL_CONF_FLAG_FILE() |
 SSL_CONF_FLAG_SERVER() |
@@ -344,7 +342,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 } else {
 int code = SSL_CONF_cmd_value_type(state.confCtx, 
localArena.allocateFrom(name));
 rc = 1;
-String errorMessage = getLastError();
+String errorMessage = OpenSSLLibrary.getLastError();
 if (errorMessage != null) {
 log.error(sm.getString("opensslconf.checkFailed", 
errorMessage));
 rc = 0;
@@ -416,7 +414,7 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 } else {
 rc = SSL_CONF_cmd(state.confCtx, 
localArena.allocateFrom(name),
 localArena.allocateFrom(value));
-String errorMessage = getLastError();
+String errorMessage = OpenSSLLibrary.getLastError();
 if (rc <= 0 || errorMessage != null) {
 log.error(sm.getString("opensslconf.commandError", 
name, value, error

Re: panama test TestOpenSSLConf.testOpenSSLConfCmdCipher() failing

2024-06-18 Thread Rémy Maucherat
On Tue, Jun 18, 2024 at 9:36 AM Rainer Jung  wrote:
>
> Hi all,
>
> when testing 11.0.0-M21 and 10.1.25 I observe new failures in panama:
>
> Testcase:
> testOpenSSLConfCmdCipher[org.apache.tomcat.util.net.openssl.panama.OpenSSLImplementation]
> took 4.438 sec
>  FAILED
> Wrong HostConfig ciphers
> Expected: is ["AES256-SHA256"]
>   but: was ["TLS_AES_256_GCM_SHA384",
> "TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
> junit.framework.AssertionFailedError: Wrong HostConfig ciphers
> Expected: is ["AES256-SHA256"]
>   but: was ["TLS_AES_256_GCM_SHA384",
> "TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
>  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
>  at
> org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher(TestOpenSSLConf.java:132)
>  at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>
> The test was done with the recent releases of OpenSSL 3.0, 3.1, 3.2 and
> 3.3. All of them fail in the same way.

I'm using OpenSSL 3.2.1 and the test was not failing for me. However,
it was also not working.

There are two issues that left errors on the stack and making the
command check fail:
- Setting a bad value for the random seed (fixed)
- Then an error supposedly about use of the legacy provider somewhere
(no idea where this happens, it's now logged [error:1E08010C:DECODER
routines::unsupported])
Now the command check passes and I don't see any error processing the command.

Rémy

> Best regards,
>
> Rainer
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69139] New: Buy Double Bed Frame Sydney

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69139

Bug ID: 69139
   Summary: Buy Double Bed Frame Sydney
   Product: Tomcat Native
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Library
  Assignee: dev@tomcat.apache.org
  Reporter: vuknite...@gufum.com
  Target Milestone: ---

https://easyhomefurniture.com.au/product-category/bed/double-bed/
Looking to upgrade your bedroom? Consider the Double Bed Frame available in
Sydney, a perfect blend of style and functionality. Crafted from high-quality
materials, this bed frame not only enhances the aesthetic appeal of your room
but also ensures durability and comfort. Its sleek design complements various
interior themes, making it versatile for modern and traditional spaces alike.
Whether you're furnishing a new home or refreshing your current decor, the
Double Bed Frame in Sydney offers a reliable foundation for restful nights and
stylish mornings. Discover the perfect balance of elegance and practicality
with this essential piece of bedroom furniture.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69139] Buy Double Bed Frame Sydney

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69139

Double Bed Frame Sydney  changed:

   What|Removed |Added

 OS||All
URL||https://easyhomefurniture.c
   ||om.au/product-category/bed/
   ||double-bed/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: TestDataSourceUserDatabase and TestDataSourceRealm need Java 17

2024-06-18 Thread Rainer Jung

Am 18.06.24 um 10:37 schrieb Rémy Maucherat:

On Tue, Jun 18, 2024 at 9:45 AM Rainer Jung  wrote:


Hi there,

the test classes org.apache.catalina.users.TestDataSourceUserDatabase
and org.apache.catalina.realm.TestDataSourceRealm have a filing test
which needs Java 17 due to the class version of
org/apache/derby/jdbc/EmbeddedDriver. For TC 10.1 this leads to failures
when testing with JDK 11-16.


More build dependencies now need Java 17 for the testsuite (bnd in
particular, and even the Ant from my Fedora ...). How do you work
around that to reach the test ?


Good point, thanks for asking:

- I provide (recent) ant myselve and add it to the PATH

- I first build everything using the release JDK version, so for 
instance Java 22 (just on one platform, currently RHEL 8).


- for each test platform and JVM version I use a copy of the resulting 
build and output tree and I adjust build.xml to be able to only run the 
tests:


  - I set an additional custom property skip.build.java.version=true in 
build.properties


  - The block "" ist changed from


  


to


  


  


  - the targets setup-bnd and add-osgi get an additional 
unless="skip.build.java.version" to supress them during the pure test run


  - the nio and nio2 test targets are duplicated and slightly adjusted
(dropping the dependencies test-compile and deploy).
Originally:

   

depends="setup-jacoco,test-compile,deploy,test-openssl-exists" 
if="${execute.test.nio}">

 
   

   

depends="setup-jacoco,test-compile,deploy,test-openssl-exists" 
if="${execute.test.nio2}">

 
   

  The added targets:

depends="setup-jacoco,test-openssl-exists" 
f="${execute.test.nio}">


  

depends="setup-jacoco,test-openssl-exists" 
f="${execute.test.nio2}">


  

  - finally the main test target alslo gets a slighty adjusted twin
(drop coverage-report, call the new "only" targets).
Originally

  

   The added target:

  


- call the new "test-only" target.

There are probably more clever ways to achieve this, but that's at least 
what I use to be able to run the tests on older JVM versions.


Since I do not apply changes to the tests temselves, this means, that 
tests assuming a newer JVM version than the minimal runtime version will 
fail when I run them. Of course I can suppress them with test.exclude 
(probably only the whole class, not just individual failing tests?). I 
will do that, if the derby dependency was intentionally updated.


Thanks and regards,

Rainer


Rémy


Details:

Testcase: testBasicUserRoleDatabase took 0.749 sec
  Caused an ERROR
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
version of the Java Runtime (class file version 61.0), this version of
the Java Runtime only recognizes class file versions up to 55.0
java.lang.UnsupportedClassVersionError:
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
version of the Java Runtime (class file version 61.0), this version of
the Java Runtime only recognizes class file versions up to 55.0
  at java.base/java.lang.ClassLoader.defineClass1(Native Method)
  at
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
  at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
  at
java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)
  at
java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698)
  at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621)
  at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
  at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
  at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
  at java.base/java.lang.Class.forName0(Native Method)
  at java.base/java.lang.Class.forName(Class.java:315)
  at
org.apache.catalina.users.TestDataSourceUserDatabase$DerbyUserDatabase.open(TestDataSourceUserDatabase.java:103)
  at
org.apache.catalina.users.TestDataSourceUserDatabase.testBasicUserRoleDatabase(TestDataSourceUserDatabase.java:131)
  at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
  at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

and

Testcase: testRealm took 1.298 sec
  Caused an ERROR
org/apache/derby/jdbc/EmbeddedDriver has been compiled by a more recent
version of the Java Runtime (class file version 61.0), this version of
the Java Runtime only recognizes class file versions up to 55.0
java.lang.UnsupportedClassVersionError:
org/apache/derby

Re: panama test TestOpenSSLConf.testOpenSSLConfCmdCipher() failing

2024-06-18 Thread Rainer Jung

Am 18.06.24 um 12:04 schrieb Rémy Maucherat:

On Tue, Jun 18, 2024 at 9:36 AM Rainer Jung  wrote:


Hi all,

when testing 11.0.0-M21 and 10.1.25 I observe new failures in panama:

Testcase:
testOpenSSLConfCmdCipher[org.apache.tomcat.util.net.openssl.panama.OpenSSLImplementation]
took 4.438 sec
  FAILED
Wrong HostConfig ciphers
Expected: is ["AES256-SHA256"]
   but: was ["TLS_AES_256_GCM_SHA384",
"TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
junit.framework.AssertionFailedError: Wrong HostConfig ciphers
Expected: is ["AES256-SHA256"]
   but: was ["TLS_AES_256_GCM_SHA384",
"TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
  at
org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher(TestOpenSSLConf.java:132)
  at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

The test was done with the recent releases of OpenSSL 3.0, 3.1, 3.2 and
3.3. All of them fail in the same way.


I'm using OpenSSL 3.2.1 and the test was not failing for me. However,
it was also not working.

There are two issues that left errors on the stack and making the
command check fail:
- Setting a bad value for the random seed (fixed)
- Then an error supposedly about use of the legacy provider somewhere
(no idea where this happens, it's now logged [error:1E08010C:DECODER
routines::unsupported])
Now the command check passes and I don't see any error processing the command.


Thanks for checking and improving. I will check the updated version and 
investigate deeper in case it still fails for me. I will also check, 
whether the test is new, or behaves diifferently for OpenSSL 3.2.1 (used 
by you and also by me for the previous release) and 3.2.2 (used by me 
now). But probably not before this evening.


No need to wait with closing the release votes, I guess panama is not 
yet a show-stopper for the vote.



Rémy


Best regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: panama test TestOpenSSLConf.testOpenSSLConfCmdCipher() failing

2024-06-18 Thread Rémy Maucherat
On Tue, Jun 18, 2024 at 12:32 PM Rainer Jung  wrote:
>
> Am 18.06.24 um 12:04 schrieb Rémy Maucherat:
> > On Tue, Jun 18, 2024 at 9:36 AM Rainer Jung  wrote:
> >>
> >> Hi all,
> >>
> >> when testing 11.0.0-M21 and 10.1.25 I observe new failures in panama:
> >>
> >> Testcase:
> >> testOpenSSLConfCmdCipher[org.apache.tomcat.util.net.openssl.panama.OpenSSLImplementation]
> >> took 4.438 sec
> >>   FAILED
> >> Wrong HostConfig ciphers
> >> Expected: is ["AES256-SHA256"]
> >>but: was ["TLS_AES_256_GCM_SHA384",
> >> "TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
> >> junit.framework.AssertionFailedError: Wrong HostConfig ciphers
> >> Expected: is ["AES256-SHA256"]
> >>but: was ["TLS_AES_256_GCM_SHA384",
> >> "TLS_CHACHA20_POLY1305_SHA256", "TLS_AES_128_GCM_SHA256", "AES256-SHA256"]
> >>   at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> >>   at
> >> org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher(TestOpenSSLConf.java:132)
> >>   at
> >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> >>
> >> The test was done with the recent releases of OpenSSL 3.0, 3.1, 3.2 and
> >> 3.3. All of them fail in the same way.
> >
> > I'm using OpenSSL 3.2.1 and the test was not failing for me. However,
> > it was also not working.
> >
> > There are two issues that left errors on the stack and making the
> > command check fail:
> > - Setting a bad value for the random seed (fixed)
> > - Then an error supposedly about use of the legacy provider somewhere
> > (no idea where this happens, it's now logged [error:1E08010C:DECODER
> > routines::unsupported])
> > Now the command check passes and I don't see any error processing the 
> > command.
>
> Thanks for checking and improving. I will check the updated version and
> investigate deeper in case it still fails for me. I will also check,
> whether the test is new, or behaves diifferently for OpenSSL 3.2.1 (used
> by you and also by me for the previous release) and 3.2.2 (used by me
> now). But probably not before this evening.
>
> No need to wait with closing the release votes, I guess panama is not
> yet a show-stopper for the vote.

Ok, I found the root cause: the TLS 1.3 check becomes false if
tomcat-native is not available. Since I had it, the FFM test is
working for me. I'll fix it one way or the other.

This test has a lot more configurations than expected ...

Rémy

> > Rémy
> >
> >> Best regards,
> >>
> >> Rainer
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Add new classes introduced in Java 23

2024-06-18 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 5e286448c8 Add new classes introduced in Java 23
5e286448c8 is described below

commit 5e286448c8dbd96b0dacc921dd9e0713a25a707b
Author: Mark Thomas 
AuthorDate: Tue Jun 18 12:05:11 2024 +0100

Add new classes introduced in Java 23
---
 java/jakarta/el/ImportHandler.java | 1 +
 test/jakarta/el/TestImportHandlerStandardPackages.java | 2 +-
 webapps/docs/changelog.xml | 9 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/jakarta/el/ImportHandler.java 
b/java/jakarta/el/ImportHandler.java
index 8cb86f990e..54b72f839b 100644
--- a/java/jakarta/el/ImportHandler.java
+++ b/java/jakarta/el/ImportHandler.java
@@ -187,6 +187,7 @@ public class ImportHandler {
 javaLangClassNames.add("Runtime.Version");
 javaLangClassNames.add("RuntimePermission");
 javaLangClassNames.add("ScopedValue");
+javaLangClassNames.add("ScopedValue.CallableOp");
 javaLangClassNames.add("ScopedValue.Carrier");
 javaLangClassNames.add("SecurityManager");
 javaLangClassNames.add("Short");
diff --git a/test/jakarta/el/TestImportHandlerStandardPackages.java 
b/test/jakarta/el/TestImportHandlerStandardPackages.java
index b93b06e586..1d4485e53c 100644
--- a/test/jakarta/el/TestImportHandlerStandardPackages.java
+++ b/test/jakarta/el/TestImportHandlerStandardPackages.java
@@ -54,7 +54,7 @@ public class TestImportHandlerStandardPackages {
 // The intention is that this test will catch new classes when the
 // tests are run on a newer JRE.
 // The latest version of the JRE where this test is known to pass 
is
-// - OpenJDK 19 EA 22
+// - OpenJDK 24 EA 2
 
ModuleFinder.ofSystem().find("java.base").get().open().list().filter(c -> 
(c.startsWith("java/lang/")))
 .filter(c -> c.lastIndexOf('/') == 9) // Exclude 
sub-packages
 .filter(c -> c.endsWith(".class")) // Exclude non-class 
resources
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 50b7674cc2..4ab75b9846 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -115,6 +115,15 @@
   
 
   
+  
+
+  
+Update the optimisation in jakarta.el.ImportHandler so it
+is aware of new classes added to the java.lang package in
+Java 23. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 10.1.x updated: Add new classes introduced in Java 23

2024-06-18 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 5b13ff2893 Add new classes introduced in Java 23
5b13ff2893 is described below

commit 5b13ff2893090aea70e0c4cdb3e70b76ae42f220
Author: Mark Thomas 
AuthorDate: Tue Jun 18 12:05:11 2024 +0100

Add new classes introduced in Java 23
---
 java/jakarta/el/ImportHandler.java | 1 +
 test/jakarta/el/TestImportHandlerStandardPackages.java | 2 +-
 webapps/docs/changelog.xml | 9 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/jakarta/el/ImportHandler.java 
b/java/jakarta/el/ImportHandler.java
index 70c955548e..b70cdb4d94 100644
--- a/java/jakarta/el/ImportHandler.java
+++ b/java/jakarta/el/ImportHandler.java
@@ -186,6 +186,7 @@ public class ImportHandler {
 javaLangClassNames.add("Runtime.Version");
 javaLangClassNames.add("RuntimePermission");
 javaLangClassNames.add("ScopedValue");
+javaLangClassNames.add("ScopedValue.CallableOp");
 javaLangClassNames.add("ScopedValue.Carrier");
 javaLangClassNames.add("SecurityManager");
 javaLangClassNames.add("Short");
diff --git a/test/jakarta/el/TestImportHandlerStandardPackages.java 
b/test/jakarta/el/TestImportHandlerStandardPackages.java
index b93b06e586..1d4485e53c 100644
--- a/test/jakarta/el/TestImportHandlerStandardPackages.java
+++ b/test/jakarta/el/TestImportHandlerStandardPackages.java
@@ -54,7 +54,7 @@ public class TestImportHandlerStandardPackages {
 // The intention is that this test will catch new classes when the
 // tests are run on a newer JRE.
 // The latest version of the JRE where this test is known to pass 
is
-// - OpenJDK 19 EA 22
+// - OpenJDK 24 EA 2
 
ModuleFinder.ofSystem().find("java.base").get().open().list().filter(c -> 
(c.startsWith("java/lang/")))
 .filter(c -> c.lastIndexOf('/') == 9) // Exclude 
sub-packages
 .filter(c -> c.endsWith(".class")) // Exclude non-class 
resources
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5a5aef0b70..707595b761 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,15 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Update the optimisation in jakarta.el.ImportHandler so it
+is aware of new classes added to the java.lang package in
+Java 23. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 9.0.x updated: Add new classes introduced in Java 23

2024-06-18 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 544f8d176c Add new classes introduced in Java 23
544f8d176c is described below

commit 544f8d176cf17758b87c50663545efb2af01d980
Author: Mark Thomas 
AuthorDate: Tue Jun 18 12:05:11 2024 +0100

Add new classes introduced in Java 23
---
 java/javax/el/ImportHandler.java | 1 +
 test/javax/el/TestImportHandlerStandardPackages.java | 2 +-
 webapps/docs/changelog.xml   | 9 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/javax/el/ImportHandler.java b/java/javax/el/ImportHandler.java
index b51c1bb07d..ee8fa97899 100644
--- a/java/javax/el/ImportHandler.java
+++ b/java/javax/el/ImportHandler.java
@@ -187,6 +187,7 @@ public class ImportHandler {
 javaLangClassNames.add("Runtime.Version");
 javaLangClassNames.add("RuntimePermission");
 javaLangClassNames.add("ScopedValue");
+javaLangClassNames.add("ScopedValue.CallableOp");
 javaLangClassNames.add("ScopedValue.Carrier");
 javaLangClassNames.add("SecurityManager");
 javaLangClassNames.add("Short");
diff --git a/test/javax/el/TestImportHandlerStandardPackages.java 
b/test/javax/el/TestImportHandlerStandardPackages.java
index 0fad5b69ff..ca5106215d 100644
--- a/test/javax/el/TestImportHandlerStandardPackages.java
+++ b/test/javax/el/TestImportHandlerStandardPackages.java
@@ -60,7 +60,7 @@ public class TestImportHandlerStandardPackages {
 // every test run. The intention is that it will catch new classes
 // when the tests are run on a newer JRE.
 // The latest version of the JRE where this test is known to pass 
is
-// - OpenJDK 19 EA 22
+// - OpenJDK 24 EA 2
 if (!JreCompat.isJre9Available()) {
 return;
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index adf1d27ef2..274924aa06 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -115,6 +115,15 @@
   
 
   
+  
+
+  
+Update the optimisation in jakarta.el.ImportHandler so it
+is aware of new classes added to the java.lang package in
+Java 23. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Use FFM to get OpenSSL version

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 163786c0db Use FFM to get OpenSSL version
163786c0db is described below

commit 163786c0db798e07b0897f828318ae2ce04a389b
Author: remm 
AuthorDate: Tue Jun 18 13:30:55 2024 +0200

Use FFM to get OpenSSL version

This should fix the testOpenSSLConfCmdCipher test when tomcat-native is
not available.
---
 test/org/apache/tomcat/util/net/TesterSupport.java | 15 +++
 webapps/docs/changelog.xml |  4 
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/test/org/apache/tomcat/util/net/TesterSupport.java 
b/test/org/apache/tomcat/util/net/TesterSupport.java
index f8055d52ca..d663bfe40c 100644
--- a/test/org/apache/tomcat/util/net/TesterSupport.java
+++ b/test/org/apache/tomcat/util/net/TesterSupport.java
@@ -63,6 +63,7 @@ import org.apache.catalina.startup.Tomcat;
 import org.apache.tomcat.jni.Library;
 import org.apache.tomcat.jni.LibraryNotFoundError;
 import org.apache.tomcat.jni.SSL;
+import org.apache.tomcat.util.compat.JreCompat;
 import org.apache.tomcat.util.descriptor.web.LoginConfig;
 import org.apache.tomcat.util.descriptor.web.SecurityCollection;
 import org.apache.tomcat.util.descriptor.web.SecurityConstraint;
@@ -105,10 +106,16 @@ public final class TesterSupport {
 int version = 0;
 String err = "";
 try {
-Library.initialize(null);
-available = true;
-version = SSL.version();
-Library.terminate();
+if (JreCompat.isJre22Available()) {
+// Try with FFM
+Class openSSL = 
Class.forName("org.apache.tomcat.util.openssl.openssl_h");
+version = ((Long) 
openSSL.getMethod("OpenSSL_version_num").invoke(null)).intValue();
+} else {
+Library.initialize(null);
+available = true;
+version = SSL.version();
+Library.terminate();
+}
 } catch (Exception | LibraryNotFoundError ex) {
 err = ex.getMessage();
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 4ab75b9846..7aac4068e6 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -113,6 +113,10 @@
 addresses. Interfaces that are configured for point to point 
connections
 or are not currently up are now skipped. (markt)
   
+  
+Clean and log OpenSSL errors before processing of OpenSSL conf commands
+in the FFM code. (remm)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 10.1.x updated: Use FFM to get OpenSSL version

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 131f5a640a Use FFM to get OpenSSL version
131f5a640a is described below

commit 131f5a640a4925f3911c3cf9f54a5efca0843bcf
Author: remm 
AuthorDate: Tue Jun 18 13:30:55 2024 +0200

Use FFM to get OpenSSL version

This should fix the testOpenSSLConfCmdCipher test when tomcat-native is
not available.
---
 test/org/apache/tomcat/util/net/TesterSupport.java | 15 +++
 webapps/docs/changelog.xml |  8 
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/test/org/apache/tomcat/util/net/TesterSupport.java 
b/test/org/apache/tomcat/util/net/TesterSupport.java
index f8055d52ca..d663bfe40c 100644
--- a/test/org/apache/tomcat/util/net/TesterSupport.java
+++ b/test/org/apache/tomcat/util/net/TesterSupport.java
@@ -63,6 +63,7 @@ import org.apache.catalina.startup.Tomcat;
 import org.apache.tomcat.jni.Library;
 import org.apache.tomcat.jni.LibraryNotFoundError;
 import org.apache.tomcat.jni.SSL;
+import org.apache.tomcat.util.compat.JreCompat;
 import org.apache.tomcat.util.descriptor.web.LoginConfig;
 import org.apache.tomcat.util.descriptor.web.SecurityCollection;
 import org.apache.tomcat.util.descriptor.web.SecurityConstraint;
@@ -105,10 +106,16 @@ public final class TesterSupport {
 int version = 0;
 String err = "";
 try {
-Library.initialize(null);
-available = true;
-version = SSL.version();
-Library.terminate();
+if (JreCompat.isJre22Available()) {
+// Try with FFM
+Class openSSL = 
Class.forName("org.apache.tomcat.util.openssl.openssl_h");
+version = ((Long) 
openSSL.getMethod("OpenSSL_version_num").invoke(null)).intValue();
+} else {
+Library.initialize(null);
+available = true;
+version = SSL.version();
+Library.terminate();
+}
 } catch (Exception | LibraryNotFoundError ex) {
 err = ex.getMessage();
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 707595b761..e52f7d98db 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Clean and log OpenSSL errors before processing of OpenSSL conf commands
+in the FFM code. (remm)
+  
+
+  
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M21

2024-06-18 Thread Dimitris Soumis
+1 Build is reproducible and all tests pass on Fedora 40 with Java 22,
tcnative-2.0.7, apr-1.7.4, openssl-3.0.13.

On Fri, Jun 14, 2024 at 6:07 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 11.0.0-M21 release is now available for
> voting.
>
> Apache Tomcat 11.0.0-M21 is a milestone release of the 11.0.x branch and
> has been made to provide users with early access to the new features in
> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> changes compared to the previous milestone include:
>
> - Ensure that static resources deployed via a JAR file remain accessible
>when the context is configured to use a bloom filter. Based on a pull
>request provided by bergander.
>
> - Ensure that static resources deployed via a JAR file remain accessible
>when the context is configured to use a bloom filter. Based on pull
>request #730 provided by bergander.
>
> - Update to Commons Daemon 1.4.0
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory. Applications using deprecated APIs may require
> further changes.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M21/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1496
>
> The tag is:
> https://github.com/apache/tomcat/tree/11.0.0-M21
> 2acc5c10a303d6ae7a28c2959432aef98ae29016
>
> The proposed 11.0.0-M21 release is:
> [ ] -1 Broken - do not release
> [X] +1 Beta   - go ahead and release as 11.0.0-M21
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[VOTE][RESULT] Release Apache Tomcat 11.0.0-M21

2024-06-18 Thread Mark Thomas

The following votes were cast:

Binding:
+1 (beta): markt, isapir, remm

Non-binding:
+1 (beta): Dimitris Soumis

No other votes were cast.

The vote therefore passes. Thanks to everyone who contributed to this 
release.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r69841 - /dev/tomcat/tomcat-11/v11.0.0-M21/ /release/tomcat/tomcat-11/v11.0.0-M21/

2024-06-18 Thread markt
Author: markt
Date: Tue Jun 18 13:08:57 2024
New Revision: 69841

Log:
Release Tomcat 11.0.0-M21

Added:
release/tomcat/tomcat-11/v11.0.0-M21/
  - copied from r69840, dev/tomcat/tomcat-11/v11.0.0-M21/
Removed:
dev/tomcat/tomcat-11/v11.0.0-M21/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Clear error earlier

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 6fcf6d333b Clear error earlier
6fcf6d333b is described below

commit 6fcf6d333bec4855bd97494679a3d5272cd5786b
Author: remm 
AuthorDate: Tue Jun 18 16:40:41 2024 +0200

Clear error earlier
---
 .../tomcat/util/net/openssl/panama/LocalStrings.properties|  1 +
 .../apache/tomcat/util/net/openssl/panama/OpenSSLContext.java | 11 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git 
a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties 
b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
index b42309b801..ad0d1d4291 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
+++ b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
@@ -58,6 +58,7 @@ openssl.errorLoadingPassword=Error loading password file: 
[{0}]
 openssl.errorLoadingPrivateKey=Error loading private key: [{0}]
 openssl.errorLoadingCertificateRevocationListWithError=Error loading 
certificate revocation [{0}] with error [{1}]
 openssl.errorPrivateKeyCheck=Private key does not match the certificate public 
key: [{0}]
+openssl.errorReadingPEMParameters=Failed reading PEM parameters [{0}] for 
certificate [{1}]
 openssl.errorSSLCtxInit=Error initializing SSL context
 openssl.invalidSslProtocol=An invalid value [{0}] was provided for the 
SSLProtocol attribute
 openssl.keyManagerMissing=No key manager found
diff --git a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java 
b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
index 9a8ba2ea2b..3dedf0fd22 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
+++ b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
@@ -1068,6 +1068,10 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 
log.debug(sm.getString("openssl.setCustomDHParameters", 
Integer.valueOf(numBits), certificate.getCertificateFile()));
 }
 } else {
+String errMessage = OpenSSLLibrary.getLastError();
+if (errMessage != null) {
+
log.debug(sm.getString("openssl.errorReadingPEMParameters", errMessage, 
certificate.getCertificateFile()));
+}
 SSL_CTX_ctrl(state.sslCtx, SSL_CTRL_SET_DH_AUTO(), 
1, MemorySegment.NULL);
 }
 }
@@ -1220,9 +1224,14 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 EVP_PKEY_free(pkey);
 } else {
 
log.debug(sm.getString("openssl.setCustomDHParameters", 
Integer.valueOf(numBits),
-certificate.getCertificateFile()));
+x509KeyManager.toString()));
 }
 } else {
+String errMessage = OpenSSLLibrary.getLastError();
+if (errMessage != null) {
+
log.debug(sm.getString("openssl.errorReadingPEMParameters", errMessage,
+x509KeyManager.toString()));
+}
 SSL_CTX_ctrl(state.sslCtx, SSL_CTRL_SET_DH_AUTO(), 1, 
MemorySegment.NULL);
 }
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 10.1.x updated: Clear error earlier

2024-06-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 4a7977e6e2 Clear error earlier
4a7977e6e2 is described below

commit 4a7977e6e24209d50ec78f962f1824c1d270147c
Author: remm 
AuthorDate: Tue Jun 18 16:40:41 2024 +0200

Clear error earlier
---
 .../tomcat/util/net/openssl/panama/LocalStrings.properties|  1 +
 .../apache/tomcat/util/net/openssl/panama/OpenSSLContext.java | 11 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git 
a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties 
b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
index 307fa3f4a2..c0923cbda0 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
+++ b/java/org/apache/tomcat/util/net/openssl/panama/LocalStrings.properties
@@ -58,6 +58,7 @@ openssl.errorLoadingCertificateWithError=Error loading 
certificate [{0}] with er
 openssl.errorLoadingPassword=Error loading password file: [{0}]
 openssl.errorLoadingPrivateKey=Error loading private key: [{0}]
 openssl.errorPrivateKeyCheck=Private key does not match the certificate public 
key: [{0}]
+openssl.errorReadingPEMParameters=Failed reading PEM parameters [{0}] for 
certificate [{1}]
 openssl.errorSSLCtxInit=Error initializing SSL context
 openssl.invalidSslProtocol=An invalid value [{0}] was provided for the 
SSLProtocol attribute
 openssl.keyManagerMissing=No key manager found
diff --git a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java 
b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
index 9a8ba2ea2b..3dedf0fd22 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
+++ b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
@@ -1068,6 +1068,10 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 
log.debug(sm.getString("openssl.setCustomDHParameters", 
Integer.valueOf(numBits), certificate.getCertificateFile()));
 }
 } else {
+String errMessage = OpenSSLLibrary.getLastError();
+if (errMessage != null) {
+
log.debug(sm.getString("openssl.errorReadingPEMParameters", errMessage, 
certificate.getCertificateFile()));
+}
 SSL_CTX_ctrl(state.sslCtx, SSL_CTRL_SET_DH_AUTO(), 
1, MemorySegment.NULL);
 }
 }
@@ -1220,9 +1224,14 @@ public class OpenSSLContext implements 
org.apache.tomcat.util.net.SSLContext {
 EVP_PKEY_free(pkey);
 } else {
 
log.debug(sm.getString("openssl.setCustomDHParameters", 
Integer.valueOf(numBits),
-certificate.getCertificateFile()));
+x509KeyManager.toString()));
 }
 } else {
+String errMessage = OpenSSLLibrary.getLastError();
+if (errMessage != null) {
+
log.debug(sm.getString("openssl.errorReadingPEMParameters", errMessage,
+x509KeyManager.toString()));
+}
 SSL_CTX_ctrl(state.sslCtx, SSL_CTRL_SET_DH_AUTO(), 1, 
MemorySegment.NULL);
 }
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1918413 - in /tomcat/site/trunk: ./ docs/tomcat-11.0-doc/ docs/tomcat-11.0-doc/annotationapi/ docs/tomcat-11.0-doc/annotationapi/jakarta/annotation/ docs/tomcat-11.0-doc/annotationapi/jak

2024-06-18 Thread markt
Author: markt
Date: Tue Jun 18 14:49:39 2024
New Revision: 1918413

URL: http://svn.apache.org/viewvc?rev=1918413&view=rev
Log:
Update docs for 11.0.0-M21 release


[This commit notification would consist of 118 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1918416 - in /tomcat/site/trunk: docs/download-11.html docs/index.html docs/migration-11.0.html docs/oldnews.html xdocs/download-11.xml xdocs/index.xml xdocs/migration-11.0.xml xdocs/oldn

2024-06-18 Thread markt
Author: markt
Date: Tue Jun 18 14:56:25 2024
New Revision: 1918416

URL: http://svn.apache.org/viewvc?rev=1918416&view=rev
Log:
Update site for 11.0.0-M21 release

Modified:
tomcat/site/trunk/docs/download-11.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-11.0.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/xdocs/download-11.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-11.0.xml
tomcat/site/trunk/xdocs/oldnews.xml

Modified: tomcat/site/trunk/docs/download-11.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-11.html?rev=1918416&r1=1918415&r2=1918416&view=diff
==
--- tomcat/site/trunk/docs/download-11.html (original)
+++ tomcat/site/trunk/docs/download-11.html Tue Jun 18 14:56:25 2024
@@ -19,7 +19,7 @@
 
   Quick Navigation
 
-[define v]11.0.0-M20[end]
+[define v]11.0.0-M21[end]
 https://downloads.apache.org/tomcat/tomcat-11/KEYS";>KEYS |
 [v] (alpha) |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1918416&r1=1918415&r2=1918416&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Tue Jun 18 14:56:25 2024
@@ -34,6 +34,37 @@ wiki page.
 Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
 project logo are trademarks of the Apache Software Foundation.
 
+2024-06-18 Tomcat 11.0.0-M21 Released
+
+The Apache Tomcat Project is proud to announce the release of version 
11.0.0-M21
+(alpha) of Apache Tomcat. This release is a milestone release and is targeted 
at
+Jakarta EE 11.
+Users of Tomcat 10 onwards should be aware that, as a result of the move 
from
+Java EE to Jakarta EE as part of the transfer of Java EE to the Eclipse
+Foundation, the primary package for all implemented APIs has changed from
+javax.* to jakarta.*. This will almost certainly
+require code changes to enable applications to migrate from Tomcat 9 and 
earlier
+to Tomcat 10 and later. A
+https://github.com/apache/tomcat-jakartaee-migration";>migration
+tool is available to aid this process.
+The notable changes in this release are:
+
+Ensure that static resources deployed via a JAR file remain accessible
+when the context is configured to use a bloom filter. Based on a pull
+request provided by bergander.
+Add task queue size configuration on the Connector element, similar to the
+Executor element, for consistency.
+Update to Commons Daemon 1.4.0 
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 11
+(alpha) changelog.
+
+
+
+https://tomcat.apache.org/download-11.cgi";>Download
+
 2024-05-13 Tomcat 10.1.24 Released
 
 The Apache Tomcat Project is proud to announce the release of version 10.1.24
@@ -49,7 +80,7 @@ migration tool for Jakarta EE tool w
 https://tomcat.apache.org/download-migration.cgi";>download for 
off-line use.
 The notable changes in this release are:
 
-  Correct error handling for asynchronous requests
+Correct error handling for asynchronous requests
 
   Refactor HTTP header parsing to use common parsing code and fix
   non-blocking reads of chunked request bodies including trailer 
fields
@@ -66,35 +97,6 @@ changelog.
 
 https://tomcat.apache.org/download-10.cgi";>Download
 
-2024-05-08 Tomcat 11.0.0-M20 Released
-
-The Apache Tomcat Project is proud to announce the release of version 
11.0.0-M20
-(alpha) of Apache Tomcat. This release is a milestone release and is targeted 
at
-Jakarta EE 11.
-Users of Tomcat 10 onwards should be aware that, as a result of the move 
from
-Java EE to Jakarta EE as part of the transfer of Java EE to the Eclipse
-Foundation, the primary package for all implemented APIs has changed from
-javax.* to jakarta.*. This will almost certainly
-require code changes to enable applications to migrate from Tomcat 9 and 
earlier
-to Tomcat 10 and later. A
-https://github.com/apache/tomcat-jakartaee-migration";>migration
-tool is available to aid this process.
-The notable changes in this release are:
-
-Add OpenSSL FFM classes to tomcat-embed-core.jar
-Refactor HTTP header parsing to use common parsing code and fix 
non-blocking
-reads of chunked request bodies including trailer fields
-Add more timescale options to AccessLogValve and 
ExtendedAccessLogValve 
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 11
-(alpha) changelog.
-
-
-
-https://tomcat.apache.org/download-11.cgi";>Download
-
 2024-05-07 Tomcat 9.0.89 Released
 
 The Apache Tomcat Project is proud to announce the release of version 9.0.89

Modified: tomcat/site/trunk/docs/migration-11.0.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-11.0.html?rev=1918416&r1=1918415&r2=19184

svn commit: r1918417 - in /tomcat/site/trunk: docs/ tools/ xdocs/ xdocs/stylesheets/

2024-06-18 Thread markt
Author: markt
Date: Tue Jun 18 15:00:07 2024
New Revision: 1918417

URL: http://svn.apache.org/viewvc?rev=1918417&view=rev
Log:
Tomcat 11.0.x is now beta

Modified:
tomcat/site/trunk/docs/download-11.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/tools/email-template-11.0.txt
tomcat/site/trunk/tools/news-template-11.0.xml
tomcat/site/trunk/xdocs/download-11.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/stylesheets/project.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/download-11.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-11.html?rev=1918417&r1=1918416&r2=1918417&view=diff
==
--- tomcat/site/trunk/docs/download-11.html (original)
+++ tomcat/site/trunk/docs/download-11.html Tue Jun 18 15:00:07 2024
@@ -1,5 +1,5 @@
 
-Apache Tomcat® - Apache Tomcat 11 Software 
Downloadshttps://www.apachecon.com/event-images/snippet.js";>http://tomcat.apache.org/";>Apache 
Tomcat®https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt=
 "Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">https://www.google.com/search"; method="get">GOApache TomcatHomeTaglibsMaven 
PluginDownloadWhich version?https://tomcat.apache.org/download-11.cgi";>Tomcat 11 (alpha)<
 /li>https://tomcat.apache.org/download-10.cgi";>Tomcat 
10https://tomcat.apache.org/download-90.cgi";>Tomcat 
9https://tomcat.apache.org/download-80.cgi";>Tomcat 
8https://tomcat.apache.org/download-migration.cgi";>Tomcat 
Migration Tool for Jakarta EEhttps://tomcat.apache.org/download-connectors.cgi";>Tomcat 
Connectorshttps://tomcat.apache.org/download-native.cgi";>Tomcat 
Nativehttps://tomcat.apache.org/download-taglibs.cgi";>Taglibshttps://archive.apache.org/dist/tomcat/";>ArchivesDocumentationTomcat 11.0 (alpha)Tomcat 10.1Tomcat 9.0Tomcat 8.5UpgradingTomcat ConnectorsTomcat Native 2Tomcat Native 1.3https://cwiki.apache.org/confluence/display/TOMCAT";>WikiMigration GuidePresentationshttps://cwiki.apache.org/confluence/x/Bi8lBg";>SpecificationsProblems?Security ReportsFind helphttps://cwiki.apache.org/confluence/display/TOMCAT/FAQ";>FAQMailing ListsBug 
DatabaseIRCGet 
InvolvedOverviewSource codeBu
 ildbothttps://cwiki.apache.org/confluence/x/vIPzBQ";>TranslationsToolsMediahttps://twitter.com/theapachetomcat";>Twitterhttps://www.youtube.com/c/ApacheTomcatOfficial";>YouTubehttps://blogs.apache.org/tomcat/";>BlogMiscWho We Arehttps://www.redbubble.com/people/comdev/works/30885254-apache-tomcat";>SwagHeritagehttp://www.apache.org";>Apache HomeResourcesContactLegalhttps://privacy.apache.org/policies/privacy-policy-public.html";>Privacyhttps://www.apache.org/foundation/contributing.html";>Support 
Apachehttps://www.a
 pache.org/foundation/sponsorship.html">Sponsorshiphttp://www.apache.org/foundation/thanks.html";>Thankshttp://www.apache.org/licenses/";>LicenseContentTomcat 11 Software Downloads
+Apache Tomcat® - Apache Tomcat 11 Software 
Downloadshttps://www.apachecon.com/event-images/snippet.js";>http://tomcat.apache.org/";>Apache 
Tomcat®https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt=
 "Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">https://www.google.com/search"; method="get">GOApache TomcatHomeTaglibsMaven 
PluginDownloadWhich version?https://tomcat.apache.org/download-11.cgi";>Tomcat 11 (beta)https://tomcat.apache.org/download-10.cgi";>Tomcat 
10https://tomcat.apache.org/download-90.cgi";>Tomcat 
9https://tomcat.apache.org/download-80.cgi";>Tomcat 
8https://tomcat.apache.org/download-migration.cgi";>Tomcat 
Migration Tool for Jakarta EEhttps://tomcat.apache.org/download-connectors.cgi";>Tomcat 
Connectorshttps://tomcat.apache.org/download-native.cgi";>Tomcat 
Nativehttps://tomcat.apache.org/download-taglibs.cgi";>Taglibshttps://archive.apache.org/dist/tomcat/";>ArchivesDocumentationTomcat 11.0 (beta)Tomcat 10.1Tomcat 9.0Tomcat 8.5Upgrading
 Tomcat ConnectorsTomcat Native 2Tomcat Native 1.3https://cwiki.apache.org/confluence/display/TOMCAT";>WikiMigration GuidePresentationshttps://cwiki.apache.org/confluence/x/Bi8lBg";>SpecificationsProblems?Security ReportsFind helphttps://cwiki.apache.org/confluence/display/TOMCAT/FAQ";>FAQMailing ListsBug 
DatabaseIRCGet 
InvolvedOverviewSource codeBuil
 dbothttps://cwiki.apache.org/confluence/x/vIPzBQ";>TranslationsToolsMediahttps://twitter.com/theapachetomcat";>Twitterhttps://www.youtube.com/c/ApacheTomcatOfficial";>YouTubehttps://blogs.apache.org/tomcat/";>BlogMiscWho We Arehttps://www.redbubble.com/people/comdev/works/30885254-apache-tomcat";>SwagHeritagehttp://www.apache.org";>Apache HomeResourcesConta

Re: [VOTE] Release Apache Tomcat 9.0.90

2024-06-18 Thread Dimitris Soumis
-1 org.apache.catalina.ant.TestDeployTask is broken although test.apr.loc
has been properly defined
Testsuite: org.apache.catalina.ant.TestDeployTask
Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.443 sec
- Standard Error -
18-Jun-2024 16:34:10.024 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[bug58086a]
18-Jun-2024 16:34:10.097 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["http-apr-127.0.0.1-auto-1"]
18-Jun-2024 16:34:10.101 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[bug58086b]
18-Jun-2024 16:34:10.102 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["http-apr-127.0.0.1-auto-2"]
18-Jun-2024 16:34:10.103 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[bug58086c]
18-Jun-2024 16:34:10.103 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["http-apr-127.0.0.1-auto-3"]
18-Jun-2024 16:34:10.104 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[bug58086d]
18-Jun-2024 16:34:10.105 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["http-apr-127.0.0.1-auto-4"]
18-Jun-2024 16:34:10.106 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[bug58086e]
18-Jun-2024 16:34:10.346 INFO [main]
org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
["http-apr-127.0.0.1-auto-5"]
18-Jun-2024 16:34:10.346 INFO [main]
org.apache.catalina.core.StandardService.stopInternal Stopping service
[Tomcat]
-  ---

Testcase: bug58086a took 0.16 sec
Testcase: bug58086b took 0.002 sec
Testcase: bug58086c took 0.002 sec
Testcase: bug58086d took 0.001 sec
Testcase: bug58086e took 0.242 sec
Caused an ERROR
The configured protocol [org.apache.coyote.http11.Http11AprProtocol]
requires the APR/native library which is not available
org.apache.catalina.LifecycleException: The configured protocol
[org.apache.coyote.http11.Http11AprProtocol] requires the APR/native
library which is not available
at org.apache.catalina.connector.Connector.initInternal(Connector.java:998)
at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
at
org.apache.catalina.core.StandardService.initInternal(StandardService.java:525)
at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
at
org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:990)
at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:155)
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:438)
at
org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:888)
at org.apache.catalina.ant.TestDeployTask.bug58086e(TestDeployTask.java:91)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

Caused an ERROR
An invalid Lifecycle transition was attempted ([before_stop]) for component
[StandardEngine[Tomcat]] in state [INITIALIZED]
org.apache.catalina.LifecycleException: An invalid Lifecycle transition was
attempted ([before_stop]) for component [StandardEngine[Tomcat]] in state
[INITIALIZED]
at
org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:392)
at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:218)
at
org.apache.catalina.core.StandardService.stopInternal(StandardService.java:471)
at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
at
org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:923)
at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:448)
at
org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:247)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

The root cause should be this commit

which introduces the lock on AprLifecycleListener class.
Have not investigated further on the issue at the moment..




On Fri, Jun 14, 2024 at 6:13 PM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.90 release is now available for voting.
>
> The notable changes compared to 9.0.89 are:
>
> - Ensure that static resources deployed via a JAR file remain accessible
>when the context is configured to use a bloom filter. Based on pull
>request #730 provided by bergander.
>
> - Update to Commons Daemon 1.4.0
>
> - The default value of the discardFacades attribute of the Connector is now
>   true for improved safety
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/de

[ANN] Apache Tomcat 11.0.0-M21 (beta) available

2024-06-18 Thread Mark Thomas

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 11.0.0-M21 (beta).

Apache Tomcat 11 is an open source software implementation of the
Jakarta Servlet, Jakarta Server Pages, Jakarta Expression Language,
Jakarta WebSocket, Jakarta Authentication and Jakarta Annotations
specifications.

Users of Tomcat 10 onwards should be aware that, as a result of the move
from Java EE to Jakarta EE as part of the transfer of Java EE to the
Eclipse Foundation, the primary package for all implemented APIs has
changed from javax.* to jakarta.*. This will almost certainly require
code changes to enable applications to migrate from Tomcat 9 and earlier
to Tomcat 10 and later. A migration tool is available to aid this process.

Apache Tomcat 11.0.0-M21 is a milestone release of the 11.0.x branch and
has been made to provide users with early access to the new features in
Apache Tomcat 11.0.x so that they may provide feedback. The notable
changes compared to 11.0.0-M20 include:

- Ensure that static resources deployed via a JAR file remain accessible
  when the context is configured to use a bloom filter. Based on a pull
  request provided by bergander.

- Add task queue size configuration on the Connector element, similar to
  the Executor element, for consistency.

- Update to Commons Daemon 1.4.0

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-11.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-11.cgi

Migration guides from Apache Tomcat 8.5.x, 9.0.x and 10.1.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.90

2024-06-18 Thread Dimitris Soumis
Sorry, I have just seen that the issue has already been referenced and
identified in the previous messages on the list. It's noteworthy though,
that the issue arises in Linux as well , Fedora 40.

Other than that, +1 from me as well.

On Tue, Jun 18, 2024 at 6:01 PM Dimitris Soumis  wrote:

> -1 org.apache.catalina.ant.TestDeployTask is broken although test.apr.loc
> has been properly defined
> Testsuite: org.apache.catalina.ant.TestDeployTask
> Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.443 sec
> - Standard Error -
> 18-Jun-2024 16:34:10.024 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086a]
> 18-Jun-2024 16:34:10.097 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-1"]
> 18-Jun-2024 16:34:10.101 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086b]
> 18-Jun-2024 16:34:10.102 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-2"]
> 18-Jun-2024 16:34:10.103 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086c]
> 18-Jun-2024 16:34:10.103 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-3"]
> 18-Jun-2024 16:34:10.104 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086d]
> 18-Jun-2024 16:34:10.105 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-4"]
> 18-Jun-2024 16:34:10.106 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086e]
> 18-Jun-2024 16:34:10.346 INFO [main]
> org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
> ["http-apr-127.0.0.1-auto-5"]
> 18-Jun-2024 16:34:10.346 INFO [main]
> org.apache.catalina.core.StandardService.stopInternal Stopping service
> [Tomcat]
> -  ---
>
> Testcase: bug58086a took 0.16 sec
> Testcase: bug58086b took 0.002 sec
> Testcase: bug58086c took 0.002 sec
> Testcase: bug58086d took 0.001 sec
> Testcase: bug58086e took 0.242 sec
> Caused an ERROR
> The configured protocol [org.apache.coyote.http11.Http11AprProtocol]
> requires the APR/native library which is not available
> org.apache.catalina.LifecycleException: The configured protocol
> [org.apache.coyote.http11.Http11AprProtocol] requires the APR/native
> library which is not available
> at org.apache.catalina.connector.Connector.initInternal(Connector.java:998)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at
> org.apache.catalina.core.StandardService.initInternal(StandardService.java:525)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at
> org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:990)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:155)
> at org.apache.catalina.startup.Tomcat.start(Tomcat.java:438)
> at
> org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:888)
> at org.apache.catalina.ant.TestDeployTask.bug58086e(TestDeployTask.java:91)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>
> Caused an ERROR
> An invalid Lifecycle transition was attempted ([before_stop]) for
> component [StandardEngine[Tomcat]] in state [INITIALIZED]
> org.apache.catalina.LifecycleException: An invalid Lifecycle transition
> was attempted ([before_stop]) for component [StandardEngine[Tomcat]] in
> state [INITIALIZED]
> at
> org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:392)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:218)
> at
> org.apache.catalina.core.StandardService.stopInternal(StandardService.java:471)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> at
> org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:923)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:448)
> at
> org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:247)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>
> The root cause should be this commit
> 
> which introduces the lock on AprLifecycleListener class.
> Have not investigated further on the issue at the moment..
>
>
>
>
> On Fri, Jun 14, 2024 at 6:13 PM Rémy Maucherat  wrote:
>
>> The proposed Apache Tomcat 9.0.90 release is now available for voting.
>>
>> The notable changes compared to 9.0.89 are:
>>
>> - Ensure that static resourc

Re: [VOTE] Release Apache Tomcat 10.1.25

2024-06-18 Thread Dimitris Soumis
+1
Build is reproducible and all tests pass on Fedora 40 with Java 21,
tcnative-2.0.7, apr-1.7.4, openssl-3.0.13.

On Sat, Jun 15, 2024 at 12:28 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 10.1.25 release is now available for
> voting.
>
> All committers and PMC members are kindly requested to provide a vote if
> possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes are
> binding. We welcome non-committer votes or comments on release builds.
>
> The notable changes compared to 10.1.24 are:
>
> - Ensure that static resources deployed via a JAR file remain accessible
>when the context is configured to use a bloom filter. Based on pull
>request #730 provided by bergander.
>
> - Update to Commons Daemon 1.4.0
>
> - Improvements to HTTP/2 streams and timeouts
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.25/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1498
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.25
>
> https://github.com/apache/tomcat/commit/a0038178b617423537dc66b2f516c53da7093421
>
> Please reply with a +1 for release or +0/-0/-1 with an explanation.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.90

2024-06-18 Thread Rémy Maucherat
On Tue, Jun 18, 2024 at 5:02 PM Dimitris Soumis  wrote:
>
> -1 org.apache.catalina.ant.TestDeployTask is broken although test.apr.loc

Yeah, ok there's still likely a problem with the counting that was
added. It's still only a testsuite problem.

Rémy

> has been properly defined
> Testsuite: org.apache.catalina.ant.TestDeployTask
> Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.443 sec
> - Standard Error -
> 18-Jun-2024 16:34:10.024 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086a]
> 18-Jun-2024 16:34:10.097 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-1"]
> 18-Jun-2024 16:34:10.101 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086b]
> 18-Jun-2024 16:34:10.102 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-2"]
> 18-Jun-2024 16:34:10.103 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086c]
> 18-Jun-2024 16:34:10.103 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-3"]
> 18-Jun-2024 16:34:10.104 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086d]
> 18-Jun-2024 16:34:10.105 INFO [main]
> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> ["http-apr-127.0.0.1-auto-4"]
> 18-Jun-2024 16:34:10.106 INFO [main]
> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> [bug58086e]
> 18-Jun-2024 16:34:10.346 INFO [main]
> org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
> ["http-apr-127.0.0.1-auto-5"]
> 18-Jun-2024 16:34:10.346 INFO [main]
> org.apache.catalina.core.StandardService.stopInternal Stopping service
> [Tomcat]
> -  ---
>
> Testcase: bug58086a took 0.16 sec
> Testcase: bug58086b took 0.002 sec
> Testcase: bug58086c took 0.002 sec
> Testcase: bug58086d took 0.001 sec
> Testcase: bug58086e took 0.242 sec
> Caused an ERROR
> The configured protocol [org.apache.coyote.http11.Http11AprProtocol]
> requires the APR/native library which is not available
> org.apache.catalina.LifecycleException: The configured protocol
> [org.apache.coyote.http11.Http11AprProtocol] requires the APR/native
> library which is not available
> at org.apache.catalina.connector.Connector.initInternal(Connector.java:998)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at
> org.apache.catalina.core.StandardService.initInternal(StandardService.java:525)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at
> org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:990)
> at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:155)
> at org.apache.catalina.startup.Tomcat.start(Tomcat.java:438)
> at
> org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:888)
> at org.apache.catalina.ant.TestDeployTask.bug58086e(TestDeployTask.java:91)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>
> Caused an ERROR
> An invalid Lifecycle transition was attempted ([before_stop]) for component
> [StandardEngine[Tomcat]] in state [INITIALIZED]
> org.apache.catalina.LifecycleException: An invalid Lifecycle transition was
> attempted ([before_stop]) for component [StandardEngine[Tomcat]] in state
> [INITIALIZED]
> at
> org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:392)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:218)
> at
> org.apache.catalina.core.StandardService.stopInternal(StandardService.java:471)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> at
> org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:923)
> at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:448)
> at
> org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:247)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>
> The root cause should be this commit
> 
> which introduces the lock on AprLifecycleListener class.
> Have not investigated further on the issue at the moment..
>
>
>
>
> On Fri, Jun 14, 2024 at 6:13 PM Rémy Maucherat  wrote:
>
> > The proposed Apache Tomcat 9.0.90 release is now available for voting.
> >
> > The notable changes compared to 9.0.89 are:
> >
> > - Ensure that static resources deployed via a JAR file remain accessible
> >when the context is configured to use a bloom filter. Base

Re: [VOTE] Release Apache Tomcat 10.1.25

2024-06-18 Thread Adam Rauch

+1 (non binding)

LabKey Server's extensive set of nightly test suites passed while 
running against embedded Tomcat 10.1.25.


Thanks!
Adam

On 6/14/2024 2:19 PM, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.25 release is now available for
voting.

All committers and PMC members are kindly requested to provide a vote 
if possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes 
are binding. We welcome non-committer votes or comments on release 
builds.


The notable changes compared to 10.1.24 are:

- Ensure that static resources deployed via a JAR file remain accessible
  when the context is configured to use a bloom filter. Based on pull
  request #730 provided by bergander.

- Update to Commons Daemon 1.4.0

- Improvements to HTTP/2 streams and timeouts

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 
10 without changes. Java EE applications designed for Tomcat 9 and 
earlier may be placed in the $CATALINA_BASE/webapps-javaee directory 
and Tomcat will automatically convert them to Jakarta EE and copy them 
to the webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.25/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1498

The tag is:
https://github.com/apache/tomcat/tree/10.1.25
https://github.com/apache/tomcat/commit/a0038178b617423537dc66b2f516c53da7093421 



Please reply with a +1 for release or +0/-0/-1 with an explanation.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.90

2024-06-18 Thread Rémy Maucherat
On Tue, Jun 18, 2024 at 8:26 PM Rémy Maucherat  wrote:
>
> On Tue, Jun 18, 2024 at 5:02 PM Dimitris Soumis  wrote:
> >
> > -1 org.apache.catalina.ant.TestDeployTask is broken although test.apr.loc
>
> Yeah, ok there's still likely a problem with the counting that was
> added. It's still only a testsuite problem.

Verified that it is still the same APR listener instance count
problem, and verified the fix is the right one. Please apply the
little patch before doing the APR testsuite [if you want to test APR].
I will proceed with the release tomorrow.

Rémy

> Rémy
>
> > has been properly defined
> > Testsuite: org.apache.catalina.ant.TestDeployTask
> > Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.443 sec
> > - Standard Error -
> > 18-Jun-2024 16:34:10.024 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [bug58086a]
> > 18-Jun-2024 16:34:10.097 INFO [main]
> > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > ["http-apr-127.0.0.1-auto-1"]
> > 18-Jun-2024 16:34:10.101 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [bug58086b]
> > 18-Jun-2024 16:34:10.102 INFO [main]
> > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > ["http-apr-127.0.0.1-auto-2"]
> > 18-Jun-2024 16:34:10.103 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [bug58086c]
> > 18-Jun-2024 16:34:10.103 INFO [main]
> > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > ["http-apr-127.0.0.1-auto-3"]
> > 18-Jun-2024 16:34:10.104 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [bug58086d]
> > 18-Jun-2024 16:34:10.105 INFO [main]
> > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > ["http-apr-127.0.0.1-auto-4"]
> > 18-Jun-2024 16:34:10.106 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [bug58086e]
> > 18-Jun-2024 16:34:10.346 INFO [main]
> > org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
> > ["http-apr-127.0.0.1-auto-5"]
> > 18-Jun-2024 16:34:10.346 INFO [main]
> > org.apache.catalina.core.StandardService.stopInternal Stopping service
> > [Tomcat]
> > -  ---
> >
> > Testcase: bug58086a took 0.16 sec
> > Testcase: bug58086b took 0.002 sec
> > Testcase: bug58086c took 0.002 sec
> > Testcase: bug58086d took 0.001 sec
> > Testcase: bug58086e took 0.242 sec
> > Caused an ERROR
> > The configured protocol [org.apache.coyote.http11.Http11AprProtocol]
> > requires the APR/native library which is not available
> > org.apache.catalina.LifecycleException: The configured protocol
> > [org.apache.coyote.http11.Http11AprProtocol] requires the APR/native
> > library which is not available
> > at org.apache.catalina.connector.Connector.initInternal(Connector.java:998)
> > at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> > at
> > org.apache.catalina.core.StandardService.initInternal(StandardService.java:525)
> > at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> > at
> > org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:990)
> > at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:122)
> > at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:155)
> > at org.apache.catalina.startup.Tomcat.start(Tomcat.java:438)
> > at
> > org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:888)
> > at org.apache.catalina.ant.TestDeployTask.bug58086e(TestDeployTask.java:91)
> > at
> > java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> >
> > Caused an ERROR
> > An invalid Lifecycle transition was attempted ([before_stop]) for component
> > [StandardEngine[Tomcat]] in state [INITIALIZED]
> > org.apache.catalina.LifecycleException: An invalid Lifecycle transition was
> > attempted ([before_stop]) for component [StandardEngine[Tomcat]] in state
> > [INITIALIZED]
> > at
> > org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:392)
> > at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:218)
> > at
> > org.apache.catalina.core.StandardService.stopInternal(StandardService.java:471)
> > at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> > at
> > org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:923)
> > at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:231)
> > at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:448)
> > at
> > org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:247)
> > at
> > java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> >
> > The root cause should be this commit
> > 

[Bug 69140] New: REGRESSION in change from Base64 from apache commons to java class

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69140

Bug ID: 69140
   Summary: REGRESSION in change from Base64 from apache commons
to java class
   Product: Tomcat 10
   Version: 10.1.24
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: mircea.butma...@radcom.ro
  Target Milestone: --

Somewere between changes from 10.1.20 to 10.1.24 it was introduced a change in
SpnegoAuthenticator that creates a big problem in Windows Integrated
Authentication.
The change is consisting in the fact that was deprected (and removed) the class
import org.apache.tomcat.util.codec.binary.Base64;

and replaced with class

import java.util.Base64;

The rest of changes are derived from this fact.

The problem is that when Windows Integrated Authentication happens from Windows
10 station Tomcat reports exception with some unrecognised character exception.

It is very clear that this change is implemented more permissive in decoding /
encoding process with respect with whitespace characters and coding of those
characters in URL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69140] REGRESSION in change from Base64 from apache commons to java class

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69140

Mircea Butmalai  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mircea Butmalai  ---
I will come again with details about exception thrown by Tomcat when Windows
Integrated Authentication happens ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69140] REGRESSION in change from Base64 from apache commons to java class

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69140

--- Comment #2 from Mircea Butmalai  ---
For now it is clear for me that all versions of Tomcat (9.0.x, 10.1.x and 11)
must have this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69140] REGRESSION in change from Base64 from apache commons to java class

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69140

--- Comment #3 from Mircea Butmalai  ---
For now it is clear for me that all versions of Tomcat (9.0.x, 10.1.x and 11)
must have this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 69121] Async requests are being forwarded to the default error page when the connection with the server is lost

2024-06-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69121

Eduwardo Horibe  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from Eduwardo Horibe  ---
I've made a simple project to illustrate the issue that I'm having, which can
be found [here](https://github.com/eduhoribe/tomcat-bz69121).
Note that the default error page wasn't being hit on `9.0.88` on the async
request and after upgrading to `9.0.89` that didn't change for the async
request, but the `onCompletion` code is not being hit either.

It seems to me that the Tomcat change is triggering some kind of redirect to
the default error page, but that is failing due to the client going away.

If checking the IO availability is not "up to spec", checking if the response
is already committed could be a better option.
I've tested the idea a little
[here](https://github.com/eduhoribe/tomcat/tree/9.0.xx)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org