(tomcat) branch main updated: Look up response wrappers to suspend
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 2654e1dae4 Look up response wrappers to suspend
2654e1dae4 is described below
commit 2654e1dae4566feeed05116bd339a0366f19e72e
Author: remm
AuthorDate: Mon Mar 4 10:17:39 2024 +0100
Look up response wrappers to suspend
BZ 68634 shows the implications and behavior difference between suspend
and close for response generation.
A flag could be added to make this optional if needed. I will delay
backporting this to other branches since this is a behavior change.
---
.../apache/catalina/core/ApplicationDispatcher.java | 20 +++-
.../org/apache/catalina/core/LocalStrings.properties | 1 +
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/catalina/core/ApplicationDispatcher.java
b/java/org/apache/catalina/core/ApplicationDispatcher.java
index 0707cf8eb3..d7abfe6ba4 100644
--- a/java/org/apache/catalina/core/ApplicationDispatcher.java
+++ b/java/org/apache/catalina/core/ApplicationDispatcher.java
@@ -295,16 +295,26 @@ final class ApplicationDispatcher implements
AsyncDispatcher, RequestDispatcher
wrapper.getLogger().trace(" Disabling the response for further
output");
}
+boolean finished = false;
if (response instanceof ResponseFacade) {
+finished = true;
((ResponseFacade) response).finish();
-} else {
+} else if (response instanceof ServletResponseWrapper) {
+ServletResponse baseResponse = response;
+do {
+baseResponse = ((ServletResponseWrapper)
baseResponse).getResponse();
+} while (baseResponse instanceof ServletResponseWrapper);
+if (baseResponse instanceof ResponseFacade) {
+finished = true;
+((ResponseFacade) baseResponse).finish();
+}
+}
+if (!finished) {
// Servlet SRV.6.2.2. The Request/Response may have been wrapped
// and may no longer be instance of RequestFacade
-if (wrapper.getLogger().isTraceEnabled()) {
-wrapper.getLogger()
-.trace(" The Response is vehiculed using a wrapper: "
+ response.getClass().getName());
+if (wrapper.getLogger().isDebugEnabled()) {
+
wrapper.getLogger().debug(sm.getString("applicationDispatcher.customResponse",
response.getClass()));
}
-
// Close anyway
try {
PrintWriter writer = response.getWriter();
diff --git a/java/org/apache/catalina/core/LocalStrings.properties
b/java/org/apache/catalina/core/LocalStrings.properties
index a335cdcd34..6c91188d22 100644
--- a/java/org/apache/catalina/core/LocalStrings.properties
+++ b/java/org/apache/catalina/core/LocalStrings.properties
@@ -42,6 +42,7 @@ applicationContext.setSessionTracking.iae.ssl=The session
tracking modes request
applicationContext.setSessionTracking.ise=The session tracking modes for
context [{0}] cannot be set whilst the context is running
applicationDispatcher.allocateException=Allocate exception for servlet [{0}]
+applicationDispatcher.customResponse=The response class [{0}] could not be
unwraped to the Catalina response class and will be closed immediately after
the forward
applicationDispatcher.deallocateException=Deallocate exception for servlet
[{0}]
applicationDispatcher.forward.ise=Cannot forward after response has been
committed
applicationDispatcher.isUnavailable=Servlet [{0}] is currently unavailable
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68631] Observing org.apache.catalina.connector.ClientAbortException: java.net.SocketTimeoutException
https://bz.apache.org/bugzilla/show_bug.cgi?id=68631 --- Comment #4 from Mark Thomas --- No response after 2+ weeks. This is heading towards WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch main updated: Changelog for previous change
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new eeb91237cb Changelog for previous change eeb91237cb is described below commit eeb91237cb35dc1c9e9b5e51476df57f694bc44c Author: remm AuthorDate: Mon Mar 4 12:38:30 2024 +0100 Changelog for previous change --- webapps/docs/changelog.xml | 4 1 file changed, 4 insertions(+) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index a7adf61445..e2ea4d9814 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -137,6 +137,10 @@ FORM authentication, ensure that neither the URI, the query string nor the protocol are corrupted when restoring the request body. (markt) + +After forwarding a request, attempt to unwrap the response in order to +suspend it, instead of simply closing it if it was wrapped. (remm) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68634] Forwards using custom response classes do not wait for session replication
https://bz.apache.org/bugzilla/show_bug.cgi?id=68634 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Remy Maucherat --- I made the change in Tomcat 11 (will be in 11.0.0-M18), however I might not port it because it is a clear change in behavior. Porting with a flag could be an option. Anyway, the problem can occur in other scenarios, so your cluster infrastructure needs to be able to handle it. As a result, I prefer resolving this as a wontfix. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68634] Forwards using custom response classes do not wait for session replication
https://bz.apache.org/bugzilla/show_bug.cgi?id=68634 --- Comment #4 from OKUYAMA Atsushi --- Thank you for your reply. I'm currently considering your responses. Sincerely. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68634] Forwards using custom response classes do not wait for session replication
https://bz.apache.org/bugzilla/show_bug.cgi?id=68634 --- Comment #4 from OKUYAMA Atsushi --- Thank you for your reply. I'm currently considering your responses. Sincerely. --- Comment #5 from OKUYAMA Atsushi --- Thank you for your reply. I'm currently considering your responses. Sincerely. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68631] Observing org.apache.catalina.connector.ClientAbortException: java.net.SocketTimeoutException
https://bz.apache.org/bugzilla/show_bug.cgi?id=68631 --- Comment #5 from Suryanarayana Garlapati --- Hi Mark, We were busy in release work. This week will test on latest release and update here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68631] Observing org.apache.catalina.connector.ClientAbortException: java.net.SocketTimeoutException
https://bz.apache.org/bugzilla/show_bug.cgi?id=68631 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Mark Thomas --- The standard Tomcat unit tests included a test of POST over TLS with a 16MB body. That has been passing consistently for as long as I can remember. Adjusting the test to use a 9k body also passes. I am therefore resolving this as WORKSFORME. If you believe you are experiencing this issue then feel free to reopen the issue provided that: - you have tested with the latest release of any supported major version - you have provided a minimal test case that reliably reproduces the issue on a clean install of Tomcat from an ASF provided distribution - you have included the full source code for your test case -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Update MERGE.txt [tomcat]
anujdevopslearn closed pull request #705: Update MERGE.txt URL: https://github.com/apache/tomcat/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68711] New: Elan Imperial 82: Prime Commercial Spaces in Gurgaon - Invest for Success
https://bz.apache.org/bugzilla/show_bug.cgi?id=68711 Bug ID: 68711 Summary: Elan Imperial 82: Prime Commercial Spaces in Gurgaon - Invest for Success Product: Tomcat 10 Version: 10.1.18 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Cluster Assignee: dev@tomcat.apache.org Reporter: kunaldubey05051...@gmail.com Target Milestone: -- Position your business for success at Elan Imperial 82, a prime commercial destination in Sector 82, Gurgaon. Boasting an expansive 8-acre land parcel and a robust B+G+4 structure, this project features 100+ units with double-height outlets, offering a distinctive retail experience. Invest confidently with a starting price of ₹1.42 Cr* and an enticing 12% assured return. Benefit from essential amenities like lifts lobby, cafeteria, and a bar & lounge, ensuring a well-rounded commercial experience. With proximity to key landmarks such as DLF Ultima and Vatika Township, Elan Imperial 82 provides a strategic location to enhance your business visibility and success. To know more visit our website https://www.elangroupprojects.com/elan-imperial-82/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 68711] Elan Imperial 82: Prime Commercial Spaces in Gurgaon - Invest for Success
https://bz.apache.org/bugzilla/show_bug.cgi?id=68711 Elan Imperial 82 changed: What|Removed |Added URL||https://www.elangroupprojec ||ts.com/elan-imperial-82/ OS||All --- Comment #1 from Elan Imperial 82 --- Position your business for success at Elan Imperial 82, a prime commercial destination in Sector 82, Gurgaon. Boasting an expansive 8-acre land parcel and a robust B+G+4 structure, this project features 100+ units with double-height outlets, offering a distinctive retail experience. Invest confidently with a starting price of ₹1.42 Cr* and an enticing 12% assured return. Benefit from essential amenities like lifts lobby, cafeteria, and a bar & lounge, ensuring a well-rounded commercial experience. With proximity to key landmarks such as DLF Ultima and Vatika Township, Elan Imperial 82 provides a strategic location to enhance your business visibility and success. To know more visit our website https://www.elangroupprojects.com/elan-imperial-82/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
