Re: Supposed to provide performance at daemon thread in tomcat

2024-01-14 Thread koteswara Rao Gundapaneni 
hi team

before clicking the link or check new private window in mozilla

[image: image.png]



when we browse the following link

https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master


[image: image.png]

Here the code page is shown as above



On Fri, Jan 12, 2024 at 6:41 PM koteswara Rao Gundapaneni <
koti.gundapan...@gmail.com> wrote:

>
> hi mark,
>
> please check if the code is now available at your end I verified from my
> end it can be visible
>
> On Fri, Jan 12, 2024 at 1:28 AM koteswara Rao Gundapaneni <
> koti.gundapan...@gmail.com> wrote:
>
>>
>> Sorry for the inconvenience as its been a private repo just now i
>> committed my changes to a new public repo
>>
>>
>> https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master
>>
>> Please find my attested changes in whole file 'Bootstrap.java'.
>>
>>
>>
>> On Fri, Jan 12, 2024 at 12:24 AM Mark Thomas  wrote:
>>
>>> On 12/01/2024 08:16, koteswara Rao Gundapaneni wrote:
>>> > Hi Team,
>>> >
>>> > As its milestone contribution for me I have added my branch along with
>>> the
>>> > pr created,
>>> >
>>> > Please add the reviewer here to commit the changes.
>>> >
>>> > Comparing singlemanager...KoteswararaoGundapaneni-patch-1 ·
>>> > KoteswararaoGundapaneni/MYREPO (github.com)
>>> > <
>>> https://github.com/KoteswararaoGundapaneni/MYREPO/compare/singlemanager...KoteswararaoGundapaneni-patch-1
>>> >
>>>
>>> That URI returns a 404.
>>>
>>> Unless and until you provide the information requested, further messages
>>> from you on this topic are likely to be ignored.
>>>
>>> Mark
>>>
>>>
>>>
>>> >
>>> >
>>> > -- Forwarded message -
>>> > From: Mark Thomas 
>>> > Date: Sat, Jan 6, 2024 at 2:05 AM
>>> > Subject: Re: Supposed to provide performance at daemon thread in tomcat
>>> > To: 
>>> >
>>> >
>>> > Please read my previous response and follow the instructions you were
>>> given.
>>> >
>>> > Mark
>>> >
>>> >
>>> > On 06/01/2024 06:26, koteswara Rao Gundapaneni wrote:
>>> >> Hi All,
>>> >>
>>> >> Somebody helps to give permissions to create the pull request as I
>>> have
>>> >> been trying to give the change at latest.
>>> >>
>>> >> regards,
>>> >> Koti
>>> >>
>>> >> On Fri, Jan 5, 2024 at 12:12 AM Mark Thomas  wrote:
>>> >>
>>> >>> On 05/01/2024 05:15, koteswara Rao Gundapaneni wrote:
>>>  It seems there are further permissions to be  added at Github
>>> 
>>>  *Error received via Github is as : **Pull request creation failed.
>>>  Validation failed: must be a collaborator*
>>> >>>
>>> >>> Anyone can submit a pull request to the Tomcat repository. The only
>>> >>> exception is users who have been blocked for spam/abuse.
>>> >>>
>>>  Actually i tried creating the pull request for providing the
>>> solution
>>> > for
>>>  daemon thread performance issue
>>> >>>
>>> >>> Please provide a link to your branch with the proposed fix.
>>> >>>
>>> >>> Please also provide a better description of the problem you are
>>> trying
>>> >>> to solve.
>>> >>>
>>> >>> Mark
>>> >>>
>>>  daemonthread background processing of the thread activity, and  it's
>>> >>> taking
>>>  significant amount of time during the tomcat launch.
>>> 
>>>  Simple hint over the next step of the solution is just like
>>> 
>>>  yield() provides the greater performance to the daemon thread
>>> startup.
>>> 
>>> 
>>>  Regards,
>>>  Koti
>>> 
>>> >>>
>>> >>> -
>>> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>> >>>
>>> >>>
>>> >>
>>> >
>>> > -
>>> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> > For additional commands, e-mail: dev-h...@tomcat.apache.org
>>> >
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>

Re: Supposed to provide performance at daemon thread in tomcat

2024-01-14 Thread Mark Thomas 
You have yet to provide an explanation of the problem you are trying to 
solve.


Unless and until you provide the information requested, further messages 
from you on this topic will be ignored.


Mark


On 14/01/2024 12:05, koteswara Rao Gundapaneni wrote:

hi team

before clicking the link or check new private window in mozilla

image.png



when we browse the following link

https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master 



image.png

Here the code page is shown as above



On Fri, Jan 12, 2024 at 6:41 PM koteswara Rao Gundapaneni 
mailto:koti.gundapan...@gmail.com>> wrote:



hi mark,

please check if the code is now available at your end I verified
from my end it can be visible

On Fri, Jan 12, 2024 at 1:28 AM koteswara Rao Gundapaneni
mailto:koti.gundapan...@gmail.com>> wrote:


Sorry for the inconvenience as its been a private repo just now
i committed my changes to a new public repo

https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master 


Please find my attested changes in whole file 'Bootstrap.java'.



On Fri, Jan 12, 2024 at 12:24 AM Mark Thomas mailto:ma...@apache.org>> wrote:

On 12/01/2024 08:16, koteswara Rao Gundapaneni wrote:
 > Hi Team,
 >
 > As its milestone contribution for me I have added my
branch along with the
 > pr created,
 >
 > Please add the reviewer here to commit the changes.
 >
 > Comparing singlemanager...KoteswararaoGundapaneni-patch-1 ·
 > KoteswararaoGundapaneni/MYREPO (github.com
)
 >

>

That URI returns a 404.

Unless and until you provide the information requested,
further messages
from you on this topic are likely to be ignored.

Mark



 >
 >
 > -- Forwarded message -
 > From: Mark Thomas mailto:ma...@apache.org>>
 > Date: Sat, Jan 6, 2024 at 2:05 AM
 > Subject: Re: Supposed to provide performance at daemon
thread in tomcat
 > To: mailto:dev@tomcat.apache.org>>
 >
 >
 > Please read my previous response and follow the
instructions you were given.
 >
 > Mark
 >
 >
 > On 06/01/2024 06:26, koteswara Rao Gundapaneni wrote:
 >> Hi All,
 >>
 >> Somebody helps to give permissions to create the pull
request as I have
 >> been trying to give the change at latest.
 >>
 >> regards,
 >> Koti
 >>
 >> On Fri, Jan 5, 2024 at 12:12 AM Mark Thomas
mailto:ma...@apache.org>> wrote:
 >>
 >>> On 05/01/2024 05:15, koteswara Rao Gundapaneni wrote:
  It seems there are further permissions to be  added at
Github
 
  *Error received via Github is as : **Pull request
creation failed.
  Validation failed: must be a collaborator*
 >>>
 >>> Anyone can submit a pull request to the Tomcat
repository. The only
 >>> exception is users who have been blocked for spam/abuse.
 >>>
  Actually i tried creating the pull request for
providing the solution
 > for
  daemon thread performance issue
 >>>
 >>> Please provide a link to your branch with the proposed fix.
 >>>
 >>> Please also provide a better description of the problem
you are trying
 >>> to solve.
 >>>
 >>> Mark
 >>>
  daemonthread background processing of the thread
activity, and  it's
 >>> taking
  significant amount of time during the tomcat launch.
 
  Simple hint over the next step of the solution is just
like
 
  yield() provides the greater performance to the daemon
thread startup.
 
 
  Regards,
  Koti
 
 >>>
 >>>

-

Re: Supposed to provide performance at daemon thread in tomcat

2024-01-14 Thread koteswara Rao Gundapaneni 
hi

Daemon threads have identified the performance issue inorder to complete .

so bootstrap has its performance issue as this loader thread is using
daemon thread.

inorder to resolve the issue we will yield the corresponding thread

regards,
koti


On Sun, Jan 14, 2024 at 4:13 AM Mark Thomas  wrote:

> You have yet to provide an explanation of the problem you are trying to
> solve.
>
> Unless and until you provide the information requested, further messages
> from you on this topic will be ignored.
>
> Mark
>
>
> On 14/01/2024 12:05, koteswara Rao Gundapaneni wrote:
> > hi team
> >
> > before clicking the link or check new private window in mozilla
> >
> > image.png
> >
> >
> >
> > when we browse the following link
> >
> >
> https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master
> <
> https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master
> >
> >
> >
> > image.png
> >
> > Here the code page is shown as above
> >
> >
> >
> > On Fri, Jan 12, 2024 at 6:41 PM koteswara Rao Gundapaneni
> > mailto:koti.gundapan...@gmail.com>> wrote:
> >
> >
> > hi mark,
> >
> > please check if the code is now available at your end I verified
> > from my end it can be visible
> >
> > On Fri, Jan 12, 2024 at 1:28 AM koteswara Rao Gundapaneni
> > mailto:koti.gundapan...@gmail.com>>
> wrote:
> >
> >
> > Sorry for the inconvenience as its been a private repo just now
> > i committed my changes to a new public repo
> >
> >
> https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master
> <
> https://github.com/KoteswararaoGundapaneni/KotiSpringRepository/tree/master
> >
> >
> > Please find my attested changes in whole file 'Bootstrap.java'.
> >
> >
> >
> > On Fri, Jan 12, 2024 at 12:24 AM Mark Thomas  > > wrote:
> >
> > On 12/01/2024 08:16, koteswara Rao Gundapaneni wrote:
> >  > Hi Team,
> >  >
> >  > As its milestone contribution for me I have added my
> > branch along with the
> >  > pr created,
> >  >
> >  > Please add the reviewer here to commit the changes.
> >  >
> >  > Comparing singlemanager...KoteswararaoGundapaneni-patch-1
> ·
> >  > KoteswararaoGundapaneni/MYREPO (github.com
> > )
> >  >
> > <
> https://github.com/KoteswararaoGundapaneni/MYREPO/compare/singlemanager...KoteswararaoGundapaneni-patch-1
> <
> https://github.com/KoteswararaoGundapaneni/MYREPO/compare/singlemanager...KoteswararaoGundapaneni-patch-1
> >>
> >
> > That URI returns a 404.
> >
> > Unless and until you provide the information requested,
> > further messages
> > from you on this topic are likely to be ignored.
> >
> > Mark
> >
> >
> >
> >  >
> >  >
> >  > -- Forwarded message -
> >  > From: Mark Thomas  > >
> >  > Date: Sat, Jan 6, 2024 at 2:05 AM
> >  > Subject: Re: Supposed to provide performance at daemon
> > thread in tomcat
> >  > To: mailto:dev@tomcat.apache.org
> >>
> >  >
> >  >
> >  > Please read my previous response and follow the
> > instructions you were given.
> >  >
> >  > Mark
> >  >
> >  >
> >  > On 06/01/2024 06:26, koteswara Rao Gundapaneni wrote:
> >  >> Hi All,
> >  >>
> >  >> Somebody helps to give permissions to create the pull
> > request as I have
> >  >> been trying to give the change at latest.
> >  >>
> >  >> regards,
> >  >> Koti
> >  >>
> >  >> On Fri, Jan 5, 2024 at 12:12 AM Mark Thomas
> > mailto:ma...@apache.org>> wrote:
> >  >>
> >  >>> On 05/01/2024 05:15, koteswara Rao Gundapaneni wrote:
> >   It seems there are further permissions to be  added at
> > Github
> >  
> >   *Error received via Github is as : **Pull request
> > creation failed.
> >   Validation failed: must be a collaborator*
> >  >>>
> >  >>> Anyone can submit a pull request to the Tomcat
> > repository. The only
> >  >>> exception is users who have been blocked for spam/abuse.
> >  >>>
> >   Actually i tried creating the pull request for
> > providing the solution
> >  > for
> >   daemon thread performance issue
> >  >>>
> >  >>> Please provide a link to your branch with the proposed
> fix.
> >  >>>
> >  >>> Please also

(tomcat) branch main updated: Fix indent

2024-01-14 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 6ec0898bc6 Fix indent
6ec0898bc6 is described below

commit 6ec0898bc6ef41a359c8713da1697b43ae273fc5
Author: Mark Thomas 
AuthorDate: Mon Jan 15 07:49:23 2024 +

Fix indent
---
 java/org/apache/catalina/session/StandardSession.java | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/catalina/session/StandardSession.java 
b/java/org/apache/catalina/session/StandardSession.java
index 81803a9d1c..bf2c944afd 100644
--- a/java/org/apache/catalina/session/StandardSession.java
+++ b/java/org/apache/catalina/session/StandardSession.java
@@ -623,11 +623,11 @@ public class StandardSession implements HttpSession, 
Session, Serializable {
 
 @Override
 public Accessor getAccessor() {
-   if (!isValidInternal()) {
-   throw new 
IllegalStateException(sm.getString("standardSession.getAccessor.ise"));
-   }
+if (!isValidInternal()) {
+throw new 
IllegalStateException(sm.getString("standardSession.getAccessor.ise"));
+}
 
-   return new StandardSessionAccessor(getManager(), getId());
+return new StandardSessionAccessor(getManager(), getId());
 }
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org