[GitHub] [tomcat] babyblue94520 closed pull request #645: feat(Http11Processor): Add max value in keepalive.
babyblue94520 closed pull request #645: feat(Http11Processor): Add max value in keepalive. URL: https://github.com/apache/tomcat/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 --- Comment #22 from Rainer Jung --- Thanks for the great finding! I plan to apply your patch. Since -E is not a standardized linker flag I would rather prefer to not include it. For me it made no difference, whether I add the -Wl,-E (so the -E flag for ld). the full "nm" output was the same when uusing it and when not using it, alsways combined with out symbol regexp. Thanks and regards, Rainer -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf opened a new pull request, #646: Parameter error handling
markt-asf opened a new pull request, #646: URL: https://github.com/apache/tomcat/pull/646 This PR updates the parameter error handling to align with the changes in Jakarta Servlet 6.0 The short version is all getParameterXXX() calls now throw exceptions on invalid parameters. Note that getParts() still needs to work even if the query string parameters are invalid. I'm providing this as a PR to give folks a chance to review it before it is merged given that it is a significant change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66005] Apache crashes, if there is a tomcat server, which can not be resolved
https://bz.apache.org/bugzilla/show_bug.cgi?id=66005 --- Comment #23 from Rainer Jung --- Too many typos: Thanks for the great finding! I plan to apply your patch. Since -E is not a standardized linker flag I would rather prefer to not include it. For me it made no difference, whether I add the -Wl,-E (so the -E flag for ld). the full "nm" output was the same when using it and when not using it, always combined with your symbol regexp. Thanks and regards, Rainer -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] aooohan commented on pull request #646: Parameter error handling
aooohan commented on PR #646: URL: https://github.com/apache/tomcat/pull/646#issuecomment-1684798995 This change look good for me. But I have found that `org.apache.catalina.valves.ExtendedAccessLogValve.RequestParameterElement` behavior is broken due to this change. Maybe here should catch `InvalidParameterException`, right ? Also, we should check if exist others call `getParameter` internally after this change merged. : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
