[Bug 66670] Add SSLHostConfig#certificateKeyPasswordFile

2023-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66670

--- Comment #8 from Michael Osipov  ---
(In reply to Christopher Schultz from comment #1)
> Why not just use an XML entity?
> 
>  
> ]>
> ...
> ...
>  ...>
>  ...>
>  ...>
>  ...>
>  ...>
>  ...>
> 
> Or, if you really want to use a separate file:
> 
>  
> ]>
> 
> ?

This does not work:
SCHWERWIEGEND: Parse Fatal Error at line 33 column 44: Externe Entityreferenz
"&certPassword;" ist in einem Attributwert nicht zulässig.
org.xml.sax.SAXParseException; systemId:
file:/var/opt/tomcat-services/conf/server.xml; lineNumber: 33; columnNumber:
44; Externe Entityreferenz "&certPassword;" ist in einem Attributwert nicht
zulässig.
at
com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)
at
com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:178)
at
com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
at
com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:32

because of https://stackoverflow.com/a/65784393/696632

I will pursue a draft PR next week.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66670] Add SSLHostConfig#certificateKeyPasswordFile

2023-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66670

--- Comment #9 from Mark Thomas  ---
(In reply to Michael Osipov from comment #8)

> because of https://stackoverflow.com/a/65784393/696632

Doesn't that link also offer a solution (an internal entity) that would work
for this use case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66670] Add SSLHostConfig#certificateKeyPasswordFile

2023-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66670

--- Comment #10 from Michael Osipov  ---
(In reply to Mark Thomas from comment #9)
> (In reply to Michael Osipov from comment #8)
> 
> > because of https://stackoverflow.com/a/65784393/696632
> 
> Doesn't that link also offer a solution (an internal entity) that would work
> for this use case?

> Reference an internal entity from an attribute value

Partially, because it still would require me to touch every server.xml file. So
it is a half-hearted solution, then I can keep vim's "s#old#new#c".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org