[GitHub] [tomcat] ppkarwasz opened a new pull request, #545: Replace `LoggerThread` with single-threaded executor

[GitBox]

ppkarwasz opened a new pull request, #545:
URL: https://github.com/apache/tomcat/pull/545

   This provides an alternative solution to the `LoggerThread` problems 
described in #544.
   
   It replaces `LoggerThread` with a single-threaded `ExecutorService` almost 
identical to the one used by `FileHandler`. This improves `AsyncFileHandler` in 
two aspects:
   
* the thread created by the executor service always uses Tomcat JULI's 
classloader as TCCL, preventing a memory leak,
* if an `Error` kills the working thread, it is regenerated by the executor 
service.
   
   A test is provided to ensure that the previous overflow policies work as 
documented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

[GitBox]

aooohan commented on code in PR #33:
URL: 
https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r950782169


##
src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java:
##
@@ -0,0 +1,16 @@
+package org.apache.tomcat.jakartaee;
+
+import static org.junit.Assert.assertTrue;

Review Comment:
   Please do not use static import.



##
src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java:
##
@@ -0,0 +1,16 @@
+package org.apache.tomcat.jakartaee;
+
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+
+public class ManifestConverterTest {
+
+   @Test
+public void testAccepts() {

Review Comment:
   Note the code format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org