[tomcat] branch main updated: Fix IDE warning

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 10bedf3a17 Fix IDE warning
10bedf3a17 is described below

commit 10bedf3a17f803e063d38235c175c7da90e68a7f
Author: Mark Thomas 
AuthorDate: Wed Aug 17 12:38:04 2022 +0100

Fix IDE warning
---
 test/org/apache/juli/TestClassLoaderLogManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/juli/TestClassLoaderLogManager.java 
b/test/org/apache/juli/TestClassLoaderLogManager.java
index 8628deac16..696af00ccb 100644
--- a/test/org/apache/juli/TestClassLoaderLogManager.java
+++ b/test/org/apache/juli/TestClassLoaderLogManager.java
@@ -87,7 +87,7 @@ public class TestClassLoaderLogManager {
 listThread.setRunning(false);
 }
 
-/**
+/*
  * Tests if a per-app root logger has a not {@code null} level.
  */
 @Test


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 10.0.x updated: Fix IDE warning

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.0.x by this push:
 new 10a1ec88c9 Fix IDE warning
10a1ec88c9 is described below

commit 10a1ec88c9204a052a937e4a338697b113880b1b
Author: Mark Thomas 
AuthorDate: Wed Aug 17 12:38:04 2022 +0100

Fix IDE warning
---
 test/org/apache/juli/TestClassLoaderLogManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/juli/TestClassLoaderLogManager.java 
b/test/org/apache/juli/TestClassLoaderLogManager.java
index 8628deac16..696af00ccb 100644
--- a/test/org/apache/juli/TestClassLoaderLogManager.java
+++ b/test/org/apache/juli/TestClassLoaderLogManager.java
@@ -87,7 +87,7 @@ public class TestClassLoaderLogManager {
 listThread.setRunning(false);
 }
 
-/**
+/*
  * Tests if a per-app root logger has a not {@code null} level.
  */
 @Test


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix IDE warning

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 7c219ea929 Fix IDE warning
7c219ea929 is described below

commit 7c219ea929eab4076a1611bfe6e01ba853117f81
Author: Mark Thomas 
AuthorDate: Wed Aug 17 12:38:04 2022 +0100

Fix IDE warning
---
 test/org/apache/juli/TestClassLoaderLogManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/juli/TestClassLoaderLogManager.java 
b/test/org/apache/juli/TestClassLoaderLogManager.java
index 8628deac16..696af00ccb 100644
--- a/test/org/apache/juli/TestClassLoaderLogManager.java
+++ b/test/org/apache/juli/TestClassLoaderLogManager.java
@@ -87,7 +87,7 @@ public class TestClassLoaderLogManager {
 listThread.setRunning(false);
 }
 
-/**
+/*
  * Tests if a per-app root logger has a not {@code null} level.
  */
 @Test


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix IDE warning

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 800832b773 Fix IDE warning
800832b773 is described below

commit 800832b7733f25f3799fcafad5edbf0a817f5186
Author: Mark Thomas 
AuthorDate: Wed Aug 17 12:38:04 2022 +0100

Fix IDE warning
---
 test/org/apache/juli/TestClassLoaderLogManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/juli/TestClassLoaderLogManager.java 
b/test/org/apache/juli/TestClassLoaderLogManager.java
index 8628deac16..696af00ccb 100644
--- a/test/org/apache/juli/TestClassLoaderLogManager.java
+++ b/test/org/apache/juli/TestClassLoaderLogManager.java
@@ -87,7 +87,7 @@ public class TestClassLoaderLogManager {
 listThread.setRunning(false);
 }
 
-/**
+/*
  * Tests if a per-app root logger has a not {@code null} level.
  */
 @Test


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66178] Reduce garbage from strings in AbstractArchiveResourceSet.getResource

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66178

--- Comment #12 from Mark Thomas  ---
Note that cache validation needs to be per URI (and not per JAR) to account for
various use cases where web application resources are changed while a web
application is running and those resources overlap with other resources (see
PreResources and PostResources).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

BUILDING.txt

[Christopher Schultz]

I just noticed that BUILDING.txt in the source distribution of Tomcat 
8.5.82 hasn't been merged as expected:


"

Building The Apache Tomcat @VERSION_MAJOR_MINOR@ 
Servlet/JSP Container



This project contains the source code for Tomcat @VERSION_MAJOR_MINOR@, 
a container that
implements the Servlet @SERVLET_SPEC_VERSION@, JSP @JSP_SPEC_VERSION@, 
EL @EL_SPEC_VERSION@, WebSocket @WEBSOCKET_SPEC_VERSION@ and JASPIC 
@JASPIC_SPEC_VERSION@

specifications from the Java Community Process .
"

I think we might need to enable token-replacement during copy. Or 
something else. I'll have a look.


I'd also like to add some information about the repeatable build process.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 66209] CPU regression when classpath Bloom filters are active

[Christopher Schultz]

Mark,

On 8/15/22 06:10, bugzi...@apache.org wrote:

https://bz.apache.org/bugzilla/show_bug.cgi?id=66209

--- Comment #1 from Mark Thomas  ---
This patch essentially trades memory for performance. We have some users that
won't want to make that trade - even if the memory concerned is relatively
small.

Given the competing demands here, I think we need to find a way to make this
configurable. Whether that is by expanding useBloomFilterForArchives beyond a
simple boolean, by tweaking the background processing frequency or by a new
configuration option is TBD. I want to mull this over a little bit before
making any changes.


+1

true = use the bloom filter as exists today
false = do not use the bloom filter
wankel = use the bloom filter with cach-purges

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66209] CPU regression when classpath Bloom filters are active

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66209

--- Comment #3 from Christopher Schultz  ---
(In reply to Mark Thomas from comment #1)
> This patch essentially trades memory for performance. We have some users
> that won't want to make that trade - even if the memory concerned is
> relatively small.
> 
> Given the competing demands here, I think we need to find a way to make this
> configurable. Whether that is by expanding useBloomFilterForArchives beyond
> a simple boolean, by tweaking the background processing frequency or by a
> new configuration option is TBD. I want to mull this over a little bit
> before making any changes.
> 
> Thoughts?

+1

true = use the bloom filter as exists today
false = do not use the bloom filter
wankel = use the bloom filter with cache-purges

I think it makes sense to re-name/alias the current setting to something more
clear such as "archiveIndexing" with values like "simple", "bloom" and now
"purged-bloom" or whatever.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BUILDING.txt

[Christopher Schultz]

All,

On 8/17/22 21:23, Christopher Schultz wrote:
I just noticed that BUILDING.txt in the source distribution of Tomcat 
8.5.82 hasn't been merged as expected:


"
     
     Building The Apache Tomcat @VERSION_MAJOR_MINOR@ 
Servlet/JSP Container

     

This project contains the source code for Tomcat @VERSION_MAJOR_MINOR@, 
a container that
implements the Servlet @SERVLET_SPEC_VERSION@, JSP @JSP_SPEC_VERSION@, 
EL @EL_SPEC_VERSION@, WebSocket @WEBSOCKET_SPEC_VERSION@ and JASPIC 
@JASPIC_SPEC_VERSION@

specifications from the Java Community Process .
"

I think we might need to enable token-replacement during copy. Or 
something else. I'll have a look.


I'd also like to add some information about the repeatable build process.


FWIW, the copy of BUILDING.txt that goes into 
output/build/webapps/docs/BUILDING.txt is properly-merged. I think when 
performing a "release" build, that file, once merged, need to be copied 
over the BUILDING.txt that is at the root of the source archive.


-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BUILDING.txt

[Han Li]

Chris,

I found that BUILDING.txt in the source distribution of all version hasn’t been 
merged as expected.
I think this is a source distribution, BUILDING.txt is part of the source, so 
it’s normal for this file not to be processed.

Best Regards,

Han

> 2022年8月18日 09:36，Christopher Schultz  写道：
> 
> All,
> 
> On 8/17/22 21:23, Christopher Schultz wrote:
>> I just noticed that BUILDING.txt in the source distribution of Tomcat 8.5.82 
>> hasn't been merged as expected:
>> "
>> 
>> Building The Apache Tomcat @VERSION_MAJOR_MINOR@ Servlet/JSP Container
>> 
>> This project contains the source code for Tomcat @VERSION_MAJOR_MINOR@, a 
>> container that
>> implements the Servlet @SERVLET_SPEC_VERSION@, JSP @JSP_SPEC_VERSION@, EL 
>> @EL_SPEC_VERSION@, WebSocket @WEBSOCKET_SPEC_VERSION@ and JASPIC 
>> @JASPIC_SPEC_VERSION@
>> specifications from the Java Community Process .
>> "
>> I think we might need to enable token-replacement during copy. Or something 
>> else. I'll have a look.
>> I'd also like to add some information about the repeatable build process.
> 
> FWIW, the copy of BUILDING.txt that goes into 
> output/build/webapps/docs/BUILDING.txt is properly-merged. I think when 
> performing a "release" build, that file, once merged, need to be copied over 
> the BUILDING.txt that is at the root of the source archive.
> 
> -chris
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org 
> 
> For additional commands, e-mail: dev-h...@tomcat.apache.org 
> 

Migrate from Bugzilla to GitHub Issues

[Vladimir Sitnikov]

Hi,


Have you considered migrating from Bugzilla to GitHub Issues?

I think co-locating issues, code, and PRs at GitHub would make it easier to
browse both issues and code.

I guess many Tomcat users browse code (including Tomcat code) in GitHub,
and they would likely use GitHub PRs (Tomcat PRs and PRs for the other
projects).

It is inconvenient to require Bugzilla login for the sole purpose of filing
an issue.

It is inconvenient that search over bugs is disconnected from search over
code.

If bugs are migrated to GitHub, then a single GitHub search would work for
everything: code, issues, PRs

GitHub allows richer comment formatting (e.g. code highlight).

GitHub shows code preview when you mention link to code in an issue comment.

Moving issues to GitHub would unlock cross-references between projects
(e.g. users could mention Tomcat issues)
so others can see which projects reference the same issue, and sometimes
you could peek into the workarounds.

I'm working on migrating Apache JMeter (Bugzilla -> GitHub Issues), see

https://lists.apache.org/thread/xmccss17s6sm8wzcm56d7sr6py663s7w ,

and I have a migration script https://github.com/vlsi/bugzilla2github

It preserves bugs, comments, attachments, and links between bugs.

Here's a recent dry-run for JMeter:
https://github.com/vlsi/tmp-jmeter-issues

For reference, the first bug in JMeter was filed on 2003, and we look
forward to migrating all the ~5K bugs to GitHub issues.

LLVM moved from Bugzilla to GitHub a year ago (50K bugs since 2003)

WDYT?

Vladimir

[GitHub] [tomcat] tianshuang opened a new pull request, #543: Optimize comment

[GitBox]

tianshuang opened a new pull request, #543:
URL: https://github.com/apache/tomcat/pull/543

   HTTP2 also supports relative redirects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org