Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-13 Thread Mark Thomas

Works for me. CI systems (Gump, BuidlBot) also look OK.

Maybe something related to the build environment?

Mark


On 12/03/2022 19:45, Igal Sapir wrote:

On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:


The proposed Apache Tomcat 10.1.0-M12 release is now available for
voting.

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory.

The notable changes compared to 10.1.0-M11 are:

- Fix a potential thread-safety issue that could cause HTTP/1.1 request
processing to pause, and potentially timeout, waiting for additional
data when the full request has been received.

- Fix a regression introduced with 65757 bugfix which better identified
non request threads but which introduced a similar problem when user
code was doing sequential operations in a single thread.

- When resolving methods in EL expressions that use beans and/or static
fields, ensure that any custom type conversion is considered when
identifying the method to call.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1360

The tag is:
https://github.com/apache/tomcat/tree/10.1.0-M12
d08498a3cefa7206bad791acf019455794f865ea


The proposed 10.1.0-M12 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)



Was there a change in dependencies?  I get an error while trying to run
`ant clean test` using Java 11.0.14 on Ubuntu 20.04:

package:
   [jar] Building jar:
/workspace/build/tomcat/main/build/lib/annotations-api.jar

add-osgi:
  [echo] add-osgi
/workspace/build/tomcat/main/build/lib/annotations-api.jar true
   [bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin - Using
module name 'jakarta.annotation' for: Jar:annotations-api
   [bnd] 2 ERRORS
   [bnd]  Input file does not exist:
../../output/manifests/default.license
   [bnd]  Input file does not exist:
../../output/manifests/default.notice
   [bnd] /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
bnd failed
   [bnd] at
aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
   [bnd] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
   [bnd] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
Source)
   [bnd] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [bnd] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   [bnd] at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
   ...
BUILD FAILED
/workspace/src/tomcat/main/build.xml:1036: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3798: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:


Igal






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.0.18

2022-03-13 Thread Mark Thomas

On 12/03/2022 19:27, Igal Sapir wrote:


The unit
test TEST-org.apache.tomcat.jni.TestSocketServerAnyLocalAddress.NIO2.txt
which used to work properly in my environment is failing with an error [1].

Any ideas why?


Nothing obvious. Maybe use Wireshark to see what is going on?

Mark




Igal

[1] Testsuite: org.apache.tomcat.jni.TestSocketServerAnyLocalAddress
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 130.291 sec
- Standard Output ---
Server is listening at [/0:0:0:0:0:0:0:0:35999]
Client attempting to connect to [/2600:1700:4000:8120:0:0:0:40%wlp2s0:35999]
-  ---
- Standard Error -
java.net.ConnectException: Connection timed out (Connection timed out)
 at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
 at
java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:412)
 at
java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:255)
 at
java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:237)
 at
java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
 at java.base/java.net.Socket.connect(Socket.java:615)
 at
org.apache.tomcat.jni.TestSocketServerAnyLocalAddress$Client.run(TestSocketServerAnyLocalAddress.java:139)
-  ---

Testcase: testWithClient took 130.268 sec
 Caused an ERROR
22: Invalid argument
org.apache.tomcat.jni.Error: 22: Invalid argument
 at org.apache.tomcat.jni.Socket.accept(Native Method)
 at
org.apache.tomcat.jni.TestSocketServerAnyLocalAddress.testWithClient(TestSocketServerAnyLocalAddress.java:94)
 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
 at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: tomcat-coyote vs. tomcat-catalina modularity problem

2022-03-13 Thread Mark Thomas

On 13/03/2022 03:07, Raymond Augé wrote:

tomcat-catalina imports org.apache.tomcat.util.http.fileupload.impl [1]
tomcat-coyote however does not export
org.apache.tomcat.util.http.fileupload.impl

How would you like to address this?

Should tomcat-coyote simply export the package?


Seems like the obvious choice.


or should the classes (two
Exceptions) be made part of the Coyote API (not a breaking change to
outsiders since it's like adding never before seen types.)


Do you mean move those classes to a new package? If so, exporting looks 
better as these classes are a packaged renamed form of Commons File 
Upload so keeping classes in the existing is preferred.


Mark



This affects all versions from what I can see. It's not a critical issue,
just a packaging and modularity one. It WOULD however come into play in
OSGi or JPMS use cases.

Thoughts?

Ray

[1]
https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Request.java#L110-L111



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: tomcat-coyote vs. tomcat-catalina modularity problem

2022-03-13 Thread Raymond Augé
👍 I'll prepare a pr.

On Sun., Mar. 13, 2022, 1:11 p.m. Mark Thomas,  wrote:

> On 13/03/2022 03:07, Raymond Augé wrote:
> > tomcat-catalina imports org.apache.tomcat.util.http.fileupload.impl [1]
> > tomcat-coyote however does not export
> > org.apache.tomcat.util.http.fileupload.impl
> >
> > How would you like to address this?
> >
> > Should tomcat-coyote simply export the package?
>
> Seems like the obvious choice.
>
> > or should the classes (two
> > Exceptions) be made part of the Coyote API (not a breaking change to
> > outsiders since it's like adding never before seen types.)
>
> Do you mean move those classes to a new package? If so, exporting looks
> better as these classes are a packaged renamed form of Commons File
> Upload so keeping classes in the existing is preferred.
>
> Mark
>
>
> > This affects all versions from what I can see. It's not a critical issue,
> > just a packaging and modularity one. It WOULD however come into play in
> > OSGi or JPMS use cases.
> >
> > Thoughts?
> >
> > Ray
> >
> > [1]
> >
> https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Request.java#L110-L111
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[tomcat] tag 8.5.77 created (now 3931695)

2022-03-13 Thread schultz
This is an automated email from the ASF dual-hosted git repository.

schultz pushed a change to tag 8.5.77
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


  at 3931695  (commit)
This tag includes the following new commits:

 new 3931695  Tag 8.5.77

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] 01/01: Tag 8.5.77

2022-03-13 Thread schultz
This is an automated email from the ASF dual-hosted git repository.

schultz pushed a commit to tag 8.5.77
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 3931695e564dd4dd1dbf029026e900b74992408c
Author: schultz 
AuthorDate: Sun Mar 13 12:15:20 2022 -0700

Tag 8.5.77
---
 build.properties.default   | 7 ---
 webapps/docs/changelog.xml | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 64cb22e..59e32da 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -33,13 +33,14 @@ version.major=8
 version.minor=5
 version.build=77
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Reproducible builds -
 # Uncomment and set to current time for reproducible builds
 # Note: The value is in seconds (unlike milliseconds used by 
System.currentTimeMillis()).
-#2022-01-12T06:00:00Z
-#ant.tstamp.now=1642003200
+ant.tstamp.now=1647198813
+#2022-03-13 19:13:33 UTC
+
 
 # - Source control flags -
 git.branch=8.5.x
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 74d49de..9909691 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,7 +104,7 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
   
 
   

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-13 Thread Igal Sapir
Mark,

On Sun, Mar 13, 2022 at 10:00 AM Mark Thomas  wrote:

> Works for me. CI systems (Gump, BuidlBot) also look OK.
>
> Maybe something related to the build environment?
>

Thanks!  I see the problem, and it also affects other versions, e.g. 9.0.x.

For each major version I have a git tree, and in that directory I have a
setting for the output directory, e.g. for 9.0.x I have
  tomcat.output=/workspace/build/tomcat/9.0.x

The manifest files are created in the correct directory:
  build-manifests:
  [mkdir] Created dir: /workspace/build/tomcat/9.0.x/manifests
   [copy] Copying 21 files to /workspace/build/tomcat/9.0.x/manifests

But are then "read" from the wrong place and fail because there is no such
directory:
  [bnd] 2 ERRORS
  [bnd]  Input file does not exist:
../../output/manifests/default.license
  [bnd]  Input file does not exist:
../../output/manifests/default.notice
  [bnd]
/workspace/src/tomcat/9.0.x/res/bnd/annotations-api.jar.tmp.bnd: bnd failed

I will try to find where that happens and patch it.

Igal



>
> Mark
>
>
> On 12/03/2022 19:45, Igal Sapir wrote:
> > On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:
> >
> >> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> >> voting.
> >>
> >> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> >> without changes. Java EE applications designed for Tomcat 9 and earlier
> >> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> >> will automatically convert them to Jakarta EE and copy them to the
> >> webapps directory.
> >>
> >> The notable changes compared to 10.1.0-M11 are:
> >>
> >> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
> >> processing to pause, and potentially timeout, waiting for additional
> >> data when the full request has been received.
> >>
> >> - Fix a regression introduced with 65757 bugfix which better identified
> >> non request threads but which introduced a similar problem when user
> >> code was doing sequential operations in a single thread.
> >>
> >> - When resolving methods in EL expressions that use beans and/or static
> >> fields, ensure that any custom type conversion is considered when
> >> identifying the method to call.
> >>
> >> For full details, see the changelog:
> >> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
> >>
> >> The Maven staging repo is:
> >> https://repository.apache.org/content/repositories/orgapachetomcat-1360
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat/tree/10.1.0-M12
> >> d08498a3cefa7206bad791acf019455794f865ea
> >>
> >>
> >> The proposed 10.1.0-M12 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
> >>
> >
> > Was there a change in dependencies?  I get an error while trying to run
> > `ant clean test` using Java 11.0.14 on Ubuntu 20.04:
> >
> > package:
> >[jar] Building jar:
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar
> >
> > add-osgi:
> >   [echo] add-osgi
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar true
> >[bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin -
> Using
> > module name 'jakarta.annotation' for: Jar:annotations-api
> >[bnd] 2 ERRORS
> >[bnd]  Input file does not exist:
> > ../../output/manifests/default.license
> >[bnd]  Input file does not exist:
> > ../../output/manifests/default.notice
> >[bnd]
> /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
> > bnd failed
> >[bnd] at
> > aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
> >[bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
> >[bnd] at
> > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
> >[bnd] at
> jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
> > Source)
> >[bnd] at
> >
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >[bnd] at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> >[bnd] at
> >
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
> >[bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
> >...
> > BUILD FAILED
> > /workspace/src/tomcat/main/build.xml:1036: The following error occurred
> > while executing this line:
> > /workspace/src/tomcat/main/build.xml:3798: The following error occurred
> > while executing this line:
> > /workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:
> >
> >
> > Igal
> >
> >
> >
> >
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>

svn commit: r53017 [1/2] - in /dev/tomcat/tomcat-8/v8.5.77: ./ bin/ bin/embed/ bin/extras/ src/

2022-03-13 Thread schultz
Author: schultz
Date: Sun Mar 13 19:31:20 2022
New Revision: 53017

Log:
Upload 8.5.77 for voting.

Added:
dev/tomcat/tomcat-8/v8.5.77/
dev/tomcat/tomcat-8/v8.5.77/KEYS
dev/tomcat/tomcat-8/v8.5.77/README.html
dev/tomcat/tomcat-8/v8.5.77/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.5.77/bin/
dev/tomcat/tomcat-8/v8.5.77/bin/README.html
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.zip.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-deployer.zip.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x64.zip.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77-windows-x86.zip.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.exe   (with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.exe.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.exe.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.zip   (with props)
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.zip.asc
dev/tomcat/tomcat-8/v8.5.77/bin/apache-tomcat-8.5.77.zip.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/embed/
dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.tar.gz.asc

dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.zip.asc
dev/tomcat/tomcat-8/v8.5.77/bin/embed/apache-tomcat-8.5.77-embed.zip.sha512
dev/tomcat/tomcat-8/v8.5.77/bin/extras/
dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.sha512
dev/tomcat/tomcat-8/v8.5.77/src/
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip   (with props)
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip.asc
dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip.sha512

Added: dev/tomcat/tomcat-8/v8.5.77/KEYS
==
--- dev/tomcat/tomcat-8/v8.5.77/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.5.77/KEYS Sun Mar 13 19:31:20 2022
@@ -0,0 +1,785 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+Type Bits/KeyIDDate   User ID
+pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: PGPfreeware 7.0.3 for non-commercial use 
+
+mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
+gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
+I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
+bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
+B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz
+gNftTbKx/MVS7cQU0II8BKo2Akr+1FZah+sD4ovK8SfkMXUQUbTeefTntsAQKyyU
+9M9tA/9on9tBiHFl0qVJht6N4GiJ2G689v7rS2giLgKjetjiCduxBXEgvUSuyQID
+nF9ATrpXjITwsRlGKFmpZiFm5oCeCXihIVH0u6q066xNW2AXkLVoJ1l1Rs2Z0lsb
+0cq3xEAcwAmYLKQvCtgDV8CYgWKVmPi+49rSuQn7Lo9l02OUbLQgQW

svn commit: r53017 [2/2] - in /dev/tomcat/tomcat-8/v8.5.77: ./ bin/ bin/embed/ bin/extras/ src/

2022-03-13 Thread schultz
Added: dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.asc
==
--- dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.asc Sun Mar 13 
19:31:20 2022
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAmIuRNcACgkQHPApP6U8
+pFhc1g/+PXPK0q8kJc+PKmNt2yW07aJPdm2fffKLTIJIobSwAC91Pif5oIC6u5ln
+SH0oxn9Z1Tj9GwuchIeuFf4QV2AmafOs7HfArcj2To+mwfqlMtnZm3EZeVyFeD5H
+a3YfUPxTjoO6sbRocHnElYojMiDvZJP2+1BZI9mqjLnEqVep9r8gFVeCU4lZ48qa
+D7IqmFKaNSsqh09cbpglTj35ysCMIL+3ZE0dm8e+CwwyEHhtQeVrgOh+VuLzl/ea
++d42bSrBfytIduvLtNLVS6Z6WIcckdGAiVmKr7+16RKSUY6eoyFCo+IsdPiRN9d1
+QR7xIb1/y45OSiaKmkVZqcVDQPj6mWGwmUHn+yl7gHdwKKEl4dhZwx1KswPjYxV8
+RMNKyYV2qVHjkmDhUt0pgJU8Z0X/F7zF2v3q1EjF6MEs7hBsyVwuOr5FZBAUIIWk
+a38dx3uyOun9RIItkx/NPtPkQKiuMDWoBM4Ti5C2gWAKEzfxTyaanWXlp97pTB6u
+4UFUwrXec0+OHrpiC39lWS/Et/tq39zgYkukascpnP1zAMO8RqXMiB5sAnKR52Y0
+3oZJCHV1kGhwi3yPqpJxpxb1O1h3WfHyB5zjy+zpgGXTmFAfQPwK9UlO+xI5aa9R
+EEmIR2v2sECfu4pCm75QnLnVCFR9ydzQXFzwqJGLk7MQdyBoMbw=
+=hnzA
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.sha512
==
--- dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.sha512 (added)
+++ dev/tomcat/tomcat-8/v8.5.77/bin/extras/catalina-ws.jar.sha512 Sun Mar 13 
19:31:20 2022
@@ -0,0 +1 @@
+fe6057f530c3515c3d4d2b10282efbfac6fcf89682c39cca77a8261dd905811f594b41c134e530fe040523e4883639a069f13b326cd8b1373d57f07e27f43a73
 *catalina-ws.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.asc
==
--- dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.asc Sun Mar 
13 19:31:20 2022
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAmIuRe8ACgkQHPApP6U8
+pFgL5A//SJXtuZvpkELO0CaZ4QnqKGCkgb1Of2W1HC6PbrM6J9T8lDEMBgHgDAjF
+7Xky64Y4Iyj3DNVR+lvqPVOyfQ2zGvRJtV5Mttm/zm9SlABups6m1hdrpzfcSkem
+ZLBYUHAGMnjh2uJUZYfVCWCLrhsU252BfhU0SRk3zDqYNv7VEc5fbeRdQkqJWuiU
+4tPfr0GXkzJ4kbovfsIlEAc9A/sGBcykQvqwgR9nNkBZcETN6WcVDitweL1fJ4iU
+mS3Z81tgQ14cOvO71QZ0VwmILlO1emz5GfKrdMWJVbXYmQ+tqXKltrHiBUl0IrJF
+ZFmERDkYw32iZmbZTuJe0om1bftsCXmu5e8ZZH4eGZl1URbws38rKewyXANkkplS
+LeW/kL26l9YPVEMdghUnk4/WJ/fAccVicgAGPTDfqInMeovwqWkDD0suI/77XwVl
+qABFzsAkOCkwjRGHkATusTdRF7YURANuOOdOl+99fJLzzUDMuK37OZ5LKlbWsLJG
+obUk4sj7Cz7Tim6pqiiwuz3pAfoXyIoOQZhrg3KmTE1aCNBeVyDoPThxp0BvuhAO
+3OyATtfDYmgE6JlopNx5m00D+YB+IEQAyFtxIdokr7ktDq3IU/YYwao8NzYxD7AF
+yYAg7/vKuymSh1sJfRwQRwlieXl78m6lgKxeRCNGbqVGXS/4k70=
+=Zcz0
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.sha512
==
--- dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.sha512 
(added)
+++ dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.tar.gz.sha512 Sun 
Mar 13 19:31:20 2022
@@ -0,0 +1 @@
+a0d2f77540b5370e09d03d04340e0c7f539eb5761b84ea3c8ef924e2a3e7f9528b3ed83a0c8e413bc9335cee6052135788e48e30d95f231ba3ade7f0b53ec157
 *apache-tomcat-8.5.77-src.tar.gz
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.77/src/apache-tomcat-8.5.77-src.zip.asc Sun Mar 13 
19:31:20 2022
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAmIuRc0ACgkQHPApP6U8
+pFgm5Q/+IgCZlm9EExBuIydmapysD7mefkJDD8DVbF98JgCpnYbsksg7JsvReVPs
+G/DYN6YcW40lHooSfV+3XboOhTu66SwUz4vNISw+ixkrBXTtr1TVVwWYYLj3HA0i
+/0WYsFi1sp17g6+m6Lrvk9E45eSdgXdWVwb8ipuwzjxoAhFipfQvsygbJN13RphN
+QijHO351RXP29YW2+fiwrSxw1C1sThexB0m49g52+dXHZKL4qjT1dljOsjXkVZhV
+78xxKcvX7FIcx/PeP/DtOtr/J4zaORhT4sYaUaX+9uZVeEkvWtjbAhO6zm4dQJP7
+JL10DSiorjCUNZ0mV+MWPwfvG3PvaOkVklEx6qM/

[VOTE] Release Apache Tomcat 8.5.77

2022-03-13 Thread Christopher Schultz

The proposed Apache Tomcat 8.5.77 release is now available for voting.

The notable changes compared to 8.5.76 are:

- Fix a potential thread-safety issue that could cause HTTP/1.1 request
   processing to pause, and potentially timeout, waiting for additional
   data when the full request has been received.

- Fix a regression introduced with 65757 bugfix which better identified
   non request threads but which introduced a similar problem when user
   code was doing sequential operations in a single thread.

- When resolving methods in EL expressions that use beans and/or static
   fields, ensure that any custom type conversion is considered when
   identifying the method to call.

Along with lots of other bug fixes and improvements.

This is the second release of Tomcat 8.5 that has been built with Java 
11 (in Java 7 mode) instead of Java 7. Please report any strangeness you 
may observe especially if you are running Tomcat 8.5 in an environment 
using Java < 11. We don't expect any issues, but understand that we 
cannot test all possible environmental configurations.


For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.77/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1363
The tag is:
https://github.com/apache/tomcat/tree/8.5.77
3931695e564dd4dd1dbf029026e900b74992408c

The proposed 8.5.77 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.76 (stable)

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Running cipher-suite tests without failure

2022-03-13 Thread Christopher Schultz

Rainer,

On 2/28/22 10:35, Rainer Jung wrote:


Am 28.02.2022 um 15:34 schrieb Christopher Schultz:

Rainer,

On 2/25/22 23:22, Rainer Jung wrote:

I don't get any unit test failures. I set in build.properties:

test.apr.loc=/path/to/tcnative/lib
test.openssl.path=/path/to/openssl/bin/openssl


I have:

test.openssl.loc=/home/cschultz/projects/apache/apache-tomcat/openssl-1.1.1/target/bin/openssl 



I have not set test.apr.loc and use the local system APR library. Here 
are the effective versions, from my test build-test-suite report:


*  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
*  APR:  1.6.5

My OpenSSL version is locally-compiled.

Here are the testcase failures:

Testsuite: org.apache.tomcat.util.net.openssl.ciphers.TestCipher
Testcase: testOpenSSLCipherAvailability took 0.008 sec
 FAILED
Unavailable cipher suites: IDEA-CBC-SHA+SSLv3  expected:<0> but was:<1>

Same failures for NIO, NIO2, and APR (of course, since these tests are 
not related to the connector-type).


Also this:

Testsuite: 
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser 

Tests run: 85, Failures: 11, Errors: 0, Skipped: 0, Time elapsed: 
0.564 sec


Error in cipher list
140089009423488:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no 
cipher match:../ssl/ssl_lib.c:2564:


Error in cipher list
140161019962496:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no 
cipher match:../ssl/ssl_lib.c:2564:


[.. many times repeated...]


Testcase: testALL took 0.012 sec
 FAILED
Expected 143 ciphers but got 141 for the specification 'ALL' 
expected:<[SSL_RSA_WITH_IDEA_CBC_SHA, [... lots of additional cipher 
suites ...]


I am missing the following two cipher suites:

SSL_RSA_WITH_IDEA_CBC_SHA
TLS_RSA_WITH_IDEA_CBC_SHA

Is there a way to disable checking for the IDEA cipher suites or do I 
need to customize my OpenSSL build to include them?


Class TesterOpenSSL.java contains the following snippet:

     String skipCiphers = 
System.getProperty("tomcat.test.openssl.unimplemented", "");

     if (!skipCiphers.isEmpty()) {
     String[] skip = skipCiphers.split(",");
     for (Cipher c : Cipher.values()) {
     for (String s : skip) {
     if (c.toString().contains(s)) {
     unimplemented.add(c);
     }
     }
     }
     }

So it seems you can add your own "unimplemented" ciphers as a comma 
separated list to the system property 
"tomcat.test.openssl.unimplemented" when running the unit tests.



And build.xml contains

value="${test.openssl.unimplemented}" />


so you an set the system property from the property 
"test.openssl.unimplemented" in build.properties.


You might have to check, which form the expected cipher names have.


Amusingly enough, I was watching this fine presentation the other day 
and this guy covers this question exactly, around the 17:35 mark:


https://youtu.be/O2wXAldxQWA?t=1056

:)

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65951] New: ant package with custom tomcat.output fails in add-osgi

2022-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65951

Bug ID: 65951
   Summary: ant package with custom tomcat.output fails in
add-osgi
   Product: Tomcat 9
   Version: 9.0.59
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: isa...@apache.org
  Target Milestone: -

The paths to the manifest files ignore the tomcat.output property, instead hard
coding a relative path with ../..

Patch coming up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: BZ-65951 Use the tomcat.output property instead of a relative path

2022-03-13 Thread isapir
This is an automated email from the ASF dual-hosted git repository.

isapir pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 8b93b46  BZ-65951 Use the tomcat.output property instead of a relative 
path
8b93b46 is described below

commit 8b93b46c9eb8c3bd931da6f8edffe66f71828edd
Author: Igal Sapir 
AuthorDate: Sun Mar 13 13:38:23 2022 -0700

BZ-65951 Use the tomcat.output property instead of a relative path
---
 res/bnd/build-defaults.bnd | 4 ++--
 res/bnd/jasper-el.jar.tmp.bnd  | 2 +-
 res/bnd/jasper.jar.tmp.bnd | 2 +-
 res/bnd/servlet-api.jar.tmp.bnd| 4 ++--
 res/bnd/tomcat-embed-core.jar.tmp.bnd  | 4 ++--
 res/bnd/tomcat-embed-jasper.jar.tmp.bnd| 2 +-
 res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 2 +-
 res/bnd/tomcat-websocket.jar.tmp.bnd   | 2 +-
 webapps/docs/changelog.xml | 4 
 9 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/res/bnd/build-defaults.bnd b/res/bnd/build-defaults.bnd
index 753d08f..be3f26f 100644
--- a/res/bnd/build-defaults.bnd
+++ b/res/bnd/build-defaults.bnd
@@ -25,8 +25,8 @@ Implementation-Vendor: Apache Software Foundation
 X-Compile-Source-JDK: ${compile.release}
 X-Compile-Target-JDK: ${compile.release}
 
--includeresource.notice: META-INF/NOTICE=../../output/manifests/default.notice
--includeresource.license: 
META-INF/LICENSE=../../output/manifests/default.license
+-includeresource.notice: 
META-INF/NOTICE=${tomcat.output}/manifests/default.notice
+-includeresource.license: 
META-INF/LICENSE=${tomcat.output}/manifests/default.license
 
 -noclassforname: true
 
diff --git a/res/bnd/jasper-el.jar.tmp.bnd b/res/bnd/jasper-el.jar.tmp.bnd
index 1b96a38..94536a4 100644
--- a/res/bnd/jasper-el.jar.tmp.bnd
+++ b/res/bnd/jasper-el.jar.tmp.bnd
@@ -26,7 +26,7 @@ Export-Package: \
 org.apache.el.stream,\
 org.apache.el.util
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper-el.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper-el.jar/
 
 -jpms-module-info: \
 ${module.name};\
diff --git a/res/bnd/jasper.jar.tmp.bnd b/res/bnd/jasper.jar.tmp.bnd
index 006c721..9747933 100644
--- a/res/bnd/jasper.jar.tmp.bnd
+++ b/res/bnd/jasper.jar.tmp.bnd
@@ -33,7 +33,7 @@ Export-Package: \
 -includepackage: \
 org.apache.jasper.resources
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper.jar/
 
 -jpms-module-info: \
 ${module.name};\
diff --git a/res/bnd/servlet-api.jar.tmp.bnd b/res/bnd/servlet-api.jar.tmp.bnd
index c7a6a70..43602ca 100644
--- a/res/bnd/servlet-api.jar.tmp.bnd
+++ b/res/bnd/servlet-api.jar.tmp.bnd
@@ -27,8 +27,8 @@ Provide-Capability: \
 version:List="4.0,3.1,3,2.5";\
 uses:='${packages;NAMED;javax.servlet.*;NAMED;!javax.servlet.jsp.*}'
 
--includeresource.notice2: 
META-INF/NOTICE=../../output/manifests/servlet-api.jar.notice
--includeresource.license2: 
META-INF/LICENSE=../../output/manifests/servlet-api.jar.license
+-includeresource.notice2: 
META-INF/NOTICE=${tomcat.output}/manifests/servlet-api.jar.notice
+-includeresource.license2: 
META-INF/LICENSE=${tomcat.output}/manifests/servlet-api.jar.license
 
 -namesection: javax/servlet*/;\
 Specification-Title='Java API for Servlets';\
diff --git a/res/bnd/tomcat-embed-core.jar.tmp.bnd 
b/res/bnd/tomcat-embed-core.jar.tmp.bnd
index 96def91..c41a851 100644
--- a/res/bnd/tomcat-embed-core.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-core.jar.tmp.bnd
@@ -96,8 +96,8 @@ Export-Package: \
 org.apache.tomcat.util.net.jsse,\
 org.apache.tomcat.util.threads.res
 
--includeresource.notice2: 
META-INF/NOTICE=../../output/manifests/servlet-api.jar.notice
--includeresource.license2: 
META-INF/LICENSE=../../output/manifests/servlet-api.jar.license
+-includeresource.notice2: 
META-INF/NOTICE=${tomcat.output}/manifests/servlet-api.jar.notice
+-includeresource.license2: 
META-INF/LICENSE=${tomcat.output}/manifests/servlet-api.jar.license
 
 Provide-Capability: \
 osgi.contract;\
diff --git a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd 
b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
index a81d4b3..c46114d 100644
--- a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
@@ -35,7 +35,7 @@ Export-Package: \
 -includepackage: \
 org.apache.jasper.resources
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper.jar/
 
 Provide-Capability: \
 osgi.contract;\
diff --git a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd 
b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
index 59285de..52fdc82 100644
--- a/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-websocket.jar.tmp.bnd
@@ -25,7 +25,7 @@ Export-Package: \
 -inc

Re: [VOTE] Release Apache Tomcat 8.5.77

2022-03-13 Thread Igal Sapir
On Sun, Mar 13, 2022 at 12:41 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.77 release is now available for voting.
>
> The notable changes compared to 8.5.76 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
> processing to pause, and potentially timeout, waiting for additional
> data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
> non request threads but which introduced a similar problem when user
> code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
> fields, ensure that any custom type conversion is considered when
> identifying the method to call.
>
> Along with lots of other bug fixes and improvements.
>
> This is the second release of Tomcat 8.5 that has been built with Java
> 11 (in Java 7 mode) instead of Java 7. Please report any strangeness you
> may observe especially if you are running Tomcat 8.5 in an environment
> using Java < 11. We don't expect any issues, but understand that we
> cannot test all possible environmental configurations.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.77/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1363
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.77
> 3931695e564dd4dd1dbf029026e900b74992408c
>
> The proposed 8.5.77 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.76 (stable)
>

Unit tests passed with Java 11.0.14 on Ubuntu 20.04

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.18

2022-03-13 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:52 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.18 release is now available for
> voting.
>
> Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.17 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.18/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1361
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.18
> 70f59e8328621e58b9493c119f05a2e57f597a1c
>
> The proposed 10.0.18 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.18 (stable)
>

After a system reboot the unit tests passed on Ubuntu 20.04 with Java
11.0.14.

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.18

2022-03-13 Thread Felix Schumacher


Am 09.03.22 um 15:52 schrieb Mark Thomas:

The proposed Apache Tomcat 10.0.18 release is now available for
voting.

Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary
package for all the specification APIs has changed from javax.* to 
jakarta.*


Applications that run on Tomcat 9 will not run on Tomcat 10 without 
changes. Java EE applications designed for Tomcat 9 and earlier may be 
placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will 
automatically convert them to Jakarta EE and copy them to the webapps 
directory


The notable changes compared to 10.0.17 are:

- Fix a potential thread-safety issue that could cause HTTP/1.1 request
  processing to pause, and potentially timeout, waiting for additional
  data when the full request has been received.

- Fix a regression introduced with 65757 bugfix which better identified
  non request threads but which introduced a similar problem when user
  code was doing sequential operations in a single thread.

- When resolving methods in EL expressions that use beans and/or static
  fields, ensure that any custom type conversion is considered when
  identifying the method to call.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.18/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1361

The tag is:
https://github.com/apache/tomcat/tree/10.0.18
70f59e8328621e58b9493c119f05a2e57f597a1c

The proposed 10.0.18 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 10.0.18 (stable)

Felix


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


[tomcat] branch main updated: BZ-65951 Use the tomcat.output property instead of a relative path

2022-03-13 Thread isapir
This is an automated email from the ASF dual-hosted git repository.

isapir pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 39761d9  BZ-65951 Use the tomcat.output property instead of a relative 
path
39761d9 is described below

commit 39761d987d0edf1473a87472012a946de79d1017
Author: Igal Sapir 
AuthorDate: Sun Mar 13 14:43:04 2022 -0700

BZ-65951 Use the tomcat.output property instead of a relative path
---
 res/bnd/build-defaults.bnd | 4 ++--
 res/bnd/jasper-el.jar.tmp.bnd  | 2 +-
 res/bnd/jasper.jar.tmp.bnd | 2 +-
 res/bnd/servlet-api.jar.tmp.bnd| 4 ++--
 res/bnd/tomcat-embed-core.jar.tmp.bnd  | 4 ++--
 res/bnd/tomcat-embed-el.jar.tmp.bnd| 2 +-
 res/bnd/tomcat-embed-jasper.jar.tmp.bnd| 2 +-
 res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 2 +-
 res/bnd/tomcat-websocket.jar.tmp.bnd   | 2 +-
 webapps/docs/changelog.xml | 4 
 10 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/res/bnd/build-defaults.bnd b/res/bnd/build-defaults.bnd
index 753d08f..be3f26f 100644
--- a/res/bnd/build-defaults.bnd
+++ b/res/bnd/build-defaults.bnd
@@ -25,8 +25,8 @@ Implementation-Vendor: Apache Software Foundation
 X-Compile-Source-JDK: ${compile.release}
 X-Compile-Target-JDK: ${compile.release}
 
--includeresource.notice: META-INF/NOTICE=../../output/manifests/default.notice
--includeresource.license: 
META-INF/LICENSE=../../output/manifests/default.license
+-includeresource.notice: 
META-INF/NOTICE=${tomcat.output}/manifests/default.notice
+-includeresource.license: 
META-INF/LICENSE=${tomcat.output}/manifests/default.license
 
 -noclassforname: true
 
diff --git a/res/bnd/jasper-el.jar.tmp.bnd b/res/bnd/jasper-el.jar.tmp.bnd
index 1b96a38..94536a4 100644
--- a/res/bnd/jasper-el.jar.tmp.bnd
+++ b/res/bnd/jasper-el.jar.tmp.bnd
@@ -26,7 +26,7 @@ Export-Package: \
 org.apache.el.stream,\
 org.apache.el.util
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper-el.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper-el.jar/
 
 -jpms-module-info: \
 ${module.name};\
diff --git a/res/bnd/jasper.jar.tmp.bnd b/res/bnd/jasper.jar.tmp.bnd
index 006c721..9747933 100644
--- a/res/bnd/jasper.jar.tmp.bnd
+++ b/res/bnd/jasper.jar.tmp.bnd
@@ -33,7 +33,7 @@ Export-Package: \
 -includepackage: \
 org.apache.jasper.resources
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper.jar/
 
 -jpms-module-info: \
 ${module.name};\
diff --git a/res/bnd/servlet-api.jar.tmp.bnd b/res/bnd/servlet-api.jar.tmp.bnd
index b1a6740..aac22a7 100644
--- a/res/bnd/servlet-api.jar.tmp.bnd
+++ b/res/bnd/servlet-api.jar.tmp.bnd
@@ -27,8 +27,8 @@ Provide-Capability: \
 version:Version=${servlet.spec.version};\
 
uses:='${packages;NAMED;jakarta.servlet.*;NAMED;!jakarta.servlet.jsp.*}'
 
--includeresource.notice2: 
META-INF/NOTICE=../../output/manifests/servlet-api.jar.notice
--includeresource.license2: 
META-INF/LICENSE=../../output/manifests/servlet-api.jar.license
+-includeresource.notice2: 
META-INF/NOTICE=${tomcat.output}/manifests/servlet-api.jar.notice
+-includeresource.license2: 
META-INF/LICENSE=${tomcat.output}/manifests/servlet-api.jar.license
 
 -namesection: jakarta/servlet*/;\
 Specification-Title=Jakarta Servlet;\
diff --git a/res/bnd/tomcat-embed-core.jar.tmp.bnd 
b/res/bnd/tomcat-embed-core.jar.tmp.bnd
index ed1c656..e5bd1e5 100644
--- a/res/bnd/tomcat-embed-core.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-core.jar.tmp.bnd
@@ -96,8 +96,8 @@ Export-Package: \
 org.apache.tomcat.util.net.jsse,\
 org.apache.tomcat.util.threads.res
 
--includeresource.notice2: 
META-INF/NOTICE=../../output/manifests/servlet-api.jar.notice
--includeresource.license2: 
META-INF/LICENSE=../../output/manifests/servlet-api.jar.license
+-includeresource.notice2: 
META-INF/NOTICE=${tomcat.output}/manifests/servlet-api.jar.notice
+-includeresource.license2: 
META-INF/LICENSE=${tomcat.output}/manifests/servlet-api.jar.license
 
 Provide-Capability: \
 osgi.contract;\
diff --git a/res/bnd/tomcat-embed-el.jar.tmp.bnd 
b/res/bnd/tomcat-embed-el.jar.tmp.bnd
index 03d75a5..ff3d1133 100644
--- a/res/bnd/tomcat-embed-el.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-el.jar.tmp.bnd
@@ -27,7 +27,7 @@ Export-Package: \
 org.apache.el.stream,\
 org.apache.el.util
 
--includeresource.meta-inf: /META-INF/=../../output/manifests/jasper-el.jar/
+-includeresource.meta-inf: /META-INF/=${tomcat.output}/manifests/jasper-el.jar/
 
 Provide-Capability: \
 osgi.contract;\
diff --git a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd 
b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
index 3987ceb..921cc9d 100644
--- a/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
+++ b/res/bnd/tomcat-embed-jasper.jar.tmp.bnd
@@ 

Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-13 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>

Unit tests passed on Ubuntu 20.04 with Java 11.0.14 after patching BZ-65951
[1] which is a minor bug and IMHO should not affect the release.

Igal

[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=65951


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 65951] ant package with custom tomcat.output fails in add-osgi

2022-03-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65951

Igal Sapir  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Igal Sapir  ---
Fixed for main 
https://github.com/apache/tomcat/commit/39761d987d0edf1473a87472012a946de79d1017
Fixed for 9.0.x
https://github.com/apache/tomcat/commit/8b93b46c9eb8c3bd931da6f8edffe66f71828edd

Other active branches seem not to be affected by this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



is org.apache.tomcat.jakartaee meant to be optional dependency

2022-03-13 Thread Raymond Augé
Hey all,

Regarding tomcat 10.x+

I'm wondering if org.apache.tomcat.jakartaee usage in tomcat-catalina is
intended to be optional?

By the looks of it, I'm thinking not, so it begs the question whether it
should be a proper module; both JPMS and OSGi? Otherwise tomcat-catalina
can never be used in either.

Ray