[Bug 65710] multipartfile stream close doesn't release the handle
https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEEDINFO|RESOLVED --- Comment #12 from Mark Thomas --- This is a JVM bug present in Java 8, not a Tomcat bug. In 9.0.53 Tomcat was updated to the latest Commons File Upload code. This happens several times a year. Once of the changes was a switch from using: new FileInputStream(dfos.getFile()); to: Files.newInputStream(dfos.getFile().toPath()); to obtain an input stream for the uploaded file. The new code triggers a JVM bug present in the latest Java 8 where, if the application doesn't explicitly close the input stream, a file descriptor is leaked. You need to raise this issue with your JVM provider. Options for work arounds until your JVM provider can provide you with a fixed JVM include: - ensure the application closes the input stream (the code should be doing this any way) - switch to Java 11 Whether Tomcat opts to try and implement a workaround to this JVM bug is a separate discussion. The project's default position is that workarounds are not provided for bugs in other software. This issue is likely to qualify as one of the few exceptions to that. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Workaround JVM bug described in BZ 65710
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1c90ee4 Workaround JVM bug described in BZ 65710 1c90ee4 is described below commit 1c90ee433ab6cda9f51fd1840e45c4e50e96afc1 Author: Mark Thomas AuthorDate: Thu Dec 2 08:27:31 2021 + Workaround JVM bug described in BZ 65710 In Java 8 (but not Java 11) Files.newInputStream(dfos.getFile().toPath()) leaks a file descriptor even after GC if the input stream is not explicitly closed. https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 --- java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java | 4 +++- webapps/docs/changelog.xml | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java index 4dcc3d9..521abaf 100644 --- a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java +++ b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java @@ -193,7 +193,9 @@ public class DiskFileItem public InputStream getInputStream() throws IOException { if (!isInMemory()) { -return Files.newInputStream(dfos.getFile().toPath()); +// Uses old code to avoid JVM bug +// https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 +return new FileInputStream(dfos.getFile()); } if (cachedContent == null) { diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index bbc985a..75d1215 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -132,6 +132,12 @@ Add debug logging to the RestCsrfPreventionFilter. Based on pull request 452 by Polina Georgieva. (markt) + +65710: Implement a workaround for a JVM bug that can trigger +a file descriptor leak when using multi-part upload and the application +does not explicitly close an input stream for an uploaded file that was +cached on disk. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Workaround JVM bug described in BZ 65710
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f4dab78 Workaround JVM bug described in BZ 65710 f4dab78 is described below commit f4dab78c50567256aa234f9be13c407d58c73761 Author: Mark Thomas AuthorDate: Thu Dec 2 08:27:31 2021 + Workaround JVM bug described in BZ 65710 In Java 8 (but not Java 11) Files.newInputStream(dfos.getFile().toPath()) leaks a file descriptor even after GC if the input stream is not explicitly closed. https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 --- java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java | 4 +++- webapps/docs/changelog.xml | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java index 9610ae1..e9a1621 100644 --- a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java +++ b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java @@ -192,7 +192,9 @@ public class DiskFileItem public InputStream getInputStream() throws IOException { if (!isInMemory()) { -return Files.newInputStream(dfos.getFile().toPath()); +// Uses old code to avoid JVM bug +// https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 +return new FileInputStream(dfos.getFile()); } if (cachedContent == null) { diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 6168046..821a316 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -132,6 +132,12 @@ Add debug logging to the RestCsrfPreventionFilter. Based on pull request 452 by Polina Georgieva. (markt) + +65710: Implement a workaround for a JVM bug that can trigger +a file descriptor leak when using multi-part upload and the application +does not explicitly close an input stream for an uploaded file that was +cached on disk. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Workaround JVM bug described in BZ 65710
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 95ccb72 Workaround JVM bug described in BZ 65710 95ccb72 is described below commit 95ccb729ecfb61cb8ee2c94b793c05b0d8c1949f Author: Mark Thomas AuthorDate: Thu Dec 2 08:27:31 2021 + Workaround JVM bug described in BZ 65710 In Java 8 (but not Java 11) Files.newInputStream(dfos.getFile().toPath()) leaks a file descriptor even after GC if the input stream is not explicitly closed. https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 --- java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java | 4 +++- webapps/docs/changelog.xml | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java index 4dcc3d9..521abaf 100644 --- a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java +++ b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java @@ -193,7 +193,9 @@ public class DiskFileItem public InputStream getInputStream() throws IOException { if (!isInMemory()) { -return Files.newInputStream(dfos.getFile().toPath()); +// Uses old code to avoid JVM bug +// https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 +return new FileInputStream(dfos.getFile()); } if (cachedContent == null) { diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 9c047e3..580a3e3 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -132,6 +132,12 @@ Add debug logging to the RestCsrfPreventionFilter. Based on pull request 452 by Polina Georgieva. (markt) + +65710: Implement a workaround for a JVM bug that can trigger +a file descriptor leak when using multi-part upload and the application +does not explicitly close an input stream for an uploaded file that was +cached on disk. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65710] multipartfile stream close doesn't release the handle
https://bz.apache.org/bugzilla/show_bug.cgi?id=65710 --- Comment #13 from Mark Thomas --- Workaround has been implemented in: - 10.0.x for 10.0.14 onwards - 9.0.x for 9.0.56 onwards - 8.5.x for 8.5.74 onwards 10.1.x is not affected since it requires Java 11 as a minimum -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Improve POM
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b8a39ab Improve POM b8a39ab is described below commit b8a39abd65540c2a6147a4f7d76f079da2f2da79 Author: remm AuthorDate: Thu Dec 2 10:29:58 2021 +0100 Improve POM --- modules/openssl-java17/README.md | 4 ++-- modules/openssl-java17/pom.xml | 50 2 files changed, 32 insertions(+), 22 deletions(-) diff --git a/modules/openssl-java17/README.md b/modules/openssl-java17/README.md index 188af2e..07f0a68 100644 --- a/modules/openssl-java17/README.md +++ b/modules/openssl-java17/README.md @@ -16,7 +16,7 @@ The module uses the OpenSSL 1.1 API. It requires an API compatible version of OpenSSL or a compatible alternative library, that can be loaded from the JVM library path. -Copy `tomcat-openssl-1.0.jar` to the Apache Tomcat `lib` folder. +Copy `openssl-java17-1.0.jar` to the Apache Tomcat `lib` folder. Remove `AprLifecycleListener` from `server.xml`. The `org.apache.tomcat.util.net.openssl.panama.OpenSSLLifecycleListener` can be @@ -68,7 +68,7 @@ index dc1260b..dd9fba9 100644 -+ ++ diff --git a/modules/openssl-java17/pom.xml b/modules/openssl-java17/pom.xml index 9ccec48..8139a3c 100644 --- a/modules/openssl-java17/pom.xml +++ b/modules/openssl-java17/pom.xml @@ -1,21 +1,21 @@ -http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + - +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> 4.0.0 @@ -25,15 +25,14 @@ org.apache.tomcat -tomcat-openssl -Apache Tomcat OpenSSL support for Panama -OpenSSL support using the Panama API -0.1 -jar +openssl-java17 +Apache Tomcat OpenSSL support for Java 17 +OpenSSL support using the Panama JEP 412 API included in Java 17 +0.1-SNAPSHOT 10.0.13 -10 + 2021-12-02T12:00:00Z @@ -80,6 +79,17 @@ + + org.apache.maven.plugins + maven-javadoc-plugin + + 17 + + --add-modules + jdk.incubator.foreign + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Add scm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8d8b3df Add scm 8d8b3df is described below commit 8d8b3dfd9f195b137cb43be9a683f77f3a9e16ec Author: remm AuthorDate: Thu Dec 2 10:37:31 2021 +0100 Add scm --- modules/openssl-java17/pom.xml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/modules/openssl-java17/pom.xml b/modules/openssl-java17/pom.xml index 8139a3c..733efa1 100644 --- a/modules/openssl-java17/pom.xml +++ b/modules/openssl-java17/pom.xml @@ -35,6 +35,13 @@ 2021-12-02T12:00:00Z + + scm:git:https://gitbox.apache.org/repos/asf/tomcat.git + scm:git:https://gitbox.apache.org/repos/asf/tomcat.git +https://gitbox.apache.org/repos/asf?p=tomcat.git +HEAD + + Development List - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Restore the warning
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7db00b2 Restore the warning 7db00b2 is described below commit 7db00b2e2a79d637857e092a8d68321db480b476 Author: remm AuthorDate: Thu Dec 2 10:42:01 2021 +0100 Restore the warning --- .../org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java | 4 1 file changed, 4 insertions(+) diff --git a/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java b/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java index e3c6f49..be94914 100644 --- a/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java +++ b/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java @@ -817,8 +817,12 @@ public class OpenSSLContext implements org.apache.tomcat.util.net.SSLContext { if (log.isDebugEnabled()) { log.debug("Certificate verification"); } +if (MemoryAddress.NULL.equals(param)) { +return 0; +} ContextState state = getState(param); if (state == null) { +log.warn(sm.getString("context.noSSL", Long.valueOf(param.toRawLongValue(; return 0; } MemoryAddress ssl = X509_STORE_CTX_get_ex_data(x509_ctx, SSL_get_ex_data_X509_STORE_CTX_idx()); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Update reproducible build timestamp
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e4540f0 Update reproducible build timestamp e4540f0 is described below commit e4540f0d03f6ff6aa572984f55cc69a232d73032 Author: Mark Thomas AuthorDate: Thu Dec 2 10:45:40 2021 + Update reproducible build timestamp --- build.properties.default | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.properties.default b/build.properties.default index 8eb46af..eb89235 100644 --- a/build.properties.default +++ b/build.properties.default @@ -38,8 +38,8 @@ version.suffix=-M8-dev # - Reproducible builds - # Uncomment and set to current time for reproducible builds # Note: The value is in seconds (unlike milliseconds used by System.currentTimeMillis()). -#2021-09-28T12:09:00Z -#ant.tstamp.now=1632819600 +#2021-12-02T10:10:00Z +#ant.tstamp.now=1638439200 # - Source control flags - git.branch=main - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65708] uncaptured exception make SocketProcessor container has a httpconnection leak
https://bz.apache.org/bugzilla/show_bug.cgi?id=65708 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mark Thomas --- If log.error("",t) throws an exception you have much bigger problems than a connection leak. Once things start to go that badly wrong, it is not practical to handle all possible errors. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] tag 10.1.0-M8 created (now cd53876)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 10.1.0-M8 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at cd53876 (commit) This tag includes the following new commits: new cd53876 Tag 10.1.0-M8 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/01: Tag 10.1.0-M8
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 10.1.0-M8 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cd53876fefaa370c31466b0f615e9ad026541a27 Author: Mark Thomas AuthorDate: Thu Dec 2 11:02:23 2021 + Tag 10.1.0-M8 --- build.properties.default | 2 +- webapps/docs/changelog.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.properties.default b/build.properties.default index eb89235..297757b 100644 --- a/build.properties.default +++ b/build.properties.default @@ -33,7 +33,7 @@ version.major=10 version.minor=1 version.build=0 version.patch=0 -version.suffix=-M8-dev +version.suffix=-M8 # - Reproducible builds - # Uncomment and set to current time for reproducible builds diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 2312bcf..3fefe16 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,7 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r51175 - in /dev/tomcat/tomcat-10/v10.1.0-M8: ./ bin/ bin/embed/ src/
Author: markt Date: Thu Dec 2 13:43:42 2021 New Revision: 51175 Log: Upload 10.1.0-M8 for voting Added: dev/tomcat/tomcat-10/v10.1.0-M8/ dev/tomcat/tomcat-10/v10.1.0-M8/KEYS dev/tomcat/tomcat-10/v10.1.0-M8/README.html dev/tomcat/tomcat-10/v10.1.0-M8/RELEASE-NOTES dev/tomcat/tomcat-10/v10.1.0-M8/bin/ dev/tomcat/tomcat-10/v10.1.0-M8/bin/README.html dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.tar.gz (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.tar.gz.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.tar.gz.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-deployer.zip.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-fulldocs.tar.gz (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-fulldocs.tar.gz.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-fulldocs.tar.gz.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x64.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x64.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x64.zip.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x86.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x86.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8-windows-x86.zip.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.exe (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.exe.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.exe.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.tar.gz (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.tar.gz.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.tar.gz.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/apache-tomcat-10.1.0-M8.zip.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/ dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.tar.gz (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.tar.gz.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.tar.gz.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/bin/embed/apache-tomcat-10.1.0-M8-embed.zip.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/src/ dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.tar.gz (with props) dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.tar.gz.asc dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.tar.gz.sha512 dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.zip (with props) dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.zip.asc dev/tomcat/tomcat-10/v10.1.0-M8/src/apache-tomcat-10.1.0-M8-src.zip.sha512 Added: dev/tomcat/tomcat-10/v10.1.0-M8/KEYS == --- dev/tomcat/tomcat-10/v10.1.0-M8/KEYS (added) +++ dev/tomcat/tomcat-10/v10.1.0-M8/KEYS Thu Dec 2 13:43:42 2021 @@ -0,0 +1,453 @@ +This file contains the PGP&GPG keys of various Apache developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Apache users: pgp < KEYS +Apache developers: +(pgpk -ll && pgpk -xa ) >> this file. + or +(gpg --fingerprint --list-sigs + && gpg --armor --export ) >> this file. + +Apache developers: please ensure that your key is also available via the +PGP keyservers (such as pgpkeys.mit.edu). + + +pub 4096R/2F6059E7 2009-09-18 + Key fingerprint = A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7 +uid Mark E D Thomas +sub 4096R/5E763BEC 2009-09-18 + +-BEGIN PGP PUBLIC KEY BLOCK- +Comment: GPGTools - http://gpgtools.org + +mQINBEq0DukBEAD4jovHOPJDxoD+JnO1Go2kiwpgRULasGlrVKuSUdP6wzcaqWmX +pqtOJKKwW2MQFQLmg7nQ9RjJwy3QCbKNDJQA/bwbQT1F7WzTCz2S6vxC4zxKck4t +6RZBq2dJsYKF0CEh6ZfY4dmKvhq+3istSoFRdHYoOPGWZpuRDqfZPdGm/m335/6K +GH59oysn1NE7a2a+kZzjBSEgv23+l4Z1Rg7+fpz1JcdHSdC2Z+ZRxML25eVatRVz +4yvDOZItqDURP24zWOodxgboldV6Y88C3v/7KRR+1vklzkuA2FqF8Q4r/2f0su7M +UVviQcy29y/RlLSDTTYoVlCZ1ni14qFU7Hpw43KJtgXmcUwq31T1+SlXdYjNJ1aF +kUi8BjCHDcSgE/IReKUanjHzm4XSymKDTeqqzidi4k6PDD4jyHb8k8v
[tomcat] branch main updated: Fix the deploy-release target
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a58d8cd Fix the deploy-release target a58d8cd is described below commit a58d8cd5e8c585d5b0386c97d97bdb1cfe5f25ac Author: Mark Thomas AuthorDate: Thu Dec 2 13:54:38 2021 + Fix the deploy-release target --- res/maven/mvn-pub.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml index 308421b..0fbde1b 100644 --- a/res/maven/mvn-pub.xml +++ b/res/maven/mvn-pub.xml @@ -509,7 +509,7 @@ - + GPG is required, but was not found at ${gpg.exec}
[tomcat] branch 10.0.x updated (95ccb72 -> cea918c)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 95ccb72 Workaround JVM bug described in BZ 65710 new 7974e71 Fix the deploy-release target new cea918c Update code signing to use new cert (that includes PMC name) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default | 2 +- res/maven/mvn-pub.xml| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Update code signing to use new cert (that includes PMC name)
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cea918c7ce6a97383277815b92343cebb7a0b2d1 Author: Mark Thomas AuthorDate: Tue Nov 23 17:45:49 2021 + Update code signing to use new cert (that includes PMC name) --- build.properties.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.properties.default b/build.properties.default index 9bd26b1..57162b3 100644 --- a/build.properties.default +++ b/build.properties.default @@ -81,7 +81,7 @@ gpg.exec=/path/to/gpg # Code signing of Windows installer # See https://infra.apache.org/digicert-use.html for setup instructions do.codesigning=false -codesigning.alias=Tomcat-PMC-cert-2021-04 +codesigning.alias=Tomcat-PMC-cert-2021-11 codesigning.digest=SHA-512 codesigning.storetype=DIGICERTONE # Set codesigning.storepass in build.properties with the following syntax - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Fix the deploy-release target
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7974e712feb6551e1ab75a6c621e94a363ff9621 Author: Mark Thomas AuthorDate: Thu Dec 2 13:54:38 2021 + Fix the deploy-release target --- res/maven/mvn-pub.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml index 0c4cf5f..150e8b6 100644 --- a/res/maven/mvn-pub.xml +++ b/res/maven/mvn-pub.xml @@ -501,7 +501,7 @@ - + GPG is required, but was not found at ${gpg.exec}
[tomcat] branch 9.0.x updated (1c90ee4 -> 6d0a9ed)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1c90ee4 Workaround JVM bug described in BZ 65710 new 5a895df Fix the deploy-release target new 6d0a9ed Update code signing to use new cert (that includes PMC name) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default | 2 +- res/maven/mvn-pub.xml| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Fix the deploy-release target
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5a895dfbca069853f97f26b28a53c33b9afaaf57 Author: Mark Thomas AuthorDate: Thu Dec 2 13:54:38 2021 + Fix the deploy-release target --- res/maven/mvn-pub.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml index 304141e..06bbdce 100644 --- a/res/maven/mvn-pub.xml +++ b/res/maven/mvn-pub.xml @@ -501,7 +501,7 @@ - + GPG is required, but was not found at ${gpg.exec}
[tomcat] 02/02: Update code signing to use new cert (that includes PMC name)
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6d0a9edfb406cc931b468ca89d989b584b97d61c Author: Mark Thomas AuthorDate: Tue Nov 23 17:45:49 2021 + Update code signing to use new cert (that includes PMC name) --- build.properties.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.properties.default b/build.properties.default index 444ed56..b85bf69 100644 --- a/build.properties.default +++ b/build.properties.default @@ -81,7 +81,7 @@ gpg.exec=/path/to/gpg # Code signing of Windows installer # See https://infra.apache.org/digicert-use.html for setup instructions do.codesigning=false -codesigning.alias=Tomcat-PMC-cert-2021-04 +codesigning.alias=Tomcat-PMC-cert-2021-11 codesigning.digest=SHA-512 codesigning.storetype=DIGICERTONE # Set codesigning.storepass in build.properties with the following syntax - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Fix the deploy-release target
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 648a8fa402ba10242fe53efcc5b25a500099feb8 Author: Mark Thomas AuthorDate: Thu Dec 2 13:54:38 2021 + Fix the deploy-release target --- res/maven/mvn-pub.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml index ea67316..f959e58 100644 --- a/res/maven/mvn-pub.xml +++ b/res/maven/mvn-pub.xml @@ -395,7 +395,7 @@ - + GPG is required, but was not found at ${gpg.exec}
[tomcat] branch 8.5.x updated (f4dab78 -> d700284)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f4dab78 Workaround JVM bug described in BZ 65710 new 648a8fa Fix the deploy-release target new d700284 Update code signing to use new cert (that includes PMC name) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default | 2 +- res/maven/mvn-pub.xml| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Update code signing to use new cert (that includes PMC name)
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d70028426b30b45ac5dad7fc7ea04fa9d5e61093 Author: Mark Thomas AuthorDate: Tue Nov 23 17:45:49 2021 + Update code signing to use new cert (that includes PMC name) --- build.properties.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.properties.default b/build.properties.default index a61dbeb..a9e6c88 100644 --- a/build.properties.default +++ b/build.properties.default @@ -84,7 +84,7 @@ gpg.exec=/path/to/gpg # Code signing of Windows installer # See https://infra.apache.org/digicert-use.html for setup instructions do.codesigning=false -codesigning.alias=Tomcat-PMC-cert-2021-04 +codesigning.alias=Tomcat-PMC-cert-2021-11 codesigning.digest=SHA-512 codesigning.storetype=DIGICERTONE # Set codesigning.storepass in build.properties with the following syntax - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Update reproducible build timestamp
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2510581 Update reproducible build timestamp 2510581 is described below commit 25105815068e64cdaf6efb59195c6a708a27b111 Author: remm AuthorDate: Thu Dec 2 15:04:32 2021 +0100 Update reproducible build timestamp --- build.properties.default | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.properties.default b/build.properties.default index b85bf69..4eb95ae 100644 --- a/build.properties.default +++ b/build.properties.default @@ -38,8 +38,8 @@ version.suffix=-dev # - Reproducible builds - # Uncomment and set to current time for reproducible builds # Note: The value is in seconds (unlike milliseconds used by System.currentTimeMillis()). -#2021-09-28T12:09:00Z -#ant.tstamp.now=1632819600 +#2021-12-02T10:10:00Z +#ant.tstamp.now=1638439200 # - Source control flags - git.branch=9.0.x - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] tag 9.0.56 created (now af2a7a4)
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to tag 9.0.56 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at af2a7a4 (commit) This tag includes the following new commits: new af2a7a4 Tag 9.0.56 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/01: Tag 9.0.56
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to tag 9.0.56 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit af2a7a4fb2db07390362af12d0020d550abd8785 Author: remm AuthorDate: Thu Dec 2 15:08:23 2021 +0100 Tag 9.0.56 --- build.properties.default | 2 +- webapps/docs/changelog.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.properties.default b/build.properties.default index 4eb95ae..939b50f 100644 --- a/build.properties.default +++ b/build.properties.default @@ -33,7 +33,7 @@ version.major=9 version.minor=0 version.build=56 version.patch=0 -version.suffix=-dev +version.suffix= # - Reproducible builds - # Uncomment and set to current time for reproducible builds diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 75d1215..37dd569 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,7 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r51176 - in /dev/tomcat/tomcat-9/v9.0.56: ./ bin/ bin/embed/ src/
Author: remm Date: Thu Dec 2 14:34:33 2021 New Revision: 51176 Log: Upload 9.0.56 for voting Added: dev/tomcat/tomcat-9/v9.0.56/ dev/tomcat/tomcat-9/v9.0.56/KEYS dev/tomcat/tomcat-9/v9.0.56/README.html dev/tomcat/tomcat-9/v9.0.56/RELEASE-NOTES dev/tomcat/tomcat-9/v9.0.56/bin/ dev/tomcat/tomcat-9/v9.0.56/bin/README.html dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.tar.gz (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.tar.gz.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.tar.gz.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.zip (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-deployer.zip.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-fulldocs.tar.gz (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-fulldocs.tar.gz.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-fulldocs.tar.gz.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x64.zip (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x64.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x64.zip.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x86.zip (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x86.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56-windows-x86.zip.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.exe (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.exe.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.exe.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.tar.gz (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.tar.gz.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.tar.gz.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.zip (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/apache-tomcat-9.0.56.zip.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/embed/ dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.tar.gz (with props) dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.tar.gz.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.tar.gz.sha512 dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.zip (with props) dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/bin/embed/apache-tomcat-9.0.56-embed.zip.sha512 dev/tomcat/tomcat-9/v9.0.56/src/ dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.tar.gz (with props) dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.tar.gz.asc (with props) dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.tar.gz.sha512 dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.zip (with props) dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.zip.asc (with props) dev/tomcat/tomcat-9/v9.0.56/src/apache-tomcat-9.0.56-src.zip.sha512 Added: dev/tomcat/tomcat-9/v9.0.56/KEYS == --- dev/tomcat/tomcat-9/v9.0.56/KEYS (added) +++ dev/tomcat/tomcat-9/v9.0.56/KEYS Thu Dec 2 14:34:33 2021 @@ -0,0 +1,237 @@ +This file contains the PGP&GPG keys of various Apache developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Apache users: pgp < KEYS +Apache developers: +(pgpk -ll && pgpk -xa ) >> this file. + or +(gpg --fingerprint --list-sigs + && gpg --armor --export ) >> this file. + +Apache developers: please ensure that your key is also available via the +PGP keyservers (such as pgpkeys.mit.edu). + + +pub 1024D/33C60243 2004-09-12 + Key fingerprint = DCFD 35E0 BF8C A734 4752 DE8B 6FB2 1E89 33C6 0243 +uid Mark E D Thomas +uid Mark E D Thomas +uid Mark E D Thomas +sub 2048g/0BECE548 2004-09-12 + +pub 4096R/2F6059E7 2009-09-18 + Key fingerprint = A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7 +uid Mark E D Thomas +sub 4096R/5E763BEC 2009-09-18 + +-BEGIN PGP PUBLIC KEY BLOCK- +Version: GnuPG v1.4.9 (MingW32) + +mQGiBEFEjegRBADocGttfROvtLGrTOW3xRqZHmFWybmEaI6jmnRdN/1gGXmb3wQL +rHsS3fLFIIOYLPph0Kov9q4qNq36LekShIvjMBDFoj2/wRxaUtFq81asaRZg8Mcw +4kVeIoe8OIOuWmvYhU8SH2jJNUnVVrpTPAa6QWquTmseNi6UJMjLxuL7DwCg//9u +k2yj0vk6e4WSO6Fe5+EkQDED/AjQsy0kj9TpNHkKSSUR2evRlWPYA0YtxBSbsgON +tT0cYipAp5IcYt6Zq5QzHiZreyQXLAjItDS2oGCIXfNbTYJ3kxxJTCU/3wlefV
[VOTE] Release Apache Tomcat 10.1.0-M8
The proposed Apache Tomcat 10.1.0-M8 release is now available for voting. Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory. The notable changes compared to 10.1.0-M7 are: - Limit cookie support to RFC 6265 to align with recent updates to the Servlet specification - Update the WebSocket API packaging to remove the copy of the client API from the server API and replace it with a dependency on the client API. This aligns Tomcat with changes in the WebSocket 2.1 specification. - Provide protection against a known OS bug that causes the acceptor to report an incoming connection more than once. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat-10.1.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M8/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1343 The tag is: https://github.com/apache/tomcat/tree/10.1.0-M8 cd53876fefaa370c31466b0f615e9ad026541a27 The proposed 10.1.0-M8 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 10.1.0-M8 (alpha) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: 9.0.57 is next
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6b8fd00 9.0.57 is next 6b8fd00 is described below commit 6b8fd002e36b3436fe21bb2e15400b73978aebb6 Author: remm AuthorDate: Thu Dec 2 15:43:30 2021 +0100 9.0.57 is next --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 4eb95ae..0f30684 100644 --- a/build.properties.default +++ b/build.properties.default @@ -31,7 +31,7 @@ # - Version Control Flags - version.major=9 version.minor=0 -version.build=56 +version.build=57 version.patch=0 version.suffix=-dev diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index a657436..48d4c1c 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=9.0.56 +maven.asf.release.deploy.version=9.0.57 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 75d1215..f61445e 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.0-M8
On Thu, Dec 2, 2021 at 3:44 PM Mark Thomas wrote: > > The proposed Apache Tomcat 10.1.0-M8 release is now available for > voting. > > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 > without changes. Java EE applications designed for Tomcat 9 and earlier > may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat > will automatically convert them to Jakarta EE and copy them to the > webapps directory. > > The notable changes compared to 10.1.0-M7 are: > > - Limit cookie support to RFC 6265 to align with recent updates to the >Servlet specification > > - Update the WebSocket API packaging to remove the copy of the client >API from the server API and replace it with a dependency on the client >API. This aligns Tomcat with changes in the WebSocket 2.1 >specification. > > - Provide protection against a known OS bug that causes the acceptor to >report an incoming connection more than once. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-10.1.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M8/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1343 > > The tag is: > https://github.com/apache/tomcat/tree/10.1.0-M8 > cd53876fefaa370c31466b0f615e9ad026541a27 > > > The proposed 10.1.0-M8 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 10.1.0-M8 (alpha) Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/01: Tag 10.0.14
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 10.0.14 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3bb5b5fcf02e25ae627e480937e755e0a99c82d7 Author: Mark Thomas AuthorDate: Thu Dec 2 21:59:15 2021 + Tag 10.0.14 --- build.properties.default | 2 +- webapps/docs/changelog.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.properties.default b/build.properties.default index 57162b3..632f2ec 100644 --- a/build.properties.default +++ b/build.properties.default @@ -33,7 +33,7 @@ version.major=10 version.minor=0 version.build=14 version.patch=0 -version.suffix=-dev +version.suffix= # - Reproducible builds - # Uncomment and set to current time for reproducible builds diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 580a3e3..5c72ae6 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,7 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] tag 10.0.14 created (now 3bb5b5f)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 10.0.14 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 3bb5b5f (commit) This tag includes the following new commits: new 3bb5b5f Tag 10.0.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r51182 - in /dev/tomcat/tomcat-10/v10.0.14: ./ bin/ bin/embed/ src/
Author: markt Date: Thu Dec 2 22:17:16 2021 New Revision: 51182 Log: Upload 10.0.14 for voting Added: dev/tomcat/tomcat-10/v10.0.14/ dev/tomcat/tomcat-10/v10.0.14/KEYS dev/tomcat/tomcat-10/v10.0.14/README.html dev/tomcat/tomcat-10/v10.0.14/RELEASE-NOTES dev/tomcat/tomcat-10/v10.0.14/bin/ dev/tomcat/tomcat-10/v10.0.14/bin/README.html dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.tar.gz (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.tar.gz.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.tar.gz.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.zip (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.zip.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-deployer.zip.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-fulldocs.tar.gz (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-fulldocs.tar.gz.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-fulldocs.tar.gz.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x64.zip (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x64.zip.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x64.zip.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x86.zip (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x86.zip.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14-windows-x86.zip.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.exe (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.exe.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.exe.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.tar.gz (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.tar.gz.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.tar.gz.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.zip (with props) dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.zip.asc dev/tomcat/tomcat-10/v10.0.14/bin/apache-tomcat-10.0.14.zip.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/embed/ dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.tar.gz (with props) dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.tar.gz.asc dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.tar.gz.sha512 dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.zip (with props) dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.zip.asc dev/tomcat/tomcat-10/v10.0.14/bin/embed/apache-tomcat-10.0.14-embed.zip.sha512 dev/tomcat/tomcat-10/v10.0.14/src/ dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.tar.gz (with props) dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.tar.gz.asc dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.tar.gz.sha512 dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.zip (with props) dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.zip.asc dev/tomcat/tomcat-10/v10.0.14/src/apache-tomcat-10.0.14-src.zip.sha512 Added: dev/tomcat/tomcat-10/v10.0.14/KEYS == --- dev/tomcat/tomcat-10/v10.0.14/KEYS (added) +++ dev/tomcat/tomcat-10/v10.0.14/KEYS Thu Dec 2 22:17:16 2021 @@ -0,0 +1,453 @@ +This file contains the PGP&GPG keys of various Apache developers. +Please don't use them for email unless you have to. Their main +purpose is code signing. + +Apache users: pgp < KEYS +Apache developers: +(pgpk -ll && pgpk -xa ) >> this file. + or +(gpg --fingerprint --list-sigs + && gpg --armor --export ) >> this file. + +Apache developers: please ensure that your key is also available via the +PGP keyservers (such as pgpkeys.mit.edu). + + +pub 4096R/2F6059E7 2009-09-18 + Key fingerprint = A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7 +uid Mark E D Thomas +sub 4096R/5E763BEC 2009-09-18 + +-BEGIN PGP PUBLIC KEY BLOCK- +Comment: GPGTools - http://gpgtools.org + +mQINBEq0DukBEAD4jovHOPJDxoD+JnO1Go2kiwpgRULasGlrVKuSUdP6wzcaqWmX +pqtOJKKwW2MQFQLmg7nQ9RjJwy3QCbKNDJQA/bwbQT1F7WzTCz2S6vxC4zxKck4t +6RZBq2dJsYKF0CEh6ZfY4dmKvhq+3istSoFRdHYoOPGWZpuRDqfZPdGm/m335/6K +GH59oysn1NE7a2a+kZzjBSEgv23+l4Z1Rg7+fpz1JcdHSdC2Z+ZRxML25eVatRVz +4yvDOZItqDURP24zWOodxgboldV6Y88C3v/7KRR+1vklzkuA2FqF8Q4r/2f0su7M +UVviQcy29y/RlLSDTTYoVlCZ1ni14qFU7Hpw43KJtgXmcUwq31T1+SlXdYjNJ1aF +kUi8BjCHDcSgE/IReKUanjHzm4XSymKDTeqqzidi4k6PDD4jyHb8k8vxi6qT6Udn +lcfo5NBkkUT1TauhEy8ktHhbl9k60BvvMBP9l6cURiJg1WS77egI4P/82oPbzzFi +GFqXyJKULVgxtdQ3JikCpodp3f1fh6PlYZwkW4xCJLJucJ5MiQp07HAkMVW5w+k8 +Xvuk4i5quh3N+2kzKHOOiQCDmN0sz0XjOE+
[VOTE] Release Apache Tomcat 10.0.14
The proposed Apache Tomcat 10.0.14 release is now available for voting. Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary package for all the specification APIs has changed from javax.* to jakarta.* Applications that run on Tomcat 9 will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory The notable changes compared to 10.0.13 are: - Provide protection against a known OS bug that causes the acceptor to report an incoming connection more than once. - Implement a workaround for a JVM bug that can trigger a file descriptor leak when using multi-part upload and the application does not explicitly close an input stream for an uploaded file that was cached on disk. - Fix exceptions when the security manager is enabled and the first request received after starting is an HTTP request to a TLS enabled NIO2 connector. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.14/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1345 The tag is: https://github.com/apache/tomcat/tree/10.0.14 3bb5b5fcf02e25ae627e480937e755e0a99c82d7 The proposed 10.0.14 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 10.0.14 (stable) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated (a58d8cd -> 9d9221b)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a58d8cd Fix the deploy-release target new 6254c8e Fix various false positives new 9d9221b Increment version for next development cycle The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default| 2 +- res/findbugs/filter-false-positives.xml | 76 + res/maven/mvn.properties.default| 2 +- webapps/docs/changelog.xml | 4 +- 4 files changed, 81 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Fix various false positives
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6254c8e54e5239423ad53b6bd862a4e9be634748 Author: Mark Thomas AuthorDate: Fri Nov 26 16:56:57 2021 + Fix various false positives --- res/findbugs/filter-false-positives.xml | 76 + 1 file changed, 76 insertions(+) diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml index 579dbce..38cc114 100644 --- a/res/findbugs/filter-false-positives.xml +++ b/res/findbugs/filter-false-positives.xml @@ -708,6 +708,20 @@ + + + + + + + + + + + + + + @@ -997,6 +1011,12 @@ + + + + + + @@ -1102,6 +1122,15 @@ + + + + + + + + + @@ -1285,6 +1314,15 @@ + + + + + + + + + @@ -1477,6 +1515,12 @@ + + + + + + @@ -1495,6 +1539,12 @@ + + + + + + @@ -1930,6 +1980,15 @@ + + + + + + + + + @@ -2130,6 +2189,12 @@ + + + + + + @@ -2146,6 +2211,12 @@ + + + + + + @@ -2156,6 +2227,11 @@ + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Increment version for next development cycle
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9d9221b157a376b4bc91a155903ec10bcae0589a Author: Mark Thomas AuthorDate: Thu Dec 2 22:23:42 2021 + Increment version for next development cycle --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index eb89235..66c9d08 100644 --- a/build.properties.default +++ b/build.properties.default @@ -33,7 +33,7 @@ version.major=10 version.minor=1 version.build=0 version.patch=0 -version.suffix=-M8-dev +version.suffix=-M9-dev # - Reproducible builds - # Uncomment and set to current time for reproducible builds diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index 78ab938..b318e5b 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=10.1.0-M8 +maven.asf.release.deploy.version=10.1.0-M9 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 2312bcf..5d231bf 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Increment version for next development cycle
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 6b773c5 Increment version for next development cycle 6b773c5 is described below commit 6b773c5f0ab750c4ff0c22e82e70f4720c838e7e Author: Mark Thomas AuthorDate: Thu Dec 2 22:26:09 2021 + Increment version for next development cycle --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 57162b3..fe3f71c 100644 --- a/build.properties.default +++ b/build.properties.default @@ -31,7 +31,7 @@ # - Version Control Flags - version.major=10 version.minor=0 -version.build=14 +version.build=15 version.patch=0 version.suffix=-dev diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index 9217ab2..1029990 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=10.0.14 +maven.asf.release.deploy.version=10.0.15 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 580a3e3..3e74120 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Tomcat 8.5.38
I think these two sentences should be transposed
Tomcat 8.5.38
I think these two sentences should be transposed
Re: Tomcat 8.5.38
On 03/12/2021 06:57, wrote: I think these two sentences should be transposed This list strips attachments. I suggest you provide a patch / PR to show the change you are suggesting. Don't forgot to explain why you think the change is necessary. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Fix copied/pasted comment
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0fd5a54 Fix copied/pasted comment 0fd5a54 is described below commit 0fd5a5495d3535f00cd9ff187fa97566c889fdab Author: Mark Thomas AuthorDate: Fri Dec 3 07:19:06 2021 + Fix copied/pasted comment --- java/org/apache/tomcat/util/collections/SynchronizedStack.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/java/org/apache/tomcat/util/collections/SynchronizedStack.java b/java/org/apache/tomcat/util/collections/SynchronizedStack.java index 1af00ce..f178b02 100644 --- a/java/org/apache/tomcat/util/collections/SynchronizedStack.java +++ b/java/org/apache/tomcat/util/collections/SynchronizedStack.java @@ -18,10 +18,10 @@ package org.apache.tomcat.util.collections; /** * This is intended as a (mostly) GC-free alternative to - * {@link java.util.concurrent.ConcurrentLinkedQueue} when the requirement is to - * create a pool of re-usable objects with no requirement to shrink the pool. - * The aim is to provide the bare minimum of required functionality as quickly - * as possible with minimum garbage. + * {@link java.util.Stack} when the requirement is to create a pool of re-usable + * objects with no requirement to shrink the pool. The aim is to provide the + * bare minimum of required functionality as quickly as possible with minimum + * garbage. * * @param The type of object managed by this stack */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Fix copied/pasted comment
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 51c8ae1 Fix copied/pasted comment 51c8ae1 is described below commit 51c8ae17ed9d767a6f7f1e7e4665b33f0e231ae8 Author: Mark Thomas AuthorDate: Fri Dec 3 07:19:06 2021 + Fix copied/pasted comment --- java/org/apache/tomcat/util/collections/SynchronizedStack.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/java/org/apache/tomcat/util/collections/SynchronizedStack.java b/java/org/apache/tomcat/util/collections/SynchronizedStack.java index 1af00ce..f178b02 100644 --- a/java/org/apache/tomcat/util/collections/SynchronizedStack.java +++ b/java/org/apache/tomcat/util/collections/SynchronizedStack.java @@ -18,10 +18,10 @@ package org.apache.tomcat.util.collections; /** * This is intended as a (mostly) GC-free alternative to - * {@link java.util.concurrent.ConcurrentLinkedQueue} when the requirement is to - * create a pool of re-usable objects with no requirement to shrink the pool. - * The aim is to provide the bare minimum of required functionality as quickly - * as possible with minimum garbage. + * {@link java.util.Stack} when the requirement is to create a pool of re-usable + * objects with no requirement to shrink the pool. The aim is to provide the + * bare minimum of required functionality as quickly as possible with minimum + * garbage. * * @param The type of object managed by this stack */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix copied/pasted comment
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b68865a Fix copied/pasted comment b68865a is described below commit b68865aa7e85f6e3532716ae10abeda43593b734 Author: Mark Thomas AuthorDate: Fri Dec 3 07:19:06 2021 + Fix copied/pasted comment --- java/org/apache/tomcat/util/collections/SynchronizedStack.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/java/org/apache/tomcat/util/collections/SynchronizedStack.java b/java/org/apache/tomcat/util/collections/SynchronizedStack.java index 1af00ce..f178b02 100644 --- a/java/org/apache/tomcat/util/collections/SynchronizedStack.java +++ b/java/org/apache/tomcat/util/collections/SynchronizedStack.java @@ -18,10 +18,10 @@ package org.apache.tomcat.util.collections; /** * This is intended as a (mostly) GC-free alternative to - * {@link java.util.concurrent.ConcurrentLinkedQueue} when the requirement is to - * create a pool of re-usable objects with no requirement to shrink the pool. - * The aim is to provide the bare minimum of required functionality as quickly - * as possible with minimum garbage. + * {@link java.util.Stack} when the requirement is to create a pool of re-usable + * objects with no requirement to shrink the pool. The aim is to provide the + * bare minimum of required functionality as quickly as possible with minimum + * garbage. * * @param The type of object managed by this stack */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix copied/pasted comment
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 88d5a87 Fix copied/pasted comment 88d5a87 is described below commit 88d5a8769136d720d27aa01af273b200dc1c2539 Author: Mark Thomas AuthorDate: Fri Dec 3 07:19:06 2021 + Fix copied/pasted comment --- java/org/apache/tomcat/util/collections/SynchronizedStack.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/java/org/apache/tomcat/util/collections/SynchronizedStack.java b/java/org/apache/tomcat/util/collections/SynchronizedStack.java index 1af00ce..f178b02 100644 --- a/java/org/apache/tomcat/util/collections/SynchronizedStack.java +++ b/java/org/apache/tomcat/util/collections/SynchronizedStack.java @@ -18,10 +18,10 @@ package org.apache.tomcat.util.collections; /** * This is intended as a (mostly) GC-free alternative to - * {@link java.util.concurrent.ConcurrentLinkedQueue} when the requirement is to - * create a pool of re-usable objects with no requirement to shrink the pool. - * The aim is to provide the bare minimum of required functionality as quickly - * as possible with minimum garbage. + * {@link java.util.Stack} when the requirement is to create a pool of re-usable + * objects with no requirement to shrink the pool. The aim is to provide the + * bare minimum of required functionality as quickly as possible with minimum + * garbage. * * @param The type of object managed by this stack */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
?????? Tomcat 8.5.38
package org.apache.tomcat.util.collections; public class SynchronizedQueue
Re: 回复: Tomcat 8.5.38
On 03/12/2021 07:23, wrote: package org.apache.tomcat.util.collections; public class SynchronizedQueue You are wrong. I suggest you use a debugger to create a queue of size 4 and then debug what happens when you do the following: - call offer() 3 times - call poll() 2 times - call offer() 4 times When multiple pollerevents are produced and not consumed, the capacity needs to be expanded That we agree on. so I think the code in the red part should exchange positions?? You have misunderstood the code. This is a FIFO queue not a LIFO queue. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org