Re: ECJ, Tomcat 8.5.x and Java 17
On 07/10/2021 20:59, Konstantin Kolinko wrote:
чт, 7 окт. 2021 г. в 18:46, Mark Thomas :
Is this a problem worth solving? If it is, is there a better way?
Hi!
Last few days I was thinking of the following approaches:
I view users having to explicitly make a choice as a disadvantage rather
than an advantage. I'd like the solution to be automatic.
a) is essentially another variation of b), c) & d) that uses "magic" to
select the right JAR from ${cataliba.base}/lib
I wonder about another variation where the common loader syntax gets a
Java version added. I'm not sure this level of configuration flexibility
is necessary.
I *really* like e). That is very neat solution. My only concern is
licensing. There are two issues:
- the JARs are licensed under different versions of the EPL
- ASF license policy says we can't modify EPL licensed artefacts
Given we aren't making source modifications, the ASF policy concern may
not be valid.
The multiple license issue should be manageable with appropriate updates
to out LICENSE and NOTICE files although I'd be more comfortable if we
checked the Eclipse foundation were happy too.
Given the completely automatic nature, my current preference is for e)
or a).
Looking at this another way, a) and e) are similar too. The difference
is in a) Tomcat selects the correct JAR whereas in a) the JRE selects
the right classes from a single JAR.
e) is certainly the more elegant solution but it does have some admin
we'd need to do. a) is less elegant but avoids the admin. Maybe
implement a) as a stop-gap while we see if e) is possible?
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Correct release date
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d92a26c Correct release date d92a26c is described below commit d92a26ce75bf187a7dd5e24b27506a581a094b7a Author: Mark Thomas AuthorDate: Fri Oct 8 09:45:08 2021 +0100 Correct release date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 589e0fa..94bbb54 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -147,7 +147,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Correct the release date
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 3e20b63 Correct the release date 3e20b63 is described below commit 3e20b630e6c60d4eb833d0bfa7aac5e0fb101c24 Author: Mark Thomas AuthorDate: Fri Oct 8 09:45:40 2021 +0100 Correct the release date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index e76086a..bf789bb 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -127,7 +127,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Correct release date
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 74ef2b4 Correct release date 74ef2b4 is described below commit 74ef2b4c7ea88c65838fe1efdf8a9db04663eee6 Author: Mark Thomas AuthorDate: Fri Oct 8 09:46:18 2021 +0100 Correct release date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index f84adc8..b236b54 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -127,7 +127,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Add release date
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 642873e Add release date 642873e is described below commit 642873edc4eb5227218a75eb65c9426f2a315671 Author: Mark Thomas AuthorDate: Fri Oct 8 09:47:09 2021 +0100 Add release date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index f0e6cd6..3342f1d 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -115,7 +115,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch main updated: Correct release date
On Fri, Oct 8, 2021 at 10:45 AM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch main > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/main by this push: > new d92a26c Correct release date > d92a26c is described below > > commit d92a26ce75bf187a7dd5e24b27506a581a094b7a > Author: Mark Thomas > AuthorDate: Fri Oct 8 09:45:08 2021 +0100 > > Correct release date Ok, so the actual date is the vote wrapping up. Good. There was some confusion for me there, no real idea if it would be the tag date, or the announcement date. Rémy > --- > webapps/docs/changelog.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml > index 589e0fa..94bbb54 100644 > --- a/webapps/docs/changelog.xml > +++ b/webapps/docs/changelog.xml > @@ -147,7 +147,7 @@ > > > > - > + > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: ECJ, Tomcat 8.5.x and Java 17
пт, 8 окт. 2021 г. в 11:18, Mark Thomas :
>
> On 07/10/2021 20:59, Konstantin Kolinko wrote:
> > чт, 7 окт. 2021 г. в 18:46, Mark Thomas :
>
>
>
> >> Is this a problem worth solving? If it is, is there a better way?
> >
> > Hi!
> >
> > Last few days I was thinking of the following approaches:
>
>
>
>
> e) is certainly the more elegant solution but it does have some admin
> we'd need to do. a) is less elegant but avoids the admin. Maybe
> implement a) as a stop-gap while we see if e) is possible?
>
f)
Looks a bit like c) but another way around, combined with a):
1. Introduce new property
common-legacy.loader="${catalina.base}/lib/legacy/*.jar"
2. ECJ JARa are at the following locations:
${catalina.base}/lib/legacy/ecj-4.6.3.jar
- moved to legacy,
${catalina.base}/lib/ecj-4.20.jar
- added to the regular libs directory.
3. Attempt to load either
"org.eclipse.jdt.internal.compiler.batch.Main" class (their Main-Class)
or
"org.eclipse.jdt.internal.compiler.tool.EclipseCompiler" class (as
specified in their META-INF/services/javax.tools.JavaCompiler file)
or some other class usually used by Jasper (I have not checked the code).
If an attempt to load fails with
java.lang.UnsupportedClassVersionError (i.e. running with Java 7),
then exclude the library and use the paths in common-legacy.loader
property as fallback.
We routinely preload several classes at startup. An attempt to load
one more class is not much work. Loading it specifically from
ecj-4.20.jar and excluding that jar from classpath is some work/magic
to be done.
Additional notes:
a. The dependency on ECJ jar for users of Apache Maven is specified in
res/maven/tomcat-jasper.pom as
org.eclipse.jdt
ecj
3.12.3
If someone needs a newer version they may override the dependency.
b. Tomcat should be able to start successfully with no ECJ jar at classpath.
E.g. if somebody has already precompiled all their JSPs elsewhere, and
wants to run with no support for compilations of the JSPs.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] t-gergely opened a new pull request #453: AsyncFileHandler: try to flush on close
t-gergely opened a new pull request #453: URL: https://github.com/apache/tomcat/pull/453 When shutting down Tomcat on a single core server, some log entries can be lost. (E.g. the last ones added by `contextDestroyed`.) This patch tries to prevent that. It's not very elegant, but it works for me. (Should you want to rewrite `AsyncFileHandler` instead, you might also want to drop the `org.apache.juli.AsyncLoggerPollInterval` property, since using that doesn't make any sense to me.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
