[Bug 65527] New: Tomcat 8.5.70 build fails

2021-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

Bug ID: 65527
   Summary: Tomcat 8.5.70 build fails
   Product: Tomcat 8
   Version: 8.5.70
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: alexand...@gmx.net
  Target Milestone: 

Tomcat 8.5.70 build fails with exception

build.xml:1421: java.lang.RuntimeException: last modification time
'162816780' is too big ( > 8589934591 )
at
org.apache.tools.tar.TarOutputStream.failForBigNumber(TarOutputStream.java:599)
at
org.apache.tools.tar.TarOutputStream.failForBigNumber(TarOutputStream.java:590)
at
org.apache.tools.tar.TarOutputStream.failForBigNumbers(TarOutputStream.java:578)
at
org.apache.tools.tar.TarOutputStream.putNextEntry(TarOutputStream.java:299)
at org.apache.tools.ant.taskdefs.Tar.tarResource(Tar.java:504)
at org.apache.tools.ant.taskdefs.Tar.tarFile(Tar.java:378)
at org.apache.tools.ant.taskdefs.Tar.tar(Tar.java:695)
at org.apache.tools.ant.taskdefs.Tar.execute(Tar.java:341)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
at org.apache.tools.ant.Task.perform(Task.java:350)
at org.apache.tools.ant.Target.execute(Target.java:449)
at org.apache.tools.ant.Target.performTasks(Target.java:470)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
at
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1254)
at org.apache.tools.ant.Main.runBuild(Main.java:830)
at org.apache.tools.ant.Main.startAnt(Main.java:223)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)

The reason is an improper timestamp literal, introduced with tag 8.5.70 commit
3d2e8b196, which has too many trailing zeroes.

https://github.com/apache/tomcat/commit/3d2e8b1964d4dff3c0656618edc0b09d0d5634b8#diff-b62863571bd045ee04f5a84b5895a5160f4d3392a10d167f477d1c0c782fb3d8R36

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65527] Tomcat 8.5.70 build fails

2021-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Mark Thomas  ---
Just set ant.timesramp.now=not.a.number in build.properties to build from the
8.5.70 tag

This change was only in the tag so no change is required in 8.5.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65527] Tomcat 8.5.70 build fails

2021-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

--- Comment #2 from Konstantin Kolinko  ---
What is your version of Apache Ant?


According to META-INF/MANIFEST.MF files, the release was built with
Ant-Version: Apache Ant 1.9.16

The files (*.jar and *.class) in apache-tomcat-8.5.70.zip have a consistent
timestamp of 2021-08-09 16:17:14, so apparently the value of ant.tstamp.now was
ignored.

The value of ant.tstamp.now in build.properties.default in the source archive
(apache-tomcat-8.5.70-src.zip) is the same as in the git commit that was
referenced earlier.

[[[
# 2021-08-05 08:50:00 -0400 = 162816780
ant.tstamp.now=162816780
]]]

Documentation for tstamp task of Apache Ant:
https://ant.apache.org/manual-1.9.x/Tasks/tstamp.html
https://ant.apache.org/manual/Tasks/tstamp.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Add a note about allowed values for ant.tstamp.now property. Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

2021-08-30 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository.

kkolinko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 378a1e5  Add a note about allowed values for ant.tstamp.now property. 
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
378a1e5 is described below

commit 378a1e5f6fb5482e49b61d494da897bca8abe3dc
Author: Konstantin Kolinko 
AuthorDate: Mon Aug 30 13:54:27 2021 +0300

Add a note about allowed values for ant.tstamp.now property.
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
---
 build.properties.default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build.properties.default b/build.properties.default
index f745036..4032660 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,6 +31,7 @@ version.suffix=-M5-dev
 
 # - Reproducible builds -
 # Uncomment and set to current time for reproducible builds
+# Note: The value is in seconds (unlike milliseconds used by 
System.currentTimeMillis()).
 #2021-08-03T18:00:00Z
 #ant.tstamp.now=1628013600
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 10.0.x updated: Add a note about allowed values for ant.tstamp.now property. Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

2021-08-30 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository.

kkolinko pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.0.x by this push:
 new 9b4ea95  Add a note about allowed values for ant.tstamp.now property. 
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
9b4ea95 is described below

commit 9b4ea9576df3ce661372e6c992666155b0e29730
Author: Konstantin Kolinko 
AuthorDate: Mon Aug 30 13:54:27 2021 +0300

Add a note about allowed values for ant.tstamp.now property.
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
---
 build.properties.default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build.properties.default b/build.properties.default
index 09f2b2f..206a2a9 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,6 +31,7 @@ version.suffix=-dev
 
 # - Reproducible builds -
 # Uncomment and set to current time for reproducible builds
+# Note: The value is in seconds (unlike milliseconds used by 
System.currentTimeMillis()).
 #2021-07-29T12:00:00Z
 #ant.tstamp.now=162756
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Add a note about allowed values for ant.tstamp.now property. Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

2021-08-30 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository.

kkolinko pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new fe7a5c8  Add a note about allowed values for ant.tstamp.now property. 
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
fe7a5c8 is described below

commit fe7a5c8c98e839e4766385da3a709d08aa5bf09f
Author: Konstantin Kolinko 
AuthorDate: Mon Aug 30 13:54:27 2021 +0300

Add a note about allowed values for ant.tstamp.now property.
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
---
 build.properties.default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build.properties.default b/build.properties.default
index ead69a3..f2208e7 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,6 +31,7 @@ version.suffix=-dev
 
 # - Reproducible builds -
 # Uncomment and set to current time for reproducible builds
+# Note: The value is in seconds (unlike milliseconds used by 
System.currentTimeMillis()).
 #2021-07-29T12:00:00Z
 #ant.tstamp.now=162756
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Add a note about allowed values for ant.tstamp.now property. Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

2021-08-30 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository.

kkolinko pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 5ae1f89  Add a note about allowed values for ant.tstamp.now property. 
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
5ae1f89 is described below

commit 5ae1f89f755d87464c5f3a6cbd14ee06a962f284
Author: Konstantin Kolinko 
AuthorDate: Mon Aug 30 13:54:27 2021 +0300

Add a note about allowed values for ant.tstamp.now property.
Thanks to https://bz.apache.org/bugzilla/show_bug.cgi?id=65527
---
 build.properties.default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build.properties.default b/build.properties.default
index 4f6b3b5..457a24d 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,6 +31,7 @@ version.suffix=-dev
 
 # - Reproducible builds -
 # Uncomment and set to current time for reproducible builds
+# Note: The value is in seconds (unlike milliseconds used by 
System.currentTimeMillis()).
 #2021-06-08T12:00:00Z
 #ant.tstamp.now=1623153600
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65527] Tomcat 8.5.70 build fails

2021-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65527

--- Comment #3 from Konstantin Kolinko  ---
I added a comment to the build.properties.default file (in main, 10.0.x, 9.0.x
and 8.5.x branches of Apache Tomcat) and amended "ReleaseProcess" page on the
wiki.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: OT: Parsing EC private keys in PEM format

2021-08-30 Thread Christopher Schultz

Mark,

On 8/26/21 06:08, Mark Thomas wrote:

On 25/08/2021 18:04, Christopher Schultz wrote:

Mark,

On 8/25/21 10:28, Mark Thomas wrote:

On 25/08/2021 15:10, Christopher Schultz wrote:

All,

I'm trying to do this without looking at the code which is in Tomcat 
because I'd like to release it separately and not have to worry 
about figuring out hos to get permission, etc.


It is ALv2 so the requirements are pretty minimal. You just need to 
include a copy of the ALv2, note you based it on Apache Tomcat and 
don;t use any ASF trademarks in your product name.


Hmm. I seem to recall asking someone if I could contribute your 
PEMFile stuff to the PostgreSQL JDBC driver project (they only support 
non-encrypted DER files directly) and the reply I got was something 
along the lines of "horrific copyright violation/IP theft/good luck 
finding all the original authors and getting their permission/etc." 
(paraphrasing).


Hmm. Odd. I wonder why they said that. Do you have a public reference to 
that conversation. Obviously, any potential IP issues are a concern.


I'll look for it.

Looking at the code, I'm struggling to see where the concern would come 
from.


The original contribution was from Emmanuel. Given his work on JSign I 
have no reason to think the contribution wasn't original.


The ASN.1 parser was written from scratch by me. There are comment 
references to various specifications but whatever copyright/license they 
are under has no bearing on the copyright/licensing of the 
implementation. (And most, if not all, are RFCs.)


One of the first things I did was write my own ASN.1 parser. It looks 
like you went for the barest of bones, while I went a step or so farther.



The other commits are essentially cosmetic / refactoring.

If they wanted to relicense the code rather than use it under the ALv2 
then I can see how they might view that as potentially difficult 
although in this instance given all the people involved are Tomcat 
committers it would likely be fairly simple (assuming all the 
contributors were happy).


PostgreSQL has their own license[1]. It's pretty bare-bones, in the MIT 
style.


I found a PRIVATE KEY[2] that my code cannot open without some 
additional work. I'm going to try it with Tomcat to see if we have the 
same issue.


There is code and references in one of the SO answers that enabled me to 
adapt my code to with with that type of encrypted key.


Thanks,
-chris

[1] https://www.postgresql.org/about/licence/
[2] 
https://stackoverflow.com/questions/63832456/parsing-encrypted-pkcs8-encoded-pem-file-programatically


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Embedded JDBC for the testsuite ?

2021-08-30 Thread Christopher Schultz

Mark,

On 8/26/21 10:17, Mark Thomas wrote:

On 26/08/2021 15:06, Rémy Maucherat wrote:

Hi,

Given there are components that use JDBC, they probably could use some
testsuite coverage. What would be the best option for a "real"
embedded JDBC DB for the Tomcat testsuite ? Derby ?


Derby is the one I thought of. If we needed a feature not present in 
Derby (seems unlikely) I'd look at h2 or hsqldb.


+1 for Derby. The driver should be available in all supported JVMs.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org