GitHub CI failures

2021-04-21 Thread Mark Thomas 

Hi all,

You may have noticed that the CI tests have started to failed for Java 8 
on Windows at GitHub.


This appears to have started when GitHub updated the JDK from Zulu 
8.0.282 to 8.0.292.


I have confirmed with local testing that I can recreate the failure with 
Zulu 8.0.292 on Windows and that switching to Zulu 8.0.282 allows the 
tests to complete.


Initial indications are, therefore, that this is a Zuku JDK issue. I 
have opened an issue with Azul and I'll keep the list update with progress.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [External] : Re: JDK 17 Early Access build 18 is available

2021-04-21 Thread Rory O'Donnell 

Thanks again Martin!

On 21/04/2021 07:48, Martin Grigorov wrote:

Hi Rory,

Apache Tomcat's build and tests passed successfully with 
JDK 17-ea+18-1490 on Linux x86_64 and aarch64!


Regards,
Martin

On Tue, Apr 20, 2021 at 1:35 PM Rory O'Donnell 
mailto:rory.odonn...@oracle.com>> wrote:



*Hi Mark, *

*OpenJDK 17 Early Access build 18is now available at
**https://jdk.java.net/17


>*

  * These early-access , open-source builds are provided under the
      o GNU General Public License, version 2, with the Classpath
        Exception >
  * Release Notes are available at
http://jdk.java.net/17/release-notes


    >


**G1 pauses may be extremely long with EA build JDK-17+18*

*During performance testing we noticed that due to a recent change
(JDK-8262068) GC pauses after a G1 full GC may be extremely slow. The
problem has been fixed with JDK-8264987 and that has already been
integrated. This change will be available with the following EA build
JDK-17+19.  For more technical info please see [1]


*JEP 382 [2]**  - Starting with build 19, **JDK 17 for macOS is
*temporarily* switched from using OpenGL**to using Apple's Metal
API**for Java 2D rendering.*

Heads up to anyone who is testing JDK 17 for running apps on macOS.
Starting with build 19, JDK 17 for macOS is *temporarily* switched
from
using OpenGL to using Apple's Metal API for Java 2D rendering.

If you are running any kind of 2D / Swing/ AWT UI application on
macOS,
and see any rendering related problems
starting with JDK 17 b19, please do report them to us along with a
test
case and screen shots.

You may also set "-Dsun.java2d.opengl=true" to re-enable OpenGL -
which
implicitly disables Metal - to confirm that it is a Metal related
rendering glltch.


Rgds,Rory

[1]

https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2021-April/034745.html


[2] https://openjdk.java.net/jeps/382


-- 
Rgds, Rory O'Donnell

Quality Engineering Manager
Oracle EMEA, Dublin, Ireland



--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland

[GitHub] [tomcat] efge removed a comment on pull request #406: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-04-21 Thread GitBox 


efge removed a comment on pull request #406:
URL: https://github.com/apache/tomcat/pull/406#issuecomment-823413218


   (force-pushed to rebase and fix conflicts in changelog.xml)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] efge commented on pull request #406: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-04-21 Thread GitBox 


efge commented on pull request #406:
URL: https://github.com/apache/tomcat/pull/406#issuecomment-824040221


   (force-pushed to rebase and fix conflicts in changelog.xml)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix use of useInstanceManagerForTags with Tags that are inner classes

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new cb2e625  Fix use of useInstanceManagerForTags with Tags that are inner 
classes
cb2e625 is described below

commit cb2e625b55e66d55452b9e67d98b5ec5727f8754
Author: Mark Thomas 
AuthorDate: Wed Apr 21 15:22:11 2021 +0100

Fix use of useInstanceManagerForTags with Tags that are inner classes
---
 java/org/apache/jasper/compiler/Generator.java | 11 ++-
 webapps/docs/changelog.xml |  5 +
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/jasper/compiler/Generator.java 
b/java/org/apache/jasper/compiler/Generator.java
index 1fd19d9..b7ad241 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -2403,7 +2403,7 @@ class Generator {
 out.print(tagHandlerVar);
 out.println("_reused = false;");
 } else {
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 }
 
 // Wrap use of tag in try/finally to ensure clean-up takes place
@@ -2480,7 +2480,8 @@ class Generator {
 n.setEndJavaLine(out.getJavaLine());
 }
 
-private void writeNewInstance(String tagHandlerVar, String 
tagHandlerClassName) {
+private void writeNewInstance(String tagHandlerVar, Class 
tagHandlerClass) {
+String tagHandlerClassName = tagHandlerClass.getCanonicalName();
 out.printin(tagHandlerClassName);
 out.print(" ");
 out.print(tagHandlerVar);
@@ -2490,7 +2491,8 @@ class Generator {
 out.print(tagHandlerClassName);
 out.print(")");
 out.print("_jsp_getInstanceManager().newInstance(\"");
-out.print(tagHandlerClassName);
+// Need the binary name here, not the canonical name
+out.print(tagHandlerClass.getName());
 out.println("\", this.getClass().getClassLoader());");
 } else {
 out.print("new ");
@@ -2647,8 +2649,7 @@ class Generator {
 // Declare AT_END scripting variables
 declareScriptingVars(n, VariableInfo.AT_END);
 
-String tagHandlerClassName = tagHandlerClass.getCanonicalName();
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 
 out.printil("try {");
 out.pushIndent();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index dc81afa..e92e1a7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -145,6 +145,11 @@
 makes it possible to define a  that will
 not be loaded at start-up. (markt)
   
+  
+Allow the JSP configuration option
+useInstanceManagerForTags to be used with Tags that are
+implemented as inner classes. (markt)
+  
 
   
   

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix use of useInstanceManagerForTags with Tags that are inner classes

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new c741d99  Fix use of useInstanceManagerForTags with Tags that are inner 
classes
c741d99 is described below

commit c741d99aa4bdfe84d7bd8e08e0926a8934ccd4f3
Author: Mark Thomas 
AuthorDate: Wed Apr 21 15:22:11 2021 +0100

Fix use of useInstanceManagerForTags with Tags that are inner classes
---
 java/org/apache/jasper/compiler/Generator.java | 11 ++-
 webapps/docs/changelog.xml |  5 +
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/jasper/compiler/Generator.java 
b/java/org/apache/jasper/compiler/Generator.java
index 94af4df..eab4ed7 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -2416,7 +2416,7 @@ class Generator {
 out.print(tagHandlerVar);
 out.println("_reused = false;");
 } else {
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 }
 
 // Wrap use of tag in try/finally to ensure clean-up takes place
@@ -2493,7 +2493,8 @@ class Generator {
 n.setEndJavaLine(out.getJavaLine());
 }
 
-private void writeNewInstance(String tagHandlerVar, String 
tagHandlerClassName) {
+private void writeNewInstance(String tagHandlerVar, Class 
tagHandlerClass) {
+String tagHandlerClassName = tagHandlerClass.getCanonicalName();
 out.printin(tagHandlerClassName);
 out.print(" ");
 out.print(tagHandlerVar);
@@ -2503,7 +2504,8 @@ class Generator {
 out.print(tagHandlerClassName);
 out.print(")");
 out.print("_jsp_getInstanceManager().newInstance(\"");
-out.print(tagHandlerClassName);
+// Need the binary name here, not the canonical name
+out.print(tagHandlerClass.getName());
 out.println("\", this.getClass().getClassLoader());");
 } else {
 out.print("new ");
@@ -2660,8 +2662,7 @@ class Generator {
 // Declare AT_END scripting variables
 declareScriptingVars(n, VariableInfo.AT_END);
 
-String tagHandlerClassName = tagHandlerClass.getCanonicalName();
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 
 out.printil("try {");
 out.pushIndent();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bf65ff6..83c 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -145,6 +145,11 @@
 makes it possible to define a  that will
 not be loaded at start-up. (markt)
   
+  
+Allow the JSP configuration option
+useInstanceManagerForTags to be used with Tags that are
+implemented as inner classes. (markt)
+  
 
   
   

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix use of useInstanceManagerForTags with Tags that are inner classes

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 73749b6  Fix use of useInstanceManagerForTags with Tags that are inner 
classes
73749b6 is described below

commit 73749b61eddc40a5a99fb8339a04f41501616afb
Author: Mark Thomas 
AuthorDate: Wed Apr 21 15:22:11 2021 +0100

Fix use of useInstanceManagerForTags with Tags that are inner classes
---
 java/org/apache/jasper/compiler/Generator.java | 11 ++-
 webapps/docs/changelog.xml |  5 +
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/jasper/compiler/Generator.java 
b/java/org/apache/jasper/compiler/Generator.java
index c7f984e..0a83cb7 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -2384,7 +2384,7 @@ class Generator {
 out.print(tagHandlerVar);
 out.println("_reused = false;");
 } else {
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 }
 
 // Wrap use of tag in try/finally to ensure clean-up takes place
@@ -2461,7 +2461,8 @@ class Generator {
 n.setEndJavaLine(out.getJavaLine());
 }
 
-private void writeNewInstance(String tagHandlerVar, String 
tagHandlerClassName) {
+private void writeNewInstance(String tagHandlerVar, Class 
tagHandlerClass) {
+String tagHandlerClassName = tagHandlerClass.getCanonicalName();
 out.printin(tagHandlerClassName);
 out.print(" ");
 out.print(tagHandlerVar);
@@ -2471,7 +2472,8 @@ class Generator {
 out.print(tagHandlerClassName);
 out.print(")");
 out.print("_jsp_getInstanceManager().newInstance(\"");
-out.print(tagHandlerClassName);
+// Need the binary name here, not the canonical name
+out.print(tagHandlerClass.getName());
 out.println("\", this.getClass().getClassLoader());");
 } else {
 out.print("new ");
@@ -2628,8 +2630,7 @@ class Generator {
 // Declare AT_END scripting variables
 declareScriptingVars(n, VariableInfo.AT_END);
 
-String tagHandlerClassName = tagHandlerClass.getCanonicalName();
-writeNewInstance(tagHandlerVar, tagHandlerClassName);
+writeNewInstance(tagHandlerVar, tagHandlerClass);
 
 out.printil("try {");
 out.pushIndent();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 9643360..1f05fb7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -141,6 +141,11 @@
 makes it possible to define a  that will
 not be loaded at start-up. (markt)
   
+  
+Allow the JSP configuration option
+useInstanceManagerForTags to be used with Tags that are
+implemented as inner classes. (markt)
+  
 
   
   

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64771] Windows CPU processor always running by a thread reading request body from https connection

2021-04-21 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=64771

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #15 from Mark Thomas  ---
OP confirms that the issue is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

More CI issues

2021-04-21 Thread Mark Thomas 
Both GitHUb CI and Travis CI have started to report failures due to hash 
mismatches for downloaded resources.


I'm not sure what is going on at this point. It doesn't seem to be 
related to a faulty mirror or an incorrect download hash in 
build.properties.


Still looking (although I might not make much more progress today)

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Code clean-up. No functional change. Primarily to trigger a CI build.

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new e663ab0  Code clean-up. No functional change. Primarily to trigger a 
CI build.
e663ab0 is described below

commit e663ab075f73876adcb5172ebb332e79f6d0ee22
Author: Mark Thomas 
AuthorDate: Thu Apr 22 07:57:22 2021 +0100

Code clean-up. No functional change. Primarily to trigger a CI build.
---
 .../catalina/ant/jmx/JMXAccessorQueryTask.java | 29 +++---
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java 
b/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
index dbc4d80..50a220d 100644
--- a/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
+++ b/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
@@ -102,8 +102,7 @@ public class JMXAccessorQueryTask extends JMXAccessorTask {
  * @param qry The query
  * @return null (no error message to report other than exception)
  */
-protected String jmxQuery(MBeanServerConnection jmxServerConnection,
-String qry) {
+protected String jmxQuery(MBeanServerConnection jmxServerConnection, 
String qry) {
 String isError = null;
 Set names = null;
 String resultproperty = getResultproperty();
@@ -113,8 +112,9 @@ public class JMXAccessorQueryTask extends JMXAccessorTask {
 setProperty(resultproperty + 
".Length",Integer.toString(names.size()));
 }
 } catch (Exception e) {
-if (isEcho())
+if (isEcho()) {
 handleErrorOutput(e.getMessage());
+}
 return "Can't query mbeans " + qry;
 }
 
@@ -142,28 +142,29 @@ public class JMXAccessorQueryTask extends JMXAccessorTask 
{
 Object value = null;
 
 for (MBeanAttributeInfo attr : attrs) {
-if (!attr.isReadable())
+if (!attr.isReadable()) {
 continue;
+}
 String attName = attr.getName();
-if (attName.indexOf('=') >= 0 || attName.indexOf(':') >= 0
-|| attName.indexOf(' ') >= 0) {
+if (attName.indexOf('=') >= 0 || attName.indexOf(':') >= 0 || 
attName.indexOf(' ') >= 0) {
 continue;
 }
 
 try {
-value = jmxServerConnection
-.getAttribute(oname, attName);
+value = jmxServerConnection.getAttribute(oname, attName);
 } catch (Exception e) {
-if (isEcho())
-handleErrorOutput("Error getting attribute "
-+ oname + " " + pname + attName + " "
-+ e.toString());
+if (isEcho()) {
+handleErrorOutput(
+"Error getting attribute " + oname + " " + 
pname + attName + " " + e.toString());
+}
 continue;
 }
-if (value == null)
+if (value == null) {
 continue;
-if ("modelerType".equals(attName))
+}
+if ("modelerType".equals(attName)) {
 continue;
+}
 createProperty(pname + attName, value);
 }
 } catch (Exception e) {

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated (c741d99 -> eac02dc)

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


from c741d99  Fix use of useInstanceManagerForTags with Tags that are inner 
classes
 add eac02dc  Code clean-up. No functional change. Primarily to trigger a 
CI build.

No new revisions were added by this update.

Summary of changes:
 .../catalina/ant/jmx/JMXAccessorQueryTask.java | 29 +++---
 1 file changed, 15 insertions(+), 14 deletions(-)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Code clean-up. No functional change. Primarily to trigger a CI build.

2021-04-21 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new d3a0122  Code clean-up. No functional change. Primarily to trigger a 
CI build.
d3a0122 is described below

commit d3a012279f099706f9d746a3161d639a6f79456a
Author: Mark Thomas 
AuthorDate: Thu Apr 22 07:58:22 2021 +0100

Code clean-up. No functional change. Primarily to trigger a CI build.
---
 .../catalina/ant/jmx/JMXAccessorQueryTask.java | 29 +++---
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java 
b/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
index dbc4d80..50a220d 100644
--- a/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
+++ b/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java
@@ -102,8 +102,7 @@ public class JMXAccessorQueryTask extends JMXAccessorTask {
  * @param qry The query
  * @return null (no error message to report other than exception)
  */
-protected String jmxQuery(MBeanServerConnection jmxServerConnection,
-String qry) {
+protected String jmxQuery(MBeanServerConnection jmxServerConnection, 
String qry) {
 String isError = null;
 Set names = null;
 String resultproperty = getResultproperty();
@@ -113,8 +112,9 @@ public class JMXAccessorQueryTask extends JMXAccessorTask {
 setProperty(resultproperty + 
".Length",Integer.toString(names.size()));
 }
 } catch (Exception e) {
-if (isEcho())
+if (isEcho()) {
 handleErrorOutput(e.getMessage());
+}
 return "Can't query mbeans " + qry;
 }
 
@@ -142,28 +142,29 @@ public class JMXAccessorQueryTask extends JMXAccessorTask 
{
 Object value = null;
 
 for (MBeanAttributeInfo attr : attrs) {
-if (!attr.isReadable())
+if (!attr.isReadable()) {
 continue;
+}
 String attName = attr.getName();
-if (attName.indexOf('=') >= 0 || attName.indexOf(':') >= 0
-|| attName.indexOf(' ') >= 0) {
+if (attName.indexOf('=') >= 0 || attName.indexOf(':') >= 0 || 
attName.indexOf(' ') >= 0) {
 continue;
 }
 
 try {
-value = jmxServerConnection
-.getAttribute(oname, attName);
+value = jmxServerConnection.getAttribute(oname, attName);
 } catch (Exception e) {
-if (isEcho())
-handleErrorOutput("Error getting attribute "
-+ oname + " " + pname + attName + " "
-+ e.toString());
+if (isEcho()) {
+handleErrorOutput(
+"Error getting attribute " + oname + " " + 
pname + attName + " " + e.toString());
+}
 continue;
 }
-if (value == null)
+if (value == null) {
 continue;
-if ("modelerType".equals(attName))
+}
+if ("modelerType".equals(attName)) {
 continue;
+}
 createProperty(pname + attName, value);
 }
 } catch (Exception e) {

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org