8.5.x unit tests crashing

[Mark Thomas]

Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch
of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
always in a compilation thread which was unusual.

I am currently doing the binary search to figure out which commit
triggered the issue.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.5.x unit tests crashing

[Mark Thomas]

On 29/01/2021 08:06, Mark Thomas wrote:
> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch
> of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
> always in a compilation thread which was unusual.
> 
> I am currently doing the binary search to figure out which commit
> triggered the issue.

That was quicker than I expected. Running the HTTP/2 tests on their own
is enough to trigger the issue.

It was the fix for bug 65111 - freeing the direct buffers - that
triggered this.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.5.x unit tests crashing

[Rémy Maucherat]

On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas  wrote:

> On 29/01/2021 08:06, Mark Thomas wrote:
> > Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch
> > of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
> > always in a compilation thread which was unusual.
> >
> > I am currently doing the binary search to figure out which commit
> > triggered the issue.
>
> That was quicker than I expected. Running the HTTP/2 tests on their own
> is enough to trigger the issue.
>
> It was the fix for bug 65111 - freeing the direct buffers - that
> triggered this.
>

I think it's a good idea to take this out then, a little possible leak is
better than a crash ... I haven't seen any crash on CI or on my test run
with 10, so I did backport.

Rémy

[tomcat] branch 8.5.x updated: Drop fix for 65111 as it is causing crashes

[remm]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 9668330  Drop fix for 65111 as it is causing crashes
9668330 is described below

commit 96683304d326d90e97aa313a7712aee999320179
Author: remm 
AuthorDate: Fri Jan 29 09:50:27 2021 +0100

Drop fix for 65111 as it is causing crashes
---
 java/org/apache/tomcat/util/net/AprEndpoint.java | 1 -
 webapps/docs/changelog.xml   | 4 
 2 files changed, 5 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/AprEndpoint.java 
b/java/org/apache/tomcat/util/net/AprEndpoint.java
index 14a2ed5..b0aacf5 100644
--- a/java/org/apache/tomcat/util/net/AprEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AprEndpoint.java
@@ -2317,7 +2317,6 @@ public class AprEndpoint extends AbstractEndpoint 
implements SNICallBack {
 return;
 }
 closed = true;
-socketBufferHandler.free();
 if (sslOutputBuffer != null) {
 ByteBufferUtils.cleanDirectBuffer(sslOutputBuffer);
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 35e4475..9b3aa82 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -118,10 +118,6 @@
 Ensure that SNI provided host names are matched to SSL virtual host
 configurations in a case insensitive manner. (markt)
   
-  
-65111: Free direct memory buffers in the APR connector.
-(remm)
-  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.5.x unit tests crashing

[Rémy Maucherat]

On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas  wrote:

> On 29/01/2021 08:06, Mark Thomas wrote:
> > Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch
> > of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
> > always in a compilation thread which was unusual.
> >
> > I am currently doing the binary search to figure out which commit
> > triggered the issue.
>
> That was quicker than I expected. Running the HTTP/2 tests on their own
> is enough to trigger the issue.
>
> It was the fix for bug 65111 - freeing the direct buffers - that
> triggered this.
>

Almost certainly the swap with SocketBufferHandler.EMPTY saves 9 and 10
from crashing. It's not certain this is 100% safe actually, but possibly
good enough. I did reproduce a (rare) crash with 8.5, so no good option
other than take it out for now.

Rémy


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: 8.5.x unit tests crashing

[Mark Thomas]

On 29/01/2021 09:01, Rémy Maucherat wrote:
> On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas  wrote:
> 
>> On 29/01/2021 08:06, Mark Thomas wrote:
>>> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a bunch
>>> of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
>>> always in a compilation thread which was unusual.
>>>
>>> I am currently doing the binary search to figure out which commit
>>> triggered the issue.
>>
>> That was quicker than I expected. Running the HTTP/2 tests on their own
>> is enough to trigger the issue.
>>
>> It was the fix for bug 65111 - freeing the direct buffers - that
>> triggered this.
>>
> 
> Almost certainly the swap with SocketBufferHandler.EMPTY saves 9 and 10
> from crashing. It's not certain this is 100% safe actually, but possibly
> good enough. I did reproduce a (rare) crash with 8.5, so no good option
> other than take it out for now.

I was thinking about moving the cleaning of the direct buffers to
destroySocket()

I'll do some tests.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.5.x unit tests crashing

[Rémy Maucherat]

On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas  wrote:

> On 29/01/2021 09:01, Rémy Maucherat wrote:
> > On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas  wrote:
> >
> >> On 29/01/2021 08:06, Mark Thomas wrote:
> >>> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a
> bunch
> >>> of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
> >>> always in a compilation thread which was unusual.
> >>>
> >>> I am currently doing the binary search to figure out which commit
> >>> triggered the issue.
> >>
> >> That was quicker than I expected. Running the HTTP/2 tests on their own
> >> is enough to trigger the issue.
> >>
> >> It was the fix for bug 65111 - freeing the direct buffers - that
> >> triggered this.
> >>
> >
> > Almost certainly the swap with SocketBufferHandler.EMPTY saves 9 and 10
> > from crashing. It's not certain this is 100% safe actually, but possibly
> > good enough. I did reproduce a (rare) crash with 8.5, so no good option
> > other than take it out for now.
>
> I was thinking about moving the cleaning of the direct buffers to
> destroySocket()
>
> I'll do some tests.
>

Yes, ideally, waiting until after the socket is removed from the poller is
a good plan.

Rémy

Re: 8.5.x unit tests crashing

[Mark Thomas]

On 29/01/2021 09:21, Rémy Maucherat wrote:
> On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas  wrote:
> 
>> On 29/01/2021 09:01, Rémy Maucherat wrote:
>>> On Fri, Jan 29, 2021 at 9:12 AM Mark Thomas  wrote:
>>>
 On 29/01/2021 08:06, Mark Thomas wrote:
> Heads up. When I ran my pre-tag tests for 8.5.x I started to see a
>> bunch
> of JVM crashes on Windows with both Java 7 and Java 8. The crashes were
> always in a compilation thread which was unusual.
>
> I am currently doing the binary search to figure out which commit
> triggered the issue.

 That was quicker than I expected. Running the HTTP/2 tests on their own
 is enough to trigger the issue.

 It was the fix for bug 65111 - freeing the direct buffers - that
 triggered this.

>>>
>>> Almost certainly the swap with SocketBufferHandler.EMPTY saves 9 and 10
>>> from crashing. It's not certain this is 100% safe actually, but possibly
>>> good enough. I did reproduce a (rare) crash with 8.5, so no good option
>>> other than take it out for now.
>>
>> I was thinking about moving the cleaning of the direct buffers to
>> destroySocket()
>>
>> I'll do some tests.
>>
> 
> Yes, ideally, waiting until after the socket is removed from the poller is
> a good plan.

Initial testing looks good. I'm running the full test suite to make sure
before committing the fix.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.5.x unit tests crashing

[Mark Thomas]

On 29/01/2021 09:34, Mark Thomas wrote:
> On 29/01/2021 09:21, Rémy Maucherat wrote:
>> On Fri, Jan 29, 2021 at 10:08 AM Mark Thomas  wrote:



>>> I was thinking about moving the cleaning of the direct buffers to
>>> destroySocket()
>>>
>>> I'll do some tests.
>>>
>>
>> Yes, ideally, waiting until after the socket is removed from the poller is
>> a good plan.
> 
> Initial testing looks good. I'm running the full test suite to make sure
> before committing the fix.

Not such a good plan after all. I still see crashes. They are less
frequent (~1 per run rather than ~4 per run) but still present.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] minfrin commented on pull request #401: Add support for unix domain sockets (APR Protocol)

[GitBox]

minfrin commented on pull request #401:
URL: https://github.com/apache/tomcat/pull/401#issuecomment-769728053


   Thanks for this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.0.2

[Mark Thomas]

On 28/01/2021 19:12, Mark Thomas wrote:

> The proposed 10.0.2 release is:
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 10.0.2 (beta)
> [X] Stable - go ahead and release as 10.0.2 (stable)

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.43

[Mark Thomas]

On 28/01/2021 20:48, Mark Thomas wrote:

> The proposed 9.0.43 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.43

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] tag 8.5.63 created (now eb8d36c)

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to tag 8.5.63
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


  at eb8d36c  (commit)
This tag includes the following new commits:

 new eb8d36c  Tag 8.5.63

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/01: Tag 8.5.63

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to tag 8.5.63
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit eb8d36c30857866536e8c931731c9f86980b00a6
Author: Mark Thomas 
AuthorDate: Fri Jan 29 11:19:43 2021 +

Tag 8.5.63
---
 build.properties.default   | 2 +-
 webapps/docs/changelog.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index da90ce6..10b855b 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -27,7 +27,7 @@ version.major=8
 version.minor=5
 version.build=63
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Source control flags -
 git.branch=8.5.x
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 9b3aa82..36ad19b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -103,7 +103,7 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r45641 - /dev/tomcat/tomcat-8/v8.5.62/

[markt]

Author: markt
Date: Fri Jan 29 11:37:08 2021
New Revision: 45641

Log:
Drop 8.5.62 (release cancelled)

Removed:
dev/tomcat/tomcat-8/v8.5.62/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r45642 [2/2] - in /dev/tomcat/tomcat-8/v8.5.63: ./ bin/ bin/embed/ bin/extras/ src/

[markt]

Added: dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc Fri Jan 29 
11:40:20 2021
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEqcXfTSLpmZjZh1pREMAcWi9gWecFAmAT8iwACgkQEMAcWi9g
+Wec3PA/9HSUO9kxxFBblxlU1b2sIDfHAkTDZtJuM9RBDPe058earnKsgP8JAzeEC
+MuZ/X0+WS87vZ0jnulvwYEiKLeeJmurWSgfBE+gE51LE9v5B22sEqRhXXzGNuCBa
+nyPNvYjKHpKQOpecHPzIoejzPEscEuyG3NdW0MgI0q1O93/ffLOzkCtBIgA2Fygl
+urAidQIijiEiTfSxDCBxdAZ8qVnxqI2TWWeQFEiV2gyT9gGA94r7mRicKez0oV0b
+k6T0+egNyEXjBkCYxfTISZivN1eM024ljhvFfBlsnQYnwXwHxUv71ETklEkD1U+p
+rBHO+y/7UUPARL7dnZcruQZXhZSXvu0UNKGsiT/93/xrk0inn0grPQC4/4ocGPEH
+ENX07lqqMyFWBpwsvMtZeO3D+jmUZirEWh5V9MzCgk3XxqRX7RCuiiOHPNTBrT3K
+LEELq2LuODAAVBu+m/n3j0f0dzlM6hkjCH37xu7+WdqIbxk9pduM79u37Qg76lXg
+1RhEg6z1r4NN7FEtEzji/miLCHST5ij8JQTsI7frFGsHw+vZbNLNAjnR30PWS5M1
+XiU2bCpgSnucsNG3f1A0RT8d6T9+Qw+iqPm+P35ocwn1Eu0Ml+ayuQGEK9Bqjcx/
+SpRMo6FgxZH8IagTNA5qtUXuGwfuzFjlDhl8h2YQ8pobifxKG2w=
+=w6+n
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.sha512
==
--- dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.sha512 (added)
+++ dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.sha512 Fri Jan 
29 11:40:20 2021
@@ -0,0 +1 @@
+9e07d76153a93ed20cbb601d19a3dc768b66aff274847a53aae15c125311f14f0047de85b8db364442c5848238b8dbc417d828680a153b51276931767799c710
 *apache-tomcat-8.5.63-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r45642 [1/2] - in /dev/tomcat/tomcat-8/v8.5.63: ./ bin/ bin/embed/ bin/extras/ src/

[markt]

Author: markt
Date: Fri Jan 29 11:40:20 2021
New Revision: 45642

Log:
Upload Apache Tomcat 8.5.63 for voting

Added:
dev/tomcat/tomcat-8/v8.5.63/
dev/tomcat/tomcat-8/v8.5.63/KEYS
dev/tomcat/tomcat-8/v8.5.63/README.html
dev/tomcat/tomcat-8/v8.5.63/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.5.63/bin/
dev/tomcat/tomcat-8/v8.5.63/bin/README.html
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.zip.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-deployer.zip.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x64.zip.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63-windows-x86.zip.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.exe   (with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.exe.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.exe.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.zip   (with props)
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.zip.asc
dev/tomcat/tomcat-8/v8.5.63/bin/apache-tomcat-8.5.63.zip.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/embed/
dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.tar.gz.asc

dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.zip.asc
dev/tomcat/tomcat-8/v8.5.63/bin/embed/apache-tomcat-8.5.63-embed.zip.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/extras/
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-jmx-remote.jar.sha512
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.5.63/bin/extras/catalina-ws.jar.sha512
dev/tomcat/tomcat-8/v8.5.63/src/
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip   (with props)
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.asc
dev/tomcat/tomcat-8/v8.5.63/src/apache-tomcat-8.5.63-src.zip.sha512

Added: dev/tomcat/tomcat-8/v8.5.63/KEYS
==
--- dev/tomcat/tomcat-8/v8.5.63/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.5.63/KEYS Fri Jan 29 11:40:20 2021
@@ -0,0 +1,676 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+Type Bits/KeyIDDate   User ID
+pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: PGPfreeware 7.0.3 for non-commercial use 
+
+mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
+gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
+I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
+bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
+B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz
+gNftTbKx/MVS7

[VOTE] Release Apache Tomcat 8.5.63

[Mark Thomas]

The proposed Apache Tomcat 8.5.63 release is now available for voting.

The notable changes compared to the 8.5.61 release are:

- Add a new StringInterpreter interface that allows applications to
  provide customised string attribute value to type conversion within
  JSPs. This allows applications to provide a conversion
  implementation that is optimised for the application.

- Add peerAddress to coyote request, which contains the IP address of
  the direct connection peer. If a reverse proxy sits in front of
  Tomcat and the protocol used is AJP or HTTP in combination with the
  RemoteIp(Valve|Filter), the peer address might differ from the
  remoteAddress. The latter then contains the address of the client in
  front of the reverse proxy, not the address of the proxy itself.

- Escape elements in the access log that need to be escaped for the
  access log to be parsed unambiguously.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.63/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1298/

The tag is:
https://github.com/apache/tomcat/tree/8.5.63
eb8d36c30857866536e8c931731c9f86980b00a6

The proposed 8.5.63 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.63

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.0.2

[Rémy Maucherat]

On Thu, Jan 28, 2021 at 8:13 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.2 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes.
>
> The notable changes compared to 10.0.0 are:
>
> - Add support for using Unix domain sockets for NIO when running on
>   Java 16 or later.
>
> - Add a new StringInterpreter interface that allows applications to
>   provide customised string attribute value to type conversion within
>   JSPs. This allows applications to provide a conversion
>   implementation that is optimised for the application.
>
> - Add peerAddress to coyote request, which contains the IP address of
>   the direct connection peer. If a reverse proxy sits in front of
>   Tomcat and the protocol used is AJP or HTTP in combination with the
>   RemoteIp(Valve|Filter), the peer address might differ from the
>   remoteAddress. The latter then contains the address of the client in
>   front of the reverse proxy, not the address of the proxy itself.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1296
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.2
> 228209117457e9b30d96f235c45efac9d4b8d9cb
>
> The proposed 10.0.2 release is:
> [ ] Broken - do not release
> [ ] Beta   - go ahead and release as 10.0.2 (beta)
> [X] Stable - go ahead and release as 10.0.2 (stable)
>

Rémy


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.43

[Rémy Maucherat]

On Thu, Jan 28, 2021 at 9:56 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.43 release is now available for voting.
>
> The notable changes compared to the 9.0.41 release are:
>
> - Add support for using Unix domain sockets for NIO when running on
>   Java 16 or later.
>
> - Add a new StringInterpreter interface that allows applications to
>   provide customised string attribute value to type conversion within
>   JSPs. This allows applications to provide a conversion
>   implementation that is optimised for the application.
>
> - Add peerAddress to coyote request, which contains the IP address of
>   the direct connection peer. If a reverse proxy sits in front of
>   Tomcat and the protocol used is AJP or HTTP in combination with the
>   RemoteIp(Valve|Filter), the peer address might differ from the
>   remoteAddress. The latter then contains the address of the client in
>   front of the reverse proxy, not the address of the proxy itself.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.43/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1297/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.43
> dc8bcd9c0704235319d322ca3d4c32263a054766
>
> The proposed 9.0.43 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.43
>

Rémy


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 8.5.63

[Rémy Maucherat]

On Fri, Jan 29, 2021 at 12:44 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.63 release is now available for voting.
>
> The notable changes compared to the 8.5.61 release are:
>
> - Add a new StringInterpreter interface that allows applications to
>   provide customised string attribute value to type conversion within
>   JSPs. This allows applications to provide a conversion
>   implementation that is optimised for the application.
>
> - Add peerAddress to coyote request, which contains the IP address of
>   the direct connection peer. If a reverse proxy sits in front of
>   Tomcat and the protocol used is AJP or HTTP in combination with the
>   RemoteIp(Valve|Filter), the peer address might differ from the
>   remoteAddress. The latter then contains the address of the client in
>   front of the reverse proxy, not the address of the proxy itself.
>
> - Escape elements in the access log that need to be escaped for the
>   access log to be parsed unambiguously.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.63/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1298/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.63
> eb8d36c30857866536e8c931731c9f86980b00a6
>
> The proposed 8.5.63 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.63
>

Rémy

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[Bug 65114] New: HTTP/2 client

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65114

Bug ID: 65114
   Summary: HTTP/2 client
   Product: Tomcat Connectors
   Version: 1.2.46
  Hardware: Macintosh
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Common
  Assignee: dev@tomcat.apache.org
  Reporter: apartmo...@gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated (8e7e1d2 -> 069801f)

[remm]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


from 8e7e1d2  Increment version to 10.0.3 for next development cycle
 add 069801f  Use URI filtering in the default source implementation

No new revisions were added by this update.

Summary of changes:
 .../tomcat/util/file/ConfigurationSource.java  | 34 +-
 1 file changed, 20 insertions(+), 14 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Use URI filtering in the default source implementation

[remm]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 2e58ae8  Use URI filtering in the default source implementation
2e58ae8 is described below

commit 2e58ae8372f9e0e588681daa2a61cb7ad1e2500e
Author: remm 
AuthorDate: Fri Jan 29 15:13:50 2021 +0100

Use URI filtering in the default source implementation

Not actually used except in the testsuite, so no real change.
---
 .../tomcat/util/file/ConfigurationSource.java  | 34 +-
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/java/org/apache/tomcat/util/file/ConfigurationSource.java 
b/java/org/apache/tomcat/util/file/ConfigurationSource.java
index 57d5ce4..4dec49a 100644
--- a/java/org/apache/tomcat/util/file/ConfigurationSource.java
+++ b/java/org/apache/tomcat/util/file/ConfigurationSource.java
@@ -26,6 +26,8 @@ import java.net.URI;
 import java.net.URL;
 import java.net.URLConnection;
 
+import org.apache.tomcat.util.buf.UriUtil;
+
 /**
  * Abstracts configuration file storage. Allows Tomcat embedding using the 
regular
  * configuration style.
@@ -40,17 +42,19 @@ public interface ConfigurationSource {
 protected final URI userDirUri = userDir.toURI();
 @Override
 public Resource getResource(String name) throws IOException {
-File f = new File(name);
-if (!f.isAbsolute()) {
-f = new File(userDir, name);
-}
-if (f.isFile()) {
-FileInputStream fis = new FileInputStream(f);
-return new Resource(fis, f.toURI());
+if (!UriUtil.isAbsoluteURI(name)) {
+File f = new File(name);
+if (!f.isAbsolute()) {
+f = new File(userDir, name);
+}
+if (f.isFile()) {
+FileInputStream fis = new FileInputStream(f);
+return new Resource(fis, f.toURI());
+}
 }
 URI uri = null;
 try {
-uri = getURI(name);
+uri = userDirUri.resolve(name);
 } catch (IllegalArgumentException e) {
 throw new FileNotFoundException(name);
 }
@@ -63,12 +67,14 @@ public interface ConfigurationSource {
 }
 @Override
 public URI getURI(String name) {
-File f = new File(name);
-if (!f.isAbsolute()) {
-f = new File(userDir, name);
-}
-if (f.isFile()) {
-return f.toURI();
+if (!UriUtil.isAbsoluteURI(name)) {
+File f = new File(name);
+if (!f.isAbsolute()) {
+f = new File(userDir, name);
+}
+if (f.isFile()) {
+return f.toURI();
+}
 }
 return userDirUri.resolve(name);
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Can't save edit to Confluence page

[Christopher Schultz]

Mark,

On 1/28/21 17:13, Mark Thomas wrote:

On 28/01/2021 22:08, Mark Thomas wrote:

On 28/01/2021 22:04, Christopher Schultz wrote:

All,

I'm trying to update this page in Confluence:

https://cwiki.apache.org/confluence/display/TOMCAT/TomcatCon+2021-02

I've added my own name + availability, and some stuff to the table at
the bottom. I'm logged-in. Whenever I click "Update" it just says
"Unable to communicate with server. Saving is not possible at the moment.".

I seem to be able to do other things.

The worst part of the process was adding my availability because it's
done using able-cell backgrounds which can't really be copy/pasted.

When I click "edit", I can see my edits.

I just can't save/publish them.

Any ideas?


None. I can see those changes too so they are saved *somewhere* server
side. It looks like I might be able to save them but I get the same
error message if I try.


You are not going to believe this. Removing that smiley character fixed
it (thanks Google).


I 100% believe it.

We had a partner recently ask us to remove an apostrophe from a person's 
name "just in case it could cause a problem".


They obviously haven't had to deal with the "person" in my database who 
has an American flag in their name to test support for Unicode 
compositional characters (which works on my end!).



I've saved the page. Worth checking all your edits made it.
Thanks for figuring this out. I was given an "Update" option for my 
edits so I clicked it. Added another page-revision with 0 changes from 
your previous edits (which were really mine). LGTM.


Thanks,
-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 65114] HTTP/2 client

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65114

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
Bugzilla is not a playground.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 65114] HTTP/2 client

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65114

Mark Thomas  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 65115] New: Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65115

Bug ID: 65115
   Summary: Missing key (jsp.error.unable.renameClassFile) in
localization file for Russian and Spanish
   Product: Tomcat 9
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
  Assignee: dev@tomcat.apache.org
  Reporter: peter_lena...@ibi.com
  Target Milestone: -

I think this is a minor change in the localizations strings file.


The issue is happening when we are testing our Russian localization within our
product.
But I am not sure if tomcat is set to Russian or English when we are testing.

The code seems to be passing the name of the file that it cannot rename,
however not all of the localization files have [{0}] to [{1}]

Caused by: java.io.IOException: tmpFile.renameTo(classFile) failed
at
org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:207)
~[jasper.jar:8.5.32]
at org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:166)
~[jasper.jar:8.5.32]

at ...

Specifically the Russian file LocalStrings_ru.properties is missing this key
jsp.error.unable.renameClassFile=Unable to rename class file from [{0}] to
[{1}]


I think that this is the code that is generating the error. and it appears to
be passing in the filenames that cannot be renamed.  But the message displayed
does not contain the filenames.

if (!tmpFile.renameTo(classFile)) {
throw new
IOException(Localizer.getMessage("jsp.error.unable.renameClassFile",
tmpFile.getAbsolutePath(),
classFile.getAbsolutePath()));
}

A search of the LocalStrings shows that the  [{0}] to [{1}] is also missing in 
Japan, and Korean and German, and the key is also missing in the Spanish
translation file.


$ grep jsp.error.unable.renameClassFile $(find . -type f )
./tomcat-8.5.x/java/org/apache/jasper/compiler/SmapUtil.java:   
throw new IOException(Localizer.getMessage("jsp.erro
r.unable.renameClassFile",
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings.properties:jsp.error.unable.renameClassFile=Unable
to rename class f
ile from [{0}] to [{1}]
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_de.properties:jsp.error.unable.renameClassFile=Fehler
beim Umbenenne
n der Klassendatei
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_fr.properties:jsp.error.unable.renameClassFile=Impossible
de renomme
r le fichier de classe de [{0}] vers [{1}]
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_ja.properties:jsp.error.unable.renameClassFile=ククララススフファァイイルルのの名名前前
をを変変更更ででききまませせんん
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_ko.properties:jsp.error.unable.renameClassFile=클클래래스스
파파일일의의 이이름름을을
변변경경할할 수수 없없습습니니다다.
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_zh_CN.properties:jsp.error.unable.renameClassFile=无无法法重重命命名名类类文文件件[{
0}]为为[{1}]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 49822] Add hash lb worker method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=49822

Vinson Merritt  changed:

   What|Removed |Added

 CC||vinnieashley4e...@gmail.com
  Attachment #25941|Patch to add hash lb worker |False
description|method  |
  Attachment #25941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 49822] Add hash lb worker method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=49822

Mark Thomas  changed:

   What|Removed |Added

  Attachment #25941|False   |Patch to add hash lb worker
description||method
  Attachment #25941|1   |0
is obsolete||

--- Comment #3 from Mark Thomas  ---
Comment on attachment 25941
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=25941
Patch to add hash lb worker method

Repair vandalism

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 49822] Add hash lb worker method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=49822

--- Comment #4 from Christopher Schultz  ---
I question the quality of this patch. There are a number of issues that I see:

1. The combining of the URI and query string is completely wrong. Only the
query string is actually used. I'm not sure if s->query_string can be NULL
(instead of simply empty-string), in which case this will crash the process.

2. There is no ensuring that the "req" "combined" URI+query-string is
null-terminated. Out-of-bounds read is possible, given that the client controls
the inputs.

3. There is a race-condition between seeding the PRNG (which is a process-wide
change) and obtaining a random number from the PRNG. Two threads running at the
same moment can step on each other and the random numbers may not be correct.

4. After hashing, why bother initializing a random-number generator and then
generating a single random number? You already have a nice "random number"
generated: the hash you just computed. Just use the hash directly.

Also, why not use a standard hashing algorithm? The one here appears to be the
ELF hash algorithm[1] which is, I suppose, standard enough. I looked at libapr
and it doesn't look like it has any specific hashing algorithms implemented,
unless I am very much mistaken. I suppose ELF hash is as good as any out there.
Suggestions are welcome.

[1] http://www.sco.com/developers/devspecs/gabi41.pdf pages 94-95, figure 5-12.
Also https://en.wikipedia.org/wiki/PJW_hash_function
I wonder if the ELF hash algorithm requires some kind of attribution. It's such
a short bit of code it can't really be implemented any other way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org