[GitHub] [tomcat] rmannibucau commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752367689


   @rmaucher it is not about letting a webapp use internal and by default I 
agree it should stick to the spec API, but it is common to need to go further, 
in particular when combining some servlet with valves or realms, and in this 
case being able to link both is important and can need the request access (even 
potentially the coyote one!). Enabling it by allowing to cast to "unwrappable" 
is good enough IMHO. In any case it is not worse than today in terms of access 
since today you can do it using reflection, it is just about making it more 
fluent for end users IMO. In TomEE we do it in several places and even unwrap 
the request until the context, having an unwrappable would make it smoother for 
ex, without breaking the facade concept at all. Only constraint is to not add 
to facade API any method out of the spec but another interface implemented by 
the same object does not violate this rule.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat-jakartaee-migration] ebourg commented on pull request #7: Convert the javax.jms package with the EE profile (Fixes #6). The previous fix c094325 targeted javax.jmx - Which is NOT touc

2020-12-30 Thread GitBox 


ebourg commented on pull request #7:
URL: 
https://github.com/apache/tomcat-jakartaee-migration/pull/7#issuecomment-752381653


   Good catch, thank you. I need more sleep.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] branch master updated (78287b2 -> c7884a4)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a change to branch master
in repository 
https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.


from 78287b2  Merge pull request #7 from alitokmen/master
 new be60024  Convert the javax.resource package with the EE profile (Java 
EE Connector API)
 new fc3009f  Convert the javax.jws package with the EE profile (Java EE 
Web Services Metadata API)
 new 8a0a171  Convert the javax.batch package with the EE profile (Java EE 
Batch Processing API)
 new 3fbd311  Convert the javax.faces package with the EE profile (Java 
Server Faces)
 new e4460ba  Convert the javax.security.jacc package with the EE profile 
(Java Authorization Contract for Containers API)
 new c7884a4  Convert the javax.xml.registry package with the EE profile 
(Java API for XML Registries)

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java |  6 +++---
 .../java/org/apache/tomcat/jakartaee/EESpecProfileTest.java  | 12 
 2 files changed, 15 insertions(+), 3 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 02/06: Convert the javax.jws package with the EE profile (Java EE Web Services Metadata API)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit fc3009fe73ae79cc6099693489152786c5e80ccd
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:21:48 2020 +0100

Convert the javax.jws package with the EE profile (Java EE Web Services 
Metadata API)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index 9fcf726..ffe611a 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -26,7 +26,7 @@ public enum EESpecProfile {
 
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
-
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|decorator|ejb|el|enterprise|jms|json|interceptor|inject|mail|persistence|"
+
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|decorator|ejb|el|enterprise|jms|json|jws|interceptor|inject|mail|persistence|"
 + 
"resource|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
 
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index 7078858..9a26340 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -43,6 +43,7 @@ public class EESpecProfileTest {
 assertEquals("javax.enterprise", profile.convert("javax.enterprise"));
 assertEquals("javax.jms", profile.convert("javax.jms"));
 assertEquals("javax.json", profile.convert("javax.json"));
+assertEquals("javax.jws", profile.convert("javax.jws"));
 assertEquals("javax.interceptor", 
profile.convert("javax.interceptor"));
 assertEquals("javax.inject", profile.convert("javax.inject"));
 assertEquals("javax.resource", profile.convert("javax.resource"));
@@ -76,6 +77,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.enterprise", 
profile.convert("javax.enterprise"));
 assertEquals("jakarta.jms", profile.convert("javax.jms"));
 assertEquals("jakarta.json", profile.convert("javax.json"));
+assertEquals("jakarta.jws", profile.convert("javax.jws"));
 assertEquals("jakarta.interceptor", 
profile.convert("javax.interceptor"));
 assertEquals("jakarta.inject", profile.convert("javax.inject"));
 assertEquals("jakarta.mail", profile.convert("javax.mail"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 04/06: Convert the javax.faces package with the EE profile (Java Server Faces)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit 3fbd31178f8654511495a5d53032ffe9d83bd928
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:37:31 2020 +0100

Convert the javax.faces package with the EE profile (Java Server Faces)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index 929303f..8db88b5 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -26,7 +26,7 @@ public enum EESpecProfile {
 
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
-
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|jms|json|jws|interceptor|inject|mail|persistence|"
+
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|faces|jms|json|jws|interceptor|inject|mail|persistence|"
 + 
"resource|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
 
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index 924fbcc..48610fc 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -42,6 +42,7 @@ public class EESpecProfileTest {
 assertEquals("javax.batch", profile.convert("javax.batch"));
 assertEquals("javax.decorator", profile.convert("javax.decorator"));
 assertEquals("javax.enterprise", profile.convert("javax.enterprise"));
+assertEquals("javax.faces", profile.convert("javax.faces"));
 assertEquals("javax.jms", profile.convert("javax.jms"));
 assertEquals("javax.json", profile.convert("javax.json"));
 assertEquals("javax.jws", profile.convert("javax.jws"));
@@ -77,6 +78,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.ejb", profile.convert("javax.ejb"));
 assertEquals("jakarta.el", profile.convert("javax.el"));
 assertEquals("jakarta.enterprise", 
profile.convert("javax.enterprise"));
+assertEquals("jakarta.faces", profile.convert("javax.faces"));
 assertEquals("jakarta.jms", profile.convert("javax.jms"));
 assertEquals("jakarta.json", profile.convert("javax.json"));
 assertEquals("jakarta.jws", profile.convert("javax.jws"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 05/06: Convert the javax.security.jacc package with the EE profile (Java Authorization Contract for Containers API)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit e4460ba8d9240bb6de57921e25f80a9cf96cee83
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:46:11 2020 +0100

Convert the javax.security.jacc package with the EE profile (Java 
Authorization Contract for Containers API)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index 8db88b5..475f9c2 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -27,7 +27,7 @@ public enum EESpecProfile {
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
 
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|faces|jms|json|jws|interceptor|inject|mail|persistence|"
-+ 
"resource|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
++ 
"resource|security[/\\.](auth[/\\.]message|jacc)|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
 
 private Pattern pattern;
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index 48610fc..ababc02 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -49,6 +49,7 @@ public class EESpecProfileTest {
 assertEquals("javax.interceptor", 
profile.convert("javax.interceptor"));
 assertEquals("javax.inject", profile.convert("javax.inject"));
 assertEquals("javax.resource", profile.convert("javax.resource"));
+assertEquals("javax.security.jacc", 
profile.convert("javax.security.jacc"));
 assertEquals("javax.validation", profile.convert("javax.validation"));
 assertEquals("javax.ws.rs", profile.convert("javax.ws.rs"));
 assertEquals("javax.xml.bind", profile.convert("javax.xml.bind"));
@@ -88,6 +89,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.persistence", 
profile.convert("javax.persistence"));
 assertEquals("jakarta.resource", profile.convert("javax.resource"));
 assertEquals("jakarta.security.auth.message", 
profile.convert("javax.security.auth.message"));
+assertEquals("jakarta.security.jacc", 
profile.convert("javax.security.jacc"));
 assertEquals("jakarta.servlet", profile.convert("javax.servlet"));
 assertEquals("jakarta.transaction", 
profile.convert("javax.transaction"));
 assertEquals("jakarta.validation", 
profile.convert("javax.validation"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 01/06: Convert the javax.resource package with the EE profile (Java EE Connector API)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit be600249852b4f38f01dad91e11edb7f5e0e6467
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:16:53 2020 +0100

Convert the javax.resource package with the EE profile (Java EE Connector 
API)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index 78d4103..9fcf726 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -27,7 +27,7 @@ public enum EESpecProfile {
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
 
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|decorator|ejb|el|enterprise|jms|json|interceptor|inject|mail|persistence|"
-+ 
"security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
++ 
"resource|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
 
 private Pattern pattern;
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index 1c97339..7078858 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -45,6 +45,7 @@ public class EESpecProfileTest {
 assertEquals("javax.json", profile.convert("javax.json"));
 assertEquals("javax.interceptor", 
profile.convert("javax.interceptor"));
 assertEquals("javax.inject", profile.convert("javax.inject"));
+assertEquals("javax.resource", profile.convert("javax.resource"));
 assertEquals("javax.validation", profile.convert("javax.validation"));
 assertEquals("javax.ws.rs", profile.convert("javax.ws.rs"));
 assertEquals("javax.xml.bind", profile.convert("javax.xml.bind"));
@@ -79,6 +80,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.inject", profile.convert("javax.inject"));
 assertEquals("jakarta.mail", profile.convert("javax.mail"));
 assertEquals("jakarta.persistence", 
profile.convert("javax.persistence"));
+assertEquals("jakarta.resource", profile.convert("javax.resource"));
 assertEquals("jakarta.security.auth.message", 
profile.convert("javax.security.auth.message"));
 assertEquals("jakarta.servlet", profile.convert("javax.servlet"));
 assertEquals("jakarta.transaction", 
profile.convert("javax.transaction"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 03/06: Convert the javax.batch package with the EE profile (Java EE Batch Processing API)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit 8a0a171135e6b4c193d495e3d4332c0477baebcd
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:30:37 2020 +0100

Convert the javax.batch package with the EE profile (Java EE Batch 
Processing API)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index ffe611a..929303f 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -26,7 +26,7 @@ public enum EESpecProfile {
 
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
-
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|decorator|ejb|el|enterprise|jms|json|jws|interceptor|inject|mail|persistence|"
+
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|jms|json|jws|interceptor|inject|mail|persistence|"
 + 
"resource|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
 
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index 9a26340..924fbcc 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -39,6 +39,7 @@ public class EESpecProfileTest {
 
 // not converted EE packages
 assertEquals("javax.activation", profile.convert("javax.activation"));
+assertEquals("javax.batch", profile.convert("javax.batch"));
 assertEquals("javax.decorator", profile.convert("javax.decorator"));
 assertEquals("javax.enterprise", profile.convert("javax.enterprise"));
 assertEquals("javax.jms", profile.convert("javax.jms"));
@@ -71,6 +72,7 @@ public class EESpecProfileTest {
 
 assertEquals("jakarta.activation", 
profile.convert("javax.activation"));
 assertEquals("jakarta.annotation", 
profile.convert("javax.annotation"));
+assertEquals("jakarta.batch", profile.convert("javax.batch"));
 assertEquals("jakarta.decorator", profile.convert("javax.decorator"));
 assertEquals("jakarta.ejb", profile.convert("javax.ejb"));
 assertEquals("jakarta.el", profile.convert("javax.el"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 06/06: Convert the javax.xml.registry package with the EE profile (Java API for XML Registries)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit c7884a42cbf31ec986e4e2261822580aa465be0a
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 10:52:26 2020 +0100

Convert the javax.xml.registry package with the EE profile (Java API for 
XML Registries)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index 475f9c2..d12f4e4 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -28,7 +28,7 @@ public enum EESpecProfile {
 
 
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|faces|jms|json|jws|interceptor|inject|mail|persistence|"
 + 
"resource|security[/\\.](auth[/\\.]message|jacc)|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
-+ 
"xml[/\\.](bind|namespace|rpc|soap|stream|ws|XMLConstants)))");
++ 
"xml[/\\.](bind|namespace|registry|rpc|soap|stream|ws|XMLConstants)))");
 
 private Pattern pattern;
 
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index ababc02..b2fe945 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -55,6 +55,7 @@ public class EESpecProfileTest {
 assertEquals("javax.xml.bind", profile.convert("javax.xml.bind"));
 assertEquals("javax.xml.namespace", 
profile.convert("javax.xml.namespace"));
 assertEquals("javax.xml.rpc", profile.convert("javax.xml.rpc"));
+assertEquals("javax.xml.registry", 
profile.convert("javax.xml.registry"));
 assertEquals("javax.xml.soap", profile.convert("javax.xml.soap"));
 assertEquals("javax.xml.stream", profile.convert("javax.xml.stream"));
 assertEquals("javax.xml.ws", profile.convert("javax.xml.ws"));
@@ -97,6 +98,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.ws.rs", profile.convert("javax.ws.rs"));
 assertEquals("jakarta.xml.bind", profile.convert("javax.xml.bind"));
 assertEquals("jakarta.xml.namespace", 
profile.convert("javax.xml.namespace"));
+assertEquals("jakarta.xml.registry", 
profile.convert("javax.xml.registry"));
 assertEquals("jakarta.xml.rpc", profile.convert("javax.xml.rpc"));
 assertEquals("jakarta.xml.soap", profile.convert("javax.xml.soap"));
 assertEquals("jakarta.xml.stream", 
profile.convert("javax.xml.stream"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] branch master updated (c7884a4 -> d35a385)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a change to branch master
in repository 
https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.


from c7884a4  Convert the javax.xml.registry package with the EE profile 
(Java API for XML Registries)
 new 77967f9  Convert the javax.security.enterprise package with the EE 
profile (Java EE Security API)
 new d35a385  Mention the Debian/Ubuntu package

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 README.md| 4 
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 3 files changed, 7 insertions(+), 1 deletion(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 02/02: Mention the Debian/Ubuntu package

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit d35a3853ae1af3282c4c19ba3050edfd94c70889
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 11:15:26 2020 +0100

Mention the Debian/Ubuntu package
---
 README.md | 4 
 1 file changed, 4 insertions(+)

diff --git a/README.md b/README.md
index 3874215..1e10a47 100644
--- a/README.md
+++ b/README.md
@@ -39,6 +39,10 @@ the same type as the source.
 >
 > A warning will be logged for each JAR file where the signature has been 
 > removed.
 
+This tool is also available on Debian and Ubuntu systems by installing the
+[tomcat-jakartaee-migration](https://tracker.debian.org/tomcat-jakartaee-migration)
+package and invoking the `javax2jakarta` command.
+
 ## Ant task
 
 The migration tool is available as an Ant task, here is an example:


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat-jakartaee-migration] 01/02: Convert the javax.security.enterprise package with the EE profile (Java EE Security API)

2020-12-30 Thread ebourg 
This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit 77967f9db1a2490441c514177715126f1b7c4aa3
Author: Emmanuel Bourg 
AuthorDate: Wed Dec 30 11:21:57 2020 +0100

Convert the javax.security.enterprise package with the EE profile (Java EE 
Security API)
---
 src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java | 2 +-
 src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java 
b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
index d12f4e4..3d3a097 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/EESpecProfile.java
@@ -27,7 +27,7 @@ public enum EESpecProfile {
 
TOMCAT("javax([/\\.](annotation(?![/\\.]processing)|ejb|el|mail|persistence|security[/\\.]auth[/\\.]message|servlet|transaction(?![/\\.]xa)|websocket))"),
 
 
EE("javax([/\\.](activation|annotation(?![/\\.]processing)|batch|decorator|ejb|el|enterprise|faces|jms|json|jws|interceptor|inject|mail|persistence|"
-+ 
"resource|security[/\\.](auth[/\\.]message|jacc)|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
++ 
"resource|security[/\\.](auth[/\\.]message|enterprise|jacc)|servlet|transaction(?![/\\.]xa)|validation|websocket|ws[/\\.]rs|"
 + 
"xml[/\\.](bind|namespace|registry|rpc|soap|stream|ws|XMLConstants)))");
 
 private Pattern pattern;
diff --git a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java 
b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
index b2fe945..564789f 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/EESpecProfileTest.java
@@ -49,6 +49,7 @@ public class EESpecProfileTest {
 assertEquals("javax.interceptor", 
profile.convert("javax.interceptor"));
 assertEquals("javax.inject", profile.convert("javax.inject"));
 assertEquals("javax.resource", profile.convert("javax.resource"));
+assertEquals("javax.security.enterprise", 
profile.convert("javax.security.enterprise"));
 assertEquals("javax.security.jacc", 
profile.convert("javax.security.jacc"));
 assertEquals("javax.validation", profile.convert("javax.validation"));
 assertEquals("javax.ws.rs", profile.convert("javax.ws.rs"));
@@ -90,6 +91,7 @@ public class EESpecProfileTest {
 assertEquals("jakarta.persistence", 
profile.convert("javax.persistence"));
 assertEquals("jakarta.resource", profile.convert("javax.resource"));
 assertEquals("jakarta.security.auth.message", 
profile.convert("javax.security.auth.message"));
+assertEquals("jakarta.security.enterprise", 
profile.convert("javax.security.enterprise"));
 assertEquals("jakarta.security.jacc", 
profile.convert("javax.security.jacc"));
 assertEquals("jakarta.servlet", profile.convert("javax.servlet"));
 assertEquals("jakarta.transaction", 
profile.convert("javax.transaction"));


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


markt-asf commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752437120


   I would be against exposing container internals via the Servlet API as it 
undermines portability.
   
   What information, specifically, do you need to access and how (read, write)? 
I think I'd rather a solution that provided the specific access required. An 
added complication is that Tomcat has always aimed to support the use case of 
running "untrusted" apps. As such providing all apps with write access to 
anything considered security sensitive is going to be tricky and would probably 
require an configuration option to explicitly enable it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] rmannibucau commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752446136


   @markt-asf requests notes. How adding RequestFacade implements 
HttpServletRequest, Unwrappable is less secure than current impl? if it helps I 
guess you can use the security manager if set un unwrap(), would be 1-1 in 
terms of security with current state where using reflection falls in the same 
bucket, no?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


rmaucher commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752472614


   @markt-asf If you really want to encourage this, there is the privileged 
flag on the Context that allows using container servlets.
   public Request getRequest() {
   if (request.getContext().getPrivileged()) { return request; } else 
throw new SecurityException(); // :)
   }



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] arjantijms commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752499693


   > I would be against exposing container internals via the Servlet API as it 
undermines portability.
   
   Well, actually it could be used by integration libraries to improve 
portability, the exact opposite. Integration libraries enumerate all known 
implementations, adapting the internals of each to some common functionality.
   
   As an example, look at how Soteria is able to implement an SPI for Weld:
   
   
https://github.com/eclipse-ee4j/soteria/blob/master/spi/bean-decorator/weld/src/main/java/org/glassfish/soteria/spi/bean/decorator/weld/WeldBeanDecorator.java
   
   It allows to get the Weld specific BeanManager from the spec compliant 
BeanManager:
   
   ```java
   BeanManagerProxy.unwrap(beanManager));
   ```
   
   Another example, using enumeration of known implementations:
   
   
https://github.com/omnifaces/exousia/blob/master/src/main/java/org/omnifaces/exousia/spi/impl/DefaultRoleMapper.java#L374
   
   It uses reflection, but you may get the idea. 
   
   Without using reflecting and specifically for Tomcat:
   
   
https://github.com/omnifaces/exousia/blob/master/src/main/java/org/omnifaces/exousia/spi/integration/IntegrationInitializer.java#L42
   
   It now only has Tomcat, but I'm planning to add Jetty there later.
   
   The internal APIs are kinda used for essentially a polyfill.
   
   
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix javadoc after changes

2020-12-30 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 0974ffc  Fix javadoc after changes
0974ffc is described below

commit 0974ffcc1880ace148f9effd35e27728cccfc558
Author: remm 
AuthorDate: Wed Dec 30 16:54:29 2020 +0100

Fix javadoc after changes
---
 java/org/apache/tomcat/util/compat/JreCompat.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/compat/JreCompat.java 
b/java/org/apache/tomcat/util/compat/JreCompat.java
index b12f80b..b8b3b48 100644
--- a/java/org/apache/tomcat/util/compat/JreCompat.java
+++ b/java/org/apache/tomcat/util/compat/JreCompat.java
@@ -305,7 +305,7 @@ public class JreCompat {
 
 
 /**
- * Create server socket channel using the specified socket domain socket 
address.
+ * Create server socket channel using the Unix domain socket 
ProtocolFamily.
  * @return the server socket channel
  */
 public ServerSocketChannel openUnixDomainServerSocketChannel() {
@@ -313,7 +313,7 @@ public class JreCompat {
 }
 
 /**
- * Create socket channel using the specified socket domain socket address.
+ * Create socket channel using the Unix domain socket ProtocolFamily.
  * @return the socket channel
  */
 public SocketChannel openUnixDomainSocketChannel() {


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix javadoc after changes

2020-12-30 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 8c54d97  Fix javadoc after changes
8c54d97 is described below

commit 8c54d978a992c8b615e53513cafea0d209b97ead
Author: remm 
AuthorDate: Wed Dec 30 16:54:29 2020 +0100

Fix javadoc after changes
---
 java/org/apache/tomcat/util/compat/JreCompat.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/compat/JreCompat.java 
b/java/org/apache/tomcat/util/compat/JreCompat.java
index 9b991ba..73a109f 100644
--- a/java/org/apache/tomcat/util/compat/JreCompat.java
+++ b/java/org/apache/tomcat/util/compat/JreCompat.java
@@ -305,7 +305,7 @@ public class JreCompat {
 
 
 /**
- * Create server socket channel using the specified socket domain socket 
address.
+ * Create server socket channel using the Unix domain socket 
ProtocolFamily.
  * @return the server socket channel
  */
 public ServerSocketChannel openUnixDomainServerSocketChannel() {
@@ -313,7 +313,7 @@ public class JreCompat {
 }
 
 /**
- * Create socket channel using the specified socket domain socket address.
+ * Create socket channel using the Unix domain socket ProtocolFamily.
  * @return the socket channel
  */
 public SocketChannel openUnixDomainSocketChannel() {


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] arjantijms commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox 


arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752685025


   Yet another example, Weld is using similar tricks to integrate with Tomcat:
   
   
https://github.com/weld/core/blob/master/environments/servlet/core/src/main/java/org/jboss/weld/environment/tomcat/WeldForwardingInstanceManager.java#L97
   
   ```java
 // Hack into Tomcat to replace the InstanceManager using
 // reflection to access private fields
 ApplicationContext appContext = (ApplicationContext) 
getContextFieldValue((ApplicationContextFacade) context, 
ApplicationContextFacade.class);
   ```
   
   It's not the average application that needs this, but libs like Weld (CDI) 
or Soteria (Jakarta Security) definitely have a need for this.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2020-12-30 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5611

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 0974ffcc1880ace148f9effd35e27728cccfc558
Blamelist: remm 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org