[Bug 65022] New: [Enhancement] Use of font with distinct lowercase l , capital I (i) and one 1 tomcat access log pattern definition
https://bz.apache.org/bugzilla/show_bug.cgi?id=65022 Bug ID: 65022 Summary: [Enhancement] Use of font with distinct lowercase l , capital I (i) and one 1 tomcat access log pattern definition Product: Tomcat 9 Version: 9.0.x Hardware: PC OS: All Status: NEW Severity: normal Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: abhisheksha...@gmail.com Target Milestone: - In the current and older tomcat docs the distinction between capital i and l is not evident with use of open sans font[1]. This is common typography issue which could be avoided with font that have distinctions in commonly confused characters similar to http's log format doc.[2] ~~~ %l - Remote logical username from identd (always returns '-') %I - Current request thread name (can compare later with stacktraces) ~~~ [1] https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Introduction [2] http://httpd.apache.org/docs/2.4/mod/mod_log_config.html#formats -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Add reflection for using Unix domain sockets
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new f331cde Add reflection for using Unix domain sockets
f331cde is described below
commit f331cdee808a0753044fc4103d869d02ae79ad79
Author: remm
AuthorDate: Tue Dec 22 11:27:35 2020 +0100
Add reflection for using Unix domain sockets
This requires Java 16.
Also remove the compat class for Graal, since it's was only used for one
method. Elsewhere, Graal incompatible code is filtered out using the
flag, so no need to do something else here (and
JreMemoryLeakPreventionListener the only caller already does not make
sense with AOT compilation, so it's not a problem to not even use the
flag). This will allow Graal to use the compat for the underlying JRE it
actually uses, like 8 or 11 at the moment.
---
.../org/apache/tomcat/util/compat/GraalCompat.java | 47
.../org/apache/tomcat/util/compat/Jre16Compat.java | 85 ++
java/org/apache/tomcat/util/compat/JreCompat.java | 42 +--
.../tomcat/util/compat/LocalStrings.properties | 4 +
4 files changed, 125 insertions(+), 53 deletions(-)
diff --git a/java/org/apache/tomcat/util/compat/GraalCompat.java
b/java/org/apache/tomcat/util/compat/GraalCompat.java
deleted file mode 100644
index 6187eb6..000
--- a/java/org/apache/tomcat/util/compat/GraalCompat.java
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.tomcat.util.compat;
-
-import java.io.IOException;
-
-class GraalCompat extends Jre9Compat {
-
-private static final boolean GRAAL;
-
-static {
-boolean result = false;
-try {
-Class nativeImageClazz =
Class.forName("org.graalvm.nativeimage.ImageInfo");
-result =
Boolean.TRUE.equals(nativeImageClazz.getMethod("inImageCode").invoke(null));
-} catch (ClassNotFoundException e) {
-// Must be Graal
-} catch (ReflectiveOperationException | IllegalArgumentException e) {
-// Should never happen
-}
-GRAAL = result ||
System.getProperty("org.graalvm.nativeimage.imagecode") != null;
-}
-
-static boolean isSupported() {
-// This property does not exist for a native image
-return GRAAL;
-}
-
-@Override
-public void disableCachingForJarUrlConnections() throws IOException {
-}
-
-}
diff --git a/java/org/apache/tomcat/util/compat/Jre16Compat.java
b/java/org/apache/tomcat/util/compat/Jre16Compat.java
new file mode 100644
index 000..406824f
--- /dev/null
+++ b/java/org/apache/tomcat/util/compat/Jre16Compat.java
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.compat;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.ProtocolFamily;
+import java.net.SocketAddress;
+import java.net.StandardProtocolFamily;
+import java.nio.channels.ServerSocketChannel;
+
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.res.StringManager;
+
+class Jre16Compat extends Jre9Compat {
+
+private static final Log log = LogFactory.getLog(Jre16Compat.class);
+private static fin
[tomcat] branch 9.0.x updated: Add reflection for using Unix domain sockets
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new d70de4f Add reflection for using Unix domain sockets
d70de4f is described below
commit d70de4fc5c67ab55c1ac6d55108d86617be924bb
Author: remm
AuthorDate: Tue Dec 22 11:27:35 2020 +0100
Add reflection for using Unix domain sockets
This requires Java 16.
Also remove the compat class for Graal, since it's was only used for one
method. Elsewhere, Graal incompatible code is filtered out using the
flag, so no need to do something else here (and
JreMemoryLeakPreventionListener the only caller already does not make
sense with AOT compilation, so it's not a problem to not even use the
flag). This will allow Graal to use the compat for the underlying JRE it
actually uses, like 8 or 11 at the moment.
---
.../org/apache/tomcat/util/compat/GraalCompat.java | 47
.../org/apache/tomcat/util/compat/Jre16Compat.java | 85 ++
java/org/apache/tomcat/util/compat/JreCompat.java | 42 +--
.../tomcat/util/compat/LocalStrings.properties | 4 +
4 files changed, 125 insertions(+), 53 deletions(-)
diff --git a/java/org/apache/tomcat/util/compat/GraalCompat.java
b/java/org/apache/tomcat/util/compat/GraalCompat.java
deleted file mode 100644
index 6187eb6..000
--- a/java/org/apache/tomcat/util/compat/GraalCompat.java
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.tomcat.util.compat;
-
-import java.io.IOException;
-
-class GraalCompat extends Jre9Compat {
-
-private static final boolean GRAAL;
-
-static {
-boolean result = false;
-try {
-Class nativeImageClazz =
Class.forName("org.graalvm.nativeimage.ImageInfo");
-result =
Boolean.TRUE.equals(nativeImageClazz.getMethod("inImageCode").invoke(null));
-} catch (ClassNotFoundException e) {
-// Must be Graal
-} catch (ReflectiveOperationException | IllegalArgumentException e) {
-// Should never happen
-}
-GRAAL = result ||
System.getProperty("org.graalvm.nativeimage.imagecode") != null;
-}
-
-static boolean isSupported() {
-// This property does not exist for a native image
-return GRAAL;
-}
-
-@Override
-public void disableCachingForJarUrlConnections() throws IOException {
-}
-
-}
diff --git a/java/org/apache/tomcat/util/compat/Jre16Compat.java
b/java/org/apache/tomcat/util/compat/Jre16Compat.java
new file mode 100644
index 000..406824f
--- /dev/null
+++ b/java/org/apache/tomcat/util/compat/Jre16Compat.java
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.compat;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.ProtocolFamily;
+import java.net.SocketAddress;
+import java.net.StandardProtocolFamily;
+import java.nio.channels.ServerSocketChannel;
+
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.res.StringManager;
+
+class Jre16Compat extends Jre9Compat {
+
+private static final Log log = LogFactory.getLog(Jre16Compat.class);
+private static final
[Bug 65022] [Enhancement] Use of font with distinct lowercase l , capital I (i) and one 1 tomcat access log pattern definition
https://bz.apache.org/bugzilla/show_bug.cgi?id=65022 --- Comment #1 from Christopher Schultz --- You are absolutely right. Would you care to create a documentation patch (or pull-request) for that? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65022] [Enhancement] Use of font with distinct lowercase l , capital I (i) and one 1 tomcat access log pattern definition
https://bz.apache.org/bugzilla/show_bug.cgi?id=65022 --- Comment #2 from shubhu shubhu --- https://technicaldude.tech/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
