[GitHub] [tomcat] lanicc commented on pull request #389: Optimize if condition

2020-12-16 Thread GitBox


lanicc commented on pull request #389:
URL: https://github.com/apache/tomcat/pull/389#issuecomment-745871337


   > @lanicc Thanks for the PR!
   > Can you please remove the merge commit ?
   
   ok, I will pull a new request



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] lanicc closed pull request #389: Optimize if condition

2020-12-16 Thread GitBox


lanicc closed pull request #389:
URL: https://github.com/apache/tomcat/pull/389


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] lanicc opened a new pull request #390: Optimize if condition

2020-12-16 Thread GitBox


lanicc opened a new pull request #390:
URL: https://github.com/apache/tomcat/pull/390


   Optimize if condition in `AbstractProtocol.startAsyncTimeout()`,
   from `if (timeoutFuture == null || (timeoutFuture != null && 
timeoutFuture.isDone()))`
to `if (timeoutFuture == null || timeoutFuture.isDone())`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-16 Thread Emmanuel Bourg
Le 11/12/2020 à 17:56, Michael Osipov a écrit :

> Well, isn't that really a OS vendor problem not ours? We can provide
> grace periods, but that's pretty much it. They need to solve that, not
> us on a volunteer basis.

Note that (most) Debian Developers are volunteers too.


> FreeBSD's port of libtcnative is uptodate. I provide patches on regular
> basis. Vendors like Debian or Red Hat lag years behind.

I don't know the state in Red Hat, but in Debian tomcat-native is
up-to-date [1]. For the stable release there are backports with more
recent versions available.

Emmanuel Bourg

[1] https://tracker.debian.org/tomcat-native

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] lanicc closed pull request #390: Optimize if condition

2020-12-16 Thread GitBox


lanicc closed pull request #390:
URL: https://github.com/apache/tomcat/pull/390


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] lanicc opened a new pull request #391: Optimize if condition

2020-12-16 Thread GitBox


lanicc opened a new pull request #391:
URL: https://github.com/apache/tomcat/pull/391


   Optimize if condition in `AbstractProtocol.startAsyncTimeout()`,
   from `if (timeoutFuture == null || (timeoutFuture != null && 
timeoutFuture.isDone()))`
to `if (timeoutFuture == null || timeoutFuture.isDone())`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org