[tomcat] branch master updated: Add some more debug logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 40660b8 Add some more debug logging
40660b8 is described below
commit 40660b8590bf2be73676958c95010664a4f34cf0
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Add some more debug logging
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 4
3 files changed, 8 insertions(+)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 38e7f74..f5787aa 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -99,6 +99,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 83960cb..3009a36 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -31,6 +31,7 @@ abstractProcessor.hostInvalid=The host [{0}] is not valid
abstractProcessor.httpupgrade.notsupported=HTTP upgrade is not supported by
this protocol
abstractProcessor.noExecute=Unable to transfer processing to a container
thread because this Processor is not currently associated with a SocketWrapper
abstractProcessor.pushrequest.notsupported=Server push requests are not
supported by this protocol
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProcessor.socket.ssl=Exception getting SSL attributes
abstractProtocol.mbeanDeregistrationFailed=Failed to deregister MBean named
[{0}] from MBean server [{1}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index b75bbe0..3ce0e13 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -120,6 +120,10 @@
Avoid most of the thread pool use during NIO2 socket accept. Patch
submitted by Anil Gursel. (remm)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Add some more debug logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new fdf14b0 Add some more debug logging
fdf14b0 is described below
commit fdf14b02fb53fd4fd3731b10bbaef57f4f09b439
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Add some more debug logging
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 4
3 files changed, 8 insertions(+)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 7255040..d6e3877 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -99,6 +99,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 83960cb..3009a36 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -31,6 +31,7 @@ abstractProcessor.hostInvalid=The host [{0}] is not valid
abstractProcessor.httpupgrade.notsupported=HTTP upgrade is not supported by
this protocol
abstractProcessor.noExecute=Unable to transfer processing to a container
thread because this Processor is not currently associated with a SocketWrapper
abstractProcessor.pushrequest.notsupported=Server push requests are not
supported by this protocol
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProcessor.socket.ssl=Exception getting SSL attributes
abstractProtocol.mbeanDeregistrationFailed=Failed to deregister MBean named
[{0}] from MBean server [{1}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 7b963a8..69a36d7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -120,6 +120,10 @@
Avoid most of the thread pool use during NIO2 socket accept. Patch
submitted by Anil Gursel. (remm)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Add some more debug logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 40660b8 Add some more debug logging
40660b8 is described below
commit 40660b8590bf2be73676958c95010664a4f34cf0
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Add some more debug logging
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 4
3 files changed, 8 insertions(+)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 38e7f74..f5787aa 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -99,6 +99,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 83960cb..3009a36 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -31,6 +31,7 @@ abstractProcessor.hostInvalid=The host [{0}] is not valid
abstractProcessor.httpupgrade.notsupported=HTTP upgrade is not supported by
this protocol
abstractProcessor.noExecute=Unable to transfer processing to a container
thread because this Processor is not currently associated with a SocketWrapper
abstractProcessor.pushrequest.notsupported=Server push requests are not
supported by this protocol
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProcessor.socket.ssl=Exception getting SSL attributes
abstractProtocol.mbeanDeregistrationFailed=Failed to deregister MBean named
[{0}] from MBean server [{1}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index b75bbe0..3ce0e13 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -120,6 +120,10 @@
Avoid most of the thread pool use during NIO2 socket accept. Patch
submitted by Anil Gursel. (remm)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Add some more debug logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new b139a83 Add some more debug logging
b139a83 is described below
commit b139a83e2b0a62ae8f282b03f80b1e8fb085727f
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Add some more debug logging
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 4
3 files changed, 8 insertions(+)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 6d66247..6480ddf 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -102,6 +102,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 1aeb314..b6441fe 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -30,6 +30,7 @@ abstractProcessor.fallToDebug=\n\
abstractProcessor.hostInvalid=The host [{0}] is not valid
abstractProcessor.httpupgrade.notsupported=HTTP upgrade is not supported by
this protocol
abstractProcessor.pushrequest.notsupported=Server push requests are not
supported by this protocol
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProcessor.socket.ssl=Exception getting SSL attributes
abstractProtocol.mbeanDeregistrationFailed=Failed to deregister MBean named
[{0}] from MBean server [{1}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 10c..97d76c3 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -95,6 +95,10 @@
Provide messages for some SocketTimeoutException instances
that did not have one. (markt)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Add some more debug logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new fdf14b0 Add some more debug logging
fdf14b0 is described below
commit fdf14b02fb53fd4fd3731b10bbaef57f4f09b439
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Add some more debug logging
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 4
3 files changed, 8 insertions(+)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 7255040..d6e3877 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -99,6 +99,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 83960cb..3009a36 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -31,6 +31,7 @@ abstractProcessor.hostInvalid=The host [{0}] is not valid
abstractProcessor.httpupgrade.notsupported=HTTP upgrade is not supported by
this protocol
abstractProcessor.noExecute=Unable to transfer processing to a container
thread because this Processor is not currently associated with a SocketWrapper
abstractProcessor.pushrequest.notsupported=Server push requests are not
supported by this protocol
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProcessor.socket.ssl=Exception getting SSL attributes
abstractProtocol.mbeanDeregistrationFailed=Failed to deregister MBean named
[{0}] from MBean server [{1}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 7b963a8..69a36d7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -120,6 +120,10 @@
Avoid most of the thread pool use during NIO2 socket accept. Patch
submitted by Anil Gursel. (remm)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Additional fix for BZ 64848. Ensure Processor instances are cleaned up
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new fde779b Additional fix for BZ 64848. Ensure Processor instances are
cleaned up
fde779b is described below
commit fde779b2f84e56aa118d6d58b8958964dd2fd7f4
Author: Mark Thomas
AuthorDate: Thu Nov 5 09:41:06 2020 +
Additional fix for BZ 64848. Ensure Processor instances are cleaned up
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/LocalStrings.properties | 1 +
webapps/docs/changelog.xml | 7 +--
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 5405fc4..36843d8 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -86,6 +86,9 @@ public abstract class AbstractProcessor implements
ActionHook, Processor {
* @param t The error which occurred
*/
protected void setErrorState(ErrorState errorState, Throwable t) {
+if (getLog().isDebugEnabled()) {
+getLog().debug(sm.getString("abstractProcessor.setErrorState",
errorState), t);
+}
// Use the return value to avoid processing more than one async error
// in a single async cycle.
boolean setError = response.setError();
diff --git a/java/org/apache/coyote/LocalStrings.properties
b/java/org/apache/coyote/LocalStrings.properties
index 3de0cd7..e0963d7 100644
--- a/java/org/apache/coyote/LocalStrings.properties
+++ b/java/org/apache/coyote/LocalStrings.properties
@@ -21,6 +21,7 @@
abstractConnectionHandler.socketexception.debug=SocketExceptions are normal, ign
abstractProcessor.fallToDebug=\n\
\ Note: further occurrences of request parsing errors will be logged at DEBUG
level.
abstractProcessor.hostInvalid=The host [{0}] is not valid
+abstractProcessor.setErrorState=Error state [{0}] reported while processing
request
abstractProtocolHandler.destroy=Destroying ProtocolHandler [{0}]
abstractProtocolHandler.destroyError=Failed to destroy end point associated
with ProtocolHandler [{0}]
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 0686895..42d0c53 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -101,6 +101,10 @@
55160: Re-fix this bug after the original fix was reverted
by
a separate fix to timeouts in 7.0.81. (markt)
+
+Add additional debug logging for I/O issues when communicating with the
+user agent. (markt)
+
@@ -141,8 +145,7 @@
Complete the fix for 63815. Users wishing to use system
properties that require quoting with catalina.sh and the
-debug option must use a JRE that includes the fix for https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808.
+debug option must use a JRE that includes the fix for https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808.
(markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Restore line break
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 3e872f0 Restore line break 3e872f0 is described below commit 3e872f00259162d075e7999efd5d509299909df6 Author: Mark Thomas AuthorDate: Thu Nov 5 09:54:20 2020 + Restore line break --- webapps/docs/changelog.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 42d0c53..432a249 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -145,7 +145,8 @@ Complete the fix for 63815. Users wishing to use system properties that require quoting with catalina.sh and the -debug option must use a JRE that includes the fix for https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808. +debug option must use a JRE that includes the fix for https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch 7.0.x updated: Additional fix for BZ 64848. Ensure Processor instances are cleaned up
On 05/11/2020 09:50, ma...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch 7.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/7.0.x by this push:
> new fde779b Additional fix for BZ 64848. Ensure Processor instances are
> cleaned up
> fde779b is described below
>
> commit fde779b2f84e56aa118d6d58b8958964dd2fd7f4
> Author: Mark Thomas
> AuthorDate: Thu Nov 5 09:41:06 2020 +
>
> Additional fix for BZ 64848. Ensure Processor instances are cleaned up
Sorry. Looks like my back-port went wrong here. This was the additional
debug logging.
Mark
> ---
> java/org/apache/coyote/AbstractProcessor.java | 3 +++
> java/org/apache/coyote/LocalStrings.properties | 1 +
> webapps/docs/changelog.xml | 7 +--
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/java/org/apache/coyote/AbstractProcessor.java
> b/java/org/apache/coyote/AbstractProcessor.java
> index 5405fc4..36843d8 100644
> --- a/java/org/apache/coyote/AbstractProcessor.java
> +++ b/java/org/apache/coyote/AbstractProcessor.java
> @@ -86,6 +86,9 @@ public abstract class AbstractProcessor implements
> ActionHook, Processor {
> * @param t The error which occurred
> */
> protected void setErrorState(ErrorState errorState, Throwable t) {
> +if (getLog().isDebugEnabled()) {
> +getLog().debug(sm.getString("abstractProcessor.setErrorState",
> errorState), t);
> +}
> // Use the return value to avoid processing more than one async error
> // in a single async cycle.
> boolean setError = response.setError();
> diff --git a/java/org/apache/coyote/LocalStrings.properties
> b/java/org/apache/coyote/LocalStrings.properties
> index 3de0cd7..e0963d7 100644
> --- a/java/org/apache/coyote/LocalStrings.properties
> +++ b/java/org/apache/coyote/LocalStrings.properties
> @@ -21,6 +21,7 @@
> abstractConnectionHandler.socketexception.debug=SocketExceptions are normal,
> ign
> abstractProcessor.fallToDebug=\n\
> \ Note: further occurrences of request parsing errors will be logged at
> DEBUG level.
> abstractProcessor.hostInvalid=The host [{0}] is not valid
> +abstractProcessor.setErrorState=Error state [{0}] reported while processing
> request
>
> abstractProtocolHandler.destroy=Destroying ProtocolHandler [{0}]
> abstractProtocolHandler.destroyError=Failed to destroy end point associated
> with ProtocolHandler [{0}]
> diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
> index 0686895..42d0c53 100644
> --- a/webapps/docs/changelog.xml
> +++ b/webapps/docs/changelog.xml
> @@ -101,6 +101,10 @@
> 55160: Re-fix this bug after the original fix was
> reverted by
> a separate fix to timeouts in 7.0.81. (markt)
>
> +
> +Add additional debug logging for I/O issues when communicating with
> the
> +user agent. (markt)
> +
>
>
>
> @@ -141,8 +145,7 @@
>
> Complete the fix for 63815. Users wishing to use system
> properties that require quoting with catalina.sh and the
> -debug option must use a JRE that includes the fix for -
> href="https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808.
> +debug option must use a JRE that includes the fix for
> https://bugs.openjdk.java.net/browse/JDK-8234808";>JDK-8234808.
> (markt)
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-9-trunk
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/530 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9-commit' triggered this build Build Source Stamp: [branch 9.0.x] fdf14b02fb53fd4fd3731b10bbaef57f4f09b439 Blamelist: Mark Thomas BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5532 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 40660b8590bf2be73676958c95010664a4f34cf0 Blamelist: Mark Thomas BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-85-trunk
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2534 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' triggered this build Build Source Stamp: [branch 8.5.x] b139a83e2b0a62ae8f282b03f80b1e8fb085727f Blamelist: Mark Thomas BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2b5cb69 Improve logging
2b5cb69 is described below
commit 2b5cb69e6de7b6568ecddaed68948fc9d222fd06
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index f070323..b4c3692 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import jakarta.websocket.RemoteEndpoint.Basic;
import jakarta.websocket.Session;
import jakarta.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2b5cb69 Improve logging
2b5cb69 is described below
commit 2b5cb69e6de7b6568ecddaed68948fc9d222fd06
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index f070323..b4c3692 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import jakarta.websocket.RemoteEndpoint.Basic;
import jakarta.websocket.Session;
import jakarta.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new bf987f5 Improve logging
bf987f5 is described below
commit bf987f5d2a92755f5d7e2dfbf45ffad8ab15747d
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index eb8ed63..2c4d893 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import javax.websocket.RemoteEndpoint.Basic;
import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5dcce0e Improve logging
5dcce0e is described below
commit 5dcce0e9ae51bcbb628f611349471aef4082f43b
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index eb8ed63..2c4d893 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import javax.websocket.RemoteEndpoint.Basic;
import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new bf987f5 Improve logging
bf987f5 is described below
commit bf987f5d2a92755f5d7e2dfbf45ffad8ab15747d
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index eb8ed63..2c4d893 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import javax.websocket.RemoteEndpoint.Basic;
import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2b5cb69 Improve logging
2b5cb69 is described below
commit 2b5cb69e6de7b6568ecddaed68948fc9d222fd06
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index f070323..b4c3692 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import jakarta.websocket.RemoteEndpoint.Basic;
import jakarta.websocket.Session;
import jakarta.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Improve logging
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 5dcce0e Improve logging
5dcce0e is described below
commit 5dcce0e9ae51bcbb628f611349471aef4082f43b
Author: Mark Thomas
AuthorDate: Thu Nov 5 11:15:05 2020 +
Improve logging
---
test/org/apache/tomcat/websocket/TesterFirehoseServer.java | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index eb8ed63..2c4d893 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -27,6 +27,8 @@ import javax.websocket.RemoteEndpoint.Basic;
import javax.websocket.Session;
import javax.websocket.server.ServerEndpoint;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.websocket.server.TesterEndpointConfig;
/**
@@ -136,6 +138,8 @@ public class TesterFirehoseServer {
private static class Writer implements Runnable {
+private static final Log log = LogFactory.getLog(Writer.class);
+
private final Session session;
public Writer(Session session) {
@@ -147,7 +151,7 @@ public class TesterFirehoseServer {
try {
doRun();
} catch (IOException ioe) {
-ioe.printStackTrace();
+log.error("Error on non-container thread", ioe);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64830] HTTP2 : GOAWAY sent with Protocol Error and Frame Size Error
https://bz.apache.org/bugzilla/show_bug.cgi?id=64830 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Mark Thomas --- Thanks. I can try testing on a similar spec machine (although it will be a VM). How long does the test case have to be running before you start to see errors? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64875] New: ClassNotFoundException with GraalVM and JNI
https://bz.apache.org/bugzilla/show_bug.cgi?id=64875 Bug ID: 64875 Summary: ClassNotFoundException with GraalVM and JNI Product: Tomcat 9 Version: 9.0.x Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: lopez.i...@gmail.com Target Milestone: - I have upgraded Tomcat integration in Micronaut to 9.0.39 (from 9.0.38) and GraalVM native image generation fails because of this issue: "Remove the entry for org.apache.tomcat.util.descriptor.tld.LocalStrings from tomcat-embed-core's GraalVM tomcat-resource.json. It no more part of the jar since Fix unwanted JPMS dependency of embed-core on embed-jasper. (mgrigorov)" As the issue is fixed in the snapshot version (9.0.40-dev) I've tried it but now the native image generation fails with: [servlet-tomcat:27563]classlist: 7,251.57 ms, 2.41 GB [servlet-tomcat:27563](cap): 707.30 ms, 2.41 GB [servlet-tomcat:27563]setup: 2,172.74 ms, 2.41 GB [servlet-tomcat:27563] (clinit): 1,285.16 ms, 3.67 GB [servlet-tomcat:27563] (typeflow): 37,093.14 ms, 3.67 GB [servlet-tomcat:27563](objects): 30,955.12 ms, 3.67 GB [servlet-tomcat:27563] (features): 1,939.07 ms, 3.67 GB [servlet-tomcat:27563] analysis: 73,590.13 ms, 3.67 GB [servlet-tomcat:27563] universe: 3,140.35 ms, 3.72 GB Fatal error:java.lang.NoClassDefFoundError at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:598) at java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1005) at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:483) at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:350) at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:509) at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:115) Caused by: java.lang.NoClassDefFoundError: io/netty/internal/tcnative/SSLPrivateKeyMethod at jdk.vm.ci.hotspot.CompilerToVM.getDeclaredMethods(Native Method) at jdk.vm.ci.hotspot.HotSpotResolvedObjectTypeImpl.getDeclaredMethods(HotSpotResolvedObjectTypeImpl.java:973) at com.oracle.svm.jni.access.JNIAccessibleMethod.anyMatchIgnoreReturnType(JNIAccessibleMethod.java:139) at com.oracle.svm.jni.access.JNIAccessibleMember.findHidingSubclasses(JNIAccessibleMember.java:103) at com.oracle.svm.jni.access.JNIAccessibleMember.findHidingSubclasses(JNIAccessibleMember.java:110) at com.oracle.svm.jni.access.JNIAccessibleMember.setHidingSubclasses(JNIAccessibleMember.java:83) at com.oracle.svm.jni.access.JNIAccessibleMethod.finishBeforeCompilation(JNIAccessibleMethod.java:135) at com.oracle.svm.jni.access.JNIAccessFeature.beforeCompilation(JNIAccessFeature.java:350) at com.oracle.svm.hosted.NativeImageGenerator.lambda$doRun$2(NativeImageGenerator.java:614) at com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:70) at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:614) at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:471) at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386) at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) Caused by: java.lang.ClassNotFoundException: io.netty.internal.tcnative.SSLPrivateKeyMethod at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ... 17 more I've been taking a look at the changes done from 9.0.39 and this commit https://github.com/apache/tomcat/commit/6287552d9a14b698990954c6591f5f8512bc4a78 broke the generation. I've tried to build tomcat locally and it worked, but I don't know how to publish it to my local maven. So what I've done is manually modifying the downloaded .jar file and removing the `tomcat-jni.json` introduced in that commit. That fixed the native image generation. You can see that I'm run
[Bug 64875] ClassNotFoundException with GraalVM and JNI
https://bz.apache.org/bugzilla/show_bug.cgi?id=64875 Iván López changed: What|Removed |Added CC||lopez.i...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5533 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 2b5cb69e6de7b6568ecddaed68948fc9d222fd06 Blamelist: Mark Thomas Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64875] ClassNotFoundException with GraalVM and JNI
https://bz.apache.org/bugzilla/show_bug.cgi?id=64875 Remy Maucherat changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Remy Maucherat --- JNI use in general makes things more difficult. SSLPrivateKeyMethod is not a class that is used by Tomcat, which does not use Netty. So this is likely coming from your application. The commit you specify are descriptors for tomcat-native, if you use your own JNI, then you need your own descriptors as well. Using this added descriptor is not mandatory at all, so just skip it if you're not using tomcat-native. IMO for embedded use cases I would avoid it at all costs (trouble !!!) and instead stick to the JVM (Java 8 Graal now does TLS with ALPN, so everything is covered). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Working around a JRE bug
All, The summary: - The JVM spec states that the ModulePackages attribute in module-info.class DOES NOT have to list ALL packages in the module - bnd is consistent with the JVM spec and only lists the packages that are required to be listed - the JRE uses a broken class loader optimisation that assumes that ModulePackages DOES list ALL packages present in the module When applications try and use our JARs with bnd provided module-info CNFE occur because the JRE can't find the module for some classes. For a fuller description of the issue see: https://bugs.openjdk.java.net/browse/JDK-8255854 This is likely the cause of several currently open bugs reports of CNFE when using modules. Possible solutions: 1. OpenJDK accepts the class loader optimisation is flawed and reverts it. Given the reaction so far to the reported bug this looks unlikely. Even if this were to happen, class loading performance would be impacted and it is going to take a long time before all the broken JREs have been updated. 2. The bnd project updates bnd to implement what amounts to an undocumented requirement that the ModulePackages attribute lists all packages in the module. This is probably the cleanest solution but depends on the goodwill of the bnd project who would be well within their rights to reject it as invalid based on the JVM spec. I haven't yet approached the bnd project. A fix along these lines might be ready for the next release round but is unlikely to be ready for this one. 3. We drop all the JPMS meta-data until we have a solution. I'm not sure of the consequences for users wanting to use Tomcat JARs in a JPMS environment. 4. We "patch" module-info after bnd has generated it via: - custom code (BCEL probably helps) - jar (if using Java 9+ jar rebuilds the module-info.class file) 5. We add "unnecessary" @aQute.bnd.annotation.jpms.Open annotations to packages so bnd includes them in module-info. It might be hard to remove these at a later date if folks start to depend on them. I am currently thinking along these lines: - Add @aQute.bnd.annotation.jpms.Open where necessary to fix this. - Document clearly in the Javadoc, change log, the release announcement and the RELEASE NOTES that this is a temporary workaround that will be removed as soon as a better fix is available. - Ask the bnd project to make a change to list all packages in a module in the ModulePackages attribute. Thoughts? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64875] ClassNotFoundException with GraalVM and JNI
https://bz.apache.org/bugzilla/show_bug.cgi?id=64875 --- Comment #2 from mgrigorov --- With https://github.com/apache/tomcat/commit/6287552d9a14b698990954c6591f5f8512bc4a78 I've made it possible to use APR protocol. There is nothing Netty specific in it. As Remy explained you need to find out how Netty is being involved and why it breaks the things. To provide custom JNI config you will need to pass -H:JNIConfigurationResources=... or -H:JNIConfigurationFiles=... argument to native-image. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Additional fixes for BZ 64848
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new f8fde70 Additional fixes for BZ 64848
f8fde70 is described below
commit f8fde70263fd9e5a087cf57df9af34f5e77342fb
Author: Mark Thomas
AuthorDate: Thu Nov 5 14:33:43 2020 +
Additional fixes for BZ 64848
---
java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
index 94b5ccb..aaeebd8 100644
--- a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
+++ b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
@@ -296,13 +296,13 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
if (!messagePartInProgress.tryAcquire(timeout,
TimeUnit.MILLISECONDS)) {
String msg = sm.getString("wsRemoteEndpoint.acquireTimeout");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg),
true);
throw new SocketTimeoutException(msg);
}
} catch (InterruptedException e) {
String msg = sm.getString("wsRemoteEndpoint.sendInterrupt");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg), true);
throw new IOException(msg, e);
}
@@ -313,14 +313,14 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
ExceptionUtils.handleThrowable(t);
messagePartInProgress.release();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw t;
}
if (!bsh.getSendResult().isOK()) {
messagePartInProgress.release();
Throwable t = bsh.getSendResult().getException();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw new IOException (t);
}
// The BlockingSendHandler doesn't call end message so update the
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Additional fixes for BZ 64848
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 0e8cfd6 Additional fixes for BZ 64848
0e8cfd6 is described below
commit 0e8cfd6e6c6e45085e006b1c293143933c3faf1f
Author: Mark Thomas
AuthorDate: Thu Nov 5 14:33:43 2020 +
Additional fixes for BZ 64848
---
java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
index 75f90e6..18c723a 100644
--- a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
+++ b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
@@ -296,13 +296,13 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
if (!messagePartInProgress.tryAcquire(timeout,
TimeUnit.MILLISECONDS)) {
String msg = sm.getString("wsRemoteEndpoint.acquireTimeout");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg),
true);
throw new SocketTimeoutException(msg);
}
} catch (InterruptedException e) {
String msg = sm.getString("wsRemoteEndpoint.sendInterrupt");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg), true);
throw new IOException(msg, e);
}
@@ -313,14 +313,14 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
ExceptionUtils.handleThrowable(t);
messagePartInProgress.release();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw t;
}
if (!bsh.getSendResult().isOK()) {
messagePartInProgress.release();
Throwable t = bsh.getSendResult().getException();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw new IOException (t);
}
// The BlockingSendHandler doesn't call end message so update the
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Additional fixes for BZ 64848
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 69b328f Additional fixes for BZ 64848
69b328f is described below
commit 69b328ff35127249c87555942de89539714572da
Author: Mark Thomas
AuthorDate: Thu Nov 5 14:33:43 2020 +
Additional fixes for BZ 64848
---
java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
index 75f90e6..18c723a 100644
--- a/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
+++ b/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
@@ -296,13 +296,13 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
if (!messagePartInProgress.tryAcquire(timeout,
TimeUnit.MILLISECONDS)) {
String msg = sm.getString("wsRemoteEndpoint.acquireTimeout");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg),
true);
throw new SocketTimeoutException(msg);
}
} catch (InterruptedException e) {
String msg = sm.getString("wsRemoteEndpoint.sendInterrupt");
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY, msg),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY, msg), true);
throw new IOException(msg, e);
}
@@ -313,14 +313,14 @@ public abstract class WsRemoteEndpointImplBase implements
RemoteEndpoint {
ExceptionUtils.handleThrowable(t);
messagePartInProgress.release();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw t;
}
if (!bsh.getSendResult().isOK()) {
messagePartInProgress.release();
Throwable t = bsh.getSendResult().getException();
wsSession.doClose(new CloseReason(CloseCodes.GOING_AWAY,
t.getMessage()),
-new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()));
+new CloseReason(CloseCodes.CLOSED_ABNORMALLY,
t.getMessage()), true);
throw new IOException (t);
}
// The BlockingSendHandler doesn't call end message so update the
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Use 2GB as the threshold for buffer pool
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new c156c3c Use 2GB as the threshold for buffer pool
c156c3c is described below
commit c156c3cbfc0a9a4a9a8cb3182506af03f1d5dba4
Author: remm
AuthorDate: Thu Nov 5 16:26:01 2020 +0100
Use 2GB as the threshold for buffer pool
There's already a constant for it.
---
java/org/apache/tomcat/util/net/SocketProperties.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/tomcat/util/net/SocketProperties.java
b/java/org/apache/tomcat/util/net/SocketProperties.java
index 0d6d89a..37311d2 100644
--- a/java/org/apache/tomcat/util/net/SocketProperties.java
+++ b/java/org/apache/tomcat/util/net/SocketProperties.java
@@ -453,7 +453,7 @@ public class SocketProperties {
long poolSize = 0;
if (actualBufferPoolSize == -2) {
long maxMemory = Runtime.getRuntime().maxMemory();
-if (maxMemory > 1024 * 1024 * 1024) {
+if (maxMemory > Integer.MAX_VALUE) {
actualBufferPoolSize = maxMemory / 32;
} else {
return 0;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64875] ClassNotFoundException with GraalVM and JNI
https://bz.apache.org/bugzilla/show_bug.cgi?id=64875 Iván López changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Iván López --- @Remy > The commit you specify are descriptors for tomcat-native, if you use your own > JNI, then you need your own descriptors as well. We are not using our own JNI. Adding that GraalVM config file triggered something that eventually needed the Netty thing. > Using this added descriptor is not mandatory at all, so just skip it if > you're not using tomcat-native. If it is not mandatory, how can I disable that descriptor if it's included in tomcat jar file? > IMO for embedded use cases I would avoid it at all costs (trouble !!!) and > instead stick to the JVM (Java 8 Graal now does TLS with ALPN, so everything > is covered). I'm sorry but I don't understand what you are trying to say. What should we avoid? Can you please elaborate on this? @mgrigorov > To provide custom JNI config you will need to pass > -H:JNIConfigurationResources=... or -H:JNIConfigurationFiles=... argument to > native-image. I can pass that but it doesn't override or remove the existing configuration inside tomcat jar file. That's why I said that maybe that configuration should be optional, so there is a way to disable it in case you don't need it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-9-trunk
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/532 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9-commit' triggered this build Build Source Stamp: [branch 9.0.x] 0e8cfd6e6c6e45085e006b1c293143933c3faf1f Blamelist: Mark Thomas Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64830] HTTP2 : GOAWAY sent with Protocol Error and Frame Size Error
https://bz.apache.org/bugzilla/show_bug.cgi?id=64830 Arshiya changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #13 from Arshiya --- Thanks Mark . Within 15 to 20 minutes of running the case I was able to see the errors , Please let us know if you need more information . -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-85-trunk
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2536 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' triggered this build Build Source Stamp: [branch 8.5.x] 69b328ff35127249c87555942de89539714572da Blamelist: Mark Thomas Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64848] WsSession objects in OUTPUT_CLOSED state are implicitly held by waitingProcessors and GC cannot purge them from the JVM heap
https://bz.apache.org/bugzilla/show_bug.cgi?id=64848 --- Comment #10 from Laszlo Karolyi --- I couldn't find any information about the publication date of 9.0.40 but it would help us if we knew when it is expected as we would include it in our next release. Please let me know if you happen to have any update on the next Tomcat version's release date. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64848] WsSession objects in OUTPUT_CLOSED state are implicitly held by waitingProcessors and GC cannot purge them from the JVM heap
https://bz.apache.org/bugzilla/show_bug.cgi?id=64848 --- Comment #11 from Mark Thomas --- Soon. Need to resolve the remaining open issues then we can tag. Hopefully early next week. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Working around a JRE bug
Woot! The great folks at bnd have fixed this. It means depending on a snapshot but compared to the disruption of the alternatives I think that is acceptable for the short term. The issue with depending on a snapshot is reproducibility of builds. The simplest option (and infra seem OK with it) is to put a copy in my home dir on home.a.o. Any objections? Better ideas? Mark On 05/11/2020 12:57, Mark Thomas wrote: > All, > > The summary: > > - The JVM spec states that the ModulePackages attribute in > module-info.class DOES NOT have to list ALL packages in the module > - bnd is consistent with the JVM spec and only lists the packages that > are required to be listed > - the JRE uses a broken class loader optimisation that assumes that > ModulePackages DOES list ALL packages present in the module > > When applications try and use our JARs with bnd provided module-info > CNFE occur because the JRE can't find the module for some classes. > > For a fuller description of the issue see: > https://bugs.openjdk.java.net/browse/JDK-8255854 > > This is likely the cause of several currently open bugs reports of CNFE > when using modules. > > > Possible solutions: > > 1. OpenJDK accepts the class loader optimisation is flawed and reverts >it. >Given the reaction so far to the reported bug this looks unlikely. >Even if this were to happen, class loading performance would be >impacted and it is going to take a long time before all the broken >JREs have been updated. > > 2. The bnd project updates bnd to implement what amounts to an >undocumented requirement that the ModulePackages attribute lists all >packages in the module. >This is probably the cleanest solution but depends on the goodwill of >the bnd project who would be well within their rights to reject it as >invalid based on the JVM spec. I haven't yet approached the bnd >project. A fix along these lines might be ready for the next release >round but is unlikely to be ready for this one. > > 3. We drop all the JPMS meta-data until we have a solution. >I'm not sure of the consequences for users wanting to use Tomcat JARs >in a JPMS environment. > > 4. We "patch" module-info after bnd has generated it via: >- custom code (BCEL probably helps) >- jar (if using Java 9+ jar rebuilds the module-info.class file) > > 5. We add "unnecessary" @aQute.bnd.annotation.jpms.Open annotations to >packages so bnd includes them in module-info. >It might be hard to remove these at a later date if folks start to >depend on them. > > > I am currently thinking along these lines: > > - Add @aQute.bnd.annotation.jpms.Open where necessary to fix this. > - Document clearly in the Javadoc, change log, the release announcement > and the RELEASE NOTES that this is a temporary workaround that will be > removed as soon as a better fix is available. > - Ask the bnd project to make a change to list all packages in a module > in the ModulePackages attribute. > > Thoughts? > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64877] New: New implementation of JDBC Based Store with better performances
https://bz.apache.org/bugzilla/show_bug.cgi?id=64877 Bug ID: 64877 Summary: New implementation of JDBC Based Store with better performances Product: Tomcat 9 Version: 9.0.39 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: p.moua...@ubik-ingenierie.com Target Milestone: - Hello, First thanks for your great product I've been using for years. Recently, I worked on a project that uses JDBCStore. I had to run performance tests on it. Those tests revealed a high contention point in this component due to the granularity of synchronization. The impact was that 1 thread could block hundreds of others. I would have been happy to provide stacktraces but I cannot due to NDA constraints. So I implemented (based on existing one) a new one with following differences: - I kept only the dataSourceName based configuration - I removed stateful instance variables in order to be able to lift synchronization This new implementation improved drastically performances. I'll propose a PR for this. I am aware that there is duplication with JDBCStore that could be improved but it's a first shot and I lack of time unfortunately. I hope you can take into account this contribution. Regards Philippe M. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64877] New implementation of JDBC Based Store with better performances
https://bz.apache.org/bugzilla/show_bug.cgi?id=64877 Philippe Mouawad changed: What|Removed |Added Keywords||PatchAvailable CC||p.mouawad@ubik-ingenierie.c ||om --- Comment #1 from Philippe Mouawad --- PR: https://github.com/apache/tomcat/pull/376 Regards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] pmouawad opened a new pull request #376: Implement Bug 64877
pmouawad opened a new pull request #376: URL: https://github.com/apache/tomcat/pull/376 Hello, First thanks for your great product I've been using for years. Recently, I worked on a project that uses JDBCStore to store sessions. I had to run performance tests on it. Those tests revealed a high contention point in this component due to the coarse granularity of synchronization. The impact was that 1 thread could block hundreds of others leading to high response time at higher scale. So I implemented (based on existing one) a new one with following differences: - I kept only the dataSourceName based configuration - I removed stateful instance variables in order to be able to lift synchronization This new implementation improved drastically performances. I am aware that there is duplication with JDBCStore that could be improved but it's a first shot and I lack of time unfortunately. I hope you can take into account this contribution. The associated bugzilla enhancement is: - https://bz.apache.org/bugzilla/show_bug.cgi?id=64877 Regards Philippe M. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
